[jira] [Updated] (CASSANDRA-8778) Adler32 Digests for Compressed SSTables are Incorrect

2015-02-19 Thread Jeff Jirsa (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-8778:
--
Attachment: cassandra-8778.diff

 Adler32 Digests for Compressed SSTables are Incorrect
 -

 Key: CASSANDRA-8778
 URL: https://issues.apache.org/jira/browse/CASSANDRA-8778
 Project: Cassandra
  Issue Type: Bug
Reporter: Jeff Jirsa
Assignee: Jeff Jirsa
Priority: Trivial
 Attachments: cassandra-8778.diff, cassandra-8778.patch


 ChecksumWriter append() calculates the checksum of a buffer, then also writes 
 that checksum as an int into the provided DataOutput. The final call to 
 writeFullChecksum will have the checksum of all of the buffers, but none of 
 the intermediate int checksums.
 This issue was discovered (and a fix proposed) in #5791 - if the patch for 
 #5791 is not accepted, some fix for 
 src/java/org/apache/cassandra/io/util/DataIntegrityMetadata.java should be 
 applied. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CASSANDRA-8778) Adler32 Digests for Compressed SSTables are Incorrect

2015-02-18 Thread Jonathan Ellis (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Ellis updated CASSANDRA-8778:
--
Reviewer: Benedict

[~benedict] to review

 Adler32 Digests for Compressed SSTables are Incorrect
 -

 Key: CASSANDRA-8778
 URL: https://issues.apache.org/jira/browse/CASSANDRA-8778
 Project: Cassandra
  Issue Type: Bug
Reporter: Jeff Jirsa
Priority: Trivial
 Attachments: cassandra-8778.patch


 ChecksumWriter append() calculates the checksum of a buffer, then also writes 
 that checksum as an int into the provided DataOutput. The final call to 
 writeFullChecksum will have the checksum of all of the buffers, but none of 
 the intermediate int checksums.
 This issue was discovered (and a fix proposed) in #5791 - if the patch for 
 #5791 is not accepted, some fix for 
 src/java/org/apache/cassandra/io/util/DataIntegrityMetadata.java should be 
 applied. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CASSANDRA-8778) Adler32 Digests for Compressed SSTables are Incorrect

2015-02-18 Thread Jeff Jirsa (JIRA)

 [ 
https://issues.apache.org/jira/browse/CASSANDRA-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Jirsa updated CASSANDRA-8778:
--
Attachment: cassandra-8778.patch

Proposed patch against trunk

{noformat}
for i in ~/.ccm/snapshot/node1/data/test2/*/*Data*; do echo $i  java 
AdlerCheckSum $i ; j=`echo $i | sed -e 's/Data.db/Digest.sha1/g' `  echo 
'value from digest'  cat $j  echo '' ; done
/Users/jeff/.ccm/snapshot/node1/data/test2/compressed_counters-c2caca90b7d311e4a8fa85b755fc16c4/la-3-big-Data.db
2241194834
value from digest
2241194834
/Users/jeff/.ccm/snapshot/node1/data/test2/compressed_counters-c2caca90b7d311e4a8fa85b755fc16c4/la-4-big-Data.db
3042888126
value from digest
3042888126
/Users/jeff/.ccm/snapshot/node1/data/test2/uncompressed_table-c37ed850b7d311e4a8fa85b755fc16c4/la-3-big-Data.db
2620019278
value from digest
2620019278
/Users/jeff/.ccm/snapshot/node1/data/test2/uncompressed_table-c37ed850b7d311e4a8fa85b755fc16c4/la-4-big-Data.db
2131686065
value from digest
2131686065
{noformat}

 Adler32 Digests for Compressed SSTables are Incorrect
 -

 Key: CASSANDRA-8778
 URL: https://issues.apache.org/jira/browse/CASSANDRA-8778
 Project: Cassandra
  Issue Type: Bug
Reporter: Jeff Jirsa
Priority: Trivial
 Attachments: cassandra-8778.patch


 ChecksumWriter append() calculates the checksum of a buffer, then also writes 
 that checksum as an int into the provided DataOutput. The final call to 
 writeFullChecksum will have the checksum of all of the buffers, but none of 
 the intermediate int checksums.
 This issue was discovered (and a fix proposed) in #5791 - if the patch for 
 #5791 is not accepted, some fix for 
 src/java/org/apache/cassandra/io/util/DataIntegrityMetadata.java should be 
 applied. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)