svn commit: r804633 - /mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/xmlfragment/XMLElement.java
Author: ngn Date: Sun Aug 16 06:34:42 2009 New Revision: 804633 URL: http://svn.apache.org/viewvc?rev=804633view=rev Log: Reverting change where we returned null instead of an empty string for elements in the empty namespace. Modified: mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/xmlfragment/XMLElement.java Modified: mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/xmlfragment/XMLElement.java URL: http://svn.apache.org/viewvc/mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/xmlfragment/XMLElement.java?rev=804633r1=804632r2=804633view=diff == --- mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/xmlfragment/XMLElement.java (original) +++ mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/xmlfragment/XMLElement.java Sun Aug 16 06:34:42 2009 @@ -97,6 +97,11 @@ String uri = getAttributeValue(xmlnsName); +// return empty string if the element is in the empty namespace +if(uri == null) { +uri = ; +} + return uri; }
svn commit: r804749 - /mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/protocol/StanzaHandlerLookup.java
Author: ngn Date: Sun Aug 16 19:29:45 2009 New Revision: 804749 URL: http://svn.apache.org/viewvc?rev=804749view=rev Log: Reverting to not using namespace handler lookup for presence and message type stanzas for now Modified: mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/protocol/StanzaHandlerLookup.java Modified: mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/protocol/StanzaHandlerLookup.java URL: http://svn.apache.org/viewvc/mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/protocol/StanzaHandlerLookup.java?rev=804749r1=804748r2=804749view=diff == --- mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/protocol/StanzaHandlerLookup.java (original) +++ mina/sandbox/vysper/trunk/server/core/src/main/java/org/apache/vysper/xmpp/protocol/StanzaHandlerLookup.java Sun Aug 16 19:29:45 2009 @@ -140,11 +140,11 @@ } private StanzaHandler getPresenceHandler(Stanza stanza) { -return getHandler(stanza, presenceHandler); +return presenceHandler; } private StanzaHandler getMessageHandler(Stanza stanza) { -return getHandler(stanza, messageHandler); +return messageHandler; } private StanzaHandler getIQHandler(Stanza stanza) {
svn commit: r804770 - /mina/sandbox/vysper/trunk/server/extensions/xep0045-muc/src/main/java/org/apache/vysper/xmpp/modules/extension/xep0045_muc/model/Occupant.java
Author: ngn Date: Sun Aug 16 20:41:17 2009 New Revision: 804770 URL: http://svn.apache.org/viewvc?rev=804770view=rev Log: Add null checks in constructor and toString Modified: mina/sandbox/vysper/trunk/server/extensions/xep0045-muc/src/main/java/org/apache/vysper/xmpp/modules/extension/xep0045_muc/model/Occupant.java Modified: mina/sandbox/vysper/trunk/server/extensions/xep0045-muc/src/main/java/org/apache/vysper/xmpp/modules/extension/xep0045_muc/model/Occupant.java URL: http://svn.apache.org/viewvc/mina/sandbox/vysper/trunk/server/extensions/xep0045-muc/src/main/java/org/apache/vysper/xmpp/modules/extension/xep0045_muc/model/Occupant.java?rev=804770r1=804769r2=804770view=diff == --- mina/sandbox/vysper/trunk/server/extensions/xep0045-muc/src/main/java/org/apache/vysper/xmpp/modules/extension/xep0045_muc/model/Occupant.java (original) +++ mina/sandbox/vysper/trunk/server/extensions/xep0045-muc/src/main/java/org/apache/vysper/xmpp/modules/extension/xep0045_muc/model/Occupant.java Sun Aug 16 20:41:17 2009 @@ -35,6 +35,11 @@ private String name; public Occupant(Entity jid, String name, Affiliation affiliation, Role role) { +if(jid == null) throw new IllegalArgumentException(JID can not be null); +if(name == null) throw new IllegalArgumentException(Name can not be null); +if(affiliation == null) throw new IllegalArgumentException(Affiliation can not be null); +if(role == null) throw new IllegalArgumentException(Role can not be null); + this.jid = jid; this.name = name; this.affiliation = affiliation; @@ -73,5 +78,9 @@ return role == Role.Moderator || role == Role.Participant; } +@Override +public String toString() { +return jid.getFullQualifiedName(); +} }
svn commit: r804819 - /mina/sshd/trunk/sshd-core/src/main/java/org/apache/sshd/common/session/AbstractSession.java
Author: gnodet Date: Sun Aug 16 23:47:23 2009 New Revision: 804819 URL: http://svn.apache.org/viewvc?rev=804819view=rev Log: SSHD-38: Typo that causes performance degradation with DEBUG-level logging enabled Modified: mina/sshd/trunk/sshd-core/src/main/java/org/apache/sshd/common/session/AbstractSession.java Modified: mina/sshd/trunk/sshd-core/src/main/java/org/apache/sshd/common/session/AbstractSession.java URL: http://svn.apache.org/viewvc/mina/sshd/trunk/sshd-core/src/main/java/org/apache/sshd/common/session/AbstractSession.java?rev=804819r1=804818r2=804819view=diff == --- mina/sshd/trunk/sshd-core/src/main/java/org/apache/sshd/common/session/AbstractSession.java (original) +++ mina/sshd/trunk/sshd-core/src/main/java/org/apache/sshd/common/session/AbstractSession.java Sun Aug 16 23:47:23 2009 @@ -357,7 +357,7 @@ int len = buffer.available(); int off = buffer.rpos() - 5; // Debug log the packet -if (log.isDebugEnabled()) { +if (log.isTraceEnabled()) { log.trace(Sending packet #{}: {}, seqo, buffer.printHex()); } // Compress the packet if needed