Re: svn commit: r466600 - in /shale/framework/trunk/shale-test/src: main/java/org/apache/shale/test/el/ main/java/org/apache/shale/test/mock/ test/java/org/apache/shale/test/el/ test/java/org/apache/s

2006-10-26 Thread Craig McClanahan

On 10/21/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:


Author: gvanmatre
Date: Sat Oct 21 15:46:02 2006
New Revision: 466600

URL: http://svn.apache.org/viewvc?view=revrev=466600
Log:
Added better mock value binding expression support for scoped attribute
names that contain dotted values.



Interesting approach.  Shouldn't we do something simpler to the
1.1-compatible ValueBinding and MethodBinding implementations in shale-test?

Craig


svn commit: r468054 - /shale/framework/trunk/pom.xml

2006-10-26 Thread matzew
Author: matzew
Date: Thu Oct 26 09:14:42 2006
New Revision: 468054

URL: http://svn.apache.org/viewvc?view=revrev=468054
Log:
whoops, that was to much of my personal shale ...

Modified:
shale/framework/trunk/pom.xml

Modified: shale/framework/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/shale/framework/trunk/pom.xml?view=diffrev=468054r1=468053r2=468054
==
--- shale/framework/trunk/pom.xml (original)
+++ shale/framework/trunk/pom.xml Thu Oct 26 09:14:42 2006
@@ -108,7 +108,7 @@
 moduleshale-spring/module
 moduleshale-test/module
 moduleshale-tiger/module
-!--moduleshale-tiles/module--
+moduleshale-tiles/module
 moduleshale-validator/module
 moduleshale-view/module
 /modules




svn commit: r468201 - /shale/framework/trunk/shale-dialog/src/main/java/org/apache/shale/dialog/base/AbstractDialogContext.java

2006-10-26 Thread rahul
Author: rahul
Date: Thu Oct 26 17:04:07 2006
New Revision: 468201

URL: http://svn.apache.org/viewvc?view=revrev=468201
Log:
Exceptions should first be logged before DialogListener callbacks, for better 
archival.
SHALE-268

Modified:

shale/framework/trunk/shale-dialog/src/main/java/org/apache/shale/dialog/base/AbstractDialogContext.java

Modified: 
shale/framework/trunk/shale-dialog/src/main/java/org/apache/shale/dialog/base/AbstractDialogContext.java
URL: 
http://svn.apache.org/viewvc/shale/framework/trunk/shale-dialog/src/main/java/org/apache/shale/dialog/base/AbstractDialogContext.java?view=diffrev=468201r1=468200r2=468201
==
--- 
shale/framework/trunk/shale-dialog/src/main/java/org/apache/shale/dialog/base/AbstractDialogContext.java
 (original)
+++ 
shale/framework/trunk/shale-dialog/src/main/java/org/apache/shale/dialog/base/AbstractDialogContext.java
 Thu Oct 26 17:04:07 2006
@@ -21,6 +21,8 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.apache.shale.dialog.DialogContext;
 import org.apache.shale.dialog.DialogListener;
 
@@ -41,6 +43,12 @@
 private List listeners = new ArrayList();
 
 
+/**
+ * pThe codeLog/code instance for this class./p
+ */
+private transient Log log;
+
+
 //--- Listener Bookkeeping
 
 /**
@@ -139,13 +147,16 @@
 
 /**
  * Inform all registered [EMAIL PROTECTED] DialogListener}s that the dialog
- * instance has encountered an unexpected error condition.
+ * instance has encountered an unexpected error condition. The exception
+ * is first logged for archival.
  *
  * @param exception A potentially implementation specific exception
  *  during the execution of this dialog instance
  */
 protected void fireOnException(Exception exception) {
 
+log().error(exception.getMessage(), exception);
+
 synchronized (listeners) {
 for (int i = 0; i  listeners.size(); i++) {
 DialogListener listener = (DialogListener) listeners.get(i);
@@ -211,6 +222,19 @@
 listener.onTransition(fromStateId, toStateId);
 }
 }
+
+}
+
+
+/**
+ * pReturn the codeLog/code instance for this class./p
+ */
+private Log log() {
+
+if (log == null) {
+log = LogFactory.getLog(AbstractDialogContext.class);
+}
+return log;
 
 }
 




svn commit: r468202 - /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/CommonsValidator.java

2006-10-26 Thread rahul
Author: rahul
Date: Thu Oct 26 17:17:03 2006
New Revision: 468202

URL: http://svn.apache.org/viewvc?view=revrev=468202
Log:
Validators only work if the validation methods are static.
SHALE-320

Modified:

shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/CommonsValidator.java

Modified: 
shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/CommonsValidator.java
URL: 
http://svn.apache.org/viewvc/shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/CommonsValidator.java?view=diffrev=468202r1=468201r2=468202
==
--- 
shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/CommonsValidator.java
 (original)
+++ 
shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/CommonsValidator.java
 Thu Oct 26 17:17:03 2006
@@ -852,7 +852,7 @@
if (!Modifier.isStatic(validatorMethod.getModifiers())) {
validator = validatorClass.newInstance();
}
-   Boolean r = (Boolean) validatorMethod.invoke(validatorClass, 
paramValues);
+   Boolean r = (Boolean) validatorMethod.invoke(validator, 
paramValues);
if (r.equals(Boolean.FALSE)) {
throw new ValidatorException(new FacesMessage(
FacesMessage.SEVERITY_ERROR,




svn commit: r468215 - in /shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test: el/MockValueExpression.java mock/MockValueBinding.java

2006-10-26 Thread rahul
Author: rahul
Date: Thu Oct 26 17:52:30 2006
New Revision: 468215

URL: http://svn.apache.org/viewvc?view=revrev=468215
Log:
Unused labels.
SHALE-310

Modified:

shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/el/MockValueExpression.java

shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/mock/MockValueBinding.java

Modified: 
shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/el/MockValueExpression.java
URL: 
http://svn.apache.org/viewvc/shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/el/MockValueExpression.java?view=diffrev=468215r1=468214r2=468215
==
--- 
shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/el/MockValueExpression.java
 (original)
+++ 
shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/el/MockValueExpression.java
 Thu Oct 26 17:52:30 2006
@@ -268,7 +268,7 @@
 List names = new ArrayList();
 StringBuffer expr = new StringBuffer(expression.substring(2, 
expression.length() - 1).replaceAll( , ));
 boolean isBlockOn = false;
-next: for (int i = expr.length() - 1; i  -1; i--) {
+for (int i = expr.length() - 1; i  -1; i--) {
 if (expr.charAt(i) == ' ') {
 expr.deleteCharAt(i);
 } else if (expr.charAt(i) == ']') {

Modified: 
shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/mock/MockValueBinding.java
URL: 
http://svn.apache.org/viewvc/shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/mock/MockValueBinding.java?view=diffrev=468215r1=468214r2=468215
==
--- 
shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/mock/MockValueBinding.java
 (original)
+++ 
shale/framework/trunk/shale-test/src/main/java/org/apache/shale/test/mock/MockValueBinding.java
 Thu Oct 26 17:52:30 2006
@@ -329,7 +329,7 @@
 List names = new ArrayList();
 StringBuffer expr = new StringBuffer(ref);
 boolean isBlockOn = false;
-next: for (int i = expr.length() - 1; i  -1; i--) {
+for (int i = expr.length() - 1; i  -1; i--) {
 if (expr.charAt(i) == ' ') {
 expr.deleteCharAt(i);
 } else if (expr.charAt(i) == ']') {




svn commit: r468238 - /shale/maven/trunk/master-pom/pom.xml

2006-10-26 Thread wsmoak
Author: wsmoak
Date: Thu Oct 26 19:19:34 2006
New Revision: 468238

URL: http://svn.apache.org/viewvc?view=revrev=468238
Log:
Stage releases under people.apache.org/builds instead of in the snapshot 
repository.
SHALE-319

Modified:
shale/maven/trunk/master-pom/pom.xml

Modified: shale/maven/trunk/master-pom/pom.xml
URL: 
http://svn.apache.org/viewvc/shale/maven/trunk/master-pom/pom.xml?view=diffrev=468238r1=468237r2=468238
==
--- shale/maven/trunk/master-pom/pom.xml (original)
+++ shale/maven/trunk/master-pom/pom.xml Thu Oct 26 19:19:34 2006
@@ -162,9 +162,9 @@
 
 distributionManagement
 repository
-idapache.snapshots/id
-nameApache Development Snapshot (and Test Build) 
Repository/name
-
urlscp://people.apache.org/www/people.apache.org/repo/m2-snapshot-repository/url
+idshale-staging/id
+nameApache Shale Staging Repository/name
+
urlscp://people.apache.org/www/people.apache.org/builds/shale/m2-staging-repository/url
 /repository
 snapshotRepository
 uniqueVersionfalse/uniqueVersion




svn commit: r468275 - /shale/framework/trunk/pom.xml

2006-10-26 Thread wsmoak
Author: wsmoak
Date: Thu Oct 26 22:09:29 2006
New Revision: 468275

URL: http://svn.apache.org/viewvc?view=revrev=468275
Log:
Adding apache.snapshots back to the shale-parent pom, so that it can find its 
parent, shale-master, in the snapshot repository.
Releases are disabled to keep Maven from searching the snapshot repo for 
non-snapshot versions.
SHALE-319

Modified:
shale/framework/trunk/pom.xml

Modified: shale/framework/trunk/pom.xml
URL: 
http://svn.apache.org/viewvc/shale/framework/trunk/pom.xml?view=diffrev=468275r1=468274r2=468275
==
--- shale/framework/trunk/pom.xml (original)
+++ shale/framework/trunk/pom.xml Thu Oct 26 22:09:29 2006
@@ -48,6 +48,15 @@
 urlscp://people.apache.org/www/shale.apache.org/url
 /site
 /distributionManagement
+
+repositories
+repository
+idapache.snapshots/id
+nameApache Development Snapshot Repository/name
+urlhttp://people.apache.org/repo/m2-snapshot-repository/url
+releasesenabledfalse/enabled/releases
+/repository
+/repositories
 
 !-- http://jira.codehaus.org/browse/MNG-2136 --
 profiles




[Shale Wiki] Update of ReleaseProcess by WendySmoak

2006-10-26 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Shale Wiki for change 
notification.

The following page has been changed by WendySmoak:
http://wiki.apache.org/shale/ReleaseProcess

The comment on the change is:
From SHALE-319, distribution management repository has changed.

--
+ === Build and Deploy the release ===
+ 
+ Maven artifacts are staged under 
http://people.apache.org/builds/shale/m2-snapshot-repository.
+ 
+ Each build should be staged separately, so once the build is complete, move 
the 'm2-snapshot-repository' underneath the (for example) 
builds/shale/shale-1.0.4 directory.
+ 
  === Archive the SNAPSHOT version in JIRA ===
  
  1.) Create a new JIRA version for the release (ex. 1.0.3)