git commit: SPARK-1488. Resolve scalac feature warnings during build
Repository: spark Updated Branches: refs/heads/branch-1.0 fdebb6952 - 74718285a SPARK-1488. Resolve scalac feature warnings during build For your consideration: scalac currently notes a number of feature warnings during compilation: ``` [warn] there were 65 feature warning(s); re-run with -feature for details ``` Warnings are like: ``` [warn] /Users/srowen/Documents/spark/core/src/main/scala/org/apache/spark/SparkContext.scala:1261: implicit conversion method rddToPairRDDFunctions should be enabled [warn] by making the implicit value scala.language.implicitConversions visible. [warn] This can be achieved by adding the import clause 'import scala.language.implicitConversions' [warn] or by setting the compiler option -language:implicitConversions. [warn] See the Scala docs for value scala.language.implicitConversions for a discussion [warn] why the feature should be explicitly enabled. [warn] implicit def rddToPairRDDFunctions[K: ClassTag, V: ClassTag](rdd: RDD[(K, V)]) = [warn]^ ``` scalac is suggesting that it's just best practice to explicitly enable certain language features by importing them where used. This PR simply adds the imports it suggests (and squashes one other Java warning along the way). This leaves just deprecation warnings in the build. Author: Sean Owen so...@cloudera.com Closes #404 from srowen/SPARK-1488 and squashes the following commits: 8598980 [Sean Owen] Quiet scalac warnings about language features by explicitly importing language features. 39bc831 [Sean Owen] Enable -feature in scalac to emit language feature warnings (cherry picked from commit 0247b5c5467ca1b0d03ba929a78fa4d805582d84) Signed-off-by: Patrick Wendell pwend...@gmail.com Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/74718285 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/74718285 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/74718285 Branch: refs/heads/branch-1.0 Commit: 74718285adc9ddce434473fcae32fe32a6c95c74 Parents: fdebb69 Author: Sean Owen so...@cloudera.com Authored: Mon Apr 14 19:50:00 2014 -0700 Committer: Patrick Wendell pwend...@gmail.com Committed: Mon Apr 14 19:55:48 2014 -0700 -- bagel/src/test/scala/org/apache/spark/bagel/BagelSuite.scala | 2 ++ core/src/main/scala/org/apache/spark/SparkContext.scala | 1 + core/src/main/scala/org/apache/spark/api/java/JavaDoubleRDD.scala | 1 + core/src/main/scala/org/apache/spark/api/java/JavaPairRDD.scala | 1 + core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala | 1 + .../main/scala/org/apache/spark/api/java/JavaSparkContext.scala | 1 + .../main/scala/org/apache/spark/deploy/FaultToleranceTest.scala | 1 + core/src/main/scala/org/apache/spark/deploy/master/Master.scala | 1 + core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala | 1 + .../main/scala/org/apache/spark/network/ConnectionManager.scala | 1 + core/src/main/scala/org/apache/spark/rdd/CoGroupedRDD.scala | 1 + core/src/main/scala/org/apache/spark/rdd/CoalescedRDD.scala | 1 + .../main/scala/org/apache/spark/scheduler/DAGSchedulerEvent.scala | 1 + core/src/main/scala/org/apache/spark/scheduler/ResultTask.scala | 1 + .../main/scala/org/apache/spark/scheduler/ShuffleMapTask.scala| 1 + .../main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala | 1 + core/src/main/scala/org/apache/spark/ui/JettyUtils.scala | 1 + .../scala/org/apache/spark/util/TimeStampedWeakValueHashMap.scala | 1 + core/src/main/scala/org/apache/spark/util/Vector.scala| 1 + core/src/test/scala/org/apache/spark/ConnectionManagerSuite.scala | 2 +- core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala| 2 ++ core/src/test/scala/org/apache/spark/DriverSuite.scala| 2 ++ core/src/test/scala/org/apache/spark/PipedRDDSuite.scala | 3 +-- .../test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala| 1 + .../test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala | 1 + .../test/scala/org/apache/spark/storage/BlockManagerSuite.scala | 3 +++ .../scala/org/apache/spark/storage/DiskBlockManagerSuite.scala| 1 + core/src/test/scala/org/apache/spark/ui/UISuite.scala | 1 + .../scala/org/apache/spark/util/random/XORShiftRandomSuite.scala | 2 ++ .../org/apache/spark/streaming/examples/ZeroMQWordCount.scala | 2 ++ graphx/src/main/scala/org/apache/spark/graphx/Graph.scala | 1 + .../scala/org/apache/spark/graphx/impl/MessageToPartition.scala | 1 + .../src/main/scala/org/apache/spark/graphx/impl/Serializers.scala | 3 ++- .../main/scala/org/apache/spark/graphx/util/BytecodeUtils.scala | 1 + .../src/main/scala/org/apache/spark/mllib/rdd/RDDFunctions.scala | 1 + .../main/scala/org/apache/spark/mllib/util/MFDataGenerator.scala | 1 +
git commit: SPARK-1488. Resolve scalac feature warnings during build
Repository: spark Updated Branches: refs/heads/master 268b53567 - 0247b5c54 SPARK-1488. Resolve scalac feature warnings during build For your consideration: scalac currently notes a number of feature warnings during compilation: ``` [warn] there were 65 feature warning(s); re-run with -feature for details ``` Warnings are like: ``` [warn] /Users/srowen/Documents/spark/core/src/main/scala/org/apache/spark/SparkContext.scala:1261: implicit conversion method rddToPairRDDFunctions should be enabled [warn] by making the implicit value scala.language.implicitConversions visible. [warn] This can be achieved by adding the import clause 'import scala.language.implicitConversions' [warn] or by setting the compiler option -language:implicitConversions. [warn] See the Scala docs for value scala.language.implicitConversions for a discussion [warn] why the feature should be explicitly enabled. [warn] implicit def rddToPairRDDFunctions[K: ClassTag, V: ClassTag](rdd: RDD[(K, V)]) = [warn]^ ``` scalac is suggesting that it's just best practice to explicitly enable certain language features by importing them where used. This PR simply adds the imports it suggests (and squashes one other Java warning along the way). This leaves just deprecation warnings in the build. Author: Sean Owen so...@cloudera.com Closes #404 from srowen/SPARK-1488 and squashes the following commits: 8598980 [Sean Owen] Quiet scalac warnings about language features by explicitly importing language features. 39bc831 [Sean Owen] Enable -feature in scalac to emit language feature warnings Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0247b5c5 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0247b5c5 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0247b5c5 Branch: refs/heads/master Commit: 0247b5c5467ca1b0d03ba929a78fa4d805582d84 Parents: 268b535 Author: Sean Owen so...@cloudera.com Authored: Mon Apr 14 19:50:00 2014 -0700 Committer: Patrick Wendell pwend...@gmail.com Committed: Mon Apr 14 19:50:00 2014 -0700 -- bagel/src/test/scala/org/apache/spark/bagel/BagelSuite.scala | 2 ++ core/src/main/scala/org/apache/spark/SparkContext.scala | 1 + core/src/main/scala/org/apache/spark/api/java/JavaDoubleRDD.scala | 1 + core/src/main/scala/org/apache/spark/api/java/JavaPairRDD.scala | 1 + core/src/main/scala/org/apache/spark/api/java/JavaRDD.scala | 1 + .../main/scala/org/apache/spark/api/java/JavaSparkContext.scala | 1 + .../main/scala/org/apache/spark/deploy/FaultToleranceTest.scala | 1 + core/src/main/scala/org/apache/spark/deploy/master/Master.scala | 1 + core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala | 1 + .../main/scala/org/apache/spark/network/ConnectionManager.scala | 1 + core/src/main/scala/org/apache/spark/rdd/CoGroupedRDD.scala | 1 + core/src/main/scala/org/apache/spark/rdd/CoalescedRDD.scala | 1 + .../main/scala/org/apache/spark/scheduler/DAGSchedulerEvent.scala | 1 + core/src/main/scala/org/apache/spark/scheduler/ResultTask.scala | 1 + .../main/scala/org/apache/spark/scheduler/ShuffleMapTask.scala| 1 + .../main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala | 1 + core/src/main/scala/org/apache/spark/ui/JettyUtils.scala | 1 + .../scala/org/apache/spark/util/TimeStampedWeakValueHashMap.scala | 1 + core/src/main/scala/org/apache/spark/util/Vector.scala| 1 + core/src/test/scala/org/apache/spark/ConnectionManagerSuite.scala | 2 +- core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala| 2 ++ core/src/test/scala/org/apache/spark/DriverSuite.scala| 2 ++ core/src/test/scala/org/apache/spark/PipedRDDSuite.scala | 3 +-- .../test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala| 1 + .../test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala | 1 + .../test/scala/org/apache/spark/storage/BlockManagerSuite.scala | 3 +++ .../scala/org/apache/spark/storage/DiskBlockManagerSuite.scala| 1 + core/src/test/scala/org/apache/spark/ui/UISuite.scala | 1 + .../scala/org/apache/spark/util/random/XORShiftRandomSuite.scala | 2 ++ .../org/apache/spark/streaming/examples/ZeroMQWordCount.scala | 2 ++ graphx/src/main/scala/org/apache/spark/graphx/Graph.scala | 1 + .../scala/org/apache/spark/graphx/impl/MessageToPartition.scala | 1 + .../src/main/scala/org/apache/spark/graphx/impl/Serializers.scala | 3 ++- .../main/scala/org/apache/spark/graphx/util/BytecodeUtils.scala | 1 + .../src/main/scala/org/apache/spark/mllib/rdd/RDDFunctions.scala | 1 + .../main/scala/org/apache/spark/mllib/util/MFDataGenerator.scala | 1 + .../test/java/org/apache/spark/mllib/linalg/JavaVectorsSuite.java | 1 + pom.xml | 1 +
