Re: PATCH [dbcp] fix for negative numActive
Thanks Dirk! I've worked up a good JUnit test for this bug fix, and I'm just about finished with it. I'll probably have time to put the finishing touches on it within the next few days. Wayne Woodfield Dirk Verbeeck wrote: patch applied -- Dirk - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 20815] - FileUpload always assumes transfer encoding to be BINARY and does not properly handle 'Content-Transfer-Encoding' header
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=20815. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=20815 FileUpload always assumes transfer encoding to be BINARY and does not properly handle 'Content-Transfer-Encoding' header [EMAIL PROTECTED] changed: What|Removed |Added OS/Version|All |Linux Product|Commons |Struts Version|1.0 Beta 2 |1.1 Final - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28619] New: - GenericObjectPool: Swallowed Exception
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28619. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28619 GenericObjectPool: Swallowed Exception Summary: GenericObjectPool: Swallowed Exception Product: Commons Version: 1.1 Final Platform: All OS/Version: Other Status: NEW Severity: Enhancement Priority: Other Component: Pool AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Unfortunately, the thrown Exceptions are not further thrown or packed into a new Exception in the method PoolableObjectFactory.validateObject() and PoolableObjectFactory.activateObject() at the GenericObjectPool. In the method GenericObjectPool.borrowObject() these two methods are executed and at an error only a new NoSuchElementException is thrown. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28629] New: - CollectionUtils.cardinality should be made smarter about Bag
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28629. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28629 CollectionUtils.cardinality should be made smarter about Bag Summary: CollectionUtils.cardinality should be made smarter about Bag Product: Commons Version: 3.0 Final Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Collections AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I see that Bag implementations have a getCount() method that one would presume is more efficient than iterating over the objects in the Collection. Why doesn't CollectionUtils.cardinality() take advantage of this? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28629] - CollectionUtils.cardinality should be made smarter about Bag
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28629.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28629
CollectionUtils.cardinality should be made smarter about Bag
--- Additional Comments From [EMAIL PROTECTED] 2004-04-27 14:38 ---
The simple change for this would be:
public static int cardinality(Object obj, final Collection col) {
if(col instanceof Bag) {
return ((Bag)col).getCount(obj);
} else {
//put the current body here
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] betwixt support for derived interfaces
Hi,
I sent out the attached email below to a betwixt developer a
while ago. That email details the problem I faced when using betwixt.
Patch.diff contains the changes I made. org.commons.betwixt.interfaces
contains the JUnit test code.
Can someone tell me how would I know if this patch is
rejected or accepted?
Thanks,
Chien-Hsing Wu
QuadraMed Corporation
(703)709-2431
[EMAIL PROTECTED]
-Original Message-
From: Wu, Chien-Hsing
Sent: Wednesday, April 14, 2004
12:57 PM
To: '[EMAIL PROTECTED]'
Subject: betwixt question
Hi,
Pardon my intrusion but I am trying to use betwixt and came
across a problem that I could not find any answers on the web. I saw that you
are listed in the team web page of the betwixt site so I'd thought
I'll ask you directly.
I have a plural property in the top level bean whose type is
an interface with multiple base interfaces, like the following code:
package com.mystuff;
public class RootBean implements IContainer {
public IContainer[] getChildren() {
}
public void addChild(IContainer
child) {
}
}
public interface IContainer entends IEnv, IService {
public IContainer[] getChildren();
public void addChild(IContainer child);
}
I set RootBean.betwixt like:
element name='Root'
element name='pot' property='children' type='com.mystuff.Pot'
element name='belly' property='children'
type='com.mystuff.Belly'
/element
after went through the source code and found that I can set
the property type using the type attribute in element. I was hoping
that in doing so ElementDescriptors for the element 'pot' is
derived from com.mysutff.Pot not com.mystuff.IContainer when reading from an
XML file. The reason for that is IContainer is an interface and Java Introspector
does not return all properties of an interface, including its base interfaces.
I could not use ClassNormalizer since it's only used when writing beans
out and it can only map from one class to another.
And it did not work as I hoped. After dig in the code more I
found that the type of the property in my betwixt file is overwritten by the
call to ElementRule.configureDescriptor - XMLIntrospectorHelper.configureProperty
and XMLIntrospectorHelper.defaultAddMethods. Moreover, XMLIntrospectorHelper.defaultAddMethods
also overwrites updater.
Can you tell me if this over writing behavior is intended or
not? If not, what's the expected behavior?
Thank you for your valuable input.
Chien-Hsing Wu
QuadraMed Corporation
(703)709-2431
[EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/math/src/java/org/apache/commons/math/stat/multivariate BivariateRegression.java
brentworden2004/04/27 09:42:35
Modified:math/src/java/org/apache/commons/math/stat/univariate/moment
GeometricMean.java FirstMoment.java
SecondMoment.java Skewness.java ThirdMoment.java
Kurtosis.java StandardDeviation.java
FourthMoment.java Mean.java Variance.java
math/src/test/org/apache/commons/math/stat
StatUtilsTest.java
math/src/java/org/apache/commons/math/stat/univariate/summary
SumOfSquares.java Sum.java SumOfLogs.java
Product.java
math/src/test/org/apache/commons/math/stat/univariate
StorelessUnivariateStatisticAbstractTest.java
DescriptiveStatisticsTest.java
math/src/java/org/apache/commons/math/analysis
BisectionSolver.java UnivariateRealSolverImpl.java
math/src/java/org/apache/commons/math/stat/univariate/rank
Min.java Median.java Max.java Percentile.java
math/src/java/org/apache/commons/math/stat/univariate
AbstractUnivariateStatistic.java
math/src/java/org/apache/commons/math/util
ContractableDoubleArray.java FixedDoubleArray.java
ExpandableDoubleArray.java
math/src/java/org/apache/commons/math/stat/inference
TestStatisticImpl.java
math/src/java/org/apache/commons/math/distribution
NormalDistributionImpl.java
math/src/java/org/apache/commons/math/stat/multivariate
BivariateRegression.java
Added: math/src/test/org/apache/commons/math/analysis
UnivariateRealSolverFactoryImplTest.java
math/src/test/org/apache/commons/math/stat/univariate/moment
FirstMomentTest.java
Log:
Fixed some checkstyle warnings. Added some unit tests.
Revision ChangesPath
1.18 +2 -1
jakarta-commons/math/src/java/org/apache/commons/math/stat/univariate/moment/GeometricMean.java
Index: GeometricMean.java
===
RCS file:
/home/cvs/jakarta-commons/math/src/java/org/apache/commons/math/stat/univariate/moment/GeometricMean.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- GeometricMean.java4 Mar 2004 04:25:09 - 1.17
+++ GeometricMean.java27 Apr 2004 16:42:30 - 1.18
@@ -26,6 +26,7 @@
*/
public class GeometricMean extends SumOfLogs implements Serializable{
+/** Serializable version identifier */
static final long serialVersionUID = -8178734905303459453L;
/** */
1.14 +2 -1
jakarta-commons/math/src/java/org/apache/commons/math/stat/univariate/moment/FirstMoment.java
Index: FirstMoment.java
===
RCS file:
/home/cvs/jakarta-commons/math/src/java/org/apache/commons/math/stat/univariate/moment/FirstMoment.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- FirstMoment.java 21 Feb 2004 21:35:15 - 1.13
+++ FirstMoment.java 27 Apr 2004 16:42:30 - 1.14
@@ -30,6 +30,7 @@
*/
public class FirstMoment extends AbstractStorelessUnivariateStatistic implements
Serializable{
+/** Serializable version identifier */
static final long serialVersionUID = -803343206421984070L;
/** count of values that have been added */
1.15 +2 -1
jakarta-commons/math/src/java/org/apache/commons/math/stat/univariate/moment/SecondMoment.java
Index: SecondMoment.java
===
RCS file:
/home/cvs/jakarta-commons/math/src/java/org/apache/commons/math/stat/univariate/moment/SecondMoment.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- SecondMoment.java 21 Feb 2004 21:35:15 - 1.14
+++ SecondMoment.java 27 Apr 2004 16:42:30 - 1.15
@@ -26,6 +26,7 @@
*/
public class SecondMoment extends FirstMoment implements Serializable {
+/** Serializable version identifier */
static final long serialVersionUID = 3942403127395076445L;
/** second moment of values that have been added */
1.20 +4 -1
jakarta-commons/math/src/java/org/apache/commons/math/stat/univariate/moment/Skewness.java
Index: Skewness.java
===
RCS file:
/home/cvs/jakarta-commons/math/src/java/org/apache/commons/math/stat/univariate/moment/Skewness.java,v
retrieving revision 1.19
retrieving
cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/linear MatrixIndexExceptionTest.java InvalidMatrixExceptionTest.java
brentworden2004/04/27 09:51:52
Added: math/src/test/org/apache/commons/math/linear
MatrixIndexExceptionTest.java
InvalidMatrixExceptionTest.java
Log:
Unit tests.
Revision ChangesPath
1.1
jakarta-commons/math/src/test/org/apache/commons/math/linear/MatrixIndexExceptionTest.java
Index: MatrixIndexExceptionTest.java
===
/*
* Copyright 2003-2004 The Apache Software Foundation.
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.math.linear;
import junit.framework.TestCase;
/**
* @version $Revision: 1.1 $ $Date: 2004/04/27 16:51:52 $
*/
public class MatrixIndexExceptionTest extends TestCase {
/**
*
*/
public void testConstructor(){
MatrixIndexException ex = new MatrixIndexException();
assertNull(ex.getCause());
assertNull(ex.getMessage());
}
/**
*
*/
public void testConstructorMessage(){
String msg = message;
MatrixIndexException ex = new MatrixIndexException(msg);
assertNull(ex.getCause());
assertEquals(msg, ex.getMessage());
}
/**
*
*/
public void testConstructorMessageCause(){
String outMsg = outer message;
String inMsg = inner message;
Exception cause = new Exception(inMsg);
MatrixIndexException ex = new MatrixIndexException(outMsg, cause);
assertEquals(outMsg, ex.getMessage());
assertEquals(cause, ex.getCause());
}
/**
*
*/
public void testConstructorCause(){
String inMsg = inner message;
Exception cause = new Exception(inMsg);
MatrixIndexException ex = new MatrixIndexException(cause);
assertEquals(cause, ex.getCause());
}
}
1.1
jakarta-commons/math/src/test/org/apache/commons/math/linear/InvalidMatrixExceptionTest.java
Index: InvalidMatrixExceptionTest.java
===
/*
* Copyright 2003-2004 The Apache Software Foundation.
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.math.linear;
import junit.framework.TestCase;
/**
* @version $Revision: 1.1 $ $Date: 2004/04/27 16:51:52 $
*/
public class InvalidMatrixExceptionTest extends TestCase {
/**
*
*/
public void testConstructor(){
InvalidMatrixException ex = new InvalidMatrixException();
assertNull(ex.getCause());
assertNull(ex.getMessage());
}
/**
*
*/
public void testConstructorMessage(){
String msg = message;
InvalidMatrixException ex = new InvalidMatrixException(msg);
assertNull(ex.getCause());
assertEquals(msg, ex.getMessage());
}
/**
*
*/
public void testConstructorMessageCause(){
String outMsg = outer message;
String inMsg = inner message;
Exception cause = new Exception(inMsg);
InvalidMatrixException ex = new InvalidMatrixException(outMsg, cause);
assertEquals(outMsg, ex.getMessage());
assertEquals(cause, ex.getCause());
}
/**
*
*/
public void testConstructorCause(){
String inMsg = inner message;
Exception cause = new Exception(inMsg);
InvalidMatrixException ex = new InvalidMatrixException(cause);
assertEquals(cause, ex.getCause());
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL
Re: [PATCH] betwixt support for derived interfaces
Wu, Chien-Hsing wrote: Can someone tell me how would I know if this patch is rejected or accepted? Your best bet would be to create a new Bugzilla item and attach your patch to it. Otherwise, as you've experienced, it is easy for patches to be missed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [PATCH] betwixt support for derived interfaces
Thanks for the advice. I'll put in bugzilla. Chien-Hsing Wu QuadraMed Corporation (703)709-2431 [EMAIL PROTECTED] -Original Message- From: matthew.hawthorne [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 27, 2004 2:33 PM To: Jakarta Commons Developers List Subject: Re: [PATCH] betwixt support for derived interfaces Wu, Chien-Hsing wrote: Can someone tell me how would I know if this patch is rejected or accepted? Your best bet would be to create a new Bugzilla item and attach your patch to it. Otherwise, as you've experienced, it is easy for patches to be missed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28635] New: - [PATCH] betwixt support for derived interfaces
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28635.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28635
[PATCH] betwixt support for derived interfaces
Summary: [PATCH] betwixt support for derived interfaces
Product: Commons
Version: 1.0 Alpha
Platform: PC
OS/Version: Windows NT/2K
Status: NEW
Severity: Major
Priority: Other
Component: Betwixt
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]
Hi,
Here’s my second attempt to send the patch. Attached files were not received
correctly. I included Patch.diff and JUnit test package
org.commons.betwixt.interfaces in the email below.
I sent out the attached email below to a betwixt developer a while ago. That
email details the problem I faced when using betwixt.
Patch.diff contains the changes I made. org.commons.betwixt.interfaces contains
the JUnit test code.
Can someone tell me how would I know if this patch is rejected or accepted?
Thanks,
Chien-Hsing Wu
QuadraMed Corporation
(703)709-2431
[EMAIL PROTECTED]
=Original Message==
From: Wu, Chien-Hsing
Sent: Wednesday, April 14, 2004 12:57 PM
To: '[EMAIL PROTECTED]'
Subject: betwixt question
Hi,
Pardon my intrusion but I am trying to use betwixt and came across a problem
that I could not find any answers on the web. I saw that you are listed in the
team web page of the betwixt site so I’d thought I’ll ask you directly.
I have a plural property in the top level bean whose type is an interface with
multiple base interfaces, like the following code:
package com.mystuff;
public class RootBean implements IContainer {
public IContainer[] getChildren() {
}
public void addChild(IContainer child) {
}
}
public interface IContainer entends IEnv, IService {
public IContainer[] getChildren();
public void addChild(IContainer child);
}
I set RootBean.betwixt like:
element name=’Root’
element name=’pot’ property=’children’
type=’com.mystuff.Pot’
element name=’belly’ property=’children’
type=’com.mystuff.Belly’
/element
after went through the source code and found that I can set the property type
using the type attribute in element. I was hoping that in doing so
ElementDescriptors for the element ‘pot’ is derived from com.mysutff.Pot not
com.mystuff.IContainer when reading from an XML file. The reason for that is
IContainer is an interface and Java Introspector does not return all properties
of an interface, including its base interfaces. I could not use ClassNormalizer
since it’s only used when writing beans out and it can only map from one class
to another.
And it did not work as I hoped. After dig in the code more I found that the
type of the property in my betwixt file is overwritten by the call to
ElementRule.configureDescriptor - XMLIntrospectorHelper.configureProperty and
XMLIntrospectorHelper.defaultAddMethods. Moreover,
XMLIntrospectorHelper.defaultAddMethods also overwrites updater.
Can you tell me if this over writing behavior is intended or not? If not,
what’s the expected behavior?
Thank you for your valuable input.
Chien-Hsing Wu
QuadraMed Corporation
(703)709-2431
[EMAIL PROTECTED]
=Patch.diff=
cvs diff -u
? ant-1.5.jar
? ant-optional-1.5.jar
? bin
? commons-beanutils-1.6.1.jar
? commons-collections-2.1.jar
? commons-digester-1.5.jar
? commons-logging-1.0.2.jar
? commons-logging-1.0.3.jar
? junit-3.8.1.jar
? log4j-1.2.8.jar
? xerces-2.2.1.jar
? xml-apis-1.0.b2.jar
? src/test/org/apache/commons/betwixt/interfaces
cvs server: Diffing .
cvs server: Diffing src
cvs server: Diffing src/conf
cvs server: Diffing src/java
cvs server: Diffing src/java/org
cvs server: Diffing src/java/org/apache
cvs server: Diffing src/java/org/apache/commons
cvs server: Diffing src/java/org/apache/commons/betwixt
Index: src/java/org/apache/commons/betwixt/Descriptor.java
===
RCS file: /home/cvspublic/jakarta-
commons/betwixt/src/java/org/apache/commons/betwixt/Descriptor.java,v
retrieving revision 1.5
diff -u -r1.5 Descriptor.java
--- src/java/org/apache/commons/betwixt/Descriptor.java 7 Apr 2004 21:16:27 -
1.5
+++ src/java/org/apache/commons/betwixt/Descriptor.java 26 Apr 2004
+++ 18:51:47 -
@@ -138,7 +138,11 @@
this.singularPropertyType = singularPropertyType;
}
-
+ // Derived Interface Support
+ public boolean isSingularPropertyType() {
+ return (singularPropertyType != null);
+ }
+
/**
* Gets the options for this descriptor.
* Options are used
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/strategy DefaultActionMappingStrategy.java
rdonkin 2004/04/27 12:59:04 Added: betwixt/src/java/org/apache/commons/betwixt/strategy Tag: REFACTORING-BRANCH_2004-01-13 DefaultActionMappingStrategy.java Log: Added support for array property setters Revision ChangesPath No revision No revision 1.1.2.1 +91 -0 jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/strategy/Attic/DefaultActionMappingStrategy.java - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/io/read TestReadContext.java
rdonkin 2004/04/27 12:59:48
Modified:betwixt/src/test/org/apache/commons/betwixt/io/read Tag:
REFACTORING-BRANCH_2004-01-13 TestReadContext.java
Log:
Added support for array property setters
Revision ChangesPath
No revision
No revision
1.1.2.5 +21 -5
jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/io/read/Attic/TestReadContext.java
Index: TestReadContext.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/io/read/Attic/TestReadContext.java,v
retrieving revision 1.1.2.4
retrieving revision 1.1.2.5
diff -u -r1.1.2.4 -r1.1.2.5
--- TestReadContext.java 19 Apr 2004 21:31:13 - 1.1.2.4
+++ TestReadContext.java 27 Apr 2004 19:59:48 - 1.1.2.5
@@ -66,6 +66,7 @@
import org.apache.commons.betwixt.AbstractTestCase;
import org.apache.commons.betwixt.BindingConfiguration;
+import org.apache.commons.betwixt.LibraryBeanWithArraySetter;
/**
* Test harness for ReadContext
@@ -178,6 +179,21 @@
context.markClassMap(Integer.class);
assertEquals(Top class, Integer.class, context.getLastMappedClass());
}
+
+
+public void testNullElementNameMatchesAll() throws Exception {
+
+ReadContext context = new ReadContext(
+new BindingConfiguration(),
+new ReadConfiguration());
+
+context.pushElement(LibraryBeanWithArraySetter);
+context.markClassMap(LibraryBeanWithArraySetter.class);
+context.pushElement(books);
+context.pushElement(whatever);
+assertNotNull(Null name should match any new element,
context.getCurrentDescriptor());
+}
+
/* Sad to say that the method tested has had to be made private.
* Maybe would be good to find a way to test the
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/test/org/apache/commons/betwixt TestDescriptors.java
rdonkin 2004/04/27 13:00:04
Modified:betwixt/src/test/org/apache/commons/betwixt Tag:
REFACTORING-BRANCH_2004-01-13 TestDescriptors.java
Log:
Added support for array property setters
Revision ChangesPath
No revision
No revision
1.4.2.4 +17 -4
jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/TestDescriptors.java
Index: TestDescriptors.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/TestDescriptors.java,v
retrieving revision 1.4.2.3
retrieving revision 1.4.2.4
diff -u -r1.4.2.3 -r1.4.2.4
--- TestDescriptors.java 19 Apr 2004 21:31:13 - 1.4.2.3
+++ TestDescriptors.java 27 Apr 2004 20:00:04 - 1.4.2.4
@@ -157,5 +157,18 @@
returned = descriptor.getElementDescriptor(Barney);
assertTrue(Barney is not a Flintstone, returned == null);
}
+
+public void testGetElementDescriptorByNameNullMatch()
+{
+ElementDescriptor descriptor = new ElementDescriptor(Flintstones);
+descriptor.addElementDescriptor(new ElementDescriptor(Freddy));
+descriptor.addElementDescriptor(new ElementDescriptor(Wilma));
+descriptor.addElementDescriptor(new ElementDescriptor(Pebbles));
+descriptor.addElementDescriptor(new ElementDescriptor());
+
+ElementDescriptor returned = descriptor.getElementDescriptor(NotFreddy);
+assertTrue(NotFreddy matched, returned != null);
+assertEquals(NotFreddy match by null descriptor, null,
returned.getLocalName());
+}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/strategy ActionMappingStrategy.java
rdonkin 2004/04/27 13:00:15
Modified:betwixt/src/java/org/apache/commons/betwixt/strategy Tag:
REFACTORING-BRANCH_2004-01-13
ActionMappingStrategy.java
Log:
Added support for array property setters
Revision ChangesPath
No revision
No revision
1.1.2.3 +14 -26
jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/strategy/Attic/ActionMappingStrategy.java
Index: ActionMappingStrategy.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/strategy/Attic/ActionMappingStrategy.java,v
retrieving revision 1.1.2.2
retrieving revision 1.1.2.3
diff -u -r1.1.2.2 -r1.1.2.3
--- ActionMappingStrategy.java18 Apr 2004 17:34:38 - 1.1.2.2
+++ ActionMappingStrategy.java27 Apr 2004 20:00:15 - 1.1.2.3
@@ -61,11 +61,8 @@
package org.apache.commons.betwixt.strategy;
-import org.apache.commons.betwixt.ElementDescriptor;
-import org.apache.commons.betwixt.io.read.BeanBindAction;
import org.apache.commons.betwixt.io.read.MappingAction;
import org.apache.commons.betwixt.io.read.ReadContext;
-import org.apache.commons.betwixt.io.read.SimpleTypeBindAction;
import org.xml.sax.Attributes;
/**
@@ -82,9 +79,15 @@
* @author a href='http://jakarta.apache.org/'Jakarta Commons Team/a
* @version $Revision$
*/
-public class ActionMappingStrategy {
+public abstract class ActionMappingStrategy {
+
+/**
+ * Default codeActionMappingStrategy/code
+ * used by betwixt
+ */
+public static final ActionMappingStrategy DEFAULT
+= new DefaultActionMappingStrategy();
-
/**
* Gets the mapping action to map the given element.
* @param namespace not null
@@ -94,25 +97,10 @@
* @return codeMappingAction/code, not null
* @throws Exception
*/
-public MappingAction getMappingAction(
+public abstract MappingAction getMappingAction(
String namespace,
String name,
Attributes attributes,
ReadContext context)
-throws Exception {
-MappingAction result = MappingAction.EMPTY;
-
-ElementDescriptor activeDescriptor = context.getCurrentDescriptor();
-if (activeDescriptor != null) {
-if (activeDescriptor.isHollow())
-{
-result = BeanBindAction.INSTANCE;
-}
-else if (activeDescriptor.isSimple())
-{
-result = SimpleTypeBindAction.INSTANCE;
-}
-}
-return result;
-}
+throws Exception;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections CollectionUtils.java
scolebourne2004/04/27 13:00:18
Modified:collections RELEASE-NOTES.html project.xml
collections/src/test/org/apache/commons/collections
TestCollectionUtils.java
collections/src/java/org/apache/commons/collections
CollectionUtils.java
Log:
Add special cases for Set and Bag to CollectionUtils cardinality()
bug 28629, from Jon Schewe
Revision ChangesPath
1.41 +1 -0 jakarta-commons/collections/RELEASE-NOTES.html
Index: RELEASE-NOTES.html
===
RCS file: /home/cvs/jakarta-commons/collections/RELEASE-NOTES.html,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- RELEASE-NOTES.html25 Apr 2004 23:33:11 - 1.40
+++ RELEASE-NOTES.html27 Apr 2004 20:00:17 - 1.41
@@ -43,6 +43,7 @@
liFunctors - Add get methods to retrieve internal state [27515]/li
liFunctors - Add additional getInstance() methods for consistency
[27856,27857]/li
liCollectionUtils - get(Object,int) method now supports primitive arrays/li
+liCollectionUtils - cardinality() now works faster for Set and Bag instances
[28629]/li
liCollectionUtils - Add size(Object) method to find the size of various
collection-like objects [27909]/li
liSingletonIterator - make remove() functionality optional/li
liAbstractLinkedList/NodeCachingLinkedList - added getValue() and setValue() to
Node, and made everything use them/li
1.39 +3 -0 jakarta-commons/collections/project.xml
Index: project.xml
===
RCS file: /home/cvs/jakarta-commons/collections/project.xml,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- project.xml 20 Apr 2004 23:35:07 - 1.38
+++ project.xml 27 Apr 2004 20:00:17 - 1.39
@@ -255,6 +255,9 @@
nameJoe Raysa/name
/contributor
contributor
+ nameJon Schewe/name
+/contributor
+contributor
nameMichael Smith/name
/contributor
contributor
1.38 +34 -12
jakarta-commons/collections/src/test/org/apache/commons/collections/TestCollectionUtils.java
Index: TestCollectionUtils.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/TestCollectionUtils.java,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- TestCollectionUtils.java 1 Apr 2004 22:43:12 - 1.37
+++ TestCollectionUtils.java 27 Apr 2004 20:00:18 - 1.38
@@ -113,17 +113,39 @@
}
public void testCardinality() {
-assertEquals(1,CollectionUtils.cardinality(a,collectionA));
-assertEquals(2,CollectionUtils.cardinality(b,collectionA));
-assertEquals(3,CollectionUtils.cardinality(c,collectionA));
-assertEquals(4,CollectionUtils.cardinality(d,collectionA));
-assertEquals(0,CollectionUtils.cardinality(e,collectionA));
+assertEquals(1, CollectionUtils.cardinality(a, collectionA));
+assertEquals(2, CollectionUtils.cardinality(b, collectionA));
+assertEquals(3, CollectionUtils.cardinality(c, collectionA));
+assertEquals(4, CollectionUtils.cardinality(d, collectionA));
+assertEquals(0, CollectionUtils.cardinality(e, collectionA));
-assertEquals(0,CollectionUtils.cardinality(a,collectionB));
-assertEquals(4,CollectionUtils.cardinality(b,collectionB));
-assertEquals(3,CollectionUtils.cardinality(c,collectionB));
-assertEquals(2,CollectionUtils.cardinality(d,collectionB));
-assertEquals(1,CollectionUtils.cardinality(e,collectionB));
+assertEquals(0, CollectionUtils.cardinality(a, collectionB));
+assertEquals(4, CollectionUtils.cardinality(b, collectionB));
+assertEquals(3, CollectionUtils.cardinality(c, collectionB));
+assertEquals(2, CollectionUtils.cardinality(d, collectionB));
+assertEquals(1, CollectionUtils.cardinality(e, collectionB));
+
+Set set = new HashSet();
+set.add(A);
+set.add(C);
+set.add(E);
+set.add(E);
+assertEquals(1, CollectionUtils.cardinality(A, set));
+assertEquals(0, CollectionUtils.cardinality(B, set));
+assertEquals(1, CollectionUtils.cardinality(C, set));
+assertEquals(0, CollectionUtils.cardinality(D, set));
+assertEquals(1, CollectionUtils.cardinality(E, set));
+
+Bag bag = new HashBag();
+bag.add(A, 3);
+bag.add(C);
+bag.add(E);
+bag.add(E);
+assertEquals(3, CollectionUtils.cardinality(A, bag));
+assertEquals(0,
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/read ReadConfiguration.java
rdonkin 2004/04/27 13:00:28 Modified:betwixt/src/java/org/apache/commons/betwixt/io/read Tag: REFACTORING-BRANCH_2004-01-13 ReadConfiguration.java Log: Added support for array property setters Revision ChangesPath No revision No revision 1.3.2.3 +6 -6 jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/read/ReadConfiguration.java Index: ReadConfiguration.java === RCS file: /home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/read/ReadConfiguration.java,v retrieving revision 1.3.2.2 retrieving revision 1.3.2.3 diff -u -r1.3.2.2 -r1.3.2.3 --- ReadConfiguration.java13 Mar 2004 18:36:33 - 1.3.2.2 +++ ReadConfiguration.java27 Apr 2004 20:00:28 - 1.3.2.3 @@ -72,8 +72,8 @@ /** Chain used to create beans defaults to BeanCreationChain.createDefaultChain() */ private BeanCreationChain beanCreationChain = BeanCreationChain.createDefaultChain(); - -private ActionMappingStrategy actionMappingStrategy = new ActionMappingStrategy(); +/** Pluggable strategy used to determine free mappings */ +private ActionMappingStrategy actionMappingStrategy = ActionMappingStrategy.DEFAULT; /** * Gets the BeanCreationChain that should be used to construct beans. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/read ChainedBeanCreator.java
rdonkin 2004/04/27 13:00:41 Modified:betwixt/src/java/org/apache/commons/betwixt/io/read Tag: REFACTORING-BRANCH_2004-01-13 ChainedBeanCreator.java Log: Added support for array property setters Revision ChangesPath No revision No revision 1.4.2.1 +6 -4 jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/read/ChainedBeanCreator.java Index: ChainedBeanCreator.java === RCS file: /home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/read/ChainedBeanCreator.java,v retrieving revision 1.4 retrieving revision 1.4.2.1 diff -u -r1.4 -r1.4.2.1 --- ChainedBeanCreator.java 9 Oct 2003 20:52:06 - 1.4 +++ ChainedBeanCreator.java 27 Apr 2004 20:00:41 - 1.4.2.1 @@ -80,6 +80,8 @@ * @param chain not null * @return the Object created, possibly null */ + +// TODO: is element mapping really necessary? public Object create( ElementMapping elementMapping, ReadContext context, - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/read BeanBindAction.java
rdonkin 2004/04/27 13:00:54
Modified:betwixt/src/java/org/apache/commons/betwixt/io/read Tag:
REFACTORING-BRANCH_2004-01-13 BeanBindAction.java
Log:
Added support for array property setters
Revision ChangesPath
No revision
No revision
1.1.2.12 +11 -5
jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/read/Attic/BeanBindAction.java
Index: BeanBindAction.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/read/Attic/BeanBindAction.java,v
retrieving revision 1.1.2.11
retrieving revision 1.1.2.12
diff -u -r1.1.2.11 -r1.1.2.12
--- BeanBindAction.java 18 Apr 2004 19:47:22 - 1.1.2.11
+++ BeanBindAction.java 27 Apr 2004 20:00:54 - 1.1.2.12
@@ -236,6 +236,9 @@
// Maybe should move the current mapping into the context
ElementMapping mapping = new ElementMapping();
Class beanClass = descriptor.getSingularPropertyType();
+if (beanClass != null beanClass.isArray()) {
+beanClass = beanClass.getComponentType();
+}
// TODO: beanClass can be deduced from descriptor
// so probably
@@ -267,6 +270,9 @@
Log log = context.getLog();
Class beanClass = propertyDescriptor.getSingularPropertyType();
if (beanClass != null !Map.class.isAssignableFrom(beanClass)) {
+if (beanClass.isArray()) {
+beanClass = beanClass.getComponentType();
+}
if (log.isTraceEnabled()) {
log.trace(Filling descriptor for: + beanClass);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/expression MethodUpdater.java
rdonkin 2004/04/27 13:01:10
Modified:betwixt/src/java/org/apache/commons/betwixt/expression Tag:
REFACTORING-BRANCH_2004-01-13 MethodUpdater.java
Log:
Added support for array property setters
Revision ChangesPath
No revision
No revision
1.11.2.1 +18 -5
jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/expression/MethodUpdater.java
Index: MethodUpdater.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/expression/MethodUpdater.java,v
retrieving revision 1.11
retrieving revision 1.11.2.1
diff -u -r1.11 -r1.11.2.1
--- MethodUpdater.java9 Oct 2003 20:52:04 - 1.11
+++ MethodUpdater.java27 Apr 2004 20:01:10 - 1.11.2.1
@@ -60,7 +60,9 @@
*/
package org.apache.commons.betwixt.expression;
+import java.lang.reflect.Array;
import java.lang.reflect.Method;
+import java.util.Collection;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
@@ -131,7 +133,18 @@
return;
}
*/
-}
+}
+// special case for collection objects into arrays
+if (newValue instanceof Collection valueType.isArray()) {
+Collection valuesAsCollection = (Collection) newValue;
+Class componentType = valueType.getComponentType();
+if (componentType != null) {
+Object[] valuesAsArray =
+(Object[]) Array.newInstance(componentType,
valuesAsCollection.size());
+newValue = valuesAsCollection.toArray(valuesAsArray);
+}
+}
+
Object[] arguments = { newValue };
try {
if ( log.isDebugEnabled() ) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt ElementDescriptor.java
rdonkin 2004/04/27 13:01:33
Modified:betwixt/src/java/org/apache/commons/betwixt Tag:
REFACTORING-BRANCH_2004-01-13
ElementDescriptor.java
Log:
Added support for array property setters
Revision ChangesPath
No revision
No revision
1.14.2.7 +17 -17
jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/ElementDescriptor.java
Index: ElementDescriptor.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/ElementDescriptor.java,v
retrieving revision 1.14.2.6
retrieving revision 1.14.2.7
diff -u -r1.14.2.6 -r1.14.2.7
--- ElementDescriptor.java19 Apr 2004 21:31:13 - 1.14.2.6
+++ ElementDescriptor.java27 Apr 2004 20:01:33 - 1.14.2.7
@@ -335,6 +335,11 @@
/**
* Gets a child ElementDescriptor matching the given name if one exists.
+ * Note that (so long as there are no better matches), a null name
+ * acts as a wildcard. In other words, an
+ * codeElementDescriptor/code the first descriptor
+ * with a null name will match any name
+ * passed in, unless some other matches the name exactly.
*
* @param name the localname to be matched, not null
* @returns the child ElementDescriptor with the given name if one exists,
@@ -343,25 +348,20 @@
public ElementDescriptor getElementDescriptor(String name) {
ElementDescriptor elementDescriptor = null;
+ElementDescriptor descriptorWithNullName = null;
ElementDescriptor[] elementDescriptors = getElementDescriptors();
for (int i=0, size=elementDescriptors.length; isize; i++) {
-if (name.equals(elementDescriptors[i].getQualifiedName())) {
+String elementName = elementDescriptors[i].getQualifiedName();
+if (name.equals(elementName)) {
elementDescriptor = elementDescriptors[i];
break;
}
-else {
-// workaround for wrapped collections
-// really, should probably have silent elements (which aren't
expressed)
-if (!elementDescriptors[i].isWrapCollectionsInElement()
-elementDescriptors[i].isCollective()) {
-
-ElementDescriptor grandchild =
elementDescriptors[i].getElementDescriptor(name);
-if (grandchild != null) {
-elementDescriptor = grandchild;
-break;
-}
-}
+if (descriptorWithNullName == null elementName == null) {
+descriptorWithNullName = elementDescriptors[i];
}
+}
+if (elementDescriptor == null) {
+elementDescriptor = descriptorWithNullName;
}
return elementDescriptor;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/java/org/apache/commons/betwixt BeanProperty.java
rdonkin 2004/04/27 13:01:47
Modified:betwixt/src/java/org/apache/commons/betwixt Tag:
REFACTORING-BRANCH_2004-01-13 BeanProperty.java
Log:
Added support for array property setters
Revision ChangesPath
No revision
No revision
1.4.2.9 +10 -5
jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/BeanProperty.java
Index: BeanProperty.java
===
RCS file:
/home/cvs/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/BeanProperty.java,v
retrieving revision 1.4.2.8
retrieving revision 1.4.2.9
diff -u -r1.4.2.8 -r1.4.2.9
--- BeanProperty.java 3 Feb 2004 22:29:15 - 1.4.2.8
+++ BeanProperty.java 27 Apr 2004 20:01:46 - 1.4.2.9
@@ -244,7 +244,7 @@
} else {
descriptor
-= createDescriptorForCollective( configuration,
propertyExpression );
+= createDescriptorForCollective( configuration,
propertyUpdater, propertyExpression );
}
} else {
if (log.isTraceEnabled()) {
@@ -365,11 +365,13 @@
/**
* Creates an codeElementDescriptor/code for a collective type property
* @param configuration
+ * @param propertyUpdater, codeUpdater/code for the property, possibly null
* @param propertyExpression
* @return
*/
private ElementDescriptor createDescriptorForCollective(
IntrospectionConfiguration configuration,
+Updater propertyUpdater,
Expression propertyExpression) {
ElementDescriptor result;
@@ -381,6 +383,9 @@
loopDescriptor.setPropertyName(getPropertyName());
loopDescriptor.setPropertyType(getPropertyType());
loopDescriptor.setHollow(true);
+// set the property updater (if it exists)
+// may be overridden later by the adder
+loopDescriptor.setUpdater(propertyUpdater);
if ( configuration.isWrapCollectionsInElement() ) {
// create wrapping desctiptor
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/strategy TestBaseMappingStrategy.java
rdonkin 2004/04/27 13:02:35 Added: betwixt/src/test/org/apache/commons/betwixt Tag: REFACTORING-BRANCH_2004-01-13 TestArrays.java betwixt/src/test/org/apache/commons/betwixt/strategy Tag: REFACTORING-BRANCH_2004-01-13 TestBaseMappingStrategy.java Log: Added support for array property setters Revision ChangesPath No revision No revision 1.1.2.1 +152 -0 jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/Attic/TestArrays.java No revision No revision 1.1.2.1 +51 -0 jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/strategy/Attic/TestBaseMappingStrategy.java - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28629] - [collections] CollectionUtils.cardinality should be made smarter about Bag
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28629. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28629 [collections] CollectionUtils.cardinality should be made smarter about Bag [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Summary|CollectionUtils.cardinality |[collections] |should be made smarter about|CollectionUtils.cardinality |Bag |should be made smarter about ||Bag --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 20:03 --- Not done previously because no-one thought of it. Special cases for Set and Bag have been added. Thanks - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/test/org/apache/commons/betwixt BookBean.java
rdonkin 2004/04/27 13:03:12 Added: betwixt/src/test/org/apache/commons/betwixt Tag: REFACTORING-BRANCH_2004-01-13 BookBean.java Log: Added support for array property setters Revision ChangesPath No revision No revision 1.1.2.1 +77 -0 jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/Attic/BookBean.java - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/test/org/apache/commons/betwixt LibraryBean.java
rdonkin 2004/04/27 13:03:28 Added: betwixt/src/test/org/apache/commons/betwixt Tag: REFACTORING-BRANCH_2004-01-13 LibraryBean.java Log: Added support for array property setters Revision ChangesPath No revision No revision 1.1.2.1 +42 -0 jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/Attic/LibraryBean.java - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/betwixt/src/test/org/apache/commons/betwixt LibraryBeanWithArraySetter.java
rdonkin 2004/04/27 13:04:00 Added: betwixt/src/test/org/apache/commons/betwixt Tag: REFACTORING-BRANCH_2004-01-13 LibraryBeanWithArraySetter.java Log: Added support for array property setters Revision ChangesPath No revision No revision 1.1.2.1 +35 -0 jakarta-commons/betwixt/src/test/org/apache/commons/betwixt/Attic/LibraryBeanWithArraySetter.java - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Validator] 1.1.3 Release
If there are no objections, I'd like to roll a 1.1.3 release Friday, April 30, sometime after 5PM EST (GMT-5). -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/pool/src/java/org/apache/commons/pool/impl GenericObjectPool.java
dirkv 2004/04/27 13:15:56
Modified:pool/src/java/org/apache/commons/pool/impl
GenericObjectPool.java
Log:
Bugzilla Bug 28638: Not possible to extend GenericObjectPool.returnObject() without
affecting addObject()
- remove the slimy dependency between the two methods ;-)
Revision ChangesPath
1.32 +9 -6
jakarta-commons/pool/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
Index: GenericObjectPool.java
===
RCS file:
/home/cvs/jakarta-commons/pool/src/java/org/apache/commons/pool/impl/GenericObjectPool.java,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- GenericObjectPool.java28 Feb 2004 11:46:33 - 1.31
+++ GenericObjectPool.java27 Apr 2004 20:15:56 - 1.32
@@ -851,6 +851,10 @@
public void returnObject(Object obj) throws Exception {
assertOpen();
+addObjectToPool(obj, true);
+}
+
+private void addObjectToPool(Object obj, boolean decrementNumActive) throws
Exception {
boolean success = true;
if(_testOnReturn !(_factory.validateObject(obj))) {
success = false;
@@ -865,7 +869,9 @@
boolean shouldDestroy = !success;
synchronized(this) {
-_numActive--;
+if (decrementNumActive) {
+_numActive--;
+}
if((_maxIdle = 0) (_pool.size() = _maxIdle)) {
shouldDestroy = true;
} else if(success) {
@@ -988,10 +994,7 @@
*/
public void addObject() throws Exception {
Object obj = _factory.makeObject();
-synchronized(this) {
-_numActive++; // A little slimy - must do this because returnObject
decrements it.
-this.returnObject(obj);
-}
+addObjectToPool(obj, false);
}
//--- non-public methods
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28638] - Not possible to extend GenericObjectPool.returnObject() without affecting addObject()
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28638. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28638 Not possible to extend GenericObjectPool.returnObject() without affecting addObject() [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 20:17 --- fixed in revision 1.32 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Validator] 1.1.3 Release
+1, Thanks If anyone would like to try out that release before hand the can go to http://apache.org/~rleland/commons-validator I uploaded it based on a build from the 1_1_2_BRANCH last night. -Rob -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 27, 2004 08:09 PM To: [EMAIL PROTECTED] Subject: [Validator] 1.1.3 Release If there are no objections, I'd like to roll a 1.1.3 release Friday, April 30, sometime after 5PM EST (GMT-5). -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections Bag.java
scolebourne2004/04/27 13:43:05
Modified:collections RELEASE-NOTES.html
collections/src/java/org/apache/commons/collections Bag.java
Log:
Update Bag interface text to indicate that we won't break compatability
Revision ChangesPath
1.42 +1 -0 jakarta-commons/collections/RELEASE-NOTES.html
Index: RELEASE-NOTES.html
===
RCS file: /home/cvs/jakarta-commons/collections/RELEASE-NOTES.html,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -r1.41 -r1.42
--- RELEASE-NOTES.html27 Apr 2004 20:00:17 - 1.41
+++ RELEASE-NOTES.html27 Apr 2004 20:43:05 - 1.42
@@ -75,6 +75,7 @@
centerh3JAVADOC/h3/center
ul
+liBag - Indicate that no changes are likely to the interface despite its
problems/li
liTreeBidiMap - Add javadoc about requiring Comparable entries [26470]/li
liMultiKey - Add extra explanatations, examples and warnings/li
liMultiMap,MultiHashMap - Add extra documentation to clarify the interface and
implementation/li
1.17 +9 -6
jakarta-commons/collections/src/java/org/apache/commons/collections/Bag.java
Index: Bag.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/Bag.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- Bag.java 18 Feb 2004 01:15:42 - 1.16
+++ Bag.java 27 Apr 2004 20:43:05 - 1.17
@@ -27,12 +27,15 @@
* Calling [EMAIL PROTECTED] #getCount(Object)} on codea/code would return 2,
while
* calling [EMAIL PROTECTED] #uniqueSet()} would return code{a, b, c}/code.
* p
- * iNote that this interface violates the [EMAIL PROTECTED] Collection}
contract./i
+ * iNOTE: This interface violates the [EMAIL PROTECTED] Collection} contract./i
* The behavior specified in many of these methods is inot/i the same
- * as the behavior specified by codeCollection/code. The noncompliant methods
- * are clearly marked with (Violation). A future
- * version of this class will specify the same behavior as codeCollection/code,
- * which unfortunately will break backwards compatibility with this version.
+ * as the behavior specified by codeCollection/code.
+ * The noncompliant methods are clearly marked with (Violation).
+ * Exercise caution when using a bag as a codeCollection/code.
+ * p
+ * This violation resulted from the original specification of this interface.
+ * In an ideal world, the interface would be changed to fix the problems, however
+ * it has been decided to maintain backwards compatibility instead.
*
* @since Commons Collections 2.0
* @version $Revision$ $Date$
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28486] - [digester] ExtendedBaseRules test fails
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28486. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28486 [digester] ExtendedBaseRules test fails [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 21:26 --- hi sorry that i've been a bit busy with other stuff recently but i'll try to find some time tomorrow to take a look at this. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/map AbstractHashedMap.java
scolebourne2004/04/27 14:28:40 Modified:collections/src/java/org/apache/commons/collections/map AbstractHashedMap.java Log: Javadoc Revision ChangesPath 1.17 +2 -2 jakarta-commons/collections/src/java/org/apache/commons/collections/map/AbstractHashedMap.java Index: AbstractHashedMap.java === RCS file: /home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/map/AbstractHashedMap.java,v retrieving revision 1.16 retrieving revision 1.17 diff -u -r1.16 -r1.17 --- AbstractHashedMap.java9 Apr 2004 22:52:48 - 1.16 +++ AbstractHashedMap.java27 Apr 2004 21:28:40 - 1.17 @@ -384,7 +384,7 @@ /** * Compares two values, in external form, to see if they are equal. - * This implementation uses the equals method and assumes neither key is null. + * This implementation uses the equals method and assumes neither value is null. * Subclasses can override this to match differently. * * @param value1 the first value to compare passed in from outside - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/map AbstractReferenceMap.java
scolebourne2004/04/27 14:32:52
Modified:collections/src/java/org/apache/commons/collections/map
AbstractReferenceMap.java
Log:
Improve subclassability by delegating methods from entry to main map
Add support for serializable subclasses
Revision ChangesPath
1.2 +146 -60
jakarta-commons/collections/src/java/org/apache/commons/collections/map/AbstractReferenceMap.java
Index: AbstractReferenceMap.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/map/AbstractReferenceMap.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- AbstractReferenceMap.java 9 Apr 2004 22:18:18 - 1.1
+++ AbstractReferenceMap.java 27 Apr 2004 21:32:52 - 1.2
@@ -15,6 +15,9 @@
*/
package org.apache.commons.collections.map;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
import java.lang.ref.Reference;
import java.lang.ref.ReferenceQueue;
import java.lang.ref.SoftReference;
@@ -72,7 +75,7 @@
* provide synchronized access to a codeReferenceMap/code.
*
* @see java.lang.ref.Reference
- * @since Commons Collections 3.1 (from ReferenceMap in 3.0)
+ * @since Commons Collections 3.1 (extracted from ReferenceMap in 3.0)
* @version $Revision$ $Date$
*
* @author Paul Jack
@@ -93,24 +96,24 @@
* The reference type for keys. Must be HARD, SOFT, WEAK.
* @serial
*/
-private int keyType;
+protected int keyType;
/**
* The reference type for values. Must be HARD, SOFT, WEAK.
* @serial
*/
-private int valueType;
+protected int valueType;
/**
* Should the value be automatically purged when the associated key has been
collected?
*/
-private boolean purgeValues;
+protected boolean purgeValues;
/**
* ReferenceQueue used to eliminate stale mappings.
* See purge.
*/
-private transient ReferenceQueue queue = new ReferenceQueue();
+private transient ReferenceQueue queue;
//---
/**
@@ -144,6 +147,13 @@
this.purgeValues = purgeValues;
}
+/**
+ * Initialise this subclass during construction, cloning or deserialization.
+ */
+protected void init() {
+queue = new ReferenceQueue();
+}
+
//---
/**
* Checks the type int is a valid value.
@@ -159,49 +169,6 @@
}
//---
-///**
-// * Writes this object to the given output stream.
-// *
-// * @param out the output stream to write to
-// * @throws IOException if the stream raises it
-// */
-//private void writeObject(ObjectOutputStream out) throws IOException {
-//out.defaultWriteObject();
-//out.writeInt(data.length);
-//
-//// Have to use null-terminated list because size might shrink
-//// during iteration
-//
-//for (Iterator iter = entrySet().iterator(); iter.hasNext();) {
-//Map.Entry entry = (Map.Entry)iter.next();
-//out.writeObject(entry.getKey());
-//out.writeObject(entry.getValue());
-//}
-//out.writeObject(null);
-//}
-//
-//
-///**
-// * Reads the contents of this object from the given input stream.
-// *
-// * @param in the input stream to read from
-// * @throws IOException if the stream raises it
-// * @throws ClassNotFoundException if the stream raises it
-// */
-//private void readObject(ObjectInputStream in) throws IOException,
ClassNotFoundException {
-//in.defaultReadObject();
-//data = new HashEntry[in.readInt()];
-//threshold = calculateThreshold(data.length, loadFactor);
-//queue = new ReferenceQueue();
-//Object key = in.readObject();
-//while (key != null) {
-//Object value = in.readObject();
-//put(key, value);
-//key = in.readObject();
-//}
-//}
-
-//---
/**
* Gets the size of the map.
*
@@ -439,6 +406,19 @@
}
/**
+ * Gets the hash code for a MapEntry.
+ * Subclasses can override this, for example to use the identityHashCode.
+ *
+ * @param key the key to get a hash code for, may be null
+ * @param value the value to get a hash code for, may be null
+ * @return the hash code,
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/map ReferenceMap.java
scolebourne2004/04/27 14:35:23
Modified:collections/src/test/org/apache/commons/collections/map
TestReferenceMap.java
collections/src/java/org/apache/commons/collections/map
ReferenceMap.java
Added: collections/data/test
ReferenceMap.emptyCollection.version3.1.obj
ReferenceMap.fullCollection.version3.1.obj
Log:
Make ReferenceMap serializable
Revision ChangesPath
1.6 +2 -2
jakarta-commons/collections/src/test/org/apache/commons/collections/map/TestReferenceMap.java
Index: TestReferenceMap.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/map/TestReferenceMap.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- TestReferenceMap.java 9 Apr 2004 22:18:17 - 1.5
+++ TestReferenceMap.java 27 Apr 2004 21:35:23 - 1.6
@@ -184,7 +184,7 @@
public String getCompatibilityVersion() {
-return 2.1; // previously in main package
+return 3.1;
}
/** Tests whether purge values setting works */
1.1
jakarta-commons/collections/data/test/ReferenceMap.emptyCollection.version3.1.obj
Binary file
1.1
jakarta-commons/collections/data/test/ReferenceMap.fullCollection.version3.1.obj
Binary file
1.13 +32 -3
jakarta-commons/collections/src/java/org/apache/commons/collections/map/ReferenceMap.java
Index: ReferenceMap.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/map/ReferenceMap.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- ReferenceMap.java 9 Apr 2004 22:18:18 - 1.12
+++ ReferenceMap.java 27 Apr 2004 21:35:23 - 1.13
@@ -15,6 +15,10 @@
*/
package org.apache.commons.collections.map;
+import java.io.IOException;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+import java.io.Serializable;
/**
* A codeMap/code implementation that allows mappings to be
@@ -35,17 +39,22 @@
* weak values, or any other combination. The default constructor uses
* hard keys and soft values, providing a memory-sensitive cache.
* p
+ * This map is similar to
+ * [EMAIL PROTECTED] org.apache.commons.collections.map.ReferenceIdentityMap
ReferenceIdentityMap}.
+ * It differs in that keys and values in this class are compared using
codeequals()/code.
+ * p
* This [EMAIL PROTECTED] Map} implementation does inot/i allow null elements.
* Attempting to add a null key or value to the map will raise a
codeNullPointerException/code.
* p
* This implementation is not synchronized.
* You can use [EMAIL PROTECTED] java.util.Collections#synchronizedMap} to
* provide synchronized access to a codeReferenceMap/code.
+ * Remember that synchronization will not stop the garbage collecter removing
entries.
* p
* All the available iterators can be reset back to the start by casting to
* codeResettableIterator/code and calling codereset()/code.
* p
- * NOTE: As from Commons Collections 3.1 this map extends
codeAbstractHashedMap/code
+ * NOTE: As from Commons Collections 3.1 this map extends
codeAbstractReferenceMap/code
* (previously it extended AbstractMap). As a result, the implementation is now
* extensible and provides a codeMapIterator/code.
*
@@ -57,7 +66,10 @@
* @author Paul Jack
* @author Stephen Colebourne
*/
-public class ReferenceMap extends AbstractReferenceMap {
+public class ReferenceMap extends AbstractReferenceMap implements Serializable {
+
+/** Serialization version */
+private static final long serialVersionUID = 1555089888138299607L;
/**
* Constructs a new codeReferenceMap/code that will
@@ -128,6 +140,23 @@
public ReferenceMap(int keyType, int valueType, int capacity,
float loadFactor, boolean purgeValues) {
super(keyType, valueType, capacity, loadFactor, purgeValues);
+}
+
+//---
+/**
+ * Write the map out using a custom routine.
+ */
+private void writeObject(ObjectOutputStream out) throws IOException {
+out.defaultWriteObject();
+doWriteObject(out);
+}
+
+/**
+ * Read the map in using a custom routine.
+ */
+private void readObject(ObjectInputStream in) throws IOException,
ClassNotFoundException {
+in.defaultReadObject();
+doReadObject(in);
}
}
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/map ReferenceIdentityMap.java
scolebourne2004/04/27 14:37:32
Added: collections/src/test/org/apache/commons/collections/map
TestReferenceIdentityMap.java
collections/data/test
ReferenceIdentityMap.fullCollection.version3.1.obj
ReferenceIdentityMap.emptyCollection.version3.1.obj
collections/src/java/org/apache/commons/collections/map
ReferenceIdentityMap.java
Log:
Add ReferenceIdentityMap
Revision ChangesPath
1.1
jakarta-commons/collections/src/test/org/apache/commons/collections/map/TestReferenceIdentityMap.java
Index: TestReferenceIdentityMap.java
===
/*
* Copyright 2004 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.collections.map;
import java.lang.ref.WeakReference;
import java.util.Iterator;
import java.util.Map;
import junit.framework.Test;
import org.apache.commons.collections.BulkTest;
import org.apache.commons.collections.IterableMap;
/**
* Tests for ReferenceIdentityMap.
*
* @version $Revision: 1.1 $
*
* @author Paul Jack
* @author Stephen Colebourne
*/
public class TestReferenceIdentityMap extends AbstractTestIterableMap {
private static final Integer I1A = new Integer(1);
private static final Integer I1B = new Integer(1);
private static final Integer I2A = new Integer(2);
private static final Integer I2B = new Integer(2);
public TestReferenceIdentityMap(String testName) {
super(testName);
}
public static Test suite() {
return BulkTest.makeSuite(TestReferenceIdentityMap.class);
}
public static void main(String args[]) {
String[] testCaseName = { TestReferenceIdentityMap.class.getName() };
junit.textui.TestRunner.main(testCaseName);
}
public Map makeEmptyMap() {
ReferenceIdentityMap map = new
ReferenceIdentityMap(ReferenceIdentityMap.WEAK, ReferenceIdentityMap.WEAK);
return map;
}
public Map makeConfirmedMap() {
// Testing against another [collections] class generally isn't a good idea,
// but the alternative is a JDK1.4 dependency in the tests
return new IdentityMap();
}
public boolean isAllowNullKey() {
return false;
}
public boolean isAllowNullValue() {
return false;
}
//---
public void testBasics() {
IterableMap map = new ReferenceIdentityMap(ReferenceIdentityMap.HARD,
ReferenceIdentityMap.HARD);
assertEquals(0, map.size());
map.put(I1A, I2A);
assertEquals(1, map.size());
assertSame(I2A, map.get(I1A));
assertSame(null, map.get(I1B));
assertEquals(true, map.containsKey(I1A));
assertEquals(false, map.containsKey(I1B));
assertEquals(true, map.containsValue(I2A));
assertEquals(false, map.containsValue(I2B));
map.put(I1A, I2B);
assertEquals(1, map.size());
assertSame(I2B, map.get(I1A));
assertSame(null, map.get(I1B));
assertEquals(true, map.containsKey(I1A));
assertEquals(false, map.containsKey(I1B));
assertEquals(false, map.containsValue(I2A));
assertEquals(true, map.containsValue(I2B));
map.put(I1B, I2B);
assertEquals(2, map.size());
assertSame(I2B, map.get(I1A));
assertSame(I2B, map.get(I1B));
assertEquals(true, map.containsKey(I1A));
assertEquals(true, map.containsKey(I1B));
assertEquals(false, map.containsValue(I2A));
assertEquals(true, map.containsValue(I2B));
}
//---
public void testHashEntry() {
IterableMap map = new ReferenceIdentityMap(ReferenceIdentityMap.HARD,
ReferenceIdentityMap.HARD);
map.put(I1A, I2A);
map.put(I1B, I2A);
Map.Entry entry1 = (Map.Entry) map.entrySet().iterator().next();
Iterator it = map.entrySet().iterator();
Map.Entry
RE: [Validator] 1.1.3 Release
works fine with nightly builds from struts thanks! -Original Message- From: Robert Leland [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 27, 2004 10:20 PM To: Jakarta Commons Developers List Subject: Re: [Validator] 1.1.3 Release +1, Thanks If anyone would like to try out that release before hand the can go to http://apache.org/~rleland/commons-validator I uploaded it based on a build from the 1_1_2_BRANCH last night. -Rob -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 27, 2004 08:09 PM To: [EMAIL PROTECTED] Subject: [Validator] 1.1.3 Release If there are no objections, I'd like to roll a 1.1.3 release Friday, April 30, sometime after 5PM EST (GMT-5). -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [digester] release 1.6
thanks for all the hard work simon. i'll make sure that i'll find some time this week to take a look at those issues which i can resolve. if craig's around, he'll probably be able to advise you on the actual release management. - robert On 22 Apr 2004, at 23:55, Simon Kitching wrote: Hi, I've done about all I can to prepare Digester for a 1.6 release. If there ever is to *be* a 1.6 release, someone else will need to step up and do the remaining tasks now. Remaining TO-DO: * cvs version info: see later * Move RSS code: Craig? * Possible logging changes: Robert? * Review/commit bug #28486 (ExtendedBaseRules): Craig/Robert? * update ant/maven to build src release including examples * build, tag, publish RC1 The cvs version info issue (whether and where to include $Id$ CVS keyword) seems such a simple one. But it seems that everyone has a different opinion on the correct solution. As I never use this info, I'll leave someone else to resolve this issue. From the last to-do email: Also: * run checkstyle? After thinking a bit, I feel it's best not to do this. * set up wiki for digester, add ref from digester website to it. Looks like the new wiki is still being worked on, so better to leave this for now. * check code with java1.2 SDK (this is the minimum java version, right?) Done. Bug#28486 (patch attached) was exposed in java1.2. Otherwise, Digester compiles and passes all tests with 1.2, 1.4 and 1.5beta. * put in some more @since tags? Done. Should all be 100% complete now. * finishing touches to release notes. Done. Release notes should be 100% complete. Regards, Simon - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections RELEASE-NOTES.html
scolebourne2004/04/27 14:45:37 Modified:collections RELEASE-NOTES.html Log: Updates to ReferenceMap et al Revision ChangesPath 1.43 +3 -0 jakarta-commons/collections/RELEASE-NOTES.html Index: RELEASE-NOTES.html === RCS file: /home/cvs/jakarta-commons/collections/RELEASE-NOTES.html,v retrieving revision 1.42 retrieving revision 1.43 diff -u -r1.42 -r1.43 --- RELEASE-NOTES.html27 Apr 2004 20:43:05 - 1.42 +++ RELEASE-NOTES.html27 Apr 2004 21:45:37 - 1.43 @@ -30,6 +30,7 @@ liTransformedPredicate - A predicate where the input object is transformed [26946]/li liObjectGraphIterator - An iterator that can iterate over a graph of objects/li liMapBackedSet - Set created by decorating a map/li +liReferenceIdentityMap - Similar to ReferenceMap, but matching keys and values by identity [26503]/li liAbstractReferenceMap - New base class for reference maps [26503]/li /ul @@ -55,6 +56,7 @@ liFast3Map [27946]/li liFixedSizeMap/SortedMap [18815]/li liLazyMap/SortedMap [18815]/li +liReferenceMap [18815]/li liListOrderedMap [18815]/li liPredicatedMap/SortedMap [18815]/li liTransformedMap/SortedMap [18815]/li @@ -81,6 +83,7 @@ liMultiMap,MultiHashMap - Add extra documentation to clarify the interface and implementation/li liXxxUtils - Clarify the internal workings of the predicated decorator classes [28115]/li liBidiMap - Clarify 1 to 1 nature of the map/li +liAbstractHashedMap - Fix isEqualValue() javadoc to refer to value not key/li liLRUMap - Added extra javadoc about method implementations/li liBoundedCollection/UnmodifiableBoundedCollection - reword to avoid misunderstandings/li liClosure/Predicate/Transformer/Factory - Additional javadoc with links/li - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26503] - [collections] New feature: Extend ReferenceMap with IdentityMap functionality (WeakIdentityHashMap)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=26503. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=26503 [collections] New feature: Extend ReferenceMap with IdentityMap functionality (WeakIdentityHashMap) [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Summary|New feature: Extend |[collections] New feature: |ReferenceMap with |Extend ReferenceMap with |IdentityMap functionality |IdentityMap functionality |(WeakIdentityHashMap) |(WeakIdentityHashMap) --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 21:47 --- ReferenceIdentityMap now committed to the CVS - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[dbcp][bug 28579] JUnit test
This JUnit test will test the fix for bug 28579. It takes between 1-2
seconds to complete on my computer. Even though it simulates a threading
issue, it's very reliable. I haven't been able to get it to generate a false
positive yet. If you commit this new test to CVS, please insert a line for
this test into the org.apache.commons.dbcp.TestAll class. I haven't done so
yet.
By the way, I often use tab characters for indentation, and so I have done so
with this file. If it is the jakarta or commons standard to use spaces for
indentation, I'll use that convention from now on.
Look it over -- if any questions or comments, let me know.
Wayne Woodfield
Dirk Verbeeck wrote:
Hi Wayne,
Excellent description and patch. The commons-dev mailing list is
indeed the place to start for getting your fix applied. Now a bugzilla
issue needs to be created to record the issue+patch and then I will
apply your patch to DBCP.
Do you have a way to simulate the error? Threading issues are always
difficult to reproduce and your solution is obviously correct but
having a JUnit test is always a plus.
Thanks
Dirk
Wayne Woodfield wrote:
I'm absolutely new to open-source development and groups like this, so
forgive me if I'm not following the correct protocol, but I found and
fixed a bug in DBCP and would like to contribute my patch back to the
project. I've created a patch file and attached it to this e-mail. If
a comitter to commons-dbcp would please look at my patch as well as the
explanation below, that'd be great. If you'd like me to do anything
differently next time I have a patch to offer, just let me know :-)
Wayne Woodfield
-
/*
* Copyright 1999-2004 The Apache Software Foundation.
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.commons.dbcp;
import java.util.Vector;
import java.util.NoSuchElementException;
import junit.framework.Test;
import junit.framework.TestCase;
import junit.framework.TestSuite;
import org.apache.commons.pool.PoolableObjectFactory;
import org.apache.commons.pool.impl.GenericObjectPool;
/**
* @author Wayne Woodfield
* @version
*/
public class TestAbandonedObjectPool extends TestCase {
private AbandonedObjectPool pool = null;
public TestAbandonedObjectPool(String testName) {
super(testName);
}
public static Test suite() {
return new TestSuite(TestAbandonedObjectPool.class);
}
public void setUp() throws Exception {
super.setUp();
AbandonedConfig config = new AbandonedConfig();
config.setRemoveAbandoned(true);
config.setRemoveAbandonedTimeout(1);
pool = new AbandonedObjectPool(new SimpleFactory(), config);
}
public void tearDown() throws Exception {
super.tearDown();
pool.close();
pool = null;
}
/**
* Tests fix for Bug 28579, a bug in AbandonedObjectPool that causes numActive
to go negative
* in GenericObjectPool
*/
public void testConcurrentInvalidation() throws Exception {
final int POOL_SIZE = 30;
pool.setMaxActive(POOL_SIZE);
pool.setMaxIdle(POOL_SIZE);
pool.setWhenExhaustedAction(AbandonedObjectPool.WHEN_EXHAUSTED_FAIL);
// Exhaust the connection pool
Vector vec = new Vector();
for (int i = 0; i POOL_SIZE; i++) {
vec.add(pool.borrowObject());
}
// Abandon all borrowed objects
for (int i = 0; i vec.size(); i++) {
((PooledTestObject)vec.elementAt(i)).setAbandoned(true);
}
// Try launching a bunch of borrows concurrently. Abandoned sweep
will be triggered for each.
final int CONCURRENT_BORROWS = 5;
Thread[] threads = new Thread[CONCURRENT_BORROWS];
for (int i = 0; i CONCURRENT_BORROWS; i++) {
threads[i] = new ConcurrentBorrower(vec);
threads[i].start();
}
// Wait for all the threads to finish
for (int i = 0; i CONCURRENT_BORROWS; i++) {
threads[i].join();
}
// Return all objects that have not been destroyed
for (int i = 0; i
Re: [Validator] 1.1.3 Release
+1 You should find that 'maven clean dist' produces a valid distro. David --- Ted Husted [EMAIL PROTECTED] wrote: If there are no objections, I'd like to roll a 1.1.3 release Friday, April 30, sometime after 5PM EST (GMT-5). -Ted. __ Do you Yahoo!? Win a $20,000 Career Makeover at Yahoo! HotJobs http://hotjobs.sweepstakes.yahoo.com/careermakeover - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/cookie TestCookieCompatibilitySpec.java TestCookieIgnoreSpec.java
olegk 2004/04/27 15:35:21
Modified:httpclient/src/java/org/apache/commons/httpclient/cookie
CookieSpec.java CookieSpecBase.java
IgnoreCookiesSpec.java RFC2109Spec.java
httpclient/src/test/org/apache/commons/httpclient/cookie
TestCookieCompatibilitySpec.java
TestCookieIgnoreSpec.java
Log:
PR #28566 (Handling sub-domain cookies)
Changelog:
* CookieSpec interface extended to expose path domain matching methods
* Browser compatibility domain matching algorithm modified to mimic the
(mis-)behavior of common browsers
Contributed by Oleg Kalnichevski
Reviewed by Michael Becke
Revision ChangesPath
1.9 +19 -3
jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/cookie/CookieSpec.java
Index: CookieSpec.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/cookie/CookieSpec.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- CookieSpec.java 18 Apr 2004 23:51:37 - 1.8
+++ CookieSpec.java 27 Apr 2004 22:35:21 - 1.9
@@ -151,6 +151,22 @@
final Cookie cookies[]);
/**
+ * Performs domain-match as defined by the cookie specification.
+ * @param host The target host.
+ * @param domain The cookie domain attribute.
+ * @return true if the specified host matches the given domain.
+ */
+boolean domainMatch(final String host, final String domain);
+
+/**
+ * Performs path-match as defined by the cookie specification.
+ * @param path The target path.
+ * @param topmostPath The cookie path attribute.
+ * @return true if the paths match
+ */
+boolean pathMatch(final String path, final String topmostPath);
+
+/**
* Create a ttCookie/tt header value for an array of cookies.
*
* @param cookie the cookie to be formatted as string
1.26 +12 -19
jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/cookie/CookieSpecBase.java
Index: CookieSpecBase.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/cookie/CookieSpecBase.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- CookieSpecBase.java 24 Apr 2004 23:51:57 - 1.25
+++ CookieSpecBase.java 27 Apr 2004 22:35:21 - 1.26
@@ -485,30 +485,23 @@
}
/**
- * Performs a domain-match as described in RFC2109.
- * @param host The host to check.
- * @param domain The domain.
+ * Performs domain-match as implemented in common browsers.
+ * @param host The target host.
+ * @param domain The cookie domain attribute.
* @return true if the specified host matches the given domain.
*/
-private static boolean domainMatch(String host, String domain) {
-boolean match = host.equals(domain)
-|| (domain.startsWith(.) host.endsWith(domain));
-
-return match;
+public boolean domainMatch(final String host, final String domain) {
+return host.endsWith(domain);
}
/**
- * Performs a path-match slightly smarter than a straight-forward startsWith
- * check.
- * @param path The path to check.
- * @param topmostPath The path to check against.
+ * Performs path-match as implemented in common browsers.
+ * @param path The target path.
+ * @param topmostPath The cookie path attribute.
* @return true if the paths match
*/
-private static boolean pathMatch(
-final String path, final String topmostPath) {
-
+public boolean pathMatch(final String path, final String topmostPath) {
boolean match = path.startsWith (topmostPath);
-
// if there is a match and these values are not exactly the same we have
// to make sure we're not matcing /foobar and /foo
if (match path.length() != topmostPath.length()) {
1.4 +17 -3
jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/cookie/IgnoreCookiesSpec.java
Index: IgnoreCookiesSpec.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/java/org/apache/commons/httpclient/cookie/IgnoreCookiesSpec.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- IgnoreCookiesSpec.java18 Apr 2004 23:51:37 - 1.3
+++ IgnoreCookiesSpec.java27 Apr 2004 22:35:21 - 1.4
@@ -119,4 +119,18 @@
throws MalformedCookieException,
cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/comparators BooleanComparator.java
scolebourne2004/04/27 15:57:00
Modified:collections/src/java/org/apache/commons/collections/comparators
BooleanComparator.java
Log:
Javadoc
Revision ChangesPath
1.12 +19 -17
jakarta-commons/collections/src/java/org/apache/commons/collections/comparators/BooleanComparator.java
Index: BooleanComparator.java
===
RCS file:
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/comparators/BooleanComparator.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- BooleanComparator.java18 Feb 2004 00:59:06 - 1.11
+++ BooleanComparator.java27 Apr 2004 22:57:00 - 1.12
@@ -33,45 +33,47 @@
public final class BooleanComparator implements Comparator, Serializable {
/**
- * Creates a codeBooleanComparator/code
- * that sorts codefalse/code values before
- * codetrue/code values.
- *
+ * Creates a codeBooleanComparator/code that sorts
+ * codefalse/code values before codetrue/code values.
+ * p
* Equivalent to [EMAIL PROTECTED] #BooleanComparator(boolean)
BooleanComparator(false)}.
+ * p
+ * Please use the static factory instead whenever possible.
*/
public BooleanComparator() {
this(false);
}
/**
- * Creates a codeBooleanComparator/code
- * that sorts codeitrueFirst/i/code values before
+ * Creates a codeBooleanComparator/code that sorts
+ * codeitrueFirst/i/code values before
* code#x21;itrueFirst/i/code values.
+ * p
+ * Please use the static factories instead whenever possible.
*
* @param trueFirst when codetrue/code, sort
- *codetrue/code [EMAIL PROTECTED] Boolean}s before
- *codefalse/code [EMAIL PROTECTED] Boolean}s.
+ * codetrue/code boolean values before codefalse/code
*/
public BooleanComparator(boolean trueFirst) {
this.trueFirst = trueFirst;
}
+//---
/**
- * Compares two arbitrary Objects. When both arguments
- * are [EMAIL PROTECTED] Boolean}, this method is equivalent to
+ * Compares two arbitrary Objects.
+ * When both arguments are codeBoolean/code, this method is equivalent to
* [EMAIL PROTECTED] #compare(Boolean,Boolean)
compare((Boolean)io1/i,(Boolean)io2/i)}.
- * When either argument is not a [EMAIL PROTECTED] Boolean}, this methods throws
+ * When either argument is not a codeBoolean/code, this methods throws
* a [EMAIL PROTECTED] ClassCastException}.
*
- * @throws ClassCastException when either argument is not
- * a [EMAIL PROTECTED] Boolean}
+ * @throws ClassCastException when either argument is not codeBoolean/code
*/
public int compare(Object o1, Object o2) {
return compare((Boolean)o1,(Boolean)o2);
}
/**
- * Compares two non-codenull/code [EMAIL PROTECTED] Boolean}s
+ * Compares two non-codenull/code codeBoolean/code objects
* according to the value of [EMAIL PROTECTED] #sortsTrueFirst}.
*
* @throws NullPointerException when either argument codenull/code
@@ -121,6 +123,7 @@
return trueFirst;
}
+//---
/**
* Returns a BooleanComparator instance that sorts
* codetrue/code values before codefalse/code values.
@@ -161,8 +164,7 @@
* virtual machine.
*
* @param trueFirst when codetrue/code, sort
- *codetrue/code [EMAIL PROTECTED] Boolean}s before
- *codefalse/code [EMAIL PROTECTED] Boolean}s.
+ * codetrue/code codeBoolean/codes before codefalse/code
* @return a cached BooleanComparator instance
*/
public static BooleanComparator getBooleanComparator(boolean trueFirst) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid UUIDClock.java
treilly 2004/04/27 19:40:20 Removed: id/src/java/org/apache/commons/id/uuid UUIDClock.java Log: Remove Clock was superceded by clock package. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid UUIDSystemClock.java
treilly 2004/04/27 19:42:12 Removed: id/src/java/org/apache/commons/id/uuid UUIDSystemClock.java Log: Remove file. Refactored in clock package. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/id HEADER.txt
treilly 2004/04/27 19:47:49 Modified:id HEADER.txt Log: Remove whitespace after lines 3,7,9 conflicts with checkstyle whitespace check Revision ChangesPath 1.2 +3 -3 jakarta-commons-sandbox/id/HEADER.txt Index: HEADER.txt === RCS file: /home/cvs/jakarta-commons-sandbox/id/HEADER.txt,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- HEADER.txt29 Feb 2004 16:07:39 - 1.1 +++ HEADER.txt28 Apr 2004 02:47:49 - 1.2 @@ -1,12 +1,12 @@ /* * Copyright 2003-2004 The Apache Software Foundation. - * + * * Licensed under the Apache License, Version 2.0 (the License); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an AS IS BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock Clock.java
treilly 2004/04/27 19:56:17 Modified:id/src/java/org/apache/commons/id/uuid/clock Clock.java Log: Remove whitespace after 3,7,9 Revision ChangesPath 1.3 +4 -4 jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock/Clock.java Index: Clock.java === RCS file: /home/cvs/jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock/Clock.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- Clock.java10 Apr 2004 07:37:06 - 1.2 +++ Clock.java28 Apr 2004 02:56:17 - 1.3 @@ -1,12 +1,12 @@ /* * Copyright 2004 The Apache Software Foundation. - * + * * Licensed under the Apache License, Version 2.0 (the License); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an AS IS BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock OverClockedException.java
treilly 2004/04/27 19:57:07 Modified:id/src/java/org/apache/commons/id/uuid/clock OverClockedException.java Log: Remove whitespace after 3,7,9 Revision ChangesPath 1.3 +4 -4 jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock/OverClockedException.java Index: OverClockedException.java === RCS file: /home/cvs/jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock/OverClockedException.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- OverClockedException.java 10 Apr 2004 07:37:06 - 1.2 +++ OverClockedException.java 28 Apr 2004 02:57:07 - 1.3 @@ -1,12 +1,12 @@ /* * Copyright 2004 The Apache Software Foundation. - * + * * Licensed under the Apache License, Version 2.0 (the License); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an AS IS BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock SystemClockImpl.java
treilly 2004/04/27 19:58:06
Modified:id/src/java/org/apache/commons/id/uuid/clock
SystemClockImpl.java
Log:
Removes whitespace after 3,7,9
Adds author and version
Revision ChangesPath
1.3 +5 -3
jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock/SystemClockImpl.java
Index: SystemClockImpl.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock/SystemClockImpl.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- SystemClockImpl.java 10 Apr 2004 07:37:06 - 1.2
+++ SystemClockImpl.java 28 Apr 2004 02:58:06 - 1.3
@@ -1,12 +1,12 @@
/*
* Copyright 2004 The Apache Software Foundation.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -22,6 +22,8 @@
* /p
*
* @see org.apache.commons.uid.uuid.Clock
+ * @author Commons-Id Team
+ * @version $Revision$ $Date$
*/
public final class SystemClockImpl implements Clock {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock ThreadClockImpl.java
treilly 2004/04/27 19:59:03
Modified:id/src/java/org/apache/commons/id/uuid/clock
ThreadClockImpl.java
Log:
Remove whitespace after 3,7,9
Adds author and version tags
catch on same line
Revision ChangesPath
1.3 +7 -5
jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock/ThreadClockImpl.java
Index: ThreadClockImpl.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/clock/ThreadClockImpl.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ThreadClockImpl.java 10 Apr 2004 07:37:06 - 1.2
+++ ThreadClockImpl.java 28 Apr 2004 02:59:03 - 1.3
@@ -1,12 +1,12 @@
/*
* Copyright 2004 The Apache Software Foundation.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -31,6 +31,9 @@
* milliseconds before the System.currentTimeMillis changes. In instances where
* 10,000 or more uuid's may be generated in a millisecond this Clock
* implementation may be required.
+ *
+ * @author Commons-Id Team
+ * @version $Revision$ $Date$
*/
public final class ThreadClockImpl extends Thread implements Clock {
@@ -124,8 +127,7 @@
currentTimeMillis += sysInterval;
}
}
-}
-catch (InterruptedException e) {
+} catch (InterruptedException e) {
System.out.println(Clock thread interrupted);
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/state InMemoryStateImpl.java
treilly 2004/04/27 20:00:10 Modified:id/src/java/org/apache/commons/id/uuid/state InMemoryStateImpl.java Log: Remove whitespace after 3,7,9 Revision ChangesPath 1.3 +4 -4 jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/state/InMemoryStateImpl.java Index: InMemoryStateImpl.java === RCS file: /home/cvs/jakarta-commons-sandbox/id/src/java/org/apache/commons/id/uuid/state/InMemoryStateImpl.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- InMemoryStateImpl.java10 Apr 2004 07:37:06 - 1.2 +++ InMemoryStateImpl.java28 Apr 2004 03:00:10 - 1.3 @@ -1,12 +1,12 @@ /* * Copyright 2004 The Apache Software Foundation. - * + * * Licensed under the Apache License, Version 2.0 (the License); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an AS IS BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 27885] - [id] more minor cleanup
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=27885. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=27885 [id] more minor cleanup [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-04-28 03:25 --- Applied. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP@lsd]: jelly-tags/commons-jelly-tags-jsl failed
To whom it may engage... This is an automated request, but not an unsolicited one. For help understanding the request please visit http://gump.apache.org/nagged.html, and/or contact [EMAIL PROTECTED] Project commons-jelly-tags-jsl has an issue affecting its community integration, and has been outstanding for 18 runs. The current state is 'Failed', for reason 'Build Failed' Full details are available at: http://lsd.student.utwente.nl/gump/jelly-tags/commons-jelly-tags-jsl/index.html That said, some snippets follow: Gump provided these annotations: - Info - Sole jar [commons-jelly-tags-jsl-20040428.jar] identifier set to project name - Info - Enable debug output, due to a sequence of 17 previous errors. - Info - Failed with reason build failed Gump performed this work: http://lsd.student.utwente.nl/gump/jelly-tags/commons-jelly-tags-jsl/gump_work/build_jelly-tags_commons-jelly-tags-jsl.html Work Name: build_jelly-tags_commons-jelly-tags-jsl (Type: Build) State: Failed Elapsed: 0 hours, 0 minutes, 18 seconds Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true -Xbootclasspath/p:/data3/gump/xml-xerces2/java/build/xercesImpl.jar:/data3/gump/xml-xerces2/java/build/xml-apis.jar org.apache.tools.ant.Main -debug -Dgump.merge=/data3/gump/gump-install/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-jelly-tags-jsl-20040428 jar [Working Directory: /data3/gump/jelly-tags/jsl] - [junit] at org.apache.commons.jelly.tags.junit.AssertTagSupport.fail(AssertTagSupport.java:50) [junit] at org.apache.commons.jelly.tags.junit.AssertTag.doTag(AssertTag.java:58) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.impl.StaticTag.doTag(StaticTag.java:65) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:102) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:51) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:71) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:148) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:51) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:73) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:65) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:57) [junit] at org.apache.commons.jelly.tags.jsl.StylesheetTag.doTag(StylesheetTag.java:124) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.core.ForEachTag.doTag(ForEachTag.java:101) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:236) [junit] at org.apache.commons.jelly.tags.log.InfoTag.doTag(InfoTag.java:39) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) BUILD FAILED /data3/gump/jelly-tags/jsl/build.xml:110: Test org.apache.commons.jelly.jsl.TestJSLSuite failed at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.actOnTestResult(JUnitTask.java:1460) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.java:698) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeOrQueue(JUnitTask.java:1426) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.java:646) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:268) at org.apache.tools.ant.Task.perform(Task.java:363) at org.apache.tools.ant.Target.execute(Target.java:321) at org.apache.tools.ant.Target.performTasks(Target.java:348) at org.apache.tools.ant.Project.executeTarget(Project.java:1212) at org.apache.tools.ant.Project.executeTargets(Project.java:1060) at org.apache.tools.ant.Main.runBuild(Main.java:666) at
[GUMP@lsd]: jelly-tags/commons-jelly-tags-jetty failed
To whom it may engage... This is an automated request, but not an unsolicited one. For help understanding the request please visit http://gump.apache.org/nagged.html, and/or contact [EMAIL PROTECTED] Project commons-jelly-tags-jetty has an issue affecting its community integration, and has been outstanding for 18 runs. The current state is 'Failed', for reason 'Build Failed' Full details are available at: http://lsd.student.utwente.nl/gump/jelly-tags/commons-jelly-tags-jetty/index.html That said, some snippets follow: Gump provided these annotations: - Info - Sole jar [commons-jelly-tags-jetty-20040428.jar] identifier set to project name - Info - Enable debug output, due to a sequence of 17 previous errors. - Info - Failed with reason build failed Gump performed this work: http://lsd.student.utwente.nl/gump/jelly-tags/commons-jelly-tags-jetty/gump_work/build_jelly-tags_commons-jelly-tags-jetty.html Work Name: build_jelly-tags_commons-jelly-tags-jetty (Type: Build) State: Failed Elapsed: 0 hours, 0 minutes, 6 seconds Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/data3/gump/xml-xerces2/java/build/xercesImpl.jar:/data3/gump/xml-xerces2/java/build/xml-apis.jar org.apache.tools.ant.Main -debug -Dgump.merge=/data3/gump/gump-install/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-jelly-tags-jetty-20040428 jar [Working Directory: /data3/gump/jelly-tags/jetty] - [javac] import org.mortbay.util.Code; [javac] ^ [javac] /data3/gump/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/JettyHttpServerTag.java:73: cannot resolve symbol [javac] symbol : class OutputStreamLogSink [javac] location: class org.apache.commons.jelly.tags.jetty.JettyHttpServerTag [javac] _logSink = new OutputStreamLogSink(DEFAULT_LOG_FILE); [javac]^ [javac] /data3/gump/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/JettyHttpServerTag.java:75: cannot resolve symbol [javac] symbol : variable Log [javac] location: class org.apache.commons.jelly.tags.jetty.JettyHttpServerTag [javac] Log.instance().add(_logSink); [javac] ^ [javac] /data3/gump/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java:191: cannot resolve symbol [javac] symbol : variable Code [javac] location: class org.apache.commons.jelly.tags.jetty.SecurityHandlerTag [javac] Code.warning(Unknown user-data-constraint:+guarantee); [javac] ^ [javac] /data3/gump/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java:236: cannot resolve symbol [javac] symbol : class Authenticator [javac] location: class org.apache.commons.jelly.tags.jetty.SecurityHandlerTag [javac] Authenticator authenticator=null; [javac] ^ [javac] /data3/gump/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java:248: cannot resolve symbol [javac] symbol : variable Code [javac] location: class org.apache.commons.jelly.tags.jetty.SecurityHandlerTag [javac] Code.warning(UNKNOWN AUTH METHOD: +m); [javac] ^ [javac] /data3/gump/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java:261: cannot resolve symbol [javac] symbol : variable Code [javac] location: class org.apache.commons.jelly.tags.jetty.SecurityHandlerTag [javac] Code.warning(FORM Authentication miss-configured); [javac] ^ [javac] 13 errors BUILD FAILED /data3/gump/jelly-tags/jetty/build.xml:46: Compile failed; see the compiler error output for details. at org.apache.tools.ant.taskdefs.Javac.compile(Javac.java:938) at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:758) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:268) at org.apache.tools.ant.Task.perform(Task.java:363) at org.apache.tools.ant.Target.execute(Target.java:321) at org.apache.tools.ant.Target.performTasks(Target.java:348) at org.apache.tools.ant.Project.executeTarget(Project.java:1212) at org.apache.tools.ant.Project.executeTargets(Project.java:1060) at org.apache.tools.ant.Main.runBuild(Main.java:666) at org.apache.tools.ant.Main.startAnt(Main.java:187) at org.apache.tools.ant.Main.start(Main.java:151) at org.apache.tools.ant.Main.main(Main.java:234) Total time: 5 seconds - To subscribe to this information via syndicated feeds: RSS: http://lsd.student.utwente.nl/gump/jelly-tags/commons-jelly-tags-jetty/rss.xml Atom: http://lsd.student.utwente.nl/gump/jelly-tags/commons-jelly-tags-jetty/atom.xml -- Apache Gump
[GUMP@lsd]: jelly-tags/commons-jelly-tags-define failed
To whom it may engage... This is an automated request, but not an unsolicited one. For help understanding the request please visit http://gump.apache.org/nagged.html, and/or contact [EMAIL PROTECTED] Project commons-jelly-tags-define has an issue affecting its community integration, and has been outstanding for 18 runs. The current state is 'Failed', for reason 'Build Failed' Full details are available at: http://lsd.student.utwente.nl/gump/jelly-tags/commons-jelly-tags-define/index.html That said, some snippets follow: Gump provided these annotations: - Info - Sole jar [commons-jelly-tags-define-20040428.jar] identifier set to project name - Info - Enable debug output, due to a sequence of 17 previous errors. - Info - Failed with reason build failed Gump performed this work: http://lsd.student.utwente.nl/gump/jelly-tags/commons-jelly-tags-define/gump_work/build_jelly-tags_commons-jelly-tags-define.html Work Name: build_jelly-tags_commons-jelly-tags-define (Type: Build) State: Failed Elapsed: 0 hours, 0 minutes, 14 seconds Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true -Xbootclasspath/p:/data3/gump/xml-xerces2/java/build/xercesImpl.jar:/data3/gump/xml-xerces2/java/build/xml-apis.jar:/data3/gump/xml-xalan/java/build/xalan-unbundled.jar:/data3/gump/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -debug -Dgump.merge=/data3/gump/gump-install/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-jelly-tags-define-20040428 jar [Working Directory: /data3/gump/jelly-tags/define] - [junit] at org.apache.commons.jelly.impl.TagScript.handleException(TagScript.java:642) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:242) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.impl.DynamicTag.doTag(DynamicTag.java:79) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:102) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:236) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] Caused by: java.lang.NullPointerException [junit] at org.apache.commons.jelly.tags.define.SuperTag.doTag(SuperTag.java:44) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] ... 20 more [junit] Root cause [junit] java.lang.NullPointerException [junit] at org.apache.commons.jelly.tags.define.SuperTag.doTag(SuperTag.java:44) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.impl.DynamicTag.doTag(DynamicTag.java:79) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:102) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:236) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) BUILD FAILED /data3/gump/jelly-tags/define/build.xml:110: Test org.apache.commons.jelly.tags.define.TestJelly failed at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.actOnTestResult(JUnitTask.java:1460) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.java:698) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.executeOrQueue(JUnitTask.java:1426) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTask.execute(JUnitTask.java:646) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:268) at org.apache.tools.ant.Task.perform(Task.java:363) at org.apache.tools.ant.Target.execute(Target.java:321) at org.apache.tools.ant.Target.performTasks(Target.java:348) at org.apache.tools.ant.Project.executeTarget(Project.java:1212) at org.apache.tools.ant.Project.executeTargets(Project.java:1060) at
DO NOT REPLY [Bug 28421] - Per socket SOCKS proxies
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28421. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28421 Per socket SOCKS proxies --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 07:11 --- Oleg, Proxy settings are 'manual routing' on the application layer of the protocol stack. Therefore proxy settings must remain a per host property in any case. Even if most proxy users will only use one proxy setting for all their connections, we must not restrict HttpClient to this most common case. I think it is an essential flexibility to be able to use a specific proxy per connection. At our company for instance, we have access to the intranets of some of our clients. It makes sense to set up one proxy server for each of those connections. With HttpClient I can then access any host in those intranets depending on the proxy setting. Also, if we ever want to implement PAC (auto config) we need to be able to use one setting per host. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: customizing debugging levels per httpclient instance
Jorrit Kronjee wrote: I would like to see the wire of one of the threads, but suppress the other. Currently this is not possible. A simple workaround with Log4J is: * set your logging string to include the thread name * grep the log for the thread name you whish HTH Ortwin Glück - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[newbie]
Dear All, How can I make a HttpClient that can do SSL Handshake with the Http Server?? Thank You. Regards, Rahmat Bagas Santoso Ps : I am sorry if I send this mail to [EMAIL PROTECTED] and [EMAIL PROTECTED] , please advise where should I send this type of question?
RE: [newbie]
Dear All, I am sorry let me rephrase my question. What I want to ask are 1. How do I check and approve a certificate sent by a web server in https request? So that I don't get error like : javax.net.ssl.SSLHandshakeException:sun.security.validator.ValidatorExce ption: No trusted certificate found. 2. Can a HttpClient uses a certificate so that it can be verified by a webserver that it trying to connect? If this can be done please give me an example? Thank You. Regards, Rahmat Bagas Santoso -Original Message- From: bagas [mailto:[EMAIL PROTECTED] Sent: Tuesday, April 27, 2004 3:02 PM To: [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [newbie] Dear All, How can I make a HttpClient that can do SSL Handshake with the Http Server?? Thank You. Regards, Rahmat Bagas Santoso Ps : I am sorry if I send this mail to [EMAIL PROTECTED] and [EMAIL PROTECTED] , please advise where should I send this type of question? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [newbie] SSL
bagas wrote: Dear All, I am sorry let me rephrase my question. What I want to ask are 1. How do I check and approve a certificate sent by a web server in https request? So that I don't get error like : javax.net.ssl.SSLHandshakeException:sun.security.validator.ValidatorExce ption: No trusted certificate found. 2. Can a HttpClient uses a certificate so that it can be verified by a webserver that it trying to connect? If this can be done please give me an example? Thank You. Regards, Rahmat Bagas Santoso Please check out the SSL guide http://jakarta.apache.org/commons/httpclient/sslguide.html which should answer your questions. As statet frequently on this list, HttpClient makes no assumptions about the underlying SSL implementation. Please refer to the documentation of your SSL implementation for further information. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28566] - Handling sub-domain cookies.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28566. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28566 Handling sub-domain cookies. --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 09:16 --- Abhishek, This problem has already been addressed. I suppose you are using the latest CVS snapshot, as the patch is against CVS HEAD. To make HttpClient send cookies as one header set the parameter 'http.protocol.single-cookie-header' to true GetMethod httpget = new GetMethod(/whatever); httpget.getParams(). setBooleanParameter(http.protocol.single-cookie-header, true); This parameter can also be set at the HttpClient level, if you want all subsequent requests issued by that HttpClient instance to send cookies as a single header HTH Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28421] - Per socket SOCKS proxies
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28421. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28421 Per socket SOCKS proxies --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 09:29 --- Odi, All I am saying is that HttpParams _might_ be a better place for proxy settings, as HostConfiguration is getting a little too messy IMO. I am not trying to say that we should not support multiple proxies and different proxy types. Let's just consider leveraging HttpParams as it has been specifically designed to allow parameter settings at client | method | connection level Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
using it as a http-url-handler...
i know this has been asked before, but maybe some progress has been made i need to use httpclient as a http url-handler in java (registering it with java.protocol.handler.pkgs and so on). are there any plans to implement it? is it implemented in cvs? would it be hard to implement it? any recommendations/advices/possible-problems on implementing it? thanks, gabor - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: using it as a http-url-handler...
There is o.a.c.h.util.HttpURLConnection. It's ancient and I don't know if it will work for you, but it's certainly a starting point. gabor wrote: i know this has been asked before, but maybe some progress has been made i need to use httpclient as a http url-handler in java (registering it with java.protocol.handler.pkgs and so on). - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Problems using SSL from inside JBoss (jsse problem?)
Hi Oleg, thanks for your reply,
Yes, I got a mail out on the jboss forums as well, but haven't had any luck
there yet. I have tried just using HttpsURLConnection to no avail. I did go
through the SSL troubleshooting guide on the httpclient site, but could
unfortunately not find a solution. I suspect the error to be somewhere in
how jboss handles jsse somehow, somewhere, so my current plan is to dive in
there.
Again thanks for your time.
/Fredrik
-Original Message-
From: Kalnichevski, Oleg [mailto:[EMAIL PROTECTED]
Sent: 26 April 2004 17:16
To: Commons HttpClient Project
Cc: [EMAIL PROTECTED]
Subject: RE: Problems using SSL from inside JBoss (jsse problem?)
Fredrik,
This problem is clearly not HttpClient related, hence you have not been
getting a lot of responses. HttpClient simply expects JSSE to be there and
be properly configured in order for the HTTPS support to be functional.
Please take a look at the HttpClient SSL guide paying special attention to
the troubleshooting section
http://jakarta.apache.org/commons/httpclient/sslguide.html
Hope this helps a little
Oleg
-Original Message-
From: Fredrik Bonde [mailto:[EMAIL PROTECTED]
Sent: Wednesday, April 21, 2004 13:18
To: '[EMAIL PROTECTED]'
Subject: Problems using SSL from inside JBoss (jsse problem?)
Hi all, I got a questing regarding using HttpClient from an MDB inside
Jboss. Normal http connections work fine, but whenever I try to connect to a
host using https I get a SocketException, claiming SSL is not available:
12:13:39,338 INFO [STDOUT] 2004-04-21 12:13:39,322 ERROR
(HttpClientWrapper.java:120) Unable to connect to 'https://mail.yahoo.com'
java.net.SocketException: SSL implementation not available
at
javax.net.ssl.DefaultSSLSocketFactory.createSocket([DashoPro-V1.2-120198])
at
org.apache.commons.httpclient.protocol.SSLProtocolSocketFactory.createSocket
(SSLProtocolSocketFactory.java:112)
at
org.apache.commons.httpclient.HttpConnection$1.doit(HttpConnection.java:691)
at
org.apache.commons.httpclient.HttpConnection$SocketTask.run(HttpConnection.j
ava:1299)
at java.lang.Thread.run(Thread.java:534)
12:13:39,322 ERROR [HttpClientWrapper] Unable to connect to
'https://mail.yahoo.com'
java.net.SocketException: SSL implementation not available
at
javax.net.ssl.DefaultSSLSocketFactory.createSocket([DashoPro-V1.2-120198])
at
org.apache.commons.httpclient.protocol.SSLProtocolSocketFactory.createSocket
(SSLProtocolSocketFactory.java:112)
at
org.apache.commons.httpclient.HttpConnection$1.doit(HttpConnection.java:691)
at
org.apache.commons.httpclient.HttpConnection$SocketTask.run(HttpConnection.j
ava:1299)
at java.lang.Thread.run(Thread.java:534)
The code works fine outside Jboss so I suppose there something I need to do
in order to enable jsse for Jboss. The problem is that I do not have a clue
*how* to set it up! If anyone could help me it would be greatly appreciated.
I'm using Java 1.4_02, HttpClient 2.0-final and Jboss 3.2.3. I have also
tried to set the system property java.protocol.handler.pkgs to
com.sun.net.ssl.internal.www.protocol using: String sRes =
System.setProperty(java.protocol.handler.pkgs,com.sun.net.ssl.internal.ww
w.protocol);
also I try to add a provider with:
Security.addProvider(new com.sun.net.ssl.internal.ssl.Provider());
code looks like this:
HttpClient httpClient = new HttpClient();
httpClient.setConnectionTimeout(connectTimeout);
httpClient.setTimeout(readTimeout);
HttpMethod method = null;
//debug
System.setProperty(org.apache.commons.logging.Log,
org.apache.commons.logging.impl.SimpleLog);
System.setProperty(org.apache.commons.logging.simplelog.showdatetime,
true);
System.setProperty(org.apache.commons.logging.simplelog.log.httpclient.wire
, debug);
System.setProperty(org.apache.commons.logging.simplelog.log.org.apache.comm
ons.httpclient, debug);
String sRes =
System.setProperty(java.protocol.handler.pkgs,com.sun.net.ssl.internal.ww
w.protocol);
int ret = Security.addProvider(new
com.sun.net.ssl.internal.ssl.Provider());
method = new GetMethod(url.toExternalForm());
method.setFollowRedirects(true);
//execute the method
try{
httpClient.executeMethod(method); // here exception is thrown
String res = method.getResponseBodyAsString();
method.releaseConnection();
return res;
} catch (HttpException e) {
_log.error(Http error connecting to ' + url + ', e);
throw new HttpClientException(e.getMessage());
} catch (IOException e){
_log.error(Unable to connect to ' + url + ', e);
throw new HttpClientException(e.getMessage());
}
Kind regards,
Fredrik Bonde ~ Java Developer
-
To unsubscribe, e-mail:
[EMAIL
Re: using it as a http-url-handler...
On Tue, 2004-04-27 at 11:41, Oleg Kalnichevski wrote: Gabor (I hope I got your name right) yes :) *.util.HttpURLConnection was only meant to be a compatibility wrapper, not a complete replacement which could be registered with JRE as a full-blown URL handler. It is half-baked and is probably not very functional. The general sentiment is that HttpURLConnection framework is so broken that it is hardly worth the trouble. Anyways, we'll happily accept a better HttpClient based HttpURLConnection implementation ;-) well...it's not a big deal if it's not complete we simply have some part of our program which use the standard-java http objects...so the other option would be to port that code to use httpclienti'm still not sure which option is better/simpler...i'll have to look into the sources more gabor - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: customizing debugging levels per httpclient instance
Hi Oleg, I had a similar problem when I started using HttpClient last year. Not thread-based though. I'm in a servlet engine, so I don't know which thread will be processing the request that uses HttpClient. I'd like to have different log settings per HttpClient instance, but that's not possible because they all use the same static loggers. It's not a big issue for me now, since I have enough application level tracing. But if someone has an idea how this problem could be solved once and for all, it might be worth considering for 4.0. Like creating a logger for each HttpClient instance instead of each implementation class. Or falling back to the class logger only if no instance logger is configured in the params. cheers, Roland Kalnichevski, Oleg [EMAIL PROTECTED] 26.04.2004 18:34 Please respond to Commons HttpClient Project To: Commons HttpClient Project [EMAIL PROTECTED] cc: Subject:RE: customizing debugging levels per httpclient instance Jorrit, HttpClient relies on commons-logging toolkit to do all its logging. The commons-logging itself is merely an abstraction layer intended to provide a uniform interface to different logging toolkits. If there is a toolkit capable of assigning different appenders on per thread basis, then HttpClient can be configured to take advantage of it. To my best knowledge Log4j cannot assign individual appenders to different threads within the same application (within the same class loader context rather). You may consider evaluating a different logging toolkit that provides such a feature, or file a feature request with the Log4j project. Oleg -Original Message- From: Jorrit Kronjee [mailto:[EMAIL PROTECTED] Sent: Monday, April 26, 2004 13:19 To: [EMAIL PROTECTED] Subject: customizing debugging levels per httpclient instance Hello, I have an application consisting of two threads. Both threads have an own instance of httpclient and use it for different things. I would like to see the wire of one of the threads, but suppress the other. I use log4j. log4j can set the debugging level (trace or not) based on package/class names. I was wondering if it's possible to set the class name for http client, so i can customize my debugging per thread. Or perhaps I'm not understanding it correctly. If this is not possible, I would like to make this a feature request. Thanks in advance, Jorrit Kronjee - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] *** The information in this email is confidential and may be legally privileged. Access to this email by anyone other than the intended addressee is unauthorized. If you are not the intended recipient of this message, any review, disclosure, copying, distribution, retention, or any action taken or omitted to be taken in reliance on it is prohibited and may be unlawful. If you are not the intended recipient, please reply to or forward a copy of this message to the sender and delete the message, any attachments, and any copies thereof from your system. *** - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: customizing debugging levels per httpclient instance
Best solution I've come up with for this sort of thing is to use Nested Diagnostic Context's (NDC) in log4j have a look at the section on them in: http://logging.apache.org/log4j/docs/manual.html Not quite what you want I know, but it will give you something to grep on. Gareth Roland Weber [EMAIL PROTECTED] com To Commons HttpClient Project 27/04/2004 14:12 [EMAIL PROTECTED] che.org cc Please respond to Commons Subject HttpClient RE: customizing debugging levels Project per httpclient instance commons-httpclie [EMAIL PROTECTED] ache.org Hi Oleg, I had a similar problem when I started using HttpClient last year. Not thread-based though. I'm in a servlet engine, so I don't know which thread will be processing the request that uses HttpClient. I'd like to have different log settings per HttpClient instance, but that's not possible because they all use the same static loggers. It's not a big issue for me now, since I have enough application level tracing. But if someone has an idea how this problem could be solved once and for all, it might be worth considering for 4.0. Like creating a logger for each HttpClient instance instead of each implementation class. Or falling back to the class logger only if no instance logger is configured in the params. cheers, Roland Kalnichevski, Oleg [EMAIL PROTECTED] 26.04.2004 18:34 Please respond to Commons HttpClient Project To: Commons HttpClient Project [EMAIL PROTECTED] cc: Subject:RE: customizing debugging levels per httpclient instance Jorrit, HttpClient relies on commons-logging toolkit to do all its logging. The commons-logging itself is merely an abstraction layer intended to provide a uniform interface to different logging toolkits. If there is a toolkit capable of assigning different appenders on per thread basis, then HttpClient can be configured to take advantage of it. To my best knowledge Log4j cannot assign individual appenders to different threads within the same application (within the same class loader context rather). You may consider evaluating a different logging toolkit that provides such a feature, or file a feature request with the Log4j project. Oleg -Original Message- From: Jorrit Kronjee [mailto:[EMAIL PROTECTED] Sent: Monday, April 26, 2004 13:19 To: [EMAIL PROTECTED] Subject: customizing debugging levels per httpclient instance Hello, I have an application consisting of two threads. Both threads have an own instance of httpclient and use it for different things. I would like to see the wire of one of the threads, but suppress the other. I use log4j. log4j can set the debugging level (trace or not) based on package/class names. I was wondering if it's possible to set the class name for http client, so i can customize my debugging per thread. Or perhaps I'm not understanding it correctly. If this is not possible, I would like to make this a feature request. Thanks in advance, Jorrit Kronjee - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] *** The information in this email is confidential and may be legally privileged. Access to this email by anyone other than the intended addressee is unauthorized. If you are not the intended recipient of this message, any review, disclosure, copying, distribution, retention, or any action taken or omitted to be taken in reliance on it is prohibited and may be unlawful. If you are not the intended recipient, please reply to or forward a copy of this message to the sender and delete the message, any attachments, and any copies thereof from your system. ***
RE: customizing debugging levels per httpclient instance
Hi Gareth, thanks a lot for the pointer. The concept is very close to what I need. The problem is that I'm not using log4j, since the application uses a different logging framework. But I might borrow the idea of attaching some context to the thread in my application. thanks again, Roland [EMAIL PROTECTED] 27.04.2004 15:20 Please respond to Commons HttpClient Project To: Commons HttpClient Project [EMAIL PROTECTED] cc: Subject:RE: customizing debugging levels per httpclient instance Best solution I've come up with for this sort of thing is to use Nested Diagnostic Context's (NDC) in log4j have a look at the section on them in: http://logging.apache.org/log4j/docs/manual.html Not quite what you want I know, but it will give you something to grep on. Gareth Roland Weber [EMAIL PROTECTED] com To Commons HttpClient Project 27/04/2004 14:12 [EMAIL PROTECTED] che.org cc Please respond to Commons Subject HttpClient RE: customizing debugging levels Project per httpclient instance commons-httpclie [EMAIL PROTECTED] ache.org Hi Oleg, I had a similar problem when I started using HttpClient last year. Not thread-based though. I'm in a servlet engine, so I don't know which thread will be processing the request that uses HttpClient. I'd like to have different log settings per HttpClient instance, but that's not possible because they all use the same static loggers. It's not a big issue for me now, since I have enough application level tracing. But if someone has an idea how this problem could be solved once and for all, it might be worth considering for 4.0. Like creating a logger for each HttpClient instance instead of each implementation class. Or falling back to the class logger only if no instance logger is configured in the params. cheers, Roland Kalnichevski, Oleg [EMAIL PROTECTED] 26.04.2004 18:34 Please respond to Commons HttpClient Project To: Commons HttpClient Project [EMAIL PROTECTED] cc: Subject:RE: customizing debugging levels per httpclient instance Jorrit, HttpClient relies on commons-logging toolkit to do all its logging. The commons-logging itself is merely an abstraction layer intended to provide a uniform interface to different logging toolkits. If there is a toolkit capable of assigning different appenders on per thread basis, then HttpClient can be configured to take advantage of it. To my best knowledge Log4j cannot assign individual appenders to different threads within the same application (within the same class loader context rather). You may consider evaluating a different logging toolkit that provides such a feature, or file a feature request with the Log4j project. Oleg -Original Message- From: Jorrit Kronjee [mailto:[EMAIL PROTECTED] Sent: Monday, April 26, 2004 13:19 To: [EMAIL PROTECTED] Subject: customizing debugging levels per httpclient instance Hello, I have an application consisting of two threads. Both threads have an own instance of httpclient and use it for different things. I would like to see the wire of one of the threads, but suppress the other. I use log4j. log4j can set the debugging level (trace or not) based on package/class names. I was wondering if it's possible to set the class name for http client, so i can customize my debugging per thread. Or perhaps I'm not understanding it correctly. If this is not possible, I would like to make this a feature request. Thanks in advance, Jorrit Kronjee - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] *** The information in this email is confidential and may be legally privileged. Access to this email by anyone other than the intended addressee is unauthorized. If you are not the intended recipient of this message, any review, disclosure, copying, distribution, retention, or any action taken or omitted to be taken in reliance on it is prohibited and may be unlawful. If you are not the intended recipient, please reply to or forward a copy of this message to the sender and delete the message, any attachments, and any copies thereof from your system. *** - To
DO NOT REPLY [Bug 28626] New: - ArrayIndexOutOfBoundsException in HttpStatus.getStatusText(508)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28626.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=28626
ArrayIndexOutOfBoundsException in HttpStatus.getStatusText(508)
Summary: ArrayIndexOutOfBoundsException in
HttpStatus.getStatusText(508)
Product: Commons
Version: 2.0 Final
Platform: All
OS/Version: All
Status: NEW
Severity: Minor
Priority: Other
Component: HttpClient
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
Try the following:
System.out.println(Status text = + HttpStatus.getStatusText(507));
try {
System.out.println(Status text = + HttpStatus.getStatusText(508));
}
catch (Exception ex) {
System.err.println(Exception! msg = + ex.getMessage());
ex.printStackTrace();
}
System.out.println(Status text = + HttpStatus.getStatusText(509));
507 - returns a message as expected
508 - ArrayIndexOutOfBoundsException
509 - null as expected
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: customizing debugging levels per httpclient instance
Roland, As long as NDC is not supported by commons-logging HttpClient will not be able to take full advantage of it. We can still think about some sort of workaround as long as it does not make stock version of HttpClient dependent on any particular logging toolkit. One idea that springs to mind is to provide logging as an aspect using AspectJ or similar Another possibility is, of course, introduce a logging toolkit abstraction layer and abstract commons-logging away ;-))) Oleg On Tue, 2004-04-27 at 15:39, Roland Weber wrote: Hi Gareth, thanks a lot for the pointer. The concept is very close to what I need. The problem is that I'm not using log4j, since the application uses a different logging framework. But I might borrow the idea of attaching some context to the thread in my application. thanks again, Roland [EMAIL PROTECTED] 27.04.2004 15:20 Please respond to Commons HttpClient Project To: Commons HttpClient Project [EMAIL PROTECTED] cc: Subject:RE: customizing debugging levels per httpclient instance Best solution I've come up with for this sort of thing is to use Nested Diagnostic Context's (NDC) in log4j have a look at the section on them in: http://logging.apache.org/log4j/docs/manual.html Not quite what you want I know, but it will give you something to grep on. Gareth Roland Weber [EMAIL PROTECTED] com To Commons HttpClient Project 27/04/2004 14:12 [EMAIL PROTECTED] che.org cc Please respond to Commons Subject HttpClient RE: customizing debugging levels Project per httpclient instance commons-httpclie [EMAIL PROTECTED] ache.org Hi Oleg, I had a similar problem when I started using HttpClient last year. Not thread-based though. I'm in a servlet engine, so I don't know which thread will be processing the request that uses HttpClient. I'd like to have different log settings per HttpClient instance, but that's not possible because they all use the same static loggers. It's not a big issue for me now, since I have enough application level tracing. But if someone has an idea how this problem could be solved once and for all, it might be worth considering for 4.0. Like creating a logger for each HttpClient instance instead of each implementation class. Or falling back to the class logger only if no instance logger is configured in the params. cheers, Roland Kalnichevski, Oleg [EMAIL PROTECTED] 26.04.2004 18:34 Please respond to Commons HttpClient Project To: Commons HttpClient Project [EMAIL PROTECTED] cc: Subject:RE: customizing debugging levels per httpclient instance Jorrit, HttpClient relies on commons-logging toolkit to do all its logging. The commons-logging itself is merely an abstraction layer intended to provide a uniform interface to different logging toolkits. If there is a toolkit capable of assigning different appenders on per thread basis, then HttpClient can be configured to take advantage of it. To my best knowledge Log4j cannot assign individual appenders to different threads within the same application (within the same class loader context rather). You may consider evaluating a different logging toolkit that provides such a feature, or file a feature request with the Log4j project. Oleg -Original Message- From: Jorrit Kronjee [mailto:[EMAIL PROTECTED] Sent: Monday, April 26, 2004 13:19 To: [EMAIL PROTECTED] Subject: customizing debugging levels per httpclient instance Hello, I have an application consisting of two threads. Both threads have an own instance of httpclient and use it for different things. I would like to see the wire of one of the threads, but suppress the other. I use log4j. log4j can set the debugging level (trace or not) based on package/class names. I was wondering if it's possible to set the class name for http client, so i can customize my debugging per thread. Or perhaps I'm not understanding it correctly. If this is not possible, I would like to make this a feature request. Thanks in advance, Jorrit Kronjee - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] *** The information in this email is
DO NOT REPLY [Bug 28626] - ArrayIndexOutOfBoundsException in HttpStatus.getStatusText(508)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28626. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28626 ArrayIndexOutOfBoundsException in HttpStatus.getStatusText(508) [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Target Milestone|--- |2.0 Final - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28626] - ArrayIndexOutOfBoundsException in HttpStatus.getStatusText(508)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28626. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28626 ArrayIndexOutOfBoundsException in HttpStatus.getStatusText(508) --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 15:29 --- Created an attachment (id=11353) Patch - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24869] - DigestScheme.authenticate returns invalid authorization string when algorithm is null
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=24869. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=24869 DigestScheme.authenticate returns invalid authorization string when algorithm is null --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 16:38 --- Created an attachment (id=11359) Patch against CVS HEAD - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Bug in HTTPUrl?
Folks, Any idea what to do with one? First of all, user name and password in HTTP url is something completely new to me. Any idea what Sung-Gu had in mind? Oleg On Fri, 2004-04-02 at 16:08, Gustav Munkby wrote: hi, If I do: HTTPUrl url = new HTTPUrl(kurt, nicepass#, hostname, 80, path); throws a URIException with message port number invalid. First of all the message is wrong... Next attempt was to urlencode the password, which resulted in the above line working, but the password was sent url-encoded to the destination, which can hardly be the desired behaviour? regards, Gustav Munkby - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28566] - Handling sub-domain cookies.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28566. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28566 Handling sub-domain cookies. --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 20:50 --- Hey Oleg, Thanks for the quick response. You are FAST. I am using the STABLE code since it will go into production pretty soon. Probably before the next HttpClient release. Would you recommend CVS HEAD for production purpose? For the time being I guess, I can work around by using a hack which ignores the strict mode settings. -- cheers, Abhishek. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28566] - Handling sub-domain cookies.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28566. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28566 Handling sub-domain cookies. --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 21:44 --- Abhishek, We are nearing the 3.0 alpha1 release with the development branch. Even though I am convinced that in many areas the code quality in our development branch is much better than that in the stable one, it would be irresponsible for me to recommend it for use in productive systems. For the time being, you might want to get the latest snapshot of 2.0 (stable) branch and tweak the compatibility cookie spec to your liking. The 3.0 release will provide many improvements in the area of cookie management. It will also allow to plug in custom cookie spec implementations. So, in the future you will not have to maintain the fork. If you do not mind, I'll apply the patch to the CVS HEAD and close the bug Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28566] - Handling sub-domain cookies.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28566. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28566 Handling sub-domain cookies. --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 21:51 --- If you do not mind, I'll apply the patch to the CVS HEAD and close the bug Please do. The fix works. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Yahoo login with Httpclient
Hi: I've been trying to use Httpclient to programmatically login to Yahoo, but I am not sure how to do it right, I've tried to follow the sample tutorials and nothing seemed to work for me, I've also searched the web for answers, but failed, it seems to me that Httpclient is the closest match for what I am looking for, can somebody please help me ? Some sample code of how to use Httpclient to login to Yahoo would be very helpful, I imagine if I supply username and password to it, I would get a page showing I'm logged in, I am trying to update my Yahoo Briefcase and Yahoo Geocities pages with my program. Is it possible to do that with Httpclient ? Thanks for any help. Frank - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 24154] - Setting CONNECTION_TIMEOUT and SO_TIMEOUT on a per-method basis
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=24154. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=24154 Setting CONNECTION_TIMEOUT and SO_TIMEOUT on a per-method basis --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 22:18 --- I have spent weeks thinking about a solution to this problem. I tend to conclude that CONNECTION_TIMEOUT and SO_TIMEOUT should simply be moved back to the HttpMethod/HttpClient level. It would be the easiest and least messy solution How do you feel about it? Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Yahoo login with Httpclient
Frank, You need to use so called form-based login. Have a look at this sample application: http://cvs.apache.org/viewcvs.cgi/jakarta-commons/httpclient/src/examples/FormLoginDemo.java?rev=1.1.2.1only_with_tag=HTTPCLIENT_2_0_BRANCHview=markup If it does not cut it for you, let me know. I may try to quickly hack it up for you (provided I do not get stamped with work (the one that helps me pay the bills I mean)) Oleg On Wed, 2004-04-28 at 00:08, Min (Frank) Ni wrote: Hi: I've been trying to use Httpclient to programmatically login to Yahoo, but I am not sure how to do it right, I've tried to follow the sample tutorials and nothing seemed to work for me, I've also searched the web for answers, but failed, it seems to me that Httpclient is the closest match for what I am looking for, can somebody please help me ? Some sample code of how to use Httpclient to login to Yahoo would be very helpful, I imagine if I supply username and password to it, I would get a page showing I'm logged in, I am trying to update my Yahoo Briefcase and Yahoo Geocities pages with my program. Is it possible to do that with Httpclient ? Thanks for any help. Frank - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28566] - Handling sub-domain cookies.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28566. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28566 Handling sub-domain cookies. [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-04-27 22:36 --- Patch committed Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26070] - [RFE] Allow streaming of POST methods via chunked transfer encoding.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=26070. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=26070 [RFE] Allow streaming of POST methods via chunked transfer encoding. [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-04-28 02:24 --- Patch applied. I'm going to create a new RFE to cover moving the Content-Type. I have also removed the deprecated tag on setRequestBody(String) until the content type is moved. Mike - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 28645] New: - Move Content-Type to the RequestEntity
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28645. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28645 Move Content-Type to the RequestEntity Summary: Move Content-Type to the RequestEntity Product: Commons Version: 3.0 Beta 1 Platform: Other OS/Version: Other Status: NEW Severity: Enhancement Priority: Other Component: HttpClient AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The content type is really a property of the RequestEntity. It should be moved there. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
