Re: [concordance-devel] Patch: Fix GetTag issue due to ref v.s. ptr change

2008-03-30 Thread Phil Dibowitz 
Stephen Warren wrote:
 GetTag has an issue because it checks whether found is NULL before
 assigning to it, but now it's a reference, so that check doesn't make
 sense, and this renders the found value invalid, which breaks a lot of
 things. The attached patch fixes this.

Applied, thanks.

-- 
Phil Dibowitz [EMAIL PROTECTED]
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/   http://www.ipom.com/

Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible -- Taylor's Laws of Programming




signature.asc
Description: OpenPGP digital signature
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

[concordance-devel] Patch: Fix GetTag issue due to ref v.s. ptr change

2008-03-29 Thread Stephen Warren 
GetTag has an issue because it checks whether found is NULL before
assigning to it, but now it's a reference, so that check doesn't make
sense, and this renders the found value invalid, which breaks a lot of
things. The attached patch fixes this.
? concordance/.concordance.c.swp
? concordance/.deps
? concordance/.libs
? concordance/Makefile
? concordance/Makefile.in
? concordance/aclocal.m4
? concordance/autom4te.cache
? concordance/concordance
? concordance/config.guess
? concordance/config.h
? concordance/config.h.in
? concordance/config.log
? concordance/config.status
? concordance/config.sub
? concordance/configure
? concordance/depcomp
? concordance/install-sh
? concordance/libtool
? concordance/ltmain.sh
? concordance/missing
? concordance/stamp-h1
? consnoop/USBLog2.txt
? consnoop/USBLog2.usblog
? consnoop/USBLog2.xml
? consnoop/USBLog3.txt
? consnoop/USBLog3.usblog
? consnoop/USBLog3.xml
? consnoop/consnoop
? consnoop/recovery.tbz2
? libconcord/.deps
? libconcord/.libconcord.cpp.swp
? libconcord/.libconcord.h.swp
? libconcord/.libs
? libconcord/.remote_info.h.swp
? libconcord/.web.cpp.swp
? libconcord/Makefile
? libconcord/Makefile.in
? libconcord/aclocal.m4
? libconcord/autom4te.cache
? libconcord/binaryfile.lo
? libconcord/config.guess
? libconcord/config.h
? libconcord/config.h.in
? libconcord/config.log
? libconcord/config.status
? libconcord/config.sub
? libconcord/configure
? libconcord/depcomp
? libconcord/install-sh
? libconcord/libconcord.la
? libconcord/libconcord.lo
? libconcord/libtool
? libconcord/libusbhid.lo
? libconcord/ltmain.sh
? libconcord/missing
? libconcord/remote.lo
? libconcord/remote_z.lo
? libconcord/stamp-h1
? libconcord/usblan.lo
? libconcord/web.lo
Index: libconcord/web.cpp
===
RCS file: /cvsroot/concordance/concordance/libconcord/web.cpp,v
retrieving revision 1.18
diff -u -p -r1.18 web.cpp
--- libconcord/web.cpp	29 Mar 2008 21:53:26 -	1.18
+++ libconcord/web.cpp	30 Mar 2008 04:29:39 -
@@ -183,9 +183,7 @@ int GetTag(const char *find, uint8_t* da
 			// Point past , at tag content
 			search += find_len + 1;
 
-			if (found) {
-found = search;
-			}
+			found = search;
 
 			/*
  			 * If a string pointer was passed in, then add the
-
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel