Re: [courier-users] PATCH: webmail address from auth

2006-11-05 Thread Alessandro Vesely
Sam Varshavchik wrote:
 Alessandro Vesely writes:
 
 Webmail currently obtains the email address from the html form.
 The patch I propose replaces that with the official address
 obtained from authentication. Often they are equal. However,
 using advanced configuration features of Courier-Authlib,
 it is possible to obtain different results. (In such cases,
 IME, webmail just fails to set the sender address correctly.)
 
 I'm not sure why you want to screw around with the first argument to 
 do_login.

Passing the address of the variable allows do_login to reallocate
ubuf if needed. The callback assumes it is either null or a pointer
to a variable that holds a successfully malloc'd memory address.

 That does not look right.  It's going to screw up the 
 subsequent call to sqpcp_login(); which although is not frequently used, 
 still should not have to suffer.

I can't see why PCP would suffer from that change. In the regular
case doauthlogin doesn't reallocate ubuf: it just overwrites it
with an identical string (capitalization may differ, though.)
Even if ubuf is reallocated, it is still a buffer obtained from
the same linked-in malloc, and still holds the user's email address.
Likewise, the subsequent call to free() isn't screwed up either.

As calendaring is disabled at mine, I didn't actually test the
sqpcp_login call. However, I noticed that login_returnaddr() is
called from pcp too. Hence, that patch might better pcp as well.
--Unlike courier, webmail fails to build a formally valid return
address in case the defaultdomain conf file is missing.


Sam, I'd re-submit the patch adapting it to the 20061028 build,
but I haven't been able to connect to the bittorrent host since
then. Right now, apache at vhost.sourceforge.net is not responding
altogether (sometimes I can connect to port 80, but get no replies.)

































-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___
courier-users mailing list
courier-users@lists.sourceforge.net
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users


Re: [courier-users] PATCH: webmail address from auth

2006-11-05 Thread Sam Varshavchik

Alessandro Vesely writes:

That does not look right.  It's going to screw up the 
subsequent call to sqpcp_login(); which although is not frequently used, 
still should not have to suffer.


I can't see why PCP would suffer from that change. In the regular


Because the login ID will now be different than the mail login ID.



pgpXLZtWYHvO2.pgp
Description: PGP signature
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
courier-users mailing list
courier-users@lists.sourceforge.net
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users


Re: [courier-users] LDAP question

2006-11-05 Thread Sam Varshavchik

Timothy S. Nelson writes:

	Hi all.  I'm interested in changing ldapaliasd.c so that the function 
search_virtual, in addition to its current functionality, will allow a 
variable (from the config file) named eg. LDAP_DOMAINQUERY which specifies the 
LDAP query to be used in fetching the alias for the domain, in much the same 
way as LDAP_EMAILMAP (in authlib).  

	I want to make the default search string 


((@[EMAIL PROTECTED]@realm@))

And if LDAP_SOURCE existed, I'd also add:

(@[EMAIL PROTECTED]@source@)

	I'd have it so that it would recognise the things I've specified in @@ 
signs, and I'd make it so that it would leave \@ alone, for uses like:


((@[EMAIL PROTECTED]@@realm@))

	(this would include the @ in the realm query).  

	The question I'm particularly interested in is, is Mr. Sam willing to 
accept a patch that implements this?  


Not if I do not understand exactly what's being accomplished here.  The 
current LDAP authenticator is flexible enough to be able to accomodate any 
reasonable situation.


I don't think I would want to start adding code for every oddball situation 
that someone might've dreamed up.  You need to clearly make a case that 
shows what specifically the current LDAP authenticator cannot do, and that 
there are a lot of people that fall into this situation.





pgpVqwtOPXPv4.pgp
Description: PGP signature
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
courier-users mailing list
courier-users@lists.sourceforge.net
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users


Re: [courier-users] LDAP question

2006-11-05 Thread Timothy S. Nelson
On Sun, 5 Nov 2006, Sam Varshavchik wrote:

 Not if I do not understand exactly what's being accomplished here.  The 
 current LDAP authenticator is flexible enough to be able to accomodate any 
 reasonable situation.
 
 I don't think I would want to start adding code for every oddball situation 
 that someone might've dreamed up.  You need to clearly make a case that 
 shows what specifically the current LDAP authenticator cannot do, and that 
 there are a lot of people that fall into this situation.

Ok.  All I want to achieve here is to allow it to search for domains 
as @example.com instead of example.com.  I can modify it to do this with a lot 
less effort than the abovementioned patch, but I thought the above was more 
flexible and generally desirable.  But if you're not interested, I'll go away 
and leave you alone :).  

The reason I want to use the ones with the @ sign are:
1.  The setup we have now works this way, and while we're transitioning to 
courier-mta, we still have some old mail servers using the old setup, 
so we didn't want to just change all of them.  
2.  Then it works just like an alias file, which people are already 
familiar with, thereby reducing the potential for future problems.  

It's nice dealing with someone who knows what they want.  Thanks for
the prompt response.

:)


-
| Name: Tim Nelson | Because the Creator is,|
| E-mail: [EMAIL PROTECTED] | I am   |
-

BEGIN GEEK CODE BLOCK
Version 3.12
GCS d+++ s+: a- C++$ U+++$ P+++$ L+++ E- W+ N+ w--- V- 
PE(+) Y+++ PGP-+++ R(+) !tv b++ DI D G+ e++ h! y-
-END GEEK CODE BLOCK-



-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___
courier-users mailing list
courier-users@lists.sourceforge.net
Unsubscribe: https://lists.sourceforge.net/lists/listinfo/courier-users