Re: [PATCH v3] spi: davinci: add support for adding delay between word's transmissions
On Fri, Sep 12, 2014 at 06:48:12PM +0300, Grygorii Strashko wrote: From: Murali Karicheri m-kariche...@ti.com This patch adds ability to configure delay between transmission of words over SPI bus if it's required by SPI slave devices. This is fine but it doesn't appear to apply against current code. Can you please check and resend? signature.asc Description: Digital signature ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH] spi: davinci: request cs_gpio's from probe
On Fri, Sep 12, 2014 at 05:54:00PM +0300, Grygorii Strashko wrote:
static void davinci_spi_cleanup(struct spi_device *spi)
{
- if (spi-cs_gpio = 0)
- gpio_free(spi-cs_gpio);
}
This function is now empty so should be removed. I've applied for now
but please send a followup fixing this.
signature.asc
Description: Digital signature
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
[PATCH 2/8] arm: mach-davinci: Convert pr_warning to pr_warn
Use the more common pr_warn.
Other miscellanea:
o Coalesce formats
o Realign arguments
Signed-off-by: Joe Perches j...@perches.com
---
arch/arm/mach-davinci/board-da830-evm.c| 76 +-
arch/arm/mach-davinci/board-dm644x-evm.c | 6 +--
arch/arm/mach-davinci/board-mityomapl138.c | 38 +++
arch/arm/mach-davinci/board-neuros-osd2.c | 3 +-
arch/arm/mach-davinci/time.c | 6 +--
5 files changed, 55 insertions(+), 74 deletions(-)
diff --git a/arch/arm/mach-davinci/board-da830-evm.c
b/arch/arm/mach-davinci/board-da830-evm.c
index 5623131..c73cd88 100644
--- a/arch/arm/mach-davinci/board-da830-evm.c
+++ b/arch/arm/mach-davinci/board-da830-evm.c
@@ -145,8 +145,7 @@ static __init void da830_evm_usb_init(void)
/* USB_REFCLKIN is not used. */
ret = davinci_cfg_reg(DA830_USB0_DRVVBUS);
if (ret)
- pr_warning(%s: USB 2.0 PinMux setup failed: %d\n,
- __func__, ret);
+ pr_warn(%s: USB 2.0 PinMux setup failed: %d\n, __func__, ret);
else {
/*
* TPS2065 switch @ 5V supplies 1 A (sustains 1.5 A),
@@ -154,14 +153,14 @@ static __init void da830_evm_usb_init(void)
*/
ret = da8xx_register_usb20(1000, 3);
if (ret)
- pr_warning(%s: USB 2.0 registration failed: %d\n,
- __func__, ret);
+ pr_warn(%s: USB 2.0 registration failed: %d\n,
+ __func__, ret);
}
ret = davinci_cfg_reg_list(da830_evm_usb11_pins);
if (ret) {
- pr_warning(%s: USB 1.1 PinMux setup failed: %d\n,
- __func__, ret);
+ pr_warn(%s: USB 1.1 PinMux setup failed: %d\n,
+ __func__, ret);
return;
}
@@ -183,8 +182,8 @@ static __init void da830_evm_usb_init(void)
ret = da8xx_register_usb11(da830_evm_usb11_pdata);
if (ret)
- pr_warning(%s: USB 1.1 registration failed: %d\n,
- __func__, ret);
+ pr_warn(%s: USB 1.1 registration failed: %d\n,
+ __func__, ret);
}
static const short da830_evm_mcasp1_pins[] = {
@@ -252,31 +251,30 @@ static inline void da830_evm_init_mmc(void)
ret = davinci_cfg_reg_list(da830_evm_mmc_sd_pins);
if (ret) {
- pr_warning(da830_evm_init: mmc/sd mux setup failed: %d\n,
- ret);
+ pr_warn(da830_evm_init: mmc/sd mux setup failed: %d\n, ret);
return;
}
ret = gpio_request(DA830_MMCSD_WP_PIN, MMC WP);
if (ret) {
- pr_warning(da830_evm_init: can not open GPIO %d\n,
- DA830_MMCSD_WP_PIN);
+ pr_warn(da830_evm_init: can not open GPIO %d\n,
+ DA830_MMCSD_WP_PIN);
return;
}
gpio_direction_input(DA830_MMCSD_WP_PIN);
ret = gpio_request(DA830_MMCSD_CD_PIN, MMC CD\n);
if (ret) {
- pr_warning(da830_evm_init: can not open GPIO %d\n,
- DA830_MMCSD_CD_PIN);
+ pr_warn(da830_evm_init: can not open GPIO %d\n,
+ DA830_MMCSD_CD_PIN);
return;
}
gpio_direction_input(DA830_MMCSD_CD_PIN);
ret = da8xx_register_mmcsd0(da830_evm_mmc_config);
if (ret) {
- pr_warning(da830_evm_init: mmc/sd registration failed: %d\n,
- ret);
+ pr_warn(da830_evm_init: mmc/sd registration failed: %d\n,
+ ret);
gpio_free(DA830_MMCSD_WP_PIN);
}
}
@@ -404,20 +402,18 @@ static inline void da830_evm_init_nand(int mux_mode)
int ret;
if (HAS_MMC) {
- pr_warning(WARNING: both MMC/SD and NAND are
- enabled, but they share AEMIF pins.\n
- \tDisable MMC/SD for NAND support.\n);
+ pr_warn(WARNING: both MMC/SD and NAND are enabled, but they
share AEMIF pins.\n
+ \tDisable MMC/SD for NAND support.\n);
return;
}
ret = davinci_cfg_reg_list(da830_evm_emif25_pins);
if (ret)
- pr_warning(da830_evm_init: emif25 mux setup failed: %d\n,
- ret);
+ pr_warn(da830_evm_init: emif25 mux setup failed: %d\n, ret);
ret = platform_device_register(da830_evm_nand_device);
if (ret)
- pr_warning(da830_evm_init: NAND device not registered.\n);
+ pr_warn(da830_evm_init: NAND device not registered.\n);
if (davinci_aemif_setup(da830_evm_nand_device))
pr_warn(%s: Cannot configure AEMIF.\n, __func__);
@@ -435,12 +431,11 @@ static inline
[PATCH 0/8] arm: Convert pr_warning to pr_warn
pr_warn is used about 3:1 over pr_warning and is mixed use in arch/arm. Standardize on pr_warn. Joe Perches (8): arm: Convert pr_warning to pr_warn arm: mach-davinci: Convert pr_warning to pr_warn arm: mach-ep93xx: Convert pr_warning to pr_warn arm: mach-imx: Convert pr_warning to pr_warn arm: mach-omap2: Convert pr_warning to pr_warn arm: mach-orion5x: Convert pr_warning to pr_warn arm: mach-pxa: Convert pr_warning to pr_warn arm: mach-u300: Convert pr_warning to pr_warn arch/arm/include/asm/syscall.h | 8 +-- arch/arm/kernel/atags_parse.c | 2 +- arch/arm/kernel/hw_breakpoint.c| 18 +++--- arch/arm/kernel/irq.c | 4 +- arch/arm/kernel/perf_event_cpu.c | 4 +- arch/arm/kernel/smp.c | 2 +- arch/arm/kernel/unwind.c | 24 arch/arm/mach-davinci/board-da830-evm.c| 76 +++--- arch/arm/mach-davinci/board-dm644x-evm.c | 6 +- arch/arm/mach-davinci/board-mityomapl138.c | 38 ++--- arch/arm/mach-davinci/board-neuros-osd2.c | 3 +- arch/arm/mach-davinci/time.c | 6 +- arch/arm/mach-ep93xx/core.c| 4 +- arch/arm/mach-imx/mach-armadillo5x0.c | 2 +- arch/arm/mach-imx/mach-mx31_3ds.c | 4 +- arch/arm/mach-imx/mach-mx31lite.c | 2 +- arch/arm/mach-imx/mach-pcm037.c| 4 +- arch/arm/mach-omap2/display.c | 2 +- arch/arm/mach-omap2/hdq1w.c| 4 +- arch/arm/mach-omap2/i2c.c | 2 +- arch/arm/mach-omap2/msdi.c | 4 +- arch/arm/mach-omap2/mux.c | 2 +- arch/arm/mach-omap2/omap_hwmod.c | 26 - arch/arm/mach-omap2/pdata-quirks.c | 4 +- arch/arm/mach-omap2/pm34xx.c | 2 +- arch/arm/mach-omap2/smartreflex-class3.c | 4 +- arch/arm/mach-omap2/sr_device.c| 2 +- arch/arm/mach-omap2/vc.c | 2 +- arch/arm/mach-omap2/voltage.c | 22 arch/arm/mach-omap2/wd_timer.c | 4 +- arch/arm/mach-orion5x/dns323-setup.c | 8 +-- arch/arm/mach-orion5x/terastation_pro2-setup.c | 2 +- arch/arm/mach-orion5x/ts209-setup.c| 2 +- arch/arm/mach-orion5x/ts409-setup.c| 2 +- arch/arm/mach-orion5x/ts78xx-setup.c | 4 +- arch/arm/mach-pxa/em-x270.c| 4 +- arch/arm/mach-pxa/gumstix.c| 3 +- arch/arm/mach-pxa/mfp-pxa2xx.c | 12 ++-- arch/arm/mach-pxa/poodle.c | 2 +- arch/arm/mach-pxa/pxa3xx-ulpi.c| 6 +- arch/arm/mach-pxa/raumfeld.c | 26 - arch/arm/mach-u300/dummyspichip.c | 65 ++ arch/arm/mm/idmap.c| 2 +- arch/arm/mm/mmu.c | 4 +- 44 files changed, 200 insertions(+), 229 deletions(-) -- 1.8.1.2.459.gbcd45b4.dirty ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
