Re: [PATCH v3] spi: davinci: add support for adding delay between word's transmissions

2014-09-15 Thread Grygorii Strashko 
On 09/13/2014 07:06 PM, Mark Brown wrote:
 On Fri, Sep 12, 2014 at 06:48:12PM +0300, Grygorii Strashko wrote:
 From: Murali Karicheri m-kariche...@ti.com

 This patch adds ability to configure delay between transmission of
 words over SPI bus if it's required by SPI slave devices.
 
 This is fine but it doesn't appear to apply against current code.  Can
 you please check and resend?
 

This one should be applied without conflicts on top of
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
branch: for-next

since you've applied the patch:
[PATCH] spi: davinci: request cs_gpio's from probe
http://www.spinics.net/lists/linux-spi/msg01811.html

I have to mention about this dependency, sorry for that.

Regards,
-grygorii

___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Re: [PATCH] spi: davinci: request cs_gpio's from probe

2014-09-15 Thread Grygorii Strashko 
On 09/13/2014 07:28 PM, Mark Brown wrote:
 On Fri, Sep 12, 2014 at 05:54:00PM +0300, Grygorii Strashko wrote:
 
   static void davinci_spi_cleanup(struct spi_device *spi)
   {
 -if (spi-cs_gpio = 0)
 -gpio_free(spi-cs_gpio);
   }
 
 This function is now empty so should be removed.  I've applied for now
 but please send a followup fixing this.
 

The function davinci_spi_cleanup() will be reused by following patch
[PATCH v3] spi: davinci: add support for adding delay between word's 
transmissions
http://www.spinics.net/lists/devicetree/msg49141.html

So, in broonie/spi.git/for-next it will not be empty.

Again, I've missed description of this dependency, sorry for that.

Regards,
-grygorii

___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Re: [PATCH] spi: davinci: request cs_gpio's from probe

2014-09-15 Thread Mark Brown 
On Mon, Sep 15, 2014 at 04:06:42PM +0300, Grygorii Strashko wrote:

 The function davinci_spi_cleanup() will be reused by following patch
 [PATCH v3] spi: davinci: add support for adding delay between word's 
 transmissions
 http://www.spinics.net/lists/devicetree/msg49141.html

 So, in broonie/spi.git/for-next it will not be empty.

 Again, I've missed description of this dependency, sorry for that.

Don't do things like this, delete the function and then re-add it - it
makes the review simpler and it means that if the second patch doesn't
get applied (as will happen here for v3.17) then the code still looks
good.


signature.asc
Description: Digital signature
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source