Re: ANNOUNCE: DBI 1.50 release candidate (bug in 10General.t)

2006-01-12 Thread Charles Jardine 

Tim Bunce wrote:

  http://dbi.demonweb.co.uk/public/DBI-1.50.tar.gz


I have successfully built the above release candidate under
Solaris 8 against an Oracle 10.2 Instant Client. The full
versions of things are:

SunOS 5.8 Generic_117350-26 sun4u sparc SUNW,Sun-Blade-100
This is perl, v5.8.7 built for sun4-solaris-64
SQL*Plus: Release 10.2.0.1.0

The resulting build fails one test. The error messages are:

t/10general.NOK 1
# Failed test (t/10general.t at line 25)
#  got: '65280'
# expected: '256'
t/10general.ok 13/33# Looks like you failed 1 test of 33.
t/10general.dubious

The line in question is:

is system(false), 18, 'system false should return 256';

The cause of the problem is that the Solaris version of /usr/bin/false
gives an exit code of 255, not 1.

Here is a patch which fixes this:

Index: t/10general.t
===
--- t/10general.t   (revision 2334)
+++ t/10general.t   (working copy)
@@ -22,8 +22,8 @@
 SKIP: {
skip not unix-like, 2 unless $Config{d_semctl};
# basic check that we can fork subprocesses and wait for the status
-   is system(false), 18, 'system false should return 256';
-   is system(true), 0, 'system true should return 0';
+   is system(exit 1;), 18, 'system exit 1; should return 256';
+   is system(exit 0;),0, 'system exit 0; should return 0';
 }

--
Charles Jardine - Computing Service, University of Cambridge
[EMAIL PROTECTED]Tel: +44 1223 334506, Fax: +44 1223 334679

Re: ANNOUNCE: DBI 1.50 release candidate (bug in 10General.t)

2006-01-12 Thread Tim Bunce 
On Thu, Jan 12, 2006 at 02:09:26PM +, Charles Jardine wrote:
 Here is a patch which fixes this:
 
 Index: t/10general.t
 ===
 --- t/10general.t   (revision 2334)
 +++ t/10general.t   (working copy)
 @@ -22,8 +22,8 @@
  SKIP: {
 skip not unix-like, 2 unless $Config{d_semctl};
 # basic check that we can fork subprocesses and wait for the status
 -   is system(false), 18, 'system false should return 256';
 -   is system(true), 0, 'system true should return 0';
 +   is system(exit 1;), 18, 'system exit 1; should return 256';
 +   is system(exit 0;),0, 'system exit 0; should return 0';
  }

Thanks, applied (to DBD::Oracle :)

Tim..