Re: [DDLUTILS-85] How to tackle the issue?
Hi Martin, Thank you for taking a look. Our priorities changed a bit during the last days and we are working on something else for now. Whenever we take another look on the DDLUtils code we will keep those guidelines in mind. Cheers, On Tue, Aug 06, 2013 at 04:15:13PM +0200, Martin van den Bemt wrote: HI Bruno, Maybe I created the wrong expectation. My last commit to this codebase was in 2006 based on an older API, so it is not so easy to advise on this level of detail. The main things I would keep in mind is : - Stay backwards compatible with the API - Keep in mind that everything shoudl be generic. So roundtrip from xml - oracle - xml export - derby - xml export should preferrably end up with the same xml. - The base platform implementation contains the things generic for a majority of db's. - Make your changes one platform at a time. (so eg if you are doing Derby you should forst start in DerbyPlatofrm to override the specific processChange method, or if it needs to be more detailed, the DerbySqlBuilder) - Make a test for you scenario. It is pretty complicated (and less enjoyable) to do that afterwards. Make sure you roundtripping works, so you know you get consistant results. At least that would be my approach. Another mail will follow about the current project status, so probably wait for that discussion to open up... Mvgr, Martin 2013/8/1 Bruno Tavares btav...@thoughtworks.com: Sure! Taking a look on the codebase I understood a bit of the flow. Maybe we can do some changes on the PlatformImplBase#processChange for the AddIndexChange objects to also create the unique constraint on the databases that support contraints. What do you think about that? On Wed, Jul 31, 2013 at 11:13:03PM +0200, Martin van den Bemt wrote: Hi Bruno, Could you give me a couple of more days to get (re) organized with DDLUtils ? Mvgr, Martin 2013/7/30 Bruno Tavares btav...@thoughtworks.com: Hi there everyone, There is an interest to work on something related to the DDLUTILS-85 issue on my current project. I would like to ask if there is any ideas on how you would approach the issue. Also, is there any standards or requirements on the code to submit patches? Cheers, -- Bruno Tavares -- Bruno Tavares Consultant Developer -- Bruno Tavares Consultant Developer
Re: [DDLUTILS-85] How to tackle the issue?
HI Bruno, Maybe I created the wrong expectation. My last commit to this codebase was in 2006 based on an older API, so it is not so easy to advise on this level of detail. The main things I would keep in mind is : - Stay backwards compatible with the API - Keep in mind that everything shoudl be generic. So roundtrip from xml - oracle - xml export - derby - xml export should preferrably end up with the same xml. - The base platform implementation contains the things generic for a majority of db's. - Make your changes one platform at a time. (so eg if you are doing Derby you should forst start in DerbyPlatofrm to override the specific processChange method, or if it needs to be more detailed, the DerbySqlBuilder) - Make a test for you scenario. It is pretty complicated (and less enjoyable) to do that afterwards. Make sure you roundtripping works, so you know you get consistant results. At least that would be my approach. Another mail will follow about the current project status, so probably wait for that discussion to open up... Mvgr, Martin 2013/8/1 Bruno Tavares btav...@thoughtworks.com: Sure! Taking a look on the codebase I understood a bit of the flow. Maybe we can do some changes on the PlatformImplBase#processChange for the AddIndexChange objects to also create the unique constraint on the databases that support contraints. What do you think about that? On Wed, Jul 31, 2013 at 11:13:03PM +0200, Martin van den Bemt wrote: Hi Bruno, Could you give me a couple of more days to get (re) organized with DDLUtils ? Mvgr, Martin 2013/7/30 Bruno Tavares btav...@thoughtworks.com: Hi there everyone, There is an interest to work on something related to the DDLUTILS-85 issue on my current project. I would like to ask if there is any ideas on how you would approach the issue. Also, is there any standards or requirements on the code to submit patches? Cheers, -- Bruno Tavares -- Bruno Tavares Consultant Developer
Re: [DDLUTILS-85] How to tackle the issue?
Hi Bruno, Could you give me a couple of more days to get (re) organized with DDLUtils ? Mvgr, Martin 2013/7/30 Bruno Tavares btav...@thoughtworks.com: Hi there everyone, There is an interest to work on something related to the DDLUTILS-85 issue on my current project. I would like to ask if there is any ideas on how you would approach the issue. Also, is there any standards or requirements on the code to submit patches? Cheers, -- Bruno Tavares
Re: [DDLUTILS-85] How to tackle the issue?
Sure! Taking a look on the codebase I understood a bit of the flow. Maybe we can do some changes on the PlatformImplBase#processChange for the AddIndexChange objects to also create the unique constraint on the databases that support contraints. What do you think about that? On Wed, Jul 31, 2013 at 11:13:03PM +0200, Martin van den Bemt wrote: Hi Bruno, Could you give me a couple of more days to get (re) organized with DDLUtils ? Mvgr, Martin 2013/7/30 Bruno Tavares btav...@thoughtworks.com: Hi there everyone, There is an interest to work on something related to the DDLUTILS-85 issue on my current project. I would like to ask if there is any ideas on how you would approach the issue. Also, is there any standards or requirements on the code to submit patches? Cheers, -- Bruno Tavares -- Bruno Tavares Consultant Developer
