Bug#1017966: lintian: Systematic false positives for source-is-missing in r-cran-* documentation
Am Sun, Sep 18, 2022 at 12:26:20AM +0100 schrieb Colin Watson: > On Tue, Aug 23, 2022 at 08:23:43AM +0200, Andreas Tille wrote: > > lintian is doing a check for overlong lines to guess for included > > JavaScript in html pages (and may be more). I now realised that several > > R packages are including > > > >img src="data:image/png;base64 > > > > images that were generated by the source of the documentation which is > > always shipped with these docs. For example see the documentation of > > r-cran-patchwork[1]. It would be great if lintian would not report > > these false positives since the source is provided by upstream and the > > html file can be re-generated by an automated process. > > I think this may be https://bugs.debian.org/1019980, but I filed that > separately just in case I'm wrong. I do not think that the issue of included data:image/png is the same as included compressed JS. I admit I don't mind much if those lots of false positives in R packages could be avoided. Its just a fact that all html documentation that comes in R packages is accompanied by an Rmd file with the same name. The html file that is rendered with tools that are packaged in Debian and thus could be reproduced might contain data:image/png, compressed JS (that could also be obtained from Debian packaged JS) or simply some lines that are unusually long. It would be great if this could be somehow expressed in lintian to avoid false positives. Kind regards Andreas. -- http://fam-tille.de
Bug#1017966: lintian: Systematic false positives for source-is-missing in r-cran-* documentation
On Tue, Aug 23, 2022 at 08:23:43AM +0200, Andreas Tille wrote: > lintian is doing a check for overlong lines to guess for included > JavaScript in html pages (and may be more). I now realised that several > R packages are including > >img src="data:image/png;base64 > > images that were generated by the source of the documentation which is > always shipped with these docs. For example see the documentation of > r-cran-patchwork[1]. It would be great if lintian would not report > these false positives since the source is provided by upstream and the > html file can be re-generated by an automated process. I think this may be https://bugs.debian.org/1019980, but I filed that separately just in case I'm wrong. -- Colin Watson (he/him) [cjwat...@debian.org]
Bug#1017966: lintian: Systematic false positives for source-is-missing in r-cran-* documentation
Hi,
another remark about the source-is-missing tag in r-* packages: For
r-cran-dplyr I've just added lintian-overrides[1] for other false
positives than embedded png files. The "source-is-missing" tag is
in cases of R documentation not sensible in general since the source
can always be found in the same directory next to the html file in
the according *.Rmd file. May be this tag should be suppressed in
general (even for embedded JS since the doc can be recreated as
in the example of r-bioc-genomicfeatures[2] via
cd inst/doc && Rscript -e "require(knitr); require(markdown);
knit('GenomicFeatures.Rmd', 'GenomicFeatures.md');
markdownToHTML('GenomicFeatures.md', 'GenomicFeatures.html',
options=c('use_xhtml', 'base64_images'));"
It would be great if those false positives from lintian could be
avoided to reduce the amount of manual maintainer interaction.
Kind regards
Andreas.
[1]
https://salsa.debian.org/r-pkg-team/r-cran-dplyr/-/blob/master/debian/source/lintian-overrides
[2]
https://salsa.debian.org/r-pkg-team/r-bioc-genomicfeatures/-/blob/master/debian/rules
--
http://fam-tille.de
Bug#1017966: lintian: Systematic false positives for source-is-missing in r-cran-* documentation
Package: lintian Version: 2.115.2 Severity: normal X-Debbugs-Cc: debia...@lists.debian.org Hi lintian maintainers, lintian is doing a check for overlong lines to guess for included JavaScript in html pages (and may be more). I now realised that several R packages are including img src="data:image/png;base64 images that were generated by the source of the documentation which is always shipped with these docs. For example see the documentation of r-cran-patchwork[1]. It would be great if lintian would not report these false positives since the source is provided by upstream and the html file can be re-generated by an automated process. Kind regards Andreas. [1] https://salsa.debian.org/r-pkg-team/r-cran-patchwork/-/blob/master/inst/doc/patchwork.html#L375 -- System Information: Debian Release: bookworm/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (50, 'buildd-unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 5.18.0-3-amd64 (SMP w/8 CPU threads; PREEMPT) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages lintian depends on: ii binutils2.38.90.20220713-2 ii bzip2 1.0.8-5 ii diffstat1.64-1 ii dpkg1.21.9 ii dpkg-dev1.21.9 ii file1:5.41-4 ii gettext 0.21-8 ii gpg 2.2.35-3 ii intltool-debian 0.35.0+20060710.5 ii iso-codes 4.11.0-1 ii libapt-pkg-perl 0.1.40+b1 ii libarchive-zip-perl 1.68-1 ii libberkeleydb-perl 0.64-1+b2 ii libcapture-tiny-perl0.48-1 ii libclass-xsaccessor-perl1.19-4 ii libclone-perl 0.45-1+b2 ii libconfig-tiny-perl 2.28-1 ii libconst-fast-perl 0.014-2 ii libcpanel-json-xs-perl 4.32-1 ii libdata-dpath-perl 0.58-1 ii libdata-validate-domain-perl0.10-1.1 ii libdata-validate-uri-perl 0.07-2 ii libdevel-size-perl 0.83-2 pn libdigest-sha-perl ii libdpkg-perl1.21.9 ii libemail-address-xs-perl1.05-1 ii libfile-basedir-perl0.09-1 ii libfile-find-rule-perl 0.34-2 ii libfont-ttf-perl1.06-2 ii libhtml-html5-entities-perl 0.004-2 ii libhtml-tokeparser-simple-perl 3.16-4 ii libio-interactive-perl 1.023-1 ii libipc-run3-perl0.048-2 ii libjson-maybexs-perl1.004003-1 ii liblist-compare-perl0.55-1 ii liblist-someutils-perl 0.58-1 ii liblist-utilsby-perl0.12-1 ii libmldbm-perl 2.05-3 ii libmoo-perl 2.005004-3 ii libmoox-aliases-perl0.001006-2 ii libnamespace-clean-perl 0.27-2 ii libpath-tiny-perl 0.122-1 ii libperlio-gzip-perl 0.20-1 ii libperlio-utf8-strict-perl 0.009-1+b1 ii libproc-processtable-perl 0.634-1+b1 ii libregexp-wildcards-perl1.05-3 ii libsereal-decoder-perl 4.025+ds-1 ii libsereal-encoder-perl 4.025+ds-1 ii libsort-versions-perl 1.62-2 ii libsyntax-keyword-try-perl 0.27-1 ii libterm-readkey-perl2.38-2 ii libtext-levenshteinxs-perl 0.03-5 ii libtext-markdown-discount-perl 0.13-1+b1 ii libtext-xslate-perl 3.5.9-1+b1 ii libtime-duration-perl 1.21-1 ii libtime-moment-perl 0.44-2 ii libtimedate-perl2.3300-2 ii libunicode-utf8-perl0.62-1+b3 ii liburi-perl 5.12-1 ii libwww-mechanize-perl 2.14-2 ii libwww-perl 6.67-1 ii libxml-libxml-perl 2.0207+dfsg+really+2.0134-1 ii libyaml-libyaml-perl0.83+ds-1+b1 ii lzip [lzip-decompressor]1.23-4 ii lzop1.04-2 ii man-db 2.10.2-2 ii patchutils 0.4.2-1 ii perl [libencode-perl] 5.34.0-5 ii t1utils 1.41-4 ii unzip 6.0-27 ii xz-utils5.2.5-2.1 lintian recommends no packages. Versions of packages lintian suggests: pn binutils-multiarch ii libtext-template-perl 1.61-1 -- no debconf information
