Bug#1034221: caddy: dh_installsystemd doesn't handle files in /usr/lib/systemd/system
Am 17. April 2023 18:35:02 MESZ schrieb Nilesh Patra : >In your fix, why not use Andreas' suggestion to install it via >"pkg-config --variable=systemdsystemunitdir systemd" ? >You might need to revert your fix again otherwise. That's true, my thinking was that, being in the middle of the freeze, going with the smallest possible change can cause the least issues, but I wrote myself a todo to go with Andreas' suggestion once that's over :)
Bug#1034221: caddy: dh_installsystemd doesn't handle files in /usr/lib/systemd/system
On Mon, Apr 17, 2023 at 03:47:43PM +, Peymaneh wrote: > Am 16.04.23 um 17:37 schrieb Nilesh Patra: > > Can you take care of this? > > thanks for the mail Nilesh, I missed the bugreport. In your fix, why not use Andreas' suggestion to install it via "pkg-config --variable=systemdsystemunitdir systemd" ? You might need to revert your fix again otherwise. > I uploaded a fix just now and will contact the release team for unblocking. I think that won't be needed. Caddy is a non-key package with (hopefully) passing autopkgtest. You'll need to ask release team if full-freeze starts before the next 20 days. -- Best, Nilesh signature.asc Description: PGP signature
Bug#1034221: caddy: dh_installsystemd doesn't handle files in /usr/lib/systemd/system
Hi Am 16.04.23 um 17:37 schrieb Nilesh Patra: Can you take care of this? thanks for the mail Nilesh, I missed the bugreport. I uploaded a fix just now and will contact the release team for unblocking :) OpenPGP_signature Description: OpenPGP digital signature
Bug#1034221: caddy: dh_installsystemd doesn't handle files in /usr/lib/systemd/system
Hi Peymaneh, On Tue, 11 Apr 2023 15:54:02 +0200 Andreas Henriksson wrote: > On Tue, Apr 11, 2023 at 09:37:27AM +0200, bi...@debian.org wrote: > > Package: caddy > > Version: 2.6.2-4 > > Severity: serious > > Tags: sid bookworm > > It seems that your package caddy is shipping files (.service, .socket or > > .timer) in /usr/lib/systemd/system. > [...] > > The culprit seems to be wrong path at: > https://sources.debian.org/src/caddy/2.6.2-4/debian/caddy.install/#L2-L3 > > Please note that if you change it to /lib/systemd/system now, you'll > likely need to reverse that change again in the future. > > Preferably the correct path is derived from the value given by > pkg-config --variable=systemdsystemunitdir systemd Can you take care of this? -- Best, Nilesh signature.asc Description: PGP signature
Bug#1034221: caddy: dh_installsystemd doesn't handle files in /usr/lib/systemd/system
On Tue, Apr 11, 2023 at 09:37:27AM +0200, bi...@debian.org wrote: > Package: caddy > Version: 2.6.2-4 > Severity: serious > Tags: sid bookworm > User: debhel...@packages.debian.org > Usertags: systemd-files-in-usr-bookworm > > Dear Maintainer, > > It seems that your package caddy is shipping files (.service, .socket or > .timer) in /usr/lib/systemd/system. [...] The culprit seems to be wrong path at: https://sources.debian.org/src/caddy/2.6.2-4/debian/caddy.install/#L2-L3 Please note that if you change it to /lib/systemd/system now, you'll likely need to reverse that change again in the future. Preferably the correct path is derived from the value given by pkg-config --variable=systemdsystemunitdir systemd You could use this via making your debian/caddy.install executable and integrating dh-exec. You'll have to decide if you think it's worth it or not. Regards, Andreas Henriksson
