Bug#1061152: asymptote: autopkgtest should test installed package
On Sat, Jul 20, 2024 at 05:44:43PM +0200, Preuße, Hilmar wrote: > On 03.04.2024 12:54, Julian Gilbey wrote: > > Hi Julian > > > If Sven's patch works, you would also be able to drop most of the > > test-time dependencies and depend only on asymptote itself (and maybe > > one or two other packages), as you would not need to build asymptote. > > > > I did for most of them [1]. The most heavy stuff (texlive-*) is pulled in by > asymptote itself. I'll evaluate if these Deps can be downgraded to > Recommends. That all sounds good. I'm not sure if it's worth the effort of downgrading these depends to recommends, even if it's technically possible. Best wishes, Julian
Bug#1061152: asymptote: autopkgtest should test installed package
Hi Hilmar,
On Sat, Jul 20, 2024 at 05:08:57PM +0200, Preuße, Hilmar wrote:
> [...]
> Today I tested again and the test suites run, not sure, what was the fault
> before. Into debian/tests/control I inserted:
That is very good to hear!
> Depends: asymptote (= ${binary:Version}),
>
> That failed b/c the syntax was not understood. When leaving out the version
> specification the test runs fine, but I'm not sure if it is OK to leave out
> the version specification.
Yes, leave out the version: autopkgtest does not preprocess the
control file, and does not have access to dpkg substitution variables.
It will always test the version that the autopkgtest is written for,
as far as I know.
Best wishes,
Julian
Bug#1061152: asymptote: autopkgtest should test installed package
On 03.04.2024 12:54, Julian Gilbey wrote: Hi Julian If Sven's patch works, you would also be able to drop most of the test-time dependencies and depend only on asymptote itself (and maybe one or two other packages), as you would not need to build asymptote. I did for most of them [1]. The most heavy stuff (texlive-*) is pulled in by asymptote itself. I'll evaluate if these Deps can be downgraded to Recommends. Hilmar [1] https://github.com/debian-tex/asymptote/commit/7afaf5386b32778e9334c6912c66a7f8628de356 -- sigfault OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1061152: asymptote: autopkgtest should test installed package
On 03.04.2024 12:54, Julian Gilbey wrote:
Hi Julian,
On Wed, Jan 24, 2024 at 06:07:56PM +0100, Sven Joachim wrote:
[...]
Hello,
Your package's autopkgtest runs the upstream test suite which is
nice. However, it first builds the program and then tests that,
rather than the package from the archive. This is not very useful,
as changes in reverse dependencies could cause breakage at runtime
which might vanish after a rebuild.
[...]
(followed by suggestion of how to fix this)
If Sven's patch works, you would also be able to drop most of the
test-time dependencies and depend only on asymptote itself (and maybe
one or two other packages), as you would not need to build asymptote.
Today I tested again and the test suites run, not sure, what was the
fault before. Into debian/tests/control I inserted:
Depends: asymptote (= ${binary:Version}),
That failed b/c the syntax was not understood. When leaving out the
version specification the test runs fine, but I'm not sure if it is OK
to leave out the version specification.
Hilmar
--
sigfault
OpenPGP_signature.asc
Description: OpenPGP digital signature
Bug#1061152: asymptote: autopkgtest should test installed package
On 03.04.2024 12:54, Julian Gilbey wrote: On Wed, Jan 24, 2024 at 06:07:56PM +0100, Sven Joachim wrote: Hi Julian, nice. However, it first builds the program and then tests that, rather than the package from the archive. This is not very useful, as changes in reverse dependencies could cause breakage at runtime which might vanish after a rebuild. [...] (followed by suggestion of how to fix this) If Sven's patch works, you would also be able to drop most of the test-time dependencies and depend only on asymptote itself (and maybe one or two other packages), as you would not need to build asymptote. Currently it does not, but I did not find the time yet to refine it and get it running. Once this is done I can test if all Deps of the test suite are really needed, I guess a few of them are not surplus, but we'll see. H. -- sigfault OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1061152: asymptote: autopkgtest should test installed package
Hi Hilmar, On Wed, Jan 24, 2024 at 06:07:56PM +0100, Sven Joachim wrote: > [...] > > Hello, > > > >> Your package's autopkgtest runs the upstream test suite which is > >> nice. However, it first builds the program and then tests that, > >> rather than the package from the archive. This is not very useful, > >> as changes in reverse dependencies could cause breakage at runtime > >> which might vanish after a rebuild. [...] (followed by suggestion of how to fix this) If Sven's patch works, you would also be able to drop most of the test-time dependencies and depend only on asymptote itself (and maybe one or two other packages), as you would not need to build asymptote. Best wishes, Julian
Bug#1061152: asymptote: autopkgtest should test installed package
Hi Hilmar, Am 24.01.2024 um 12:42 schrieb Preuße, Hilmar: > On 19.01.2024 17:23, Sven Joachim wrote: > > Hello, > >> Your package's autopkgtest runs the upstream test suite which is >> nice. However, it first builds the program and then tests that, >> rather than the package from the archive. This is not very useful, >> as changes in reverse dependencies could cause breakage at runtime >> which might vanish after a rebuild. >> > > Not sure how to change that. I removed the "build-needed" restriction > from the test suite control file and run the autopkgtest as follows: > > autopkgtest asymptote_2.86+ds1-2_amd64.deb asymptote_2.86+ds1-2.dsc -- > schroot unstable-amd64-sbuild > > The test fails: > > (Reading database ... 52447 files and directories currently installed.) > Removing autopkgtest-satdep (0) ... > autopkgtest [12:35:24]: test test-suite: [--- > make: *** No rule to make target 'test'. Stop. > autopkgtest [12:35:25]: test test-suite: ---] > autopkgtest [12:35:25]: test test-suite: - - - - - - - - - - results > - - - - - - - - - - > test-suite FAIL non-zero exit status 2 > autopkgtest [12:35:25]: summary > test-suite FAIL non-zero exit status 2 > > ...probably b/c the build did not run yet and there is no Makefile. Yes, the Makefile is generated from Makefile.in. > Were you able to run the test suite w/o running a build first? If yes > let me know how. Thanks! I have not tried it, but in the tests/ directory there is a nice Makefile which can be used. It only needs to be persuaded to run the installed asy program rather than the one from the parent directory. Something like the attached patch might work, at least if run the test-suite script under autopkgtest (otherwise you need to create the $AUTOPKGTEST_TMP temporary directory first). Sorry for not having tested the patch - actually I do not use asymptote, only its strange autopkgtest failures like [1] last week motivated me to look at it. Good luck, Sven 1. https://ci.debian.net/packages/a/asymptote/testing/amd64/41886606/ diff --git a/debian/tests/test-suite b/debian/tests/test-suite index cff9edf2..21797e58 100644 --- a/debian/tests/test-suite +++ b/debian/tests/test-suite @@ -2,5 +2,9 @@ set -e +cp -a tests "$AUTOPKGTEST_TMP" +ln -s /usr/share/asymptote "$AUTOPKGTEST_TMP"/base +ln -s /usr/bin/asy "$AUTOPKGTEST_TMP"/asy + export ASYMPTOTE_HOME=$(mktemp -d) -make test \ No newline at end of file +make -C "$AUTOPKGTEST_TMP"/tests all
Bug#1061152: asymptote: autopkgtest should test installed package
On 19.01.2024 17:23, Sven Joachim wrote: Hello, Your package's autopkgtest runs the upstream test suite which is nice. However, it first builds the program and then tests that, rather than the package from the archive. This is not very useful, as changes in reverse dependencies could cause breakage at runtime which might vanish after a rebuild. Not sure how to change that. I removed the "build-needed" restriction from the test suite control file and run the autopkgtest as follows: autopkgtest asymptote_2.86+ds1-2_amd64.deb asymptote_2.86+ds1-2.dsc -- schroot unstable-amd64-sbuild The test fails: (Reading database ... 52447 files and directories currently installed.) Removing autopkgtest-satdep (0) ... autopkgtest [12:35:24]: test test-suite: [--- make: *** No rule to make target 'test'. Stop. autopkgtest [12:35:25]: test test-suite: ---] autopkgtest [12:35:25]: test test-suite: - - - - - - - - - - results - - - - - - - - - - test-suite FAIL non-zero exit status 2 autopkgtest [12:35:25]: summary test-suite FAIL non-zero exit status 2 ...probably b/c the build did not run yet and there is no Makefile. Were you able to run the test suite w/o running a build first? If yes let me know how. Thanks! H. -- sigfault OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1061152: asymptote: autopkgtest should test installed package
Package: asymptote Version: 2.86+ds1-1 Your package's autopkgtest runs the upstream test suite which is nice. However, it first builds the program and then tests that, rather than the package from the archive. This is not very useful, as changes in reverse dependencies could cause breakage at runtime which might vanish after a rebuild. In #1061151 I have requested that the test suite be run at build time. Cheers, Sven
