Bug#1066296: RE: Bug#1066296: xli: FTBFS: dither.c:77:36: error: implicit declaration of function ‘strlen’ [-Werror=implicit-function-declaration]

2024-03-26 Thread Andrius Merkys

Hi Nilson,

On Wed, 13 Mar 2024 17:34:15 + Nilson Silva 
 wrote:

Relevant part (hopefully):
> cc -c -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
-DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 fill.c
> dither.c: In function ‘dither’:
> dither.c:77:36: error: implicit declaration of function ‘strlen’ 
[-Werror=implicit-function-declaration]
>77 | image->title = (char *)lmalloc(strlen(cimage->title) + 12);
>   |^~
> dither.c:28:1: note: include ‘’ or provide a declaration of ‘strlen’
>27 | #include "xli.h"
>   +++ |+#include 
>28 |


Do you need a hand in fixing this? This issue threatens a bunch of my 
packages with autoremoval.


Best wishes,
Andrius



Bug#1066296: xli: FTBFS: dither.c:77:36: error: implicit declaration of function ‘strlen’ [-Werror=implicit-function-declaration]

2024-03-13 Thread Nilson Silva
Hello Lucas!
Thanks!
I will correct


Nilson F. Silva



De: Lucas Nussbaum 
Enviado: quarta-feira, 13 de março de 2024 08:46
Para: sub...@bugs.debian.org 
Assunto: Bug#1066296: xli: FTBFS: dither.c:77:36: error: implicit declaration 
of function ‘strlen’ [-Werror=implicit-function-declaration]

Source: xli
Version: 1.17.0+20061110-8
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 fill.c
> dither.c: In function ‘dither’:
> dither.c:77:36: error: implicit declaration of function ‘strlen’ 
> [-Werror=implicit-function-declaration]
>77 | image->title = (char *)lmalloc(strlen(cimage->title) + 12);
>   |^~
> dither.c:28:1: note: include ‘’ or provide a declaration of ‘strlen’
>27 | #include "xli.h"
>   +++ |+#include 
>28 |
> dither.c:77:36: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>77 | image->title = (char *)lmalloc(strlen(cimage->title) + 12);
>   |^~
> dither.c:77:36: note: include ‘’ or provide a declaration of 
> ‘strlen’
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 g3.c
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 gif.c
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 
> halftone.c
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 
> imagetypes.c
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 img.c
> gif.c: In function ‘gifin_open_file’:
> gif.c:193:7: error: implicit declaration of function ‘strcmp’ 
> [-Werror=implicit-function-declaration]
>   193 |   if (strcmp((char *) buf, GIF_SIG) == 0)
>   |   ^~
> gif.c:21:1: note: include ‘’ or provide a declaration of ‘strcmp’
>20 | #include "imagetypes.h"
>   +++ |+#include 
>21 |
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 mac.c
> cc1: some warnings being treated as errors
> imagetypes.c: In function ‘loadImage’:
> imagetypes.c:66:39: error: implicit declaration of function ‘strlen’ 
> [-Werror=implicit-function-declaration]
>66 | image_ops->fullname = lmalloc(strlen(fullname) + 1);
>   |   ^~
> imagetypes.c:15:1: note: include ‘’ or provide a declaration of 
> ‘strlen’
>14 | #include 
>   +++ |+#include 
>15 |
> imagetypes.c:66:39: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>66 | image_ops->fullname = lmalloc(strlen(fullname) + 1);
>   |   ^~
> imagetypes.c:66:39: note: include ‘’ or provide a declaration of 
> ‘strlen’
> imagetypes.c:67:9: error: implicit declaration of

Bug#1066296: xli: FTBFS: dither.c:77:36: error: implicit declaration of function ‘strlen’ [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: xli
Version: 1.17.0+20061110-8
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 fill.c
> dither.c: In function ‘dither’:
> dither.c:77:36: error: implicit declaration of function ‘strlen’ 
> [-Werror=implicit-function-declaration]
>77 | image->title = (char *)lmalloc(strlen(cimage->title) + 12);
>   |^~
> dither.c:28:1: note: include ‘’ or provide a declaration of ‘strlen’
>27 | #include "xli.h"
>   +++ |+#include 
>28 | 
> dither.c:77:36: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>77 | image->title = (char *)lmalloc(strlen(cimage->title) + 12);
>   |^~
> dither.c:77:36: note: include ‘’ or provide a declaration of 
> ‘strlen’
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 g3.c
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 gif.c
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 
> halftone.c
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 
> imagetypes.c
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 img.c
> gif.c: In function ‘gifin_open_file’:
> gif.c:193:7: error: implicit declaration of function ‘strcmp’ 
> [-Werror=implicit-function-declaration]
>   193 |   if (strcmp((char *) buf, GIF_SIG) == 0)
>   |   ^~
> gif.c:21:1: note: include ‘’ or provide a declaration of ‘strcmp’
>20 | #include "imagetypes.h"
>   +++ |+#include 
>21 | 
> cc -c -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O 
> -DSYSPATHFILE=\"/usr/lib/X11/Xli\"   -Wdate-time -D_FORTIFY_SOURCE=2 mac.c
> cc1: some warnings being treated as errors
> imagetypes.c: In function ‘loadImage’:
> imagetypes.c:66:39: error: implicit declaration of function ‘strlen’ 
> [-Werror=implicit-function-declaration]
>66 | image_ops->fullname = lmalloc(strlen(fullname) + 1);
>   |   ^~
> imagetypes.c:15:1: note: include ‘’ or provide a declaration of 
> ‘strlen’
>14 | #include 
>   +++ |+#include 
>15 | 
> imagetypes.c:66:39: warning: incompatible implicit declaration of built-in 
> function ‘strlen’ [-Wbuiltin-declaration-mismatch]
>66 | image_ops->fullname = lmalloc(strlen(fullname) + 1);
>   |   ^~
> imagetypes.c:66:39: note: include ‘’ or provide a declaration of 
> ‘strlen’
> imagetypes.c:67:9: error: implicit declaration of function ‘strcpy’ 
> [-Werror=implicit-function-declaration]
>67 | strcpy(image_ops->fullname, fullname);
>   | ^~
> imagetypes.c:67:9: note: include ‘’ or provide a declaration of 
> ‘strcpy’
> imagetypes.c:67:9: warning: incompatible implicit declaration of built-in 
> function ‘strcpy’ [-Wbuiltin-declaration-mismatch]
> imagetypes.c:67:9: note: include ‘’ or provide a declaration of 
> ‘strcpy’
> make[2]: *** [Makefile.std:101: dither.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/xli_1.17.0+20061110-8_unstable.log

All bugs filed during this archive rebuild are listed at: