Bug#1066498: dh-make-perl: autopkgtest regression due to time_t transition
On Thu, 14 Mar 2024 18:40:27 +0200, Niko Tyni wrote: > Sure we need to allow for libperl5.XX to stay future-proof. I was just > thinking of hardcoding libperl5.38t64 as the (temporary) other option > rather than using a generic libperl5.XXt64 name. > But no worries :) There were already for variables for getting the perl API version in the script :) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#1066498: dh-make-perl: autopkgtest regression due to time_t transition
On Thu, Mar 14, 2024 at 05:14:17PM +0100, gregor herrmann wrote: > After some thinking, I think I makes to (temporarily) allow both > libperl5.XXt64 and libperl5.XX, otherwise we'll have a mess during > the 5.40 transition. > (After that we can get rid of the option with the suffix again.) Sure we need to allow for libperl5.XX to stay future-proof. I was just thinking of hardcoding libperl5.38t64 as the (temporary) other option rather than using a generic libperl5.XXt64 name. But no worries :) -- Niko
Bug#1066498: dh-make-perl: autopkgtest regression due to time_t transition
On Wed, 13 Mar 2024 23:12:57 +0200, Niko Tyni wrote: > > Reviews welcome; I'm not sure it's the most elegant and safe solution, > > and also if this libperl5.38t64 naming has other effects. > Thanks for fixing this. Thanks for checking. > Didn't dig deeply into what the test is actually doing, but I think it'd > be fine to just hardcode libperl5.38t64 FWIW. After some thinking, I think I makes to (temporarily) allow both libperl5.XXt64 and libperl5.XX, otherwise we'll have a mess during the 5.40 transition. (After that we can get rid of the option with the suffix again.) > But whatever works is good of course. :) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#1066498: dh-make-perl: autopkgtest regression due to time_t transition
On Wed, Mar 13, 2024 at 05:39:49PM +0100, gregor herrmann via pkg-perl-maintainers wrote: > On Wed, 13 Mar 2024 13:34:57 +0100, gregor herrmann wrote: > > > > 80s not ok 5 - Errno is in libperl5.38 or perl-base (or only perl-base > > > for perl < 5.22) > > libperl5.38 or as it's called nowadays: libperl5.38t64, that's the > > point probably … > > Fix committed in git. > > Reviews welcome; I'm not sure it's the most elegant and safe solution, > and also if this libperl5.38t64 naming has other effects. Thanks for fixing this. Didn't dig deeply into what the test is actually doing, but I think it'd be fine to just hardcode libperl5.38t64 FWIW. We can get rid of the suffix with 5.40, and I doubt any other distro will go through this than Ubuntu who we're syncing with anyway (for better or worse). But whatever works is good of course. -- Niko
Bug#1066498: dh-make-perl: autopkgtest regression due to time_t transition
On Wed, 13 Mar 2024 13:34:57 +0100, gregor herrmann wrote: > > 80s not ok 5 - Errno is in libperl5.38 or perl-base (or only perl-base > > for perl < 5.22) > libperl5.38 or as it's called nowadays: libperl5.38t64, that's the > point probably … Fix committed in git. Reviews welcome; I'm not sure it's the most elegant and safe solution, and also if this libperl5.38t64 naming has other effects. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#1066498: dh-make-perl: autopkgtest regression due to time_t transition
On Wed, 13 Mar 2024 11:20:06 -0100, Graham Inggs wrote: > dh-make-perl's autopkgtest regress when tested with perl/5.38.2-3.2 > [1]. I've copied what I hope is the relevant part of the log below. Huh, thanks for the bug report; the autopkgtests still worked a week ago on my laptop, when I did the last upload. > From what I can see on the excuses page for perl [2], dh-make-perl's > autopkgtests are the only ones failing on all architectures, besides > perl's own. Do these test cases need updating to handle the 't64'? Let's have a look: > 80s not ok 5 - Errno is in libperl5.38 or perl-base (or only perl-base > for perl < 5.22) *sigh* libperl5.38 or as it's called nowadays: libperl5.38t64, that's the point probably … Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- BOFH excuse #233: TCP/IP UDP alarm threshold is set too low.
Bug#1066498: dh-make-perl: autopkgtest regression due to time_t transition
Source: dh-make-perl
Version: 0.123
Severity: serious
User: debian...@lists.debian.org
Usertags: regression
Hi Maintainer
dh-make-perl's autopkgtest regress when tested with perl/5.38.2-3.2
[1]. I've copied what I hope is the relevant part of the log below.
>From what I can see on the excuses page for perl [2], dh-make-perl's
autopkgtests are the only ones failing on all architectures, besides
perl's own. Do these test cases need updating to handle the 't64'?
Regards
Graham
[1] https://ci.debian.net/packages/d/dh-make-perl/testing/amd64/
[2] https://qa.debian.org/excuses.php?package=perl
80s t/DpkgLists.t ...
80s 1..7
80s ok 1 - use Debian::DpkgLists;
80s # Perl API is 5.38
80s ok 2 - /usr/bin/perl is in perl-base
80s ok 3 - partial /bin/perl is in perl-base
80s ok 4 - qr{/bin/perl$} is in perl-base
80s not ok 5 - Errno is in libperl5.38 or perl-base (or only perl-base
for perl < 5.22)
80s
80s # Failed test 'Errno is in libperl5.38 or perl-base (or only
perl-base for perl < 5.22)'
80s # at t/DpkgLists.t line 33.
80s # Structures begin differing at:
80s # $got->[0] = 'libperl5.38t64'
80s # $expected->[0] = 'libperl5.38'
80s not ok 6 - IO::Socket::UNIX is in libperl5.38 or perl-base (or
only perl-base for perl < 5.22)
80s
80s # Failed test 'IO::Socket::UNIX is in libperl5.38 or perl-base (or
only perl-base for perl < 5.22)'
80s # at t/DpkgLists.t line 39.
80s # Structures begin differing at:
80s # $got->[0] = 'libperl5.38t64'
80s # $expected->[0] = 'libperl5.38'
80s ok 7 - utf8 is in perl-base or perl-modules-5.38 (or only
perl-base for perl < 5.22)
80s # Looks like you failed 2 tests of 7.
80s Dubious, test returned 2 (wstat 512, 0x200)
80s Failed 2/7 subtests
