Bug#1069247: libconfig-model-dpkg-perl: test failures
Control: reassign 1069247 apt 2.9.0 Control: reassign 1069246 apt 2.9.0 Control: forcemerge 1069247 1069246 Control: retitle 1069247 apt: apt 2.9.0's output breaks libapt-pkg-perl Control: affects 1069247 + libapt-pkg-perl libconfig-model-dpkg-perl dh-make-perl Control: tag 1069247 = sid Control: fixed 1069247 2.9.2 On Mon, 22 Apr 2024 19:44:38 +0200, Julian Andres Klode wrote: > On Mon, Apr 22, 2024 at 07:41:42PM +0200, Dominique Dumont wrote: > > On Sunday, 21 April 2024 18:07:00 CEST Julian Andres Klode wrote: > > > This should be fixed in apt git already, just needs an upload, > > > which is waiting-ish for some more merges > > Given [1], I need to ask... > > Is this a definitive fix or will this feature come back with apt 3.0 ? … > This should be fixed in apt side on 2.9.2 I just uploaded, but > either way it's a weird thing to break because we change progress > messages for interactive output, maybe run with -q instead or don't > pretend to be a tty. I can confirm that the issues in dh-make-perl's and libconfig-model-dpkg-perl's test suites (via libapt-pkg-perl) are gone with apt 2.9.2. Thanks! (Further change requests should probably go to libapt-pkg-perl, if necessary.) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#1069247: libconfig-model-dpkg-perl: test failures
On Mon, Apr 22, 2024 at 07:41:42PM +0200, Dominique Dumont wrote: > On Sunday, 21 April 2024 18:07:00 CEST Julian Andres Klode wrote: > > This should be fixed in apt git already, just needs an upload, > > which is waiting-ish for some more merges > > Given [1], I need to ask... > > Is this a definitive fix or will this feature come back with apt 3.0 ? The feature remains available in output version 3.0 which is what apt(8) is defaulting to right now. apt-get remains at output version 0 at least until 4.0. This should be fixed in apt side on 2.9.2 I just uploaded, but either way it's a weird thing to break because we change progress messages for interactive output, maybe run with -q instead or don't pretend to be a tty. -- debian developer - deb.li/jak | jak-linux.org - free software dev ubuntu core developer i speak de, en
Bug#1069247: libconfig-model-dpkg-perl: test failures
On Sunday, 21 April 2024 18:07:00 CEST Julian Andres Klode wrote: > This should be fixed in apt git already, just needs an upload, > which is waiting-ish for some more merges Given [1], I need to ask... Is this a definitive fix or will this feature come back with apt 3.0 ? All the best [1] https://salsa.debian.org/apt-team/apt/-/commit/fc35b4d7d95b2848db482021df4f4500ac142080
Bug#1069247: libconfig-model-dpkg-perl: test failures
On Sun, Apr 21, 2024 at 04:32:48PM +0300, Niko Tyni wrote: > [Copying Julian as the apt maintainer.] > > On Sat, Apr 20, 2024 at 09:02:35PM +0300, Niko Tyni wrote: > > On Sat, Apr 20, 2024 at 11:09:17AM +0200, Dominique Dumont wrote: > > > On Thursday, 18 April 2024 19:21:55 CEST you wrote: > > > > Source: libconfig-model-dpkg-perl > > > > Version: 3.004 > > > > Severity: serious > > > > Tags: ftbfs > > > > Justification: fails to build from source > > > > > > This really looks like a bug with prove: > > > > > > $ perl t/reorder.t > > > ok 1 - test re-ordered list > > > 1..1 > > > > > I can't see what's wrong with the output of reorder test... > > > > Looks like something is injecting apt progress messages to stdout with > > CR characters hiding it on the terminal but obviously not from `prove`. > > > > $ perl t/reorder.t |od -c > > > 460 f o r m a t i o n . . . 0 % \r > > 500 > > * > > 540 \r o k 1 - t e s t r e > > 560 - o r d e r e d l i s t \n 1 . > > 600 . 1 \n > > These come from apt, via libapt-pkg-perl which I don't think has ever > filtered them away. The thing that broke this is surely output changes > in apt 2.9. > > The crucial difference wrt. at least bookworm seems to be that the > apt messages used to end with a line feed "\n" before the actual TAP > format started. Now it only has a carriage return "\r" there. Apparently > `prove` ignores unknown lines, but now interprets all the apt output to > be part of the first line that ends with the 'ok 1' part. So that gets > ignored as well. > > I see the TAP format spec says at > > https://testanything.org/tap-version-14-specification.html > > A Harness should normalize line endings by replacing any instances of > \r\n or \r in the TAP document with \n. > > so I suppose this might be a normal/wishlist bug in `prove`. In that case, > please note that it needs to be fixed in libtest-harness-perl first as > src:perl just bundles an older version of it. > > Not sure if apt should go back to ending its output with a line > feed. Julian, what do you think? > -- > Niko This should be fixed in apt git already, just needs an upload, which is waiting-ish for some more merges -- debian developer - deb.li/jak | jak-linux.org - free software dev ubuntu core developer i speak de, en
Bug#1069247: libconfig-model-dpkg-perl: test failures
[Copying Julian as the apt maintainer.] On Sat, Apr 20, 2024 at 09:02:35PM +0300, Niko Tyni wrote: > On Sat, Apr 20, 2024 at 11:09:17AM +0200, Dominique Dumont wrote: > > On Thursday, 18 April 2024 19:21:55 CEST you wrote: > > > Source: libconfig-model-dpkg-perl > > > Version: 3.004 > > > Severity: serious > > > Tags: ftbfs > > > Justification: fails to build from source > > > > This really looks like a bug with prove: > > > > $ perl t/reorder.t > > ok 1 - test re-ordered list > > 1..1 > > > I can't see what's wrong with the output of reorder test... > > Looks like something is injecting apt progress messages to stdout with > CR characters hiding it on the terminal but obviously not from `prove`. > > $ perl t/reorder.t |od -c > 460 f o r m a t i o n . . . 0 % \r > 500 > * > 540 \r o k 1 - t e s t r e > 560 - o r d e r e d l i s t \n 1 . > 600 . 1 \n These come from apt, via libapt-pkg-perl which I don't think has ever filtered them away. The thing that broke this is surely output changes in apt 2.9. The crucial difference wrt. at least bookworm seems to be that the apt messages used to end with a line feed "\n" before the actual TAP format started. Now it only has a carriage return "\r" there. Apparently `prove` ignores unknown lines, but now interprets all the apt output to be part of the first line that ends with the 'ok 1' part. So that gets ignored as well. I see the TAP format spec says at https://testanything.org/tap-version-14-specification.html A Harness should normalize line endings by replacing any instances of \r\n or \r in the TAP document with \n. so I suppose this might be a normal/wishlist bug in `prove`. In that case, please note that it needs to be fixed in libtest-harness-perl first as src:perl just bundles an older version of it. Not sure if apt should go back to ending its output with a line feed. Julian, what do you think? -- Niko
Bug#1069247: libconfig-model-dpkg-perl: test failures
On Sat, Apr 20, 2024 at 11:09:17AM +0200, Dominique Dumont wrote: > On Thursday, 18 April 2024 19:21:55 CEST you wrote: > > Source: libconfig-model-dpkg-perl > > Version: 3.004 > > Severity: serious > > Tags: ftbfs > > Justification: fails to build from source > > This really looks like a bug with prove: > > $ perl t/reorder.t > ok 1 - test re-ordered list > 1..1 > I can't see what's wrong with the output of reorder test... Looks like something is injecting apt progress messages to stdout with CR characters hiding it on the terminal but obviously not from `prove`. $ perl t/reorder.t |od -c 000 \r R e a d i n g p a c k a g e 020 l i s t s . . . 0 % \r \r R e 040 a d i n g p a c k a g e l i 060 s t s . . . 1 0 0 % \r 100 120 \r \r B u i l 140 d i n g d e p e n d e n c y 160 t r e e . . . 0 % \r \r B u i l 200 d i n g d e p e n d e n c y 220 t r e e . . . 0 % \r \r B u i l 240 d i n g d e p e n d e n c y 260 t r e e . . . 5 0 % \r \r B u i 300 l d i n g d e p e n d e n c y 320 t r e e . . . 5 0 % \r 340 360 \r \r R 400 e a d i n g s t a t e i n f 420 o r m a t i o n . . . 0 % \r \r 440 R e a d i n g s t a t e i n 460 f o r m a t i o n . . . 0 % \r 500 * 540 \r o k 1 - t e s t r e 560 - o r d e r e d l i s t \n 1 . 600 . 1 \n 603 HTH, -- Niko
Bug#1069247: libconfig-model-dpkg-perl: test failures
On Sat, 20 Apr 2024 11:09:17 +0200, Dominique Dumont wrote: > This really looks like a bug with prove: > > $ perl t/reorder.t > ok 1 - test re-ordered list > 1..1 > $ prove -l -v -p t/reorder.t > t/reorder.t .. > ok 1 - test re-ordered list > 1..1 > Failed 1/1 subtests > > Test Summary Report > --- > t/reorder.t (Wstat: 0 Tests: 0 Failed: 0) > Parse errors: Bad plan. You planned 1 tests but ran 0. > Files=1, Tests=0, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.92 cusr 0.07 > csys = 1.01 CPU) > Result: FAIL Good idea to run this directly with `perl'. > I can't see what's wrong with the output of reorder test... Ack, and same for the failing test in dh-make-perl (#1069246). But I don't see that `prove' has changed recently … So maybe this is in fact even somewhere "deeper"? > I'll try to dig this later on.. Thanks! Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#1069247: libconfig-model-dpkg-perl: test failures
On Thursday, 18 April 2024 19:21:55 CEST you wrote: > Source: libconfig-model-dpkg-perl > Version: 3.004 > Severity: serious > Tags: ftbfs > Justification: fails to build from source This really looks like a bug with prove: $ perl t/reorder.t ok 1 - test re-ordered list 1..1 $ prove -l -v -p t/reorder.t t/reorder.t .. ok 1 - test re-ordered list 1..1 Failed 1/1 subtests Test Summary Report --- t/reorder.t (Wstat: 0 Tests: 0 Failed: 0) Parse errors: Bad plan. You planned 1 tests but ran 0. Files=1, Tests=0, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.92 cusr 0.07 csys = 1.01 CPU) Result: FAIL I can't see what's wrong with the output of reorder test... I'll try to dig this later on.. All the best
Bug#1069247: libconfig-model-dpkg-perl: test failures
Source: libconfig-model-dpkg-perl Version: 3.004 Severity: serious Tags: ftbfs Justification: fails to build from source -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 As seen on https://ci.debian.net/packages/libc/libconfig-model-dpkg-perl/unstable/amd64/45274399/ libconfig-model-dpkg-perl has test failures: 183s Test Summary Report 183s --- 183s t/dependency-check.t (Wstat: 0 Tests: 109 Failed: 0) 183s Parse errors: Tests out of sequence. Found (3) but expected (2) 183s Tests out of sequence. Found (4) but expected (3) 183s Tests out of sequence. Found (5) but expected (4) 183s Tests out of sequence. Found (6) but expected (5) 183s Tests out of sequence. Found (7) but expected (6) 183s Displayed the first 5 of 109 TAP syntax errors. 183s Re-run prove with the -p option to see them all. 183s t/dpkg.t (Wstat: 0 Tests: 50 Failed: 0) 183s Parse errors: Tests out of sequence. Found (3) but expected (2) 183s Tests out of sequence. Found (4) but expected (3) 183s Tests out of sequence. Found (5) but expected (4) 183s Tests out of sequence. Found (6) but expected (5) 183s Tests out of sequence. Found (7) but expected (6) 183s Displayed the first 5 of 50 TAP syntax errors. 183s Re-run prove with the -p option to see them all. 183s t/reorder.t(Wstat: 0 Tests: 0 Failed: 0) 183s Parse errors: Bad plan. You planned 1 tests but ran 0. 183s Files=18, Tests=1786, 106 wallclock secs ( 0.20 usr 0.03 sys + 103.34 cusr 3.44 csys = 107.01 CPU) 183s Result: FAIL This also happens locally for autopkgtest but also for the tests during build. (The version in git has more and unrelated test failure due to the last commit.) We see bascially the same -- the "Tests out of sequence." errors -- also in dh-make-perl, hence I think that there's some underlying problem. Cheers, gregor -BEGIN PGP SIGNATURE- iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmYhVrNfFIAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgYXgQ/+ISS+Mo+83JAstQtZtiX4wWhUQbJDXG4xnQeu5YTj04AF/2WgCaDLzQf9 73iSweb9AJ+epJhQTuUxoo78XghIJkGaD7QiYaTCX1egOCmG72ZKVjIl2Hvr+C1n nqMDVRhKX21TW2tD0dQRQ+WaZYEd+pB5gkfq3hgPyYnIgwB4LubU8F2M7uo1cxf9 J5aD7Fv0fMGmuwPQ5ncflljf8yRSuocRLvMQLlHB0JjcpeFPKGgQ6ZyoKBfGWvZ0 x0qp4Ez2oqIXNNiDTz+8jET7m+bSdE2lL73dlADRjt2wqaQf7O8i2MCuf4krMqwJ owOyjBYzi//0qhOEj7Eh846Fclz4WMpwSO3+pns2du4gvaB6jN5mWK1uQrC4ohAi CSAlWqjXFyZ1kchuYxiejlvVPQrJ9EyAW4yeDzWAnXWCsI3gMAE/TUGUchc0dWyY nVviLMkdRSpgaOp08ITJ1se2yDapHXP/pIFSxeqzCj8L7hflzUPqC0/BsLHYkzQG kvSZxCIBZcB2biWQBVEcexPsHKliPgzu01FUdHb5uTCncxfjEwRiWO3QAKuZ0eca LXFWdyr2YVZH9NMWY2rxVhV9Lrf1ldwBWcTa4BzbBY3HbOrfxStyZ1PMmG8cVlc4 IkjOdMGhBiCyuE5TYqMEZyCsl/+Z3juWsjzt6/GLjwPUv6QgEDw= =1EkQ -END PGP SIGNATURE-
