Bug#397147: About handling of bugs and changelog entries

2006-11-08 Thread Raphael Hertzog
Hello pkg-voip maintainers,

I'm a bit astonished on how the bugs 375141 and 397147 have been handled.
While recompiling the testing version of asterisk I discovered that I lost
ogg support because of the lack of build-depends so I start looking on the
bugs and find out #375141 which reports the problem.

This bug has been closed with this sentence:
- format_ogg_vorbis.so was present in i386, no longer in packages
 (Closes: #375141)

rant
Sorry this is NOT a changelog entry, we don't know why it's fixed and how
you fixed it or if you simply decided that Ogg support was not worth
having.

In the mean time the real bug is still here: i386 is the only arch with
OGG support because it's compiled by the maintainer on a system with
libvorbis-dev installed but the other archs don't have it and any custom
recompilation (like mine) may result in a binary without ogg support.

The bug is reported again with #397147 and this time the submitter was
skilled enough to point out to the real problem and the real fix got
integrated but the changelog entry is still as bad:
   [ Mark Purcell ]
   * asterisk-classic, asterisk-bristuff:
 /usr/lib/asterisk/modules/format_ogg_vorbis.so gone missing when
 rebuilt (Closes: #397147

You describe the problem but a changelog is here to describe the change and
in particular the fix made to correct the problem. This is very important if you
want to have good feedback from users/testers/bug reporters. I need to know
what changed by looking at the changelog so that I can check if the fix is
the one that I expected.
/rant

Please take some more care in the future, and many thanks for your work on
asterisk!

Cheers,
-- 
Raphaël Hertzog

Premier livre français sur Debian GNU/Linux :
http://www.ouaza.com/livre/admin-debian/



Bug#375141: Bug#397147: About handling of bugs and changelog entries

2006-11-08 Thread Mark Purcell
 rant
 Sorry this is NOT a changelog entry, we don't know why it's fixed and how
 you fixed it or if you simply decided that Ogg support was not worth
 having.

Raphael,

Fair call and my fault for those changelog entries.

I think perhaps I have been relying too much on the --closes functionality
of dch and need to put more consideration into the fix, rather than the
symptom.

Ideally something like:

$ dch --closes 397147 'Added Build-Depends: libvorbis-dev'

Would generate a change log entry like:

   * Added Build-Depends: libvorbis-dev
  - Fixes: /usr/lib/asterisk/modules/format_ogg_vorbis.so gone
  missing when rebuilt (Closes: #397147)

This would also be useful for debcommit as well.

One can manually do the above so there isn't an excuse.

As you say, more care is needed in the changelog entries.

Thanks for the feedback.

Mark




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]