Bug#837928: Bug#837925: usrmerge: fails to merge with molly-guard installed

[Simó Albert i Beltran]

I can't reproduce the failure on current fresh sid installation.

I'm trying to reproduce it with the following commands:

apt install molly-guard
apt install libfile-find-rule-perl
apt download usrmerge
dpkg --force-conflicts -i usrmerge_16_all.deb

Could you give me any hint or can I close the bug?

Bug#837928: Bug#837925: usrmerge: fails to merge with molly-guard installed

[Jonas Smedegaard]

Quoting Francois Marier (2016-11-07 18:38:58)
> On 2016-11-02 at 03:02:29, Jonas Smedegaard wrote:
> > I am busy getting that system to production use (yes, stretch is not yet 
> > stable, but more stable than stable on the ARM device I use), but if you 
> > have suggestions for closer inspections that might help shed some light 
> > on this issue, please shoot - fast.
> 
> I reached out to Marco about this bug but have not heard back.
> 
> I don't know how dpkg-diverts are supposed to work in a usrmerge world and I
> can't see anything obviously wrong with the way it's done in molly-guard so
> I don't have any ideas on how to fix this.

I no longer believe this issue is tied to use with the usrmerge package: 
It happens also on freshly installed systems!

It seems that on a usrmerge+systemd system /bin/reboot is a symlink.

Perhaps molly-guard (in its use of dpkg-divert) wrongly assumes that if 
/bin/reboot already exists then it is _installed_ by a package rather 
than added in a package postinst script which seems to be the case with 
systemd (just guessing here, having looked closely at it).

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Bug#837928: Bug#837925: usrmerge: fails to merge with molly-guard installed

[Francois Marier]

On 2016-11-02 at 03:02:29, Jonas Smedegaard wrote:
> I am busy getting that system to production use (yes, stretch is not yet 
> stable, but more stable than stable on the ARM device I use), but if you 
> have suggestions for closer inspections that might help shed some light 
> on this issue, please shoot - fast.

I reached out to Marco about this bug but have not heard back.

I don't know how dpkg-diverts are supposed to work in a usrmerge world and I
can't see anything obviously wrong with the way it's done in molly-guard so
I don't have any ideas on how to fix this.

Francois

-- 
https://fmarier.org/

Bug#837928: Bug#837925: usrmerge: fails to merge with molly-guard installed

[Jonas Smedegaard]

[dropping Marco from cc]

Quoting Jonas Smedegaard (2016-11-02 02:19:42)
> I don't know how it is wrong, just experienced that it failed, and 
> when I looked mollyguard was not registered with dpkg-divert.  I have 
> had molly-guard installed for quite some time, so perhaps that newer 
> behaviour was not applied to existing installs?

Ah - seems this same issue emerges when upgrading a system installed 
from scratch few days ago:

Preparing to unpack .../0-systemd-sysv_231-9_armhf.deb ...
Unpacking systemd-sysv (231-9) over (231-4) ...
dpkg: error processing archive 
/tmp/apt-dpkg-install-CgGd9t/0-systemd-sysv_231-9_armhf.deb (--unpack):
 trying to overwrite '/sbin/halt', which is also in package molly-guard 0.6.4


I am busy getting that system to production use (yes, stretch is not yet 
stable, but more stable than stable on the ARM device I use), but if you 
have suggestions for closer inspections that might help shed some light 
on this issue, please shoot - fast.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature

Bug#837928: Bug#837925: usrmerge: fails to merge with molly-guard installed

[Jonas Smedegaard]

Quoting Francois Marier (2016-11-01 22:14:43)
> On 2016-11-01 at 18:48:51, Jonas Smedegaard wrote:
> > I don't know how to be more exact than how I wrote it initially for 
> > this bugreport.
> > 
> > Could you perhaps elaborate on what details you are missing?
> 
> You wrote this:
> 
> "molly-guard adds wrappers for commands like pm-hibernate and 
> poweroff.
> 
> The wrappers are added not using dpkg-divert but as symlinks in /sbin, 
> where the wrapped commands reside in /usr/sbin."
> 
> But the wrappers _are_ added using dpkg-divert:
> 
> https://anonscm.debian.org/cgit/collab-maint/molly-guard.git/tree/debian/molly-guard.preinst?id=1a3675db6ae1015c4d6e8367c7132c87fb9f3b31#n25
> 
> which looks like this on my machine:
> 
> $ ls -l /sbin/reboot
> lrwxrwxrwx 1 root root 28 Aug 15 22:16 /sbin/reboot -> 
> /lib/molly-guard/molly-guard
> 
> So what's wrong with this use of dpkg-divert?

Thanks for elaborating.

I don't know how it is wrong, just experienced that it failed, and when 
I looked mollyguard was not registered with dpkg-divert.  I have had 
molly-guard installed for quite some time, so perhaps that newer 
behaviour was not applied to existing installs?


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature

Bug#837928: Bug#837925: usrmerge: fails to merge with molly-guard installed

[Francois Marier]

On 2016-11-01 at 18:48:51, Jonas Smedegaard wrote:
> I don't know how to be more exact than how I wrote it initially for this 
> bugreport.
> 
> Could you perhaps elaborate on what details you are missing?

You wrote this:

"molly-guard adds wrappers for commands like pm-hibernate and poweroff.

The wrappers are added not using dpkg-divert but as symlinks in /sbin,
where the wrapped commands reside in /usr/sbin."

But the wrappers _are_ added using dpkg-divert:

https://anonscm.debian.org/cgit/collab-maint/molly-guard.git/tree/debian/molly-guard.preinst?id=1a3675db6ae1015c4d6e8367c7132c87fb9f3b31#n25

which looks like this on my machine:

$ ls -l /sbin/reboot
lrwxrwxrwx 1 root root 28 Aug 15 22:16 /sbin/reboot -> 
/lib/molly-guard/molly-guard

So what's wrong with this use of dpkg-divert?

Francois

-- 
https://fmarier.org/

Bug#837928: Bug#837925: usrmerge: fails to merge with molly-guard installed

[Jonas Smedegaard]

Quoting Francois Marier (2016-11-01 18:11:45)
> On 2016-10-23 at 18:15:15, Marco d'Itri wrote:
> > Control: severity -1 grave
> > 
> > On Sep 15, Marco d'Itri  wrote:
> > 
> > > Looks like molly-guard is still buggy after #660064 and #812535.
> > > Can it be fixed quickly or should I add an unversioned Conflict?
> > Merged /usr is the default since debootstrap 1.0.85, so the package
> > is uninstallable on new systems.
> 
> The pm-utils diverts were commented out in molly-guard 0.6.3:
> 
> https://anonscm.debian.org/cgit/collab-maint/molly-guard.git/commit/?id=1a3675db6ae1015c4d6e8367c7132c87fb9f3b31
> 
> What exactly is broken when molly-guard is used with usrmerge?

I don't know how to be more exact than how I wrote it initially for this 
bugreport.

Could you perhaps elaborate on what details you are missing?

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature

Bug#837928: Bug#837925: usrmerge: fails to merge with molly-guard installed

[Francois Marier]

On 2016-10-23 at 18:15:15, Marco d'Itri wrote:
> Control: severity -1 grave
> 
> On Sep 15, Marco d'Itri  wrote:
> 
> > Looks like molly-guard is still buggy after #660064 and #812535.
> > Can it be fixed quickly or should I add an unversioned Conflict?
> Merged /usr is the default since debootstrap 1.0.85, so the package
> is uninstallable on new systems.

The pm-utils diverts were commented out in molly-guard 0.6.3:

https://anonscm.debian.org/cgit/collab-maint/molly-guard.git/commit/?id=1a3675db6ae1015c4d6e8367c7132c87fb9f3b31

What exactly is broken when molly-guard is used with usrmerge?

Francois

-- 
https://fmarier.org/

Bug#837928: Bug#837925: usrmerge: fails to merge with molly-guard installed

[Marco d'Itri]

Control: severity -1 grave

On Sep 15, Marco d'Itri  wrote:

> Looks like molly-guard is still buggy after #660064 and #812535.
> Can it be fixed quickly or should I add an unversioned Conflict?
Merged /usr is the default since debootstrap 1.0.85, so the package
is uninstallable on new systems.

-- 
ciao,
Marco


signature.asc
Description: PGP signature