Bug#849691: RFS: gnome-shell-extension-radio/1.4-1 [ITP] -- GNOME shell extension for listening to Internet radio streams

[leo]

Hi,

Le 2017-01-01 21:31, Andreas Henriksson a écrit :

Hello Leo,

On Thu, Dec 29, 2016 at 09:22:23PM +0100, l...@ndrs.fr wrote:

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package 
"gnome-shell-extension-radio",

[...]

Thanks for your interest in debian packaging.

[...]

Everything is ready except a few contributors informations missing in
`debian/copyright` but I hope it'll to be fixed soon, see [4].


Please note that not all contributors may be copyright holders.



I'm not really versed in copyright/license things, so I just added each 
contributor as a copyright holder... I'm going to read about it and find 
how to do this properly.



If actual copyright holders are missing from debian/copyright that's
likely a blocking issue though, as your package likely won't pass
through the initial NEW review done by ftp-masters.



Indeed, I knew about this. I just found the email of the two missing 
copyright holders (I'm not sure they're actually, they're contributor) 
and asked them, waiting for an answer.



(You seem to have put work into your debian/copyright and thanks for
doing so. Having copyright and licensing information in order
is great help for getting the package accepted and shipped in
the Debian archive.)



This is my first Debian package, sorry if I'm doing something wrong...


Your package seems mostly fine.



Glad to here it. :)


I'm not sure why you're overriding the build target in your
debian/rules though rather than using override_dh_auto_build:.



It was due to some environment variables set somewhere, when running 
`debuild` the package didn't build. Strange things is that running 
`dpkg-buildpackage` worked. I asked on #debian-mentors but didn't get a 
clear explanation. But, overriding the build target fixed the problem 
with `debuild`. I guess I'm missing something here, will try to see 
what's wrong.



My main issue though is how to build from the VCS you refer us to?


In fact, I used [1] as a template (found it here: [2]) ; I'm not sure 
about what I should provide, how and where...



Please document the procedure for working with your source in
debian/README.source when you use anything non-standard by choice.


Will do.


(Anything that's not building via a pure dpkg-buildpackage or
gbp buildpackage invocation would count in my book as being
non-standard.  Please note that with gbp you can just ship
debian/gbp.conf to make it 'just work'. Having all people who
potentially want to build from source jump through hoops is not a good
recipe for scalability.)



I see. I tried using gbp with no success. Will give it another try.


I have thus not actually tried to build your package.
Given I've not built it I also can not upload it (and this can't
even be considered a complete review of it).



I received a few comments from folks on #debian-mentors, one of them 
tried to build it and spotted a few problems. Thanks for your remarks. 
Should I ping you once I've fixed all those things ?




[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849522
[2] http://213.246.39.125/~leo/packaging/gnome-shell-extension-radio/
[3] 
https://gitlab.com/zapashcanon/gnome-shell-extension-radio-packaging/tree/master/debian

[4] https://github.com/hslbck/gnome-shell-extension-radio/issues/43


Regards,
Andreas Henriksson


[1] 
https://gitlab.com/highvoltage/gnome-shell-extension-dashtodock-packaging/tree/master
[2] 
https://packages.qa.debian.org/g/gnome-shell-extension-dashtodock.html


Cheers,

--

Léo Andrès

Bug#849691: RFS: gnome-shell-extension-radio/1.4-1 [ITP] -- GNOME shell extension for listening to Internet radio streams

[Andreas Henriksson]

Hello Leo,

On Thu, Dec 29, 2016 at 09:22:23PM +0100, l...@ndrs.fr wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "gnome-shell-extension-radio",
[...]

Thanks for your interest in debian packaging.

[...]
> Everything is ready except a few contributors informations missing in
> `debian/copyright` but I hope it'll to be fixed soon, see [4].

Please note that not all contributors may be copyright holders.

If actual copyright holders are missing from debian/copyright that's
likely a blocking issue though, as your package likely won't pass
through the initial NEW review done by ftp-masters.

(You seem to have put work into your debian/copyright and thanks for
doing so. Having copyright and licensing information in order
is great help for getting the package accepted and shipped in
the Debian archive.)

> 
> This is my first Debian package, sorry if I'm doing something wrong...

Your package seems mostly fine.

I'm not sure why you're overriding the build target in your
debian/rules though rather than using override_dh_auto_build:.

My main issue though is how to build from the VCS you refer us to?
Please document the procedure for working with your source in
debian/README.source when you use anything non-standard by choice.
(Anything that's not building via a pure dpkg-buildpackage or 
gbp buildpackage invocation would count in my book as being
non-standard.  Please note that with gbp you can just ship
debian/gbp.conf to make it 'just work'. Having all people who
potentially want to build from source jump through hoops is not a good
recipe for scalability.)

I have thus not actually tried to build your package.
Given I've not built it I also can not upload it (and this can't
even be considered a complete review of it).

> 
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849522
> [2] http://213.246.39.125/~leo/packaging/gnome-shell-extension-radio/
> [3] 
> https://gitlab.com/zapashcanon/gnome-shell-extension-radio-packaging/tree/master/debian
> [4] https://github.com/hslbck/gnome-shell-extension-radio/issues/43

Regards,
Andreas Henriksson

Bug#849691: RFS: gnome-shell-extension-radio/1.4-1 [ITP] -- GNOME shell extension for listening to Internet radio streams

[leo]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "gnome-shell-extension-radio", 
(see ITP [1]) :


* Package name: gnome-shell-extension-radio
  Version : 1.4-1
  Upstream Author : hslbck 
* URL : 
https://github.com/hslbck/gnome-shell-extension-radio

* License : GPL-3+
  Section : gnome

It builds those binary packages:

  gnome-shell-extension-radio - GNOME shell extension for listening to 
Internet radio streams


The source package is available at [2].

Packaging is available at [3].

Everything is ready except a few contributors informations missing in 
`debian/copyright` but I hope it'll to be fixed soon, see [4].


This is my first Debian package, sorry if I'm doing something wrong...

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=849522
[2] http://213.246.39.125/~leo/packaging/gnome-shell-extension-radio/
[3] 
https://gitlab.com/zapashcanon/gnome-shell-extension-radio-packaging/tree/master/debian

[4] https://github.com/hslbck/gnome-shell-extension-radio/issues/43

--

Cheers,

Léo Andrès