Bug#920225: pv: replace ash shell with dash
Hi Andrew! Thanks for take the time to see it. Regards, Juan Picca On Sun, Feb 10, 2019 at 8:03 PM Andrew Wood wrote: > Thanks for this discussion and for the patch. I have no idea why this > script uses ash instead of sh. Digging into its history a little bit I see > that it has been unchanged since December 2003, so who knows what I was > thinking. > > It will use /bin/sh in the next release. > > > On Tue, Jan 22, 2019 at 09:53:16PM -0500, Antoine Beaupre wrote: > > On Tue, Jan 22, 2019 at 09:01:21PM -0300, Juan Picca wrote: > > > Closed as not directly related to debian. > > > Thanks Antoine for your comments and sorry for the noise. > > > > Glad I could be of service. > > > > And no problem at all for the noise, I believe it was a fine patch, it's > > just we don't need it in Debian specifically. I would suggest you > > contact upstream here: > > > > https://www.ivarch.com/personal/contact.shtml > > > > They are usually quite supportive and responsive to patches, bug reports > > and suggestions. Don't expect a response immediately, however, they take > > their time, which is fine. :) > > -- > Andrew Wood >
Bug#920225: pv: replace ash shell with dash
Thanks for this discussion and for the patch. I have no idea why this script uses ash instead of sh. Digging into its history a little bit I see that it has been unchanged since December 2003, so who knows what I was thinking. It will use /bin/sh in the next release. On Tue, Jan 22, 2019 at 09:53:16PM -0500, Antoine Beaupre wrote: > On Tue, Jan 22, 2019 at 09:01:21PM -0300, Juan Picca wrote: > > Closed as not directly related to debian. > > Thanks Antoine for your comments and sorry for the noise. > > Glad I could be of service. > > And no problem at all for the noise, I believe it was a fine patch, it's > just we don't need it in Debian specifically. I would suggest you > contact upstream here: > > https://www.ivarch.com/personal/contact.shtml > > They are usually quite supportive and responsive to patches, bug reports > and suggestions. Don't expect a response immediately, however, they take > their time, which is fine. :) -- Andrew Wood
Bug#920225: pv: replace ash shell with dash
On Tue, Jan 22, 2019 at 09:01:21PM -0300, Juan Picca wrote: > Closed as not directly related to debian. > Thanks Antoine for your comments and sorry for the noise. Glad I could be of service. And no problem at all for the noise, I believe it was a fine patch, it's just we don't need it in Debian specifically. I would suggest you contact upstream here: https://www.ivarch.com/personal/contact.shtml They are usually quite supportive and responsive to patches, bug reports and suggestions. Don't expect a response immediately, however, they take their time, which is fine. :) A. -- It may be roundly asserted that human ingenuity cannot concoct a cipher which human ingenuity cannot resolve. - Edgar Allan Poe signature.asc Description: PGP signature
Bug#920225: pv: replace ash shell with dash
On 2019-01-22 19:56:33, Juan Picca wrote: >> I see. But the script is not shipped with the pv binary package and is >> unlikely to be ever called. At least it isn't called during build, >> unless I'm mistaken... > > You are right in that, but if has sense that somebody (maybe a > developer) execute `make index` i think that this patch equally apply. > If not, please tell me and I close this bug. Well, I don't think we should apply the patch just in the Debian package. We should forward it upstream and see what they think instead... I can do that later or you can do it as well. :) Cheers! A. -- The university must paint itself black, mulatto, worker anddd peasant. If not, people will break down their doors and paint the university the color they like. - Ernesto "Che" Guevara
Bug#920225: pv: replace ash shell with dash
> I see. But the script is not shipped with the pv binary package and is > unlikely to be ever called. At least it isn't called during build, > unless I'm mistaken... You are right in that, but if has sense that somebody (maybe a developer) execute `make index` i think that this patch equally apply. If not, please tell me and I close this bug. Regards, Juan Picca
Bug#920225: pv: replace ash shell with dash
On 2019-01-22 18:42:38, Juan Picca wrote: > Hi Antoine, > Thanks for your fast response. > > The ash shell is not installed by default and the package pv (or its > dependencies) don't depend of it. > Due that, the script can fail if executed. > Also, the ash package was supersedeed by dash and this is one of the > few (less than ten) packages that uses it. I see. But the script is not shipped with the pv binary package and is unlikely to be ever called. At least it isn't called during build, unless I'm mistaken... A. -- Quidquid latine dictum sit, altum sonatur. Whatever is said in Latin sounds profound.
Bug#920225: pv: replace ash shell with dash
Hi Antoine, Thanks for your fast response. The ash shell is not installed by default and the package pv (or its dependencies) don't depend of it. Due that, the script can fail if executed. Also, the ash package was supersedeed by dash and this is one of the few (less than ten) packages that uses it. Regards, Juan Picca On Tue, Jan 22, 2019 at 6:33 PM Antoine Beaupré wrote: > > On 2019-01-22 18:18:00, Juan Picca wrote: > > Package: pv > > Version: 1.6.6-1 > > Severity: wishlist > > Tags: patch > > > > Dear maintainer, > > > > One script in autoconf directory uses the ash shell, which is replaced > > in debian with the dash shell. > > > > Regards, > > Juan Picca > > Description: Replace usage of ash with dash > > Replace usage of ash shell with dash (/bin/sh). > > Author: Juan Picca > > Last-Update: 2019-01-22 > > --- > > --- a/autoconf/scripts/index.sh > > +++ b/autoconf/scripts/index.sh > > @@ -1,4 +1,4 @@ > > -#!/bin/ash > > +#!/bin/sh > > # > > # Script to generate an HTML index of all C code from the current directory > > # downwards (skipping directories ending in ~). The header comment in each > > Hi! > > Thanks for your bug report. > > Could you clarify what problem this patch fixes exactly? > > A. > > -- > L'adversaire d'une vraie liberté est un désir excessif de sécurité. > - Jean de la Fontaine
Bug#920225: pv: replace ash shell with dash
On 2019-01-22 18:18:00, Juan Picca wrote: > Package: pv > Version: 1.6.6-1 > Severity: wishlist > Tags: patch > > Dear maintainer, > > One script in autoconf directory uses the ash shell, which is replaced > in debian with the dash shell. > > Regards, > Juan Picca > Description: Replace usage of ash with dash > Replace usage of ash shell with dash (/bin/sh). > Author: Juan Picca > Last-Update: 2019-01-22 > --- > --- a/autoconf/scripts/index.sh > +++ b/autoconf/scripts/index.sh > @@ -1,4 +1,4 @@ > -#!/bin/ash > +#!/bin/sh > # > # Script to generate an HTML index of all C code from the current directory > # downwards (skipping directories ending in ~). The header comment in each Hi! Thanks for your bug report. Could you clarify what problem this patch fixes exactly? A. -- L'adversaire d'une vraie liberté est un désir excessif de sécurité. - Jean de la Fontaine
Bug#920225: pv: replace ash shell with dash
Package: pv Version: 1.6.6-1 Severity: wishlist Tags: patch Dear maintainer, One script in autoconf directory uses the ash shell, which is replaced in debian with the dash shell. Regards, Juan Picca Description: Replace usage of ash with dash Replace usage of ash shell with dash (/bin/sh). Author: Juan Picca Last-Update: 2019-01-22 --- --- a/autoconf/scripts/index.sh +++ b/autoconf/scripts/index.sh @@ -1,4 +1,4 @@ -#!/bin/ash +#!/bin/sh # # Script to generate an HTML index of all C code from the current directory # downwards (skipping directories ending in ~). The header comment in each
