Bug#1034237: gammu-smsd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-11 Thread Boian Bonev
On Tue, 2023-04-11 at 15:03 +0200, Andreas Henriksson wrote:
> On Tue, Apr 11, 2023 at 09:37:27AM +0200, bi...@debian.org wrote:
...

> > It seems that your package gammu-smsd is shipping files (.service, .socket
> > or
> > .timer) in /usr/lib/systemd/system.
> [...]
> 
> The culprit seems to be here:
> https://sources.debian.org/src/gammu/1.42.0-7/debian/rules/#L32
> 
> ```
> -DSYSTEMD_SERVICES_INSTALL_DIR=/usr/lib/systemd/system \
> ```
> 
> By removing this line you'll let cmake auto-detect the correct path via
> ./cmake/FindSystemD.cmake which uses pkg-config.
> 
> Make sure you also build-dep on the package containing systemd.pc
> (you already seem to have pkg-config itself in build-deps).
> 
> Also note that you need to adjust:
> https://sources.debian.org/src/gammu/1.42.0-7/debian/gammu-smsd.install/#L5

Thanks for this.

My concern is that involves moving files between lib and usr/lib - as far as I
am aware this is a big problem with the current state of usrmerge, isn't it?

There is no systemd.pc, libsystemd.pc contains prefix=/usr - how that is going
to change anything?

I did try to apply the proposed change and cmake breaks in a bad way without
the -DSYSTEMD_SERVICES_INSTALL_DIR; I have kept that and changed the path,
please review my changes on salsa.

--
With best regards,
b.




signature.asc
Description: This is a digitally signed message part


Bug#1034237: gammu-smsd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-11 Thread Andreas Henriksson
On Tue, Apr 11, 2023 at 09:37:27AM +0200, bi...@debian.org wrote:
> Package: gammu-smsd
> Version: 1.42.0-7  
> Severity: serious
> Tags: sid bookworm
> User: debhel...@packages.debian.org
> Usertags: systemd-files-in-usr-bookworm
> 
> Dear Maintainer,
> 
> It seems that your package gammu-smsd is shipping files (.service, .socket or
> .timer) in /usr/lib/systemd/system.
[...]

The culprit seems to be here:
https://sources.debian.org/src/gammu/1.42.0-7/debian/rules/#L32

```
-DSYSTEMD_SERVICES_INSTALL_DIR=/usr/lib/systemd/system \
```

By removing this line you'll let cmake auto-detect the correct path via
./cmake/FindSystemD.cmake which uses pkg-config.

Make sure you also build-dep on the package containing systemd.pc
(you already seem to have pkg-config itself in build-deps).


Also note that you need to adjust:
https://sources.debian.org/src/gammu/1.42.0-7/debian/gammu-smsd.install/#L5

Regards,
Andreas Henriksson



Bug#1034237: gammu-smsd: dh_installsystemd doesn't handle files in /usr/lib/systemd/system

2023-04-11 Thread bigon
Package: gammu-smsd
Version: 1.42.0-7  
Severity: serious
Tags: sid bookworm
User: debhel...@packages.debian.org
Usertags: systemd-files-in-usr-bookworm

Dear Maintainer,

It seems that your package gammu-smsd is shipping files (.service, .socket or
.timer) in /usr/lib/systemd/system.

This is not supported by the version of dh_installsystemd/debhelper currently
in unstable and bookworm (See: #1031695). That means that currently your
service might not be enabled at boot and/or started as expected.

With the freeze currently in effect, debhelper will not be fixed for bookworm.

As a result, could you please move these files to /lib/systemd/system instead
so they are properly detected by debhelper?
As soon as debhelper is supporting (not until bookworm+1 aka Trixie) you will
be able to move them back to the newer location.

Note that bookworm is currently in hard freeze, please limit the changes you
are uploading to the ones fixing RC bugs.  Also note that you might have to
request a freeze exception to the release team.
See: https://release.debian.org/testing/freeze_policy.html

Feel free to contact me if you have any questions.

Kind regards,
Laurent Bigonville

The list of packages has been generated with the following command:
apt-file search -x '^/usr/lib/systemd/system/.*\.(service|timer|socket)$'|cut 
-d: -f1|sort -u