Bug#1063261: xdp-tools: NMU diff for 64-bit time_t transition
We have done the work now to get an out-of-band result from
abi-compliance-checker confirming that this library's ABI is not affected.
On Mon, Feb 05, 2024 at 10:06:28PM +, Steve Langasek wrote:
> Source: xdp-tools
> Version: 1.4.0-1
> Severity: serious
> Tags: patch pending sid trixie
> Justification: library ABI skew on upgrade
> User: debian-...@lists.debian.org
> Usertags: time-t
>
> NOTICE: these changes must not be uploaded to unstable yet!
>
> Dear maintainer,
>
> As part of the 64-bit time_t transition required to support 32-bit
> architectures in 2038 and beyond
> (https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
> xdp-tools as a source package shipping runtime libraries whose ABI
> either is affected by the change in size of time_t, or could not be
> analyzed via abi-compliance-checker (and therefore to be on the safe
> side we assume is affected).
>
> To ensure that inconsistent combinations of libraries with their
> reverse-dependencies are never installed together, it is necessary to
> have a library transition, which is most easily done by renaming the
> runtime library package.
>
> Since turning on 64-bit time_t is being handled centrally through a change
> to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
> important that libraries affected by this ABI change all be uploaded close
> together in time. Therefore I have prepared a 0-day NMU for xdp-tools
> which will initially be uploaded to experimental if possible, then to
> unstable after packages have cleared binary NEW.
>
> Please find the patch for this NMU attached.
>
> If you have any concerns about this patch, please reach out ASAP. Although
> this package will be uploaded to experimental immediately, there will be a
> period of several days before we begin uploads to unstable; so if information
> becomes available that your package should not be included in the transition,
> there is time for us to amend the planned uploads.
>
>
>
> -- System Information:
> Debian Release: trixie/sid
> APT prefers unstable
> APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1,
> 'experimental')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
> Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
> Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)
> diff -Nru xdp-tools-1.4.0/debian/changelog xdp-tools-1.4.0/debian/changelog
> --- xdp-tools-1.4.0/debian/changelog 2023-07-08 15:10:01.0 +
> +++ xdp-tools-1.4.0/debian/changelog 2024-02-05 20:59:22.0 +
> @@ -1,3 +1,10 @@
> +xdp-tools (1.4.0-1.1) experimental; urgency=medium
> +
> + * Non-maintainer upload.
> + * Rename libraries for 64-bit time_t transition.
> +
> + -- Steve Langasek Mon, 05 Feb 2024 20:59:22 +
> +
> xdp-tools (1.4.0-1) unstable; urgency=medium
>
>* Enable ELF metadata stamping
> diff -Nru xdp-tools-1.4.0/debian/control xdp-tools-1.4.0/debian/control
> --- xdp-tools-1.4.0/debian/control2023-07-08 14:55:18.0 +
> +++ xdp-tools-1.4.0/debian/control2024-02-05 20:59:21.0 +
> @@ -18,7 +18,10 @@
> Vcs-Browser: https://salsa.debian.org/debian/xdp-tools
> Vcs-Git: https://salsa.debian.org/debian/xdp-tools.git
>
> -Package: libxdp1
> +Package: libxdp1t64
> +Provides: ${t64:Provides}
> +Replaces: libxdp1
> +Breaks: libxdp1 (<< ${source:Version})
> Section: libs
> Architecture: linux-any
> Multi-Arch: same
> @@ -32,7 +35,7 @@
> Section: libdevel
> Architecture: linux-any
> Multi-Arch: same
> -Depends: libxdp1 (= ${binary:Version}), ${misc:Depends}, libbpf-dev,
> +Depends: libxdp1t64 (= ${binary:Version}), ${misc:Depends}, libbpf-dev,
> Description: library and utilities for use with XDP - development files
> Library for working with the eXpress Data Path facility of the Linux kernel,
> and a collection of utilities and example code that uses the library.
> @@ -41,7 +44,7 @@
>
> Package: xdp-tools
> Architecture: linux-any
> -Depends: libxdp1 (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends},
> +Depends: libxdp1t64 (= ${binary:Version}), ${misc:Depends},
> ${shlibs:Depends},
> Description: library and utilities for use with XDP
> Library for working with the eXpress Data Path facility of the Linux kernel,
> and a collection of utilities and example code that uses the library.
> diff -Nru xdp-tools-1.4.0/debian/libxdp1.install
> xdp-tools-1.4.0/debian/libxdp1.install
> --- xdp-tools-1.4.0/debian/libxdp1.install2023-07-08 14:55:18.0
> +
> +++ xdp-tools-1.4.0/debian/libxdp1.install1970-01-01 00:00:00.0
> +
> @@ -1,2 +0,0 @@
> -usr/lib/*/bpf/
> -usr/lib/*/lib*.so.*
> diff -Nru xdp-tools-1.4.0/debian/libxdp1.lintian-overrides
> xdp-tools-1.4.0/debian/libxdp1.lintian-overrides
> ---
Bug#1063261: xdp-tools: NMU diff for 64-bit time_t transition
Control: close -1 On Mon, 05 Feb 2024 22:06:28 + Steve Langasek wrote: > Source: xdp-tools > Version: 1.4.0-1 > Severity: serious > Tags: patch pending sid trixie > Justification: library ABI skew on upgrade > User: debian-...@lists.debian.org > Usertags: time-t > > NOTICE: these changes must not be uploaded to unstable yet! > > Dear maintainer, > > As part of the 64-bit time_t transition required to support 32-bit > architectures in 2038 and beyond > (https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified > xdp-tools as a source package shipping runtime libraries whose ABI > either is affected by the change in size of time_t, or could not be > analyzed via abi-compliance-checker (and therefore to be on the safe > side we assume is affected). > > To ensure that inconsistent combinations of libraries with their > reverse-dependencies are never installed together, it is necessary to > have a library transition, which is most easily done by renaming the > runtime library package. > > Since turning on 64-bit time_t is being handled centrally through a change > to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is > important that libraries affected by this ABI change all be uploaded close > together in time. Therefore I have prepared a 0-day NMU for xdp- tools > which will initially be uploaded to experimental if possible, then to > unstable after packages have cleared binary NEW. > > Please find the patch for this NMU attached. > > If you have any concerns about this patch, please reach out ASAP. Although > this package will be uploaded to experimental immediately, there will be a > period of several days before we begin uploads to unstable; so if information > becomes available that your package should not be included in the transition, > there is time for us to amend the planned uploads. According to what was reported on IRC, this is a failed analysis rather than detection of an ABI change, and that's the reason the package was marked. But there is no reference of 'time_t' anywhere in the code base, let alone in the public headers, so it seems to me this is a false positive, closing accordingly. -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part
Bug#1063261: xdp-tools: NMU diff for 64-bit time_t transition
Source: xdp-tools
Version: 1.4.0-1
Severity: serious
Tags: patch pending sid trixie
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t
NOTICE: these changes must not be uploaded to unstable yet!
Dear maintainer,
As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
xdp-tools as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).
To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.
Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time. Therefore I have prepared a 0-day NMU for xdp-tools
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.
Please find the patch for this NMU attached.
If you have any concerns about this patch, please reach out ASAP. Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.
-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru xdp-tools-1.4.0/debian/changelog xdp-tools-1.4.0/debian/changelog
--- xdp-tools-1.4.0/debian/changelog2023-07-08 15:10:01.0 +
+++ xdp-tools-1.4.0/debian/changelog2024-02-05 20:59:22.0 +
@@ -1,3 +1,10 @@
+xdp-tools (1.4.0-1.1) experimental; urgency=medium
+
+ * Non-maintainer upload.
+ * Rename libraries for 64-bit time_t transition.
+
+ -- Steve Langasek Mon, 05 Feb 2024 20:59:22 +
+
xdp-tools (1.4.0-1) unstable; urgency=medium
* Enable ELF metadata stamping
diff -Nru xdp-tools-1.4.0/debian/control xdp-tools-1.4.0/debian/control
--- xdp-tools-1.4.0/debian/control 2023-07-08 14:55:18.0 +
+++ xdp-tools-1.4.0/debian/control 2024-02-05 20:59:21.0 +
@@ -18,7 +18,10 @@
Vcs-Browser: https://salsa.debian.org/debian/xdp-tools
Vcs-Git: https://salsa.debian.org/debian/xdp-tools.git
-Package: libxdp1
+Package: libxdp1t64
+Provides: ${t64:Provides}
+Replaces: libxdp1
+Breaks: libxdp1 (<< ${source:Version})
Section: libs
Architecture: linux-any
Multi-Arch: same
@@ -32,7 +35,7 @@
Section: libdevel
Architecture: linux-any
Multi-Arch: same
-Depends: libxdp1 (= ${binary:Version}), ${misc:Depends}, libbpf-dev,
+Depends: libxdp1t64 (= ${binary:Version}), ${misc:Depends}, libbpf-dev,
Description: library and utilities for use with XDP - development files
Library for working with the eXpress Data Path facility of the Linux kernel,
and a collection of utilities and example code that uses the library.
@@ -41,7 +44,7 @@
Package: xdp-tools
Architecture: linux-any
-Depends: libxdp1 (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends},
+Depends: libxdp1t64 (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends},
Description: library and utilities for use with XDP
Library for working with the eXpress Data Path facility of the Linux kernel,
and a collection of utilities and example code that uses the library.
diff -Nru xdp-tools-1.4.0/debian/libxdp1.install
xdp-tools-1.4.0/debian/libxdp1.install
--- xdp-tools-1.4.0/debian/libxdp1.install 2023-07-08 14:55:18.0
+
+++ xdp-tools-1.4.0/debian/libxdp1.install 1970-01-01 00:00:00.0
+
@@ -1,2 +0,0 @@
-usr/lib/*/bpf/
-usr/lib/*/lib*.so.*
diff -Nru xdp-tools-1.4.0/debian/libxdp1.lintian-overrides
xdp-tools-1.4.0/debian/libxdp1.lintian-overrides
--- xdp-tools-1.4.0/debian/libxdp1.lintian-overrides2023-07-08
14:55:18.0 +
+++ xdp-tools-1.4.0/debian/libxdp1.lintian-overrides1970-01-01
00:00:00.0 +
@@ -1,2 +0,0 @@
-# BPF binaries
-libxdp1: binary-from-other-architecture [usr/lib/*/bpf/*.o]
diff -Nru xdp-tools-1.4.0/debian/libxdp1.symbols
xdp-tools-1.4.0/debian/libxdp1.symbols
--- xdp-tools-1.4.0/debian/libxdp1.symbols 2023-07-08 15:10:01.0
+
+++
