Bug#1067141: kcemu: FTBFS with -Werror=implicit-function-declaration
Hello Zixing, On Wed, 2024-04-10 at 17:34 -0600, Zixing Liu wrote: > In Ubuntu, the attached patch was applied to achieve the following: > > * debian/patches/add-missing-includes.patch: Add missing includes. > Closes LP: #2060887. The issue has already been fixed upstream. I am waiting for upstream to make a new release as this would also fix #970666 [1]. Adrian > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970666 -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Bug#1067141: kcemu: FTBFS with -Werror=implicit-function-declaration
Package: kcemu Followup-For: Bug #1067141 User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu noble ubuntu-patch Control: tags -1 patch Dear Maintainer, In Ubuntu, the attached patch was applied to achieve the following: * debian/patches/add-missing-includes.patch: Add missing includes. Closes LP: #2060887. Thanks for considering the patch. -- System Information: Debian Release: bookworm/sid APT prefers jammy-updates APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), (100, 'jammy-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 6.5.0-26-generic (SMP w/10 CPU threads; PREEMPT) Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA:en Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled diff -Nru kcemu-0.5.2+dfsg/debian/control kcemu-0.5.2+dfsg/debian/control --- kcemu-0.5.2+dfsg/debian/control 2024-03-07 22:13:42.0 -0700 +++ kcemu-0.5.2+dfsg/debian/control 2024-04-10 17:17:16.0 -0600 @@ -1,8 +1,7 @@ Source: kcemu Section: contrib/otherosfs Priority: optional -Maintainer: Ubuntu Developers -XSBC-Original-Maintainer: John Paul Adrian Glaubitz +Maintainer: John Paul Adrian Glaubitz Build-Depends: debhelper-compat (= 13), libz80ex-dev, libsdl1.2-dev, libsndfile-dev, libvncserver-dev, libtheora-dev, libgtk2.0-dev, automake, autoconf, libxmu-dev, libncurses5-dev, netpbm, imagemagick, dh-autoreconf Standards-Version: 4.6.1 diff -Nru kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch --- kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch 1969-12-31 17:00:00.0 -0700 +++ kcemu-0.5.2+dfsg/debian/patches/add-missing-includes.patch 2024-04-10 17:17:01.0 -0600 @@ -0,0 +1,18 @@ +Description: Add missing includes +Author: Zixing Liu +Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067141 +Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/kcemu/+bug/2060887 +Forwarded: no +Last-Update: 2024-04-10 +Index: kcemu/src/sys/unix/sys_socket_create.c +=== +--- kcemu.orig/src/sys/unix/sys_socket_create.c kcemu/src/sys/unix/sys_socket_create.c +@@ -23,6 +23,7 @@ + #include + #include + #include ++#include + + #include "kc/config.h" + #include "sys/sysdep.h" diff -Nru kcemu-0.5.2+dfsg/debian/patches/series kcemu-0.5.2+dfsg/debian/patches/series --- kcemu-0.5.2+dfsg/debian/patches/series 1969-12-31 17:00:00.0 -0700 +++ kcemu-0.5.2+dfsg/debian/patches/series 2024-04-10 17:06:09.0 -0600 @@ -0,0 +1 @@ +add-missing-includes.patch
Bug#1067141: kcemu: FTBFS with -Werror=implicit-function-declaration
Package: kcemu Version: 0.5.2+dfsg-1 Followup-For: Bug #1067141 Tags: patch Hi, I just test the patch and it seems it works. -- Regards, -- Bo YU diff -Nru kcemu-0.5.2+dfsg/debian/changelog kcemu-0.5.2+dfsg/debian/changelog --- kcemu-0.5.2+dfsg/debian/changelog 2022-11-30 05:53:48.0 -0500 +++ kcemu-0.5.2+dfsg/debian/changelog 2024-03-19 11:32:12.0 -0400 @@ -1,3 +1,10 @@ +kcemu (0.5.2+dfsg-1.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Fix implicit-function-declaration issue. (Closes: #1067141) + + -- a Tue, 19 Mar 2024 11:32:12 -0400 + kcemu (0.5.2+dfsg-1) unstable; urgency=medium * New upstream release diff -Nru kcemu-0.5.2+dfsg/debian/patches/fix-error-implicit-function-declaration.patch kcemu-0.5.2+dfsg/debian/patches/fix-error-implicit-function-declaration.patch --- kcemu-0.5.2+dfsg/debian/patches/fix-error-implicit-function-declaration.patch 1969-12-31 19:00:00.0 -0500 +++ kcemu-0.5.2+dfsg/debian/patches/fix-error-implicit-function-declaration.patch 2024-03-19 11:32:02.0 -0400 @@ -0,0 +1,28 @@ +Description: fix implicit-function-declaration error +Author: Bo YU +Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067141 +Forwarded: https://github.com/t-paul/kcemu/issues/6 +Last-Update: 2024-03-19 +--- +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ +--- a/src/sys/mingw/sys_socket_create.c b/src/sys/mingw/sys_socket_create.c +@@ -18,6 +18,7 @@ + */ + + #include ++#include + + #include "kc/config.h" + #include "sys/sysdep.h" +--- a/src/sys/unix/sys_socket_create.c b/src/sys/unix/sys_socket_create.c +@@ -23,6 +23,8 @@ + #include + #include + #include ++#include ++ + + #include "kc/config.h" + #include "sys/sysdep.h" diff -Nru kcemu-0.5.2+dfsg/debian/patches/series kcemu-0.5.2+dfsg/debian/patches/series --- kcemu-0.5.2+dfsg/debian/patches/series 1969-12-31 19:00:00.0 -0500 +++ kcemu-0.5.2+dfsg/debian/patches/series 2024-03-19 05:37:35.0 -0400 @@ -0,0 +1 @@ +fix-error-implicit-function-declaration.patch signature.asc Description: PGP signature
Bug#1067141: kcemu: FTBFS with -Werror=implicit-function-declaration
Source: kcemu
Version: 0.5.2+dfsg-1
Severity: serious
Tags: ftbfs sid trixie
Justification: fails to build from source (but built successfully in the past)
Hi,
kcemu FTBFS with -Werror=implicit-function-declaration which was
recently enabled by default in dpkg 1.22.6 to support the 64-bit time_t
transition. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
gcc -DHAVE_CONFIG_H -I. -I../../../include/kc -I../../../include -Wdate-time
-D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration
-ffile-prefix-map=/build/kcemu-0.5.2+dfsg=. -fstack-protector-strong
-fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o
sys_socket_create.o sys_socket_create.c
sys_socket_create.c: In function 'sys_socket_create':
sys_socket_create.c:44:9: error: implicit declaration of function 'perror'
[-Werror=implicit-function-declaration]
44 | perror("setsockopt() failed");
| ^~
cc1: some warnings being treated as errors
make[4]: *** [Makefile:518: sys_socket_create.o] Error 1
Andreas
