Re: maven-debian-helper & module inter-dependencies
On Mon, 18 Dec 2017, Emmanuel Bourg wrote: > Le 18/12/2017 à 16:34, Thorsten Glaser a écrit : > > > Does this sound doable? > > No 'mvn deploy' doesn't work in offline mode. You probably want to use > 'mvn install' instead. Oops, sorry, yes. I need more coffee, obviously. bye, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-235 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Re: maven-debian-helper & module inter-dependencies
Le 18/12/2017 à 16:34, Thorsten Glaser a écrit : > Does this sound doable? No 'mvn deploy' doesn't work in offline mode. You probably want to use 'mvn install' instead. Emmanuel Bourg
Re: maven-debian-helper & module inter-dependencies
On Sat, 16 Dec 2017, Markus Koschany wrote: > Am 16.12.2017 um 15:52 schrieb Sebastiaan Couwenberg: > > But I don't consider build depending on oneself an acceptable solution. I tend to agree here. And this problem pops up every so often. > Ok, then what would you consider an acceptable solution because I don't Fix the Debian maven magic so that: • mvn clean deploy is called during build • the “deploy” part installs to e.g. debian/.m2/repository/ • debian/.m2 being removed during d/rules clean • debian/.m2/repository being used during the build Does this sound doable? bye, //mirabilos -- tarent solutions GmbH Rochusstraße 2-4, D-53123 Bonn • http://www.tarent.de/ Tel: +49 228 54881-393 • Fax: +49 228 54881-235 HRB 5168 (AG Bonn) • USt-ID (VAT): DE122264941 Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Re: maven-debian-helper & module inter-dependencies
On 12/16/2017 06:07 PM, Emmanuel Bourg wrote: > Le 16/12/2017 à 14:03, Sebastiaan Couwenberg a écrit : >> Thanks for the feedback. Unfortunately I still cannot get the build to work. > > I got a look and I committed a fix. This one was a bit tricky, it was > mostly about ignoring jts-core when used as a test dependency. Thanks for those changes. > Do you want to complete the upload? Not really, I want the package to be adopted by people more comfortable maintaining Java packages. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Re: maven-debian-helper & module inter-dependencies
Le 16/12/2017 à 14:03, Sebastiaan Couwenberg a écrit : > Thanks for the feedback. Unfortunately I still cannot get the build to work. I got a look and I committed a fix. This one was a bit tricky, it was mostly about ignoring jts-core when used as a test dependency. Do you want to complete the upload? Emmanuel Bourg
Re: maven-debian-helper & module inter-dependencies
Am 16.12.2017 um 17:00 schrieb Sebastiaan Couwenberg: [...] > That is up to the maintainers of libsejda-java. My concern is with the > jts package. My point is that you could have applied the same lessons learned to jts. signature.asc Description: OpenPGP digital signature
Re: maven-debian-helper & module inter-dependencies
On 12/16/2017 04:39 PM, Markus Koschany wrote: > Am 16.12.2017 um 15:52 schrieb Sebastiaan Couwenberg: >> On 12/16/2017 03:43 PM, Markus Koschany wrote: >>> Am 16.12.2017 um 14:03 schrieb Sebastiaan Couwenberg: >>> [...] Thanks for the feedback. Unfortunately I still cannot get the build to work. I'm giving up on this package, and request the Debian Java Maintainers to take over its maintenance since all reverse dependencies are maintained within the Java team as well. >>> >>> Did you receive my email? I think that would have been the way forward >>> in your case. >> >> I read your mail, as I'm subscribed to this list. >> >> But I don't consider build depending on oneself an acceptable solution. > > Ok, then what would you consider an acceptable solution because I don't > see a better one for libsejda-java? I could also introduce a second > libsejda-java source package and build-depend on that but is this really > better? Also it works is not just some theory. That is up to the maintainers of libsejda-java. My concern is with the jts package. > I would like to point out that it is rather unlikely that someone will > adopt jts. We should either strive to improve our documentation and > tools or reduce the number of packages because the status quo is not > sustainable in the long-run. Then I'll orphan it, and there'll be an unmaintained package in the in the dependency tree for elasticsearch, h2database, spatial4j & spatial4j-0.4. I'd rather remove the jts package from Debian, but it's not appropriate for me to request the removal of its reverse dependencies for which I'm not the maintainer. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 signature.asc Description: OpenPGP digital signature
Re: maven-debian-helper & module inter-dependencies
Am 16.12.2017 um 15:52 schrieb Sebastiaan Couwenberg: > On 12/16/2017 03:43 PM, Markus Koschany wrote: >> Am 16.12.2017 um 14:03 schrieb Sebastiaan Couwenberg: >> [...] >>> Thanks for the feedback. Unfortunately I still cannot get the build to work. >>> >>> I'm giving up on this package, and request the Debian Java Maintainers >>> to take over its maintenance since all reverse dependencies are >>> maintained within the Java team as well. >> >> Did you receive my email? I think that would have been the way forward >> in your case. > > I read your mail, as I'm subscribed to this list. > > But I don't consider build depending on oneself an acceptable solution. > > Kind Regards, > > Bas Ok, then what would you consider an acceptable solution because I don't see a better one for libsejda-java? I could also introduce a second libsejda-java source package and build-depend on that but is this really better? Also it works is not just some theory. I would like to point out that it is rather unlikely that someone will adopt jts. We should either strive to improve our documentation and tools or reduce the number of packages because the status quo is not sustainable in the long-run. Regards, Markus signature.asc Description: OpenPGP digital signature
Re: maven-debian-helper & module inter-dependencies
On 12/16/2017 03:43 PM, Markus Koschany wrote: > Am 16.12.2017 um 14:03 schrieb Sebastiaan Couwenberg: > [...] >> Thanks for the feedback. Unfortunately I still cannot get the build to work. >> >> I'm giving up on this package, and request the Debian Java Maintainers >> to take over its maintenance since all reverse dependencies are >> maintained within the Java team as well. > > Did you receive my email? I think that would have been the way forward > in your case. I read your mail, as I'm subscribed to this list. But I don't consider build depending on oneself an acceptable solution. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 signature.asc Description: OpenPGP digital signature
Re: maven-debian-helper & module inter-dependencies
Am 16.12.2017 um 14:03 schrieb Sebastiaan Couwenberg: [...] > Thanks for the feedback. Unfortunately I still cannot get the build to work. > > I'm giving up on this package, and request the Debian Java Maintainers > to take over its maintenance since all reverse dependencies are > maintained within the Java team as well. > > Kind Regards, > > Bas Did you receive my email? I think that would have been the way forward in your case. https://lists.debian.org/debian-java/2017/12/msg00029.html Markus signature.asc Description: OpenPGP digital signature
Re: maven-debian-helper & module inter-dependencies
On 12/15/2017 02:51 PM, Emmanuel Bourg wrote: > Le 15/12/2017 à 10:53, Sebastiaan Couwenberg a écrit : >> How should maven-debian-helper be used in a package that builds modules >> which depend on other jars in the project? >> >> The case in question is JTS 1.15 [0] which builds, among others, >> jts-core.jar which is required by the jts-io module. While building the >> latter the jts-core that was built earlier in the process cannot be >> found (see attached build log). >> >> Should it be sufficient to have the correct maven.rules to have other >> artefacts of the project be usable in the build? Or is a local >> repository perhaps required to make these available later in the build? > > Usually it just works, but there are some corner cases. We have several > multi modules projects already packaged that you can use as examples > (maven, javamail, activemq, jetty9, antlr4, wagon...). Sometimes when > the packaging type is 'bundle' instead of 'jar' it's necessary to either > patch the pom dependencies and specify explicitly the 'bundle' type, or > patch the poms and change the type to 'jar'. Also some builds expect the > artifacts of the other modules to be installed in the local repository > (because they do obscure manipulations like injecting source files from > another module into the current one), so in this case you have to > override dh_auto_build and call the Maven 'install' phase (instead of > 'package' by default). Thanks for the feedback. Unfortunately I still cannot get the build to work. I'm giving up on this package, and request the Debian Java Maintainers to take over its maintenance since all reverse dependencies are maintained within the Java team as well. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Re: maven-debian-helper & module inter-dependencies
Hi Sebastiaan, Le 15/12/2017 à 10:53, Sebastiaan Couwenberg a écrit : > How should maven-debian-helper be used in a package that builds modules > which depend on other jars in the project? > > The case in question is JTS 1.15 [0] which builds, among others, > jts-core.jar which is required by the jts-io module. While building the > latter the jts-core that was built earlier in the process cannot be > found (see attached build log). > > Should it be sufficient to have the correct maven.rules to have other > artefacts of the project be usable in the build? Or is a local > repository perhaps required to make these available later in the build? Usually it just works, but there are some corner cases. We have several multi modules projects already packaged that you can use as examples (maven, javamail, activemq, jetty9, antlr4, wagon...). Sometimes when the packaging type is 'bundle' instead of 'jar' it's necessary to either patch the pom dependencies and specify explicitly the 'bundle' type, or patch the poms and change the type to 'jar'. Also some builds expect the artifacts of the other modules to be installed in the local repository (because they do obscure manipulations like injecting source files from another module into the current one), so in this case you have to override dh_auto_build and call the Maven 'install' phase (instead of 'package' by default). Emmanuel Bourg
Re: maven-debian-helper & module inter-dependencies
Am 15.12.2017 um 10:53 schrieb Sebastiaan Couwenberg:
> How should maven-debian-helper be used in a package that builds modules
> which depend on other jars in the project?
>
> The case in question is JTS 1.15 [0] which builds, among others,
> jts-core.jar which is required by the jts-io module. While building the
> latter the jts-core that was built earlier in the process cannot be
> found (see attached build log).
>
> Should it be sufficient to have the correct maven.rules to have other
> artefacts of the project be usable in the build? Or is a local
> repository perhaps required to make these available later in the build?
>
> [0] https://anonscm.debian.org/cgit/pkg-grass/jts.git/log/?h=experimental
>
> Kind Regards,
>
> Bas
You can change the build directory to
${user.dir}/lib for example and then use a local
systemPath for your artifact that depends on another module in the same
project. Check out libsejda-java 2.10.4-1 for further hints. That makes
your package mostly unusable though (paths pointing to local
directories), so you have to make sure in your second upload to
build-depend on jts itself and to remove the patch again.
https://anonscm.debian.org/git/pkg-java/libsejda-java.git/tree/debian/patches/use-local-jars.patch?h=debian/2.10.4-1
Regards,
Markus
signature.asc
Description: OpenPGP digital signature
