Re: RFS: irmp3 -- mp3 Jukebox (LIRC support)
Hello! i have now overworked the package again, fixed the outstanding mistakes in the manpages, debian/rules and debian/control. The package should now really be okey. Here again the informations for the package: Description: A Multimedia Audio Jukebox application. With irmp3 you can control mpg321 (currently, other players are planned) to play songs, lists, and lists of play lists. irmp3 features 'environments' that you can set to play a certain type of music, alarms, can be controlled over the network, via remote control (requires LIRC) and a number of other useful features, including LCD display and keypad input support via LCDProc. It is most useful for those building MP3 jukeboxes with remote or keypad controls. Homepage: http://irmp3.sourceforge.net ITA: #327776 License: GPL Packages: http://server01.marioiseli.com/~mario/dpkgs/irmp3/ I would be very happy if someone is interested in sponsoring my package, because i've already received some mails from interested people asking where to download my package. I have also made an entry on sponsors.debian.net some time ago. Regards Mario Iseli -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: irmp3 -- mp3 Jukebox (LIRC support)
Erik Schanze wrote: Why should the config.* files included into the diff? Depends on how one like to maintain a package. I for myself prefere to have it in the diff.gz, otherwise it is left debian-specific and non-debian users cannot profit from. At the end of the day, it is just a matter of taste... Aren't autotools-dev available on ports you mention? Yes, of course. -- Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist Email: [EMAIL PROTECTED] Internet: http://people.panthera-systems.net/~daniel-baumann/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: irmp3 -- mp3 Jukebox (LIRC support)
Hi Mario, please send your answers on my list mails back to the list, so others can also help or could correct me, if I'm wrong. Mario Iseli Mario Iseli [EMAIL PROTECTED]: On Sun, 2005-11-06 at 16:42 +0100, Erik Schanze wrote: Perhaps you should mention, that irmp3 was recently removed from archive because it was unmaintained for a long time[1]. If irmp3 enters archive again, you have to deal with some old bugs[2], some of them were RC bugs. Yes, i saw it. To the bugs: I had a look at it and had contact with the upstream - it is no problem anymore, everything is solved. Every single bug is solved? Great. So you could add a note to changelog that state this and Closes: all bugs. This seems silly, because they are already closed, but leave IMO a good closing report on archived bugs. Anyway let me do some remarks on your package: debian/control: - You Build-Depend on autotools-dev, but your diff.gz contains config.guess.diff and config.sub.diff. It's better to backup the original files before configure and link to /usr/share/misc/config.* then restore it on clean. So you will get a smaller diff.gz. (same applied to irmp3-ncurses) Why do you mean? A friend of me (an expierienced maintainer) told me that this is okey. He had already a look on my package. Your way will not fail, but could be improved. The advantage of Build-Depends on autotools-dev is to have the newest config.* stuff available. There is no need to include the new config.* files into diff. If you do so, you don't need to Build-Depend on autotools-dev, but your diff grows. Yours is actually 29208 byte. If you use a target before configure to backup original config.* files (if were are any) and link to the autotools-dev ones, and commands in clean to remove the links and restore original config.* files. See the rules file on http://www.erikschanze.de/debian/rules (Don't forget to remove the created links by your rules file in upstream dir, if you test it.) The resulting diff.gz will be 7694 Byte. :-) debian/patches/01-manpages.dpatch: - you change Jérémy to Jeremy, perhaps he will be unhappy about it. Please see groff_char(7) for better substitution. In the original it is Jérémy, yes. But lintian is not happy with it and i had to change it! Did you read groff_char(7)? How about \['e]? I changed manpage.dpatch, see: http://www.erikschanze.de/debian/01-manpages.dpatch I also removed mail address from .TH line in irmp3d.7 because it is too long and overwrites version number in manpage footer. The updated can be found on the old location: http://server01.marioiseli.com/~mario/dpkgs/irmp3/ I had a look at it. debian/rules: - you gives the configure call a CFLAG with -O2, but configure.in defines -O3, so gcc is called with -O2 -O3 Because -Wall is also set, you should remove your CFLAG variable debian/control: - add a empty line (space and dot) between description and Homepage:. debian/docs: - NEWS file is quite seemless, remove it debian/copyright: - Copyright Holder(s) - Copyright Holders manpages: - You should rephrase irmp3conf.1. (e.g. option -f is very unclear to me, too many defaults ;-).) - irmp3.conf.5: mouse_move_[left|right|up|downe] must be: mouse_move_[left|right|up|down] - irmp3.conf.5, irmp3d.8: SEE ALSO: irmp3d_commands(1) This manpage doesn't exist. The other manpages should also checked for technical errors and for wording, they sounds pretty strange sometimes. Because I'm not a DD (yet), I'm unfortunately not able to sponsor yur packages, but hope my comments help you. Kindly regards, Erik -- www.ErikSchanze.de * Bitte keine HTML-E-Mails! No HTML mails, please! Limit: 100 kB * COMTEC in Dresden, 09. - 11. November 2005 * Info: http://www.messe-comtec.de/ * pgpGAMqEckrbq.pgp Description: PGP signature
Re: RFS: irmp3 -- mp3 Jukebox (LIRC support)
Erik Schanze wrote:
Your way will not fail, but could be improved.
The advantage of Build-Depends on autotools-dev is to have the newest
config.* stuff available. There is no need to include the new config.*
files into diff. If you do so, you don't need to Build-Depend on
autotools-dev, but your diff grows.
Well, I beg to differ. Its important to have current config.{sub,guess}
to ensure, that the package builds on the latest debian ports (e.g.
kfreebsd), and sometimes.. if the files are really outdated, its even
essential to be buildable on !i386.
Second, to build-depend on autotools-dev and importing them via the
clean-target into the diff.gz. is the usual way to handle this.
--
Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: [EMAIL PROTECTED]
Internet: http://people.panthera-systems.net/~daniel-baumann/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: irmp3 -- mp3 Jukebox (LIRC support)
Hi Daniel,
Daniel Baumann [EMAIL PROTECTED]:
Erik Schanze wrote:
Your way will not fail, but could be improved.
The advantage of Build-Depends on autotools-dev is to have the
newest config.* stuff available. There is no need to include the
new config.* files into diff. If you do so, you don't need to
Build-Depend on autotools-dev, but your diff grows.
Well, I beg to differ. Its important to have current
config.{sub,guess} to ensure, that the package builds on the latest
debian ports (e.g. kfreebsd), and sometimes.. if the files are really
outdated, its even essential to be buildable on !i386.
Yes, it's important to have the latest config.* files at build time, but
isn't the autotools-dev depends responsible for it, that they are
available under /usr/share/misc/ at buildtime?
Then we link to it and have it. The original ones are out of interest.
(Should be moved aside.)
Why should the config.* files included into the diff?
Aren't autotools-dev available on ports you mention?
Second, to build-depend on autotools-dev and importing them via the
clean-target into the diff.gz. is the usual way to handle this.
And the diff grows with the same content in every (related) package.
Sounds not like a good solution for me.
Wondering,
Erik
--
www.ErikSchanze.de *
Bitte keine HTML-E-Mails! No HTML mails, please! Limit: 100 kB *
COMTEC in Dresden, 09. - 11. November 2005 *
Info: http://www.messe-comtec.de/ *
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: irmp3 -- mp3 Jukebox (LIRC support)
On Wed, Nov 09, 2005 at 11:30:23PM +0100, Erik Schanze wrote:
Hi Daniel,
Daniel Baumann [EMAIL PROTECTED]:
Erik Schanze wrote:
Your way will not fail, but could be improved.
The advantage of Build-Depends on autotools-dev is to have the
newest config.* stuff available. There is no need to include the
new config.* files into diff. If you do so, you don't need to
Build-Depend on autotools-dev, but your diff grows.
Well, I beg to differ. Its important to have current
config.{sub,guess} to ensure, that the package builds on the latest
debian ports (e.g. kfreebsd), and sometimes.. if the files are really
outdated, its even essential to be buildable on !i386.
Yes, it's important to have the latest config.* files at build time, but
isn't the autotools-dev depends responsible for it, that they are
available under /usr/share/misc/ at buildtime?
Then we link to it and have it. The original ones are out of interest.
(Should be moved aside.)
Why should the config.* files included into the diff?
Aren't autotools-dev available on ports you mention?
I think the idea is that then the .diff defines the entire state of
the package as it existed when the maintainer created the .deb for his
architecture.
--
Clear skies,
Justin
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: irmp3 -- mp3 Jukebox (LIRC support)
Hi Mario! Mario Iseli Mario Iseli [EMAIL PROTECTED]: License: GPL Description: mp3 Jukebox (LIRC support) With irmp3 you can build a mp3-database and control the playback via remote control (over LIRC). There are a lot of settings to change and your jukebox is like you want it. Location: http://server01.marioiseli.com/~mario/dpkgs/irmp3/ Perhaps you should mention, that irmp3 was recently removed from archive because it was unmaintained for a long time[1]. If irmp3 enters archive again, you have to deal with some old bugs[2], some of them were RC bugs. Have you tried to reproduce and fix some of them? Which of them were fixed by new upstream version? Although the bugs are now closed because irmp3s removing, you should reopen it after a new upload or add proper bug fixing messages, if one should stay closed. Anyway let me do some remarks on your package: debian/control: - If you Build-Depends on mpg123, your package have to go into contrib. Please read README.Debian of irmp3_0.4.3pre6-3. Is it no longer possible to use mpg321 instead? - You Build-Depend on autotools-dev, but your diff.gz contains config.guess.diff and config.sub.diff. It's better to backup the original files before configure and link to /usr/share/misc/config.* then restore it on clean. So you will get a smaller diff.gz. (same applied to irmp3-ncurses) - Your Build-Depends line misses lirc. You will get without it installed: configure: WARNING: LIRC client library not found - disabling mod_lirc. (mod_lirc sounds important for your package, or isn't it?) - You could add libmagic-dev to Build-Depends for including mod_magic - Description should IMO firstly mention, that it is a audio player and list additional features then. The old description were a good base for write a new one. - Add Homepage: line to description (same applied to irmp3-ncurses) debian/copyright: - You should list all authors with years as copyright holders or point to a copy of AUTHORS file in /usr/share/doc/irmp3. debian/changelog: - You should list _all_ changes since previous version here. (Yes, there are many in your case.) + introduced dpatch support incl. the patches + no dirs, new docs file, no README.Debian + many changes on files in debian/ + and any other changes debian/patches/01-manpages.dpatch: - you change Jérémy to Jeremy, perhaps he will be unhappy about it. Please see groff_char(7) for better substitution. debian/rules: - dh_link is not needed (same applied to irmp3-ncurses) [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=327629 [2] http://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=irmp3 Kindly regards, Erik -- www.ErikSchanze.de * Bitte keine HTML-E-Mails! No HTML mails, please! Limit: 100 kB * COMTEC in Dresden, 09. - 11. November 2005 * Info: http://www.messe-comtec.de/ * pgpUa2MZ7ayHF.pgp Description: PGP signature
