Bug#1069704: bookworm-pu: package xscreensaver/6.06+dfsg1-3+deb12u1

2024-04-23 Thread Jonathan Wiltshire
On Tue, Apr 23, 2024 at 08:29:06PM +0200, Tormod Volden wrote:
> On Tue, Apr 23, 2024 at 7:05 PM Jonathan Wiltshire wrote:
> >
> > Thanks for the upload. Once built I intend to release it through the
> > stable-updates mechanism, but the announcement will carry your name. Any
> > comments on the following text?
> >
> > | The XScreenSaver package as released in Debian 12 includes an "out-of-date
> > | software warning", which is displayed prior to each unlock operation.
> > | This update disables such warnings.
> > |
> > | Users can rest assured that XScreenSaver remains supported by Debian
> > | for the lifetime of the stable distribution.
> >
> 
> Thanks a lot for processing this update. Your suggested text is very
> well formulated, I have nothing to add.

Amusingly it turns out our template example is the last xscreensaver
update, so I've just used that. It says the same things anyway.

Should be published tonight or tomorrow.

-- 
Jonathan Wiltshire  j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51
ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1



Bug#1069704: bookworm-pu: package xscreensaver/6.06+dfsg1-3+deb12u1

2024-04-23 Thread Tormod Volden
On Tue, Apr 23, 2024 at 9:51 AM Jonathan Wiltshire wrote:
> Urgh, I thought this was long since dealt with. Please go ahead urgently.
>
> I presume you've taken steps to avoid it creeping back into future
> releases?

It requires a thorough review of the code (and testing) at every
upstream release (and in particular for the ones that ends up in our
stable), for as long as we want to keep shipping this package.
Sometimes it changes location and form, and extent, therefore this one
was missed. We are getting better at it though. And I'll try to handle
it in a more timely manner if it happens again.

I will also try to get the latest upstream version into backports, so
it will be easier for users to install the version that upstream so
dearly wants everybody to use.

Tormod



Bug#1069704: bookworm-pu: package xscreensaver/6.06+dfsg1-3+deb12u1

2024-04-23 Thread Tormod Volden
On Tue, Apr 23, 2024 at 7:05 PM Jonathan Wiltshire wrote:
>
> Thanks for the upload. Once built I intend to release it through the
> stable-updates mechanism, but the announcement will carry your name. Any
> comments on the following text?
>
> | The XScreenSaver package as released in Debian 12 includes an "out-of-date
> | software warning", which is displayed prior to each unlock operation.
> | This update disables such warnings.
> |
> | Users can rest assured that XScreenSaver remains supported by Debian
> | for the lifetime of the stable distribution.
>

Thanks a lot for processing this update. Your suggested text is very
well formulated, I have nothing to add.

Best regards,
Tormod



Bug#1069704: bookworm-pu: package xscreensaver/6.06+dfsg1-3+deb12u1

2024-04-23 Thread Jonathan Wiltshire
Thanks for the upload. Once built I intend to release it through the
stable-updates mechanism, but the announcement will carry your name. Any
comments on the following text?

| The XScreenSaver package as released in Debian 12 includes an "out-of-date
| software warning", which is displayed prior to each unlock operation.
| This update disables such warnings.
|
| Users can rest assured that XScreenSaver remains supported by Debian
| for the lifetime of the stable distribution.

Thanks,

-- 
Jonathan Wiltshire  j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51
ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1



Processed: Re: Bug#1069704: bookworm-pu: package xscreensaver/6.06+dfsg1-3+deb12u1

2024-04-23 Thread Debian Bug Tracking System
Processing control commands:

> tag -1 confirmed
Bug #1069704 [release.debian.org] bookworm-pu: package 
xscreensaver/6.06+dfsg1-3+deb12u1
Added tag(s) confirmed.

-- 
1069704: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1069704
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#1069704: bookworm-pu: package xscreensaver/6.06+dfsg1-3+deb12u1

2024-04-23 Thread Jonathan Wiltshire
Control: tag -1 confirmed

On Tue, Apr 23, 2024 at 08:37:21AM +0200, Tormod Volden wrote:
> Bug #1069617: xscreensaver 6.06 shows upstream upgrade warning from 2024-05-04

Urgh, I thought this was long since dealt with. Please go ahead urgently.

I presume you've taken steps to avoid it creeping back into future
releases?

Thanks,

-- 
Jonathan Wiltshire  j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51
ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1



Bug#1069704: bookworm-pu: package xscreensaver/6.06+dfsg1-3+deb12u1

2024-04-23 Thread Tormod Volden
Package: release.debian.org
Control: affects -1 + src:xscreensaver
User: release.debian@packages.debian.org
Usertags: pu
Tags: bookworm
Severity: normal

Bug #1069617: xscreensaver 6.06 shows upstream upgrade warning from 2024-05-04

(https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1069617)

[ Reason ]
The xscreensaver code has a mechanism to display upgrade warnings when
it is 17 months past its upstream release date. The 6.06 release that
currently is in Debian stable (bookworm) was released 2022-12-11 and
the warning will start appear 2024-05-04.

Since Debian backports bug and security fixes to older versions of
software as needed, it should not be necessary for the user to upgrade
XScreenSaver manually. The warning can therefore be removed.

We had the same situation in jessie some years ago, with a similar
patch, please see pu request
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=820945, where it
went straight into jessie-updates.

[ Impact ]
If the update isn't approved, the upstream upgrade warning will appear
to the user (from May 4th), for many users causing high blood pressure
and an urge to yell at upstream and package maintainers, for other
users causing considerable confusion because they expect all necessary
updates to be taken care of by normal package update flows.

[ Tests ]
The patch has been used in unstable since February (2024-02-21),
slightly refreshed to apply against the newer upstream 6.08. The
original patch was first applied in Ubuntu 6.06+dfsg1-3ubuntu1 so it
has been tested there as well.

[ Risks ]
The fix is minimal, just commenting out the date check for the upgrade warning.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
Comment out the date check for the upgrade warning, thus disabling the warning.

[ Other info ]
Since the patch is trivial, I recommend this for stable-updates
directly, so that users can avoid the annoyance of the upgrade
warning. As can be seen in the jessie package bug report
(https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=819703) it quickly
became a sh*t storm.

Regards,
Tormod


xscreensaver_6.06+dfsg1-3+deb12u1.debdiff
Description: Binary data