Bug#575850: RFS: libspring-webflow-2.0-java
Hi Miguel, Le jeudi 01 avril 2010 02:09:47, Miguel Landaeta a écrit : I uploaded a new version to mentors and pushed the changes to the git repo. Let me know if more changes are needed. Cheers, - URL: http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java/li bspring-webflow-2.0-java_2.0.8.RELEASE-1.dsc - Vcs-Git: git://git.debian.org/pkg-java/libspring-webflow-2.0-java.git I've uploaded your last mentors upload as is. Remember to tag this release in your Git VCS. Cheers, -- Damien - Debian Developper http://wiki.debian.org/DamienRaudeMorvan signature.asc Description: This is a digitally signed message part.
Bug#575850: RFS: libspring-webflow-2.0-java
On Tue, Apr 6, 2010 at 1:02 PM, Damien Raude-Morvan draz...@debian.org wrote: I've uploaded your last mentors upload as is. Remember to tag this release in your Git VCS. Thank you very much for uploading this package. Cheers, -- Miguel Landaeta, miguel at miguel.cc secure email with PGP 0x7D8967E9 available at http://keyserver.pgp.com/ Faith means not wanting to know what is true. -- Nietzsche -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/o2r86aeadee1004061050g32166619p5d3cee527f...@mail.gmail.com
Bug#575850: RFS: libspring-webflow-2.0-java
Hi Miguel, Here we go for libspring-webflow-2.0-java review : - debian/patches/02_fix_compilation.diff You should try to forward your patch upstream (maybe they'll be please to deliver you a parser compliant with OGNL version in debian) - debian/README.Debian-source Should be renamed to debian/README.source (as per Debian Policy § 4.14) - debian/control: * libspring-js-2.0-java short description seems a bit too generic Javascript abstraction framework. What about server-side Javascript abstraction framework ? * libspring-webflow-2.0-java: junit seems removable libhibernate3-java is twice + should be Recommends ... - projects/spring-js/src/main/resources/META-INF/dojo/ Seems already available inside libjs-dojo-core package 1) you can of course ship it inside original tarball (after all it's DFSG- compliant) 2) you should try to use existing JS and don't embedded it in JAR file. I don't exactly know how Spring.js can handle this :/ As a general guideline, we should try to avoid embedded code copies. Same apply for META-INF/dijix/ (in libjs-dojo-dijix package) - notice.txt (install) There is no need to install this file as we already ship it in source form (orig tarball) and copyright notice are provided by copyright file in each binary package (compliant with Apache License 2.0 §4d) - readme.txt Debhelper already take care of changelog.txt, but maybe you should install readme.txt too ? - docs/spring-webflow-reference/ As you already strip Javadoc from source package, you may want to remove all this. (As you may know, docbook source is here : projects/spring-webflow- reference/) Embedded code copies is the only blocking issue for me to upload your package. Can you provide me some feedback about this ? Cheers, -- Damien Raude-Morvan - http://www.damien-raude-morvan.com/ signature.asc Description: This is a digitally signed message part.
Bug#575850: RFS: libspring-webflow-2.0-java
Hi again Damien, thanks for the review. Please see my comments below. On Wed, Mar 31, 2010 at 4:12 PM, Damien Raude-Morvan draz...@debian.org wrote: Hi Miguel, Here we go for libspring-webflow-2.0-java review : - debian/patches/02_fix_compilation.diff You should try to forward your patch upstream (maybe they'll be please to deliver you a parser compliant with OGNL version in debian) Ok, I will try to find how to send that patch to upstream. - debian/README.Debian-source Should be renamed to debian/README.source (as per Debian Policy § 4.14) Renamed. Done. - debian/control: * libspring-js-2.0-java short description seems a bit too generic Javascript abstraction framework. What about server-side Javascript abstraction framework ? * libspring-webflow-2.0-java: junit seems removable libhibernate3-java is twice + should be Recommends Done. I updated the short description for libspring-js-2.0 and fixed the Depends/Recommends for this package. - projects/spring-js/src/main/resources/META-INF/dojo/ Seems already available inside libjs-dojo-core package 1) you can of course ship it inside original tarball (after all it's DFSG- compliant) 2) you should try to use existing JS and don't embedded it in JAR file. I don't exactly know how Spring.js can handle this :/ As a general guideline, we should try to avoid embedded code copies. Same apply for META-INF/dijix/ (in libjs-dojo-dijix package) Yes, I forgot that those Javascript frameworks are already available in Debian. I removed those embedded code copies. Thanks for pointing this out. - notice.txt (install) There is no need to install this file as we already ship it in source form (orig tarball) and copyright notice are provided by copyright file in each binary package (compliant with Apache License 2.0 §4d) Done. I removed notice.txt from the binary packages. - readme.txt Debhelper already take care of changelog.txt, but maybe you should install readme.txt too ? Done. I included that file in the binary packages. - docs/spring-webflow-reference/ As you already strip Javadoc from source package, you may want to remove all this. (As you may know, docbook source is here : projects/spring-webflow- reference/) I prefer to not remove those docs yet. The reference manual can be generated from the source but the ant target provided by upstream to build that documentation depends on some libraries not available in Debian yet. Embedded code copies is the only blocking issue for me to upload your package. Can you provide me some feedback about this ? I removed those embedded code copies from spring-js jar file. The right thing should be Recommends libjs-dojo-core and libjs-dojo-dijit and document this change from upstream in README.Debian. I uploaded a new version to mentors and pushed the changes to the git repo. Let me know if more changes are needed. Cheers, - URL: http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java/libspring-webflow-2.0-java_2.0.8.RELEASE-1.dsc - Vcs-Git: git://git.debian.org/pkg-java/libspring-webflow-2.0-java.git -- Miguel Landaeta, miguel at miguel.cc secure email with PGP 0x7D8967E9 available at http://keyserver.pgp.com/ Faith means not wanting to know what is true. -- Nietzsche -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/u2s86aeadee1003311709q5ed2f2ccjf857657709ce3...@mail.gmail.com
Bug#575850: RFS: libspring-webflow-2.0-java
On Tue, Mar 30, 2010 at 9:31 AM, Damien Raude-Morvan draz...@debian.org wrote: Hi Miguel, Hi Damien, thanks for review this package. I'm interested in sponsoring your package. I'll try to have a look at it this evening or tomorow. FYI, you might check your Homepage field (debian/control) : http://www.springsource.com/webflow may be replaced by http://www.springsource.ORG/webflow (first version won't work - just redirect to spring source inc. main site) Yes, that was a silly typo only with my RFS email. The Homepage field in the package is correct. Homepage: http://www.springsource.org/webflow I'll wait for your review. Cheers, -- Miguel Landaeta, miguel at miguel.cc secure email with PGP 0x7D8967E9 available at http://keyserver.pgp.com/ Faith means not wanting to know what is true. -- Nietzsche -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/86aeadee1003300715u79fc5d1n59ff8531e8540...@mail.gmail.com
Bug#575850: RFS: libspring-webflow-2.0-java
On Mon, 29 Mar 2010 20:41:49 -0430, Miguel Landaeta mig...@miguel.cc wrote: Hi mentors, Hi Miguel, I am looking for a sponsor for my package libspring-webflow-2.0-java. * Package name: libspring-webflow-2.0-java Version : 2.0.8.RELEASE-1 Upstream Author : SpringSource Inc. * URL : http://www.springsource.com/webflow * License : Apache-2.0, BSD and others Section : java I'm interested in sponsoring your package. I'll try to have a look at it this evening or tomorow. FYI, you might check your Homepage field (debian/control) : http://www.springsource.com/webflow may be replaced by http://www.springsource.ORG/webflow (first version won't work - just redirect to spring source inc. main site) Cheers, -- Damien - Debian Developper http://wiki.debian.org/DamienRaudeMorvan -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/b06f631684f8f67be222978c286fb...@drazzib.com
Bug#575850: RFS: libspring-webflow-2.0-java
Hi mentors, I am looking for a sponsor for my package libspring-webflow-2.0-java. * Package name: libspring-webflow-2.0-java Version : 2.0.8.RELEASE-1 Upstream Author : SpringSource Inc. * URL : http://www.springsource.com/webflow * License : Apache-2.0, BSD and others Section : java It builds these binary packages: libspring-js-2.0-java - JavaScript abstraction framework libspring-webflow-2.0-java - Java MVC framework focused in View and Controller layers libspring-webflow-2.0-java-doc - documentation for libspring-webflow-2.0-java The package is lintian clean. The upload would fix these bugs: 575850. My motivation for maintaining this package is: I develop software using this library. Also it is needed on the server-side. Additionally, this software is needed by other software that I'm packaging. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/l/libspring-webflow-2.0-java/libspring-webflow-2.0-java_2.0.8.RELEASE-1.dsc - Vcs-Git: git://git.debian.org/pkg-java/libspring-webflow-2.0-java.git I would be glad if someone uploaded this package for me. Regards, -- Miguel Landaeta, miguel at miguel.cc secure email with PGP 0x7D8967E9 available at http://keyserver.pgp.com/ Faith means not wanting to know what is true. -- Nietzsche -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/86aeadee1003291811m134d3708i594fa1f00573b...@mail.gmail.com
