[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046056#comment-16046056 ] Harshvardhan Gupta commented on DERBY-6935: --- Yes, the latest commit looks good. I am resolving the issue. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: moreCycleTests.diff, simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045717#comment-16045717 ] Bryan Pendleton commented on DERBY-6935: Thanks again for catching this. Can you re-check the latest commit and make sure it has the right tests? Then I think we can re-resolve this issue. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: moreCycleTests.diff, simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045716#comment-16045716 ] ASF subversion and git services commented on DERBY-6935: Commit 1798340 from [~bryanpendleton] in branch 'code/trunk' [ https://svn.apache.org/r1798340 ] DERBY-6935: Test coverage for added features This patch was contributed by Harshvardhan Gupta (harshvardhan145 at gmail dot com) The patch adds additional test cases for the new CYCLE-related features of the identity column support. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: moreCycleTests.diff, simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045702#comment-16045702 ] Harshvardhan Gupta commented on DERBY-6935: --- Bryan, Yes the 'moreCycleTests.diff' contains the missing tests, I had not synced from remote before adding more tests to IdentitySequenceTests.java, maybe that could have caused problems with the usual patch command. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: moreCycleTests.diff, simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045567#comment-16045567 ] Bryan Pendleton commented on DERBY-6935: I see now that I missed some of your tests when working with simpleTests_2.diff. I think the patch command must have skipped that file because I already had the DERBY-6904 changes to IdentitySequenceTests.java applied, and I did not notice. I'm sorry! Yes, please re-submit a new patch with the tests that I missed from simpleTests_2. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045566#comment-16045566 ] Bryan Pendleton commented on DERBY-6935: Did we add tests covering the behavior of SYSCOLUMNS.AUTOINCREMENTCYCLE for a non-generated column? If not, perhaps you could include a couple of such tests? > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045558#comment-16045558 ] Bryan Pendleton commented on DERBY-6935: OK, let me look more closely; I probably fumbled the "patch" command while working with the diffs. Or, best: can you please attach a new diff to this issue that contains only the missing changes to IdentitySequenceTests.java? Thanks! > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045556#comment-16045556 ] Harshvardhan Gupta commented on DERBY-6935: --- No, the recent changes to IdentitySequenceTests.java do not seem to be included in 1797283. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045553#comment-16045553 ] Bryan Pendleton commented on DERBY-6935: Yes, I believe those were committed as part of Commit 1797283 for DERBY-6904. Can you 'svn up' your sandbox and confirm whether or not you see those tests in the current head revision from Subversion? > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045551#comment-16045551 ] Harshvardhan Gupta commented on DERBY-6935: --- Hi Bryan, I added some catalog tests too in IdentitySequenceTests.java which are not included in this commit but included in the patch I attached earlier. Thanks > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Fix For: 10.14.0.0 > > Attachments: simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045314#comment-16045314 ] ASF subversion and git services commented on DERBY-6935: Commit 1798290 from [~bryanpendleton] in branch 'code/trunk' [ https://svn.apache.org/r1798290 ] DERBY-6935: Test coverage for added features This patch was contributed by Harshvardhan Gupta (harshvardhan145 at gmail dot com) The patch adds additional test cases for the new CYCLE-related features of the identity column support. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Attachments: simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044865#comment-16044865 ] Harshvardhan Gupta commented on DERBY-6935: --- Bryan, I do think that we should go ahead and commit them. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Attachments: simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1606#comment-1606 ] Bryan Pendleton commented on DERBY-6935: Hi Vardhan, thanks for the updated tests. The new tests look fine to me, and work without problems on my machine. Are you working on more tests right now? Or do you think we should go ahead and commit these tests now (we can always add more tests later as we think of them)? > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Attachments: simpleTests_2.diff, simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036035#comment-16036035 ] Harshvardhan Gupta commented on DERBY-6935: --- Hey Bryan, Yes the tests look good to me and capture the expected behaviour, I'll take your patch and add some more, particularly tests related to DERBY-6903 and DERBY-6905. thanks, vardhan > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > Attachments: simpleTests.diff > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028615#comment-16028615 ] Bryan Pendleton commented on DERBY-6935: That seems like a good plan to me. Why don't you write the tests that you've described, and if I think of additional test cases as I review your tests I'll let you know. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028482#comment-16028482 ] Harshvardhan Gupta commented on DERBY-6935: --- Hey Bryan, Since most of the functionality we are testing is closely knit together, I think it is better if we write tests independently rather than trying to divide the work and later merge them, how about I do the first iteration of all the tests and then you can perhaps add some more tricker tests or refine them as part of the second iteration if it's required. Or maybe vice versa as well if that suits. Thanks > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (DERBY-6935) Test Coverage for added features.
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028480#comment-16028480 ] Harshvardhan Gupta commented on DERBY-6935: --- The following functionality should be covered as part of writing tests for the patch - 1) SYS.SYSCOLUMNS now reports the cycle value for the Identity column. 2) Alter table alter column command doesn't have any effect on the cycle column.(Two of the tests fixed as part of patch already cover this, I am sure we can add some more trickier test cases) 3) Explicitly turn off cycling using NO CYCLE command during create table or alter table queries. > Test Coverage for added features. > - > > Key: DERBY-6935 > URL: https://issues.apache.org/jira/browse/DERBY-6935 > Project: Derby > Issue Type: Sub-task > Components: SQL >Reporter: Harshvardhan Gupta >Assignee: Harshvardhan Gupta >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
