[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ https://issues.apache.org/jira/browse/DERBY-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510892 ] Myrna van Lunteren commented on DERBY-1610: --- thx for your input...Except of course that in some of the calls, client has been made to *fail* for both drivers, if that was the correct action Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: https://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Client, Network Server Reporter: Tomohito Nakayama Assignee: Tomohito Nakayama Fix For: 10.3.0.0 Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, releaseNote.html, releaseNote.html, releaseNote.html, releaseNote.html, releaseNote_2.html, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ https://issues.apache.org/jira/browse/DERBY-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510849 ] Daniel John Debrunner commented on DERBY-1610: -- It takes a while with that release note to understand what the new behaviour is. Replacing text of the form: setNull(LONGVARBINARY) on parameter of type CHAR FOR BIT DATA (Types.BINARY). In previous releases, Embedded succeeds, Client fails (state 22005) with something like These method calls now succeed on both drivers. In 10.2 and earlier releases the client driver threw an exception with SQL state 22005 setNull(Types.LONGVARBINARY) on parameter of type CHAR FOR BIT DATA (Types.BINARY) [and other calls] might be clearer Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: https://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Client, Network Server Reporter: Tomohito Nakayama Assignee: Tomohito Nakayama Fix For: 10.3.0.0 Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, releaseNote.html, releaseNote.html, releaseNote.html, releaseNote.html, releaseNote_2.html, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ https://issues.apache.org/jira/browse/DERBY-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499358 ] Myrna van Lunteren commented on DERBY-1610: --- Hi, This issue is one of several that is in progress, however, if I understand it correctly, a change that might impact existing applications has already gone in, and will be in for 10.3. I too find it important to document this change in behavior in the 10.3 release notes. The way it works, though, is that unless we do something, nothing will show up in the release notes on this. We have a number of choices; 1. adjust/falsify history and change the comment for revision 453886 to belong to for instance DERBY-1501, or maybe DERBY-1494... 2. close this bug as fixed in 10.3 and add the release note here. I vote for 2. I propose the following: - log a new bug (if not done already) for the issue with the type incompatibility of OUT parameters for stored procedures and link this new bug to DERBY-310. - close this bug as fixed in 10.3. - removing the existing application impact check from DERBY-1501 because no change specific to that bug went into subversion, so a release note seems contrary. I understand your concern about giving the impression that all type differences were resolved, but then again, I don't think a release note about a fix is the appropriate place for that. So, I suggest we use verbage that suggests more differences may exist. I propose something like the following for the release note, please review correct: -- Summary of Change Derby's Client implementation will return an appropriate error, matching the behavior with Embedded in the a number of situations related to PreparedStatement.setNull(int, int). Symptoms Seen by Applications Affected by Change In a number of situations, Derby's client implementation behaved differently from the Embedded implementation: 1. setNull(LONGVARCHAR) on parameter of type CHAR FOR BIT DATA (Types.BINARY). In previous releases, the Client succeeds, embedded fails (state 22005). 2. setNull(LONGVARBINARY) on parameter of type CHAR FOR BIT DATA (Types.BINARY). In previous releases, Embedded succeeds, client fails (state 22005). 3. setNull(LONGVARBINARY) on parameter of type VARCHAR FOR BIT DATA (Types.VARBINARY). In previous releases, Embedded succeeds, client fails (state 22005). 4. setNull(BINARY) on parameter of type LONG VARCHAR FOR BIT DATA (Types.LONGVARBINARY) In previous releases, Embedded succeeds, client fails (state 22005). 5. setNull(TIME) on parameter of TIMESTAMP. In previous releases, Client succeeds, embedded fails (state 22005). Incompatibilities with Previous Release Now, in the cases indicated above, the client and Embedded implementation show the behavior previously shown only with Embedded. Rationale for Change Derby's Client implementation and Embedded implementation should behave the same way from the point of view of an application whenever possible. Application Changes Required Applications relying on the Client behaving in the old way will have to be adjusted. -- If I do not hear objections, I'll proceed with this plan. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: https://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Client, Network Server Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ https://issues.apache.org/jira/browse/DERBY-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499381 ] Tomohito Nakayama commented on DERBY-1610: -- I have no objection for your plan on the whole. I think we should refer to imcompatible type of setX(null). By the way my concern around OUT PARAMETER of stored procedure seems to be groundless fears. It was resolved in DERBY-2381. However, reading current ParameterMappingTest, there seems to remain difference of handling NULL value in getStream/getBlob/getClob The specificCheck method supresses the test for them. I will file it and close this issue. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: https://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Client, Network Server Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ https://issues.apache.org/jira/browse/DERBY-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499382 ] Tomohito Nakayama commented on DERBY-1610: -- Not close but resolve . Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: https://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Client, Network Server Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Fix For: 10.3.0.0 Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ https://issues.apache.org/jira/browse/DERBY-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496603 ] Rick Hillegas commented on DERBY-1610: -- Hi Tomohito and Knut Anders, Is this issue ready to have a release note written? A comment on DERBY-2430 suggests that a single release note should cover both issues. Is that the plan? Thanks-Rick Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: https://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Client, Network Server Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ https://issues.apache.org/jira/browse/DERBY-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12496619 ] Tomohito Nakayama commented on DERBY-1610: -- Hi. I think release note should be written. However I have a concern around type compatibility of OUT PARAMETER of stored procedure . When I implemented this issue, the functionality of setObject(java.sql.Blob)/ setObject(java.sql.Clob)/ OUT PARAMETER of stored procedure was not implemented in NetworkServer/NetworkClient. //Please have a glance on https://issues.apache.org/jira/secure/attachment/12339632/parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient Because those functionality was not same between NetworkServer and NetworkClient, type compatibility was *not completely same* between them though they are *not different* in the extent where functionality was implemented. The reason why I did not resolve this issue is that I felt concern around them. I understand DERBY-2430 resolve my concern around setObject(java.sql.Blob)/ setObject(java.sql.Clob). Then there still remain OUT PARAMETER of stored procedure. I think we need to take the care of not implemented functionality when we wrote release note. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: https://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Client, Network Server Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12441374 ] Knut Anders Hatlen commented on DERBY-1610: --- Thanks Tomohito. If the methods are static, each setter method must call getColumnMetaDataX(), getColumnType() and checkForEscapedCallWithResult(). I think it is better to have these calls in checkTypeForXXX() because it makes the setters cleaner and reduces the footprint. Since it reduces the amount of duplicated code, I think it also makes the code more maintainable. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12441400 ] Tomohito Nakayama commented on DERBY-1610: -- I see. It would be a descision. My stand point is +0. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12441109 ] Knut Anders Hatlen commented on DERBY-1610: --- There are some failures in the jdbc40 suite caused by these changes. I'll post a patch for it. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12441136 ] Tomohito Nakayama commented on DERBY-1610: -- Thank you for clean up those. I have a concern for checkTypeForSetAsciiStream, checkTypeForSetBlob, checkTypeForSetClob. I think static method is better than instance methods, because information handled in the static method is clearer ... Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: derby-1610-jdk16.diff, DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440832 ] Tomohito Nakayama commented on DERBY-1610: -- Committed. Sendingjava/client/org/apache/derby/client/am/PreparedStatement.java Transmitting file data . Committed revision 454312. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, DERBY-1610_7_regressionfix_2_3.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440735 ] Tomohito Nakayama commented on DERBY-1610: -- Committed. Sendingjava/client/org/apache/derby/client/am/PreparedStatement.java Transmitting file data . Committed revision 454098. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
Well This modification may be unneccesary because next 10.3 does not supoprt jdk13 ... However, the phenomena was so critical that any set method is failed on jdk13 I thought it is too sudden change and difficulty for escaping it is acceptable. Then I committed ... Best regards. Tomohito Nakayama (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440735 ] Tomohito Nakayama commented on DERBY-1610: -- Committed. Sendingjava/client/org/apache/derby/client/am/PreparedStatement.java Transmitting file data . Committed revision 454098. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- /* Tomohito Nakayama [EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED] Naka http://www5.ocn.ne.jp/~tomohito/TopPage.html */
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440806 ] Tomohito Nakayama commented on DERBY-1610: -- Reading the code, I found problem in the DERBY-1610_7_regressionfix_2_2.patch ... In the case PreparedStatement.escapedProcedureCallWithResult_ is true, I can't access type information of parameterMetaData_ with original parameter index value. As it is treated in ParameterMetaData, I need to decreaseindex value before access the type information. It seeems that I need to use checkForEscapedCallWithResult method Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, DERBY-1610_7_regressionfix_2_2.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440655 ] Tomohito Nakayama commented on DERBY-1610: -- Committed. Sendingjava/client/org/apache/derby/client/am/PreparedStatement.java Sending java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/callable.out Sending java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/blobclob4BLOB.out Sending java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/callable.out Sending java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/parameterMapping.out Sending java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/callable.java Sending java/testing/org/apache/derbyTesting/functionTests/tests/derbynet/csPrepStmt.java Sending java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/parameterMapping.java Transmitting file data Committed revision 453886. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440667 ] Øystein Grøvlen commented on DERBY-1610: The latest check-in seems to have introduced an error in callable.java Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440668 ] Øystein Grøvlen commented on DERBY-1610: Diff from the tinderbox test: * Diff file derbyall/derbynetmats/DerbyNet/derbynetmats/callable.diff *** Start: callable jdk1.5.0_07 DerbyNet derbynetmats:derbynetmats 2006-10-07 14:02:10 *** 34d33 execute the procedure with BLOB Test Failed. *** End: callable jdk1.5.0_07 DerbyNet derbynetmats:derbynetmats 2006-10-07 14:02:16 *** Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440671 ] Tomohito Nakayama commented on DERBY-1610: -- Sorry for the regression I updated next 2 callable.out file in patch. [EMAIL PROTECTED]:~/derby/dev/trunk$ grep Index: DERBY-1610_7.patch | grep callable.out Index: java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/callable.out Index: java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/callable.out However, there exists next 4 callable.out file [EMAIL PROTECTED]:~/derby/dev/trunk$ find -name callable.out ./java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/jdk15/callable.out ./java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/callable.out ./java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/jdk15/callable.out ./java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/callable.out Next 2 out file needs to be updated. ./java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/jdk15/callable.out and ./java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/jdk15/callable.out I will fix it soon. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440675 ] Tomohito Nakayama commented on DERBY-1610: -- I committed. Sending java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/jdk15/callable.out Sending java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/jdk15/callable.out Transmitting file data .. Committed revision 453922. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440677 ] Tomohito Nakayama commented on DERBY-1610: -- In addition to the derbyall test, the compatibility test seems to be failed after this patch. http://www.multinet.no/~solberg/public/Apache/TinderBox_Derby/Limited/testSummary-453887.html I will see what happen. However, jdk13 can't work at my site. Then, I will use ibm13 instead . Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440684 ] Tomohito Nakayama commented on DERBY-1610: -- I think I could find reason for compatibility error Next error was found in serverVM-1.3_serverTrunk_clientVM-1.3_clientTrunk when compatibility test was executed and failed. .E. Time: 2.974 There was 1 error: 1) testJDBCDriver(org.apache.derbyTesting.functionTests.tests.junitTests.compatibility.JDBCDriverTest)java.lang.NoClassDefFoundError: java/sql/ParameterMetaData at java.lang.ClassLoader.defineClass0(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:703) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:133) at java.net.URLClassLoader.defineClass(URLClassLoader.java:320) at java.net.URLClassLoader.access$400(URLClassLoader.java:93) at java.net.URLClassLoader$ClassFinder.run(URLClassLoader.java:678) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:239) at java.lang.ClassLoader.loadClass(ClassLoader.java:516) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:460) at java.lang.ClassLoader.loadClass(ClassLoader.java:448) at org.apache.derby.client.net.ClientJDBCObjectFactoryImpl.newParameterMetaData(ClientJDBCObjectFactoryImpl.java:348) at org.apache.derby.client.am.PreparedStatement.getParameterMetaDataX(PreparedStatement.java:1774) at org.apache.derby.client.am.PreparedStatement.getParameterMetaData(PreparedStatement.java:1759) at org.apache.derby.client.am.PreparedStatement.setInt(PreparedStatement.java:562) at org.apache.derbyTesting.functionTests.tests.junitTests.compatibility.JDBCDriverTest.setRow(JDBCDriverTest.java:655) at org.apache.derbyTesting.functionTests.tests.junitTests.compatibility.JDBCDriverTest.stuffTable(JDBCDriverTest.java:377) at org.apache.derbyTesting.functionTests.tests.junitTests.compatibility.JDBCDriverTest.datatypesTest(JDBCDriverTest.java:281) at org.apache.derbyTesting.functionTests.tests.junitTests.compatibility.JDBCDriverTest.testJDBCDriver(JDBCDriverTest.java:258) at org.apache.derbyTesting.functionTests.tests.junitTests.compatibility.CompatibilitySuite.main(CompatibilitySuite.java:138) FAILURES!!! Tests run: 2, Failures: 0, Errors: 1 Reading javadoc for ParameterMetadata interface, I found we can use this class after jdk.1.4. http://java.sun.com/j2se/1.4.2/docs/api/java/sql/ParameterMetaData.html I think using ParameterMetadata is reason why compatibility suite was failed. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440685 ] Tomohito Nakayama commented on DERBY-1610: -- Reading the code, I think I can use org.apache.derby.client.am.ColumnMetaData instead of ParameterMetadata. I will fix it too. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440687 ] Tomohito Nakayama commented on DERBY-1610: -- And compatibility test also Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440688 ] Bryan Pendleton commented on DERBY-1610: It appears that you are working on making this change compatible with JDK 1.3. I thought we had decided that the trunk no longer worked with JDK 1.3? Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440716 ] Tomohito Nakayama commented on DERBY-1610: -- At least, current lateest release support JDK1.3. http://db.apache.org/derby/releases/release-10.2.1.6.cgi#Release%20Overview And phenomena would make it almost completely impossilbe to run DerbyNetClient of next release on JDK 1.3 ... I think we have two options. 1) Make DerbyNetClient to work on JDK 1.3 to some extent though not supported officialy. 2) Give up DerbyNetClient to work on JDK 1.3. DerbyNet (db2jcc.jar) may work as expected Well I think we need to know how difficult 1) is , at least ... Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440717 ] Bryan Pendleton commented on DERBY-1610: Here's a link to the 1.3 discussion on the mailing list: http://www.nabble.com/forum/ViewPost.jtp?post=6610713framed=y Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440719 ] Tomohito Nakayama commented on DERBY-1610: -- With the patch DERBY-1610_7_regressionfix_2.patch , I executed derbyall and compatibility suite. The result was that compatibility test was passed and jdbcapi/StmtCloseFunTest.java in DerbyNetClinet of derbyall was failed. Next are exceptions found in StmtCloseFunTest.tmp : Prepared Statement test begin FAIL -- unexpected exception:java.lang.NullPointerException java.lang.NullPointerException at org.apache.derby.client.am.PreparedStatement.setInt(PreparedStatement.java:562) at org.apache.derbyTesting.functionTests.tests.jdbcapi.StmtCloseFunTest.test2(StmtCloseFunTest.java:335) at org.apache.derbyTesting.functionTests.tests.jdbcapi.StmtCloseFunTest.main(StmtCloseFunTest.java:72) Callable Statement test begin The result is 3 FAIL -- unexpected exception:java.lang.NullPointerException java.lang.NullPointerException at org.apache.derby.client.am.PreparedStatement.setString(PreparedStatement.java:925) at org.apache.derbyTesting.functionTests.tests.jdbcapi.StmtCloseFunTest.test3(StmtCloseFunTest.java:577) at org.apache.derbyTesting.functionTests.tests.jdbcapi.StmtCloseFunTest.main(StmtCloseFunTest.java:73) Statement Close Fun Test finished Where exception found was around next org.apache.derbyTesting.functionTests.tests.jdbcapi.StmtCloseFunTest : test2 method : ps.setInt(1, 420); ps.setFloat(2, (float)12.21); ps.setDate(3, new Date(87050520L)); ps.setString(4, China); ps.executeUpdate(); ps.close(); //now, we begin the test try { ps.setInt(1, 530); System.out.println(Prepared Statement Test failed); } catch(SQLException e) { } test3 method : cs = conn.prepareCall(call takesString(?,?)); cs.registerOutParameter(1, Types.CHAR); cs.setInt(2, Types.INTEGER); cs.execute(); System.out.println(The result is + cs.getString(1)); cs.close(); try { cs.setString(1, ABC); System.out.println(Callable Statement Test failed); } catch(SQLException e) { } It seems that program throw NullPointerExceptioon because method of instance variable ,parameterMetaData_ , was called after Statement was closed and substituted null for parameterMetaData_ . Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12440726 ] Tomohito Nakayama commented on DERBY-1610: -- I think it is possible to solve problem found in jdbcapi/StmtCloseFunTest.java ... I will post the patch after derbyall was examined. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, DERBY-1610_7_regressionfix.patch, DERBY-1610_7_regressionfix_2.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12439477 ] Knut Anders Hatlen commented on DERBY-1610: --- I have run tests of setNull() and setObject() on most type combinations, and I didn't find any inconsistencies. +1 to commit. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12439485 ] Tomohito Nakayama commented on DERBY-1610: -- Thank you for your persistent follow-up ! I will commit the patch after 10.2 is released. This patch have much impact on behavior of NetworkClient driver and I think it should not be committed in rush. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12439547 ] Bryan Pendleton commented on DERBY-1610: Is this issue related to the issue discussed in DERBY-1904, specifically: http://issues.apache.org/jira/browse/DERBY-1904?page=comments#action_12439484 Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, DERBY-1610_7.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.7.diff, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12438972 ] Tomohito Nakayama commented on DERBY-1610: -- I found another problem in derbynet/csPrepStmt.java. The part of setNull in this test expect it possible to setNull(TIME) on 18th column typed as TIMESTAMP. If nod modified this test, it is impossible to correct 5. setNull(TIME) on parameter of TIMESTAMP: Client succeeds, embedded fails (state 22005). @ http://issues.apache.org/jira/browse/DERBY-1610#action_12438657 . I will fix this part in the test too. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12438886 ] Tomohito Nakayama commented on DERBY-1610: -- 1)-4) Test on parameter of type CHAR FOR BIT DATA/VARCHAR FOR BIT DATA/LONG VARCHAR FOR BIT DATA was not included in parameterMapping.java. I agree your suggested line. 5) Well ... Type compatibility should be strict rather than lenient. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12438887 ] Tomohito Nakayama commented on DERBY-1610: -- Sorry. I took mistaken. Test for CHAR FOR BIT DATA/VARCHAR FOR BIT DATA/LONG VARCHAR FOR BIT DATA existed in parameterMapping.java as next. CHAR(60) FOR BIT DATA was skipped. VARCHAR(60) FOR BIT DATA was executed. LONG VARCHAR FOR BIT DATA was sipped. I think here exists something ... Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12438889 ] Tomohito Nakayama commented on DERBY-1610: -- In the parameterMapping.java, tests of setNull on parameter typed VARCHAR FOR BIT DATA (Types.VARBINARY) existed and execued. However, setNull(LONGVARBINARY) was not tested in those tests. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12438952 ] Tomohito Nakayama commented on DERBY-1610: -- Regarding 1. setNull(LONGVARCHAR) on parameter of type CHAR FOR BIT DATA (Types.BINARY): Client succeeds, embedded fails (state 22005)., I found derbynet/csPrepStmt.java have problem. The part of setNull in this test tries to setNull(LONGVARCHAR) on 13th column typed as char(23) for bit data. I think we need to modify this test program in this point. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12438657 ] Knut Anders Hatlen commented on DERBY-1610: --- Hi Tomohito, I tried to test all type combinations on setNull(). Seems like most of the combinations are treated the same way by the client driver and the embedded driver. Great! The only differences I found were: 1. setNull(LONGVARCHAR) on parameter of type CHAR FOR BIT DATA (Types.BINARY): Client succeeds, embedded fails (state 22005). 2. setNull(LONGVARBINARY) on parameter of type CHAR FOR BIT DATA (Types.BINARY): Embedded succeeds, client fails (state 22005). 3. setNull(LONGVARBINARY) on parameter of type VARCHAR FOR BIT DATA (Types.VARBINARY): Embedded succeeds, client fails (state 22005). 4. setNull(BINARY) on parameter of type LONG VARCHAR FOR BIT DATA (Types.LONGVARBINARY): Embedded succeeds, client fails (state 22005). 5. setNull(TIME) on parameter of TIMESTAMP: Client succeeds, embedded fails (state 22005). I believe the embedded driver behaves correctly in these cases, and that the client driver should behave the same way. Do you think so too? Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, DERBY-1610_6.patch, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping.out.diff, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12437796 ] Tomohito Nakayama commented on DERBY-1610: -- I found another inconsistency. At Line 300 in derbynet/callable.java, BLOB is set to variable typed as VARCHAR(1) FOR BIT DATA. However, this combination was expected to be failed in jdbcapi/parameterMapping.java. I will correct derbynet/callable.java to solve this inconsistency. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436793 ] Knut Anders Hatlen commented on DERBY-1610: --- I'm sorry, I didn't notice the FOR BIT DATA part. I agree with your first comment, that csPrepStmt should be changed. setNull(Date) should fail on a VARCHAR FOR BIT DATA (VARBINARY) parameter. What worried me, was that I thought the test ran under embedded and expected the call to succeed. But it is a derbynet test and doesn't run under embedded, so that should not be a problem. I also agree that setNull(Types.TIME) and setTime(null) should behave the same way. Table B-5 in the JDBC spec says that setObject(java.sql.Time) can be used on parameters of type CHAR, VARCHAR, LONGVARCHAR or TIME. I would expect setNull(Types.TIME) and setTime() to accept the same parameter types as setObject(Time). Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436883 ] Tomohito Nakayama commented on DERBY-1610: -- Thank you for your concern, Knut. I will correct csPrepStmt.java and unify the behavior of setNull(Types.TIME) and setTiime(null) in NetworkClient in this issue. Moreover, I will file it as different issue to unify the behavior of setNull(Types.TIME) and setTiime(null) in engine. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
Tomohito Nakayama (JIRA) derby-dev@db.apache.org writes: [ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436883 ] Tomohito Nakayama commented on DERBY-1610: -- Thank you for your concern, Knut. I will correct csPrepStmt.java and unify the behavior of setNull(Types.TIME) and setTiime(null) in NetworkClient in this issue. Moreover, I will file it as different issue to unify the behavior of setNull(Types.TIME) and setTiime(null) in engine. Great! That sounds like a good approach. Thanks again for all your hard work on cleaning up this area of the code and making the behaviour consistent across the drivers. -- Knut Anders
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436536 ] Tomohito Nakayama commented on DERBY-1610: -- I found problem in test of setNull method in derbynet/csPrepStmt.java. In that test, 16 th value in sql is typed as LONGVARCHAR. However 16th column is typed as DATE I will try to correct this test too ... Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436543 ] Knut Anders Hatlen commented on DERBY-1610: --- I'm not sure the test should be changed. The test intentionally calls setNull() with another type and expects it to succeed. From the conversion tables in appendix B of the JDBC spec, it seems reasonable to expect that setNull(Types.LONGVARCHAR) on a DATE parameter succeeds. (LONGVARCHAR maps into a String object, and setObject(String) is allowed on a DATE parameter. Also, getDate() is allowed on a LONGVARCHAR column, and getString() is allowed on a DATE column.) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436554 ] Tomohito Nakayama commented on DERBY-1610: -- Through examing result, I found another problem, in result of parameterMapping.java at engine itself. The result of setNull(java.sql.Types.TIME) for TIMESTAMP typed variable is regarded as error. However, the result of setTime(null) for TIMESTAMP typed variable is not regarded as error Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436555 ] Tomohito Nakayama commented on DERBY-1610: -- I correct my previous comment in http://issues.apache.org/jira/browse/DERBY-1610#action_12436536. In that test, 16 th value in sql is typed as LONGVARCHAR FOR BIT DATA. However 16th column is typed as DATE Not LONGVARCHAR, but LONGVARCHAR FOR BIT DATA. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436557 ] Tomohito Nakayama commented on DERBY-1610: -- I understand Knut's comment at http://issues.apache.org/jira/browse/DERBY-1610#action_12436543. I found comments in derbynet/csPrepStmt.java told as next. // test setNull on different datatypes of the input parameters of PreparedStatement But I'm not sure about question at http://issues.apache.org/jira/browse/DERBY-1610#action_12436554 yet. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436566 ] Tomohito Nakayama commented on DERBY-1610: -- Based on Knut's comment at http://issues.apache.org/jira/browse/DERBY-1610#action_12436543, The result of parameterMapping.java at enginemay have another problem. This result of parameterMapping.java at engine is inconsistent with the result of derbynet/csPrepStmt.java In the result of parameterMapping.java, it is regarded as type imcompatible error to call setNull(VARCHAR FOR BIT DATA) for column typed in DATE, though derbynet/csPrepStmt.java expect same processing to be passed. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436568 ] Tomohito Nakayama commented on DERBY-1610: -- As I could understand . Now, we have two inconsistency. 1: Inconsistency in a result of jdbcapi/parameterMapping.java at engine. The result of setNull(java.sql.Types.TIME) for TIMESTAMP typed variable is regarded as error. However, the result of setTime(null) for TIMESTAMP typed variable is not regarded as error . http://issues.apache.org/jira/browse/DERBY-1610#action_12436554 2: Inconsistency between results of jdbcpai/parameterMapping.java at engine and derbynet/csPrepStmt.java. Former regards it as error to execute setNull(VARCHAR FOR BIT DATA) for column typed in DATE. Though latter regards it as expected. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
Hello. I summarized problems that I encountered through DERBY-1610 in the comment just before. I will DERBY-1610.wait() for your response. Please DERBY-1610.notify() to wake up me. // It's midnight now in Japan :) Best regards. Tomohito Nakayama (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436568 ] Tomohito Nakayama commented on DERBY-1610: -- As I could understand . Now, we have two inconsistency. 1: Inconsistency in a result of jdbcapi/parameterMapping.java at engine. The result of setNull(java.sql.Types.TIME) for TIMESTAMP typed variable is regarded as error. However, the result of setTime(null) for TIMESTAMP typed variable is not regarded as error . http://issues.apache.org/jira/browse/DERBY-1610#action_12436554 2: Inconsistency between results of jdbcpai/parameterMapping.java at engine and derbynet/csPrepStmt.java. Former regards it as error to execute setNull(VARCHAR FOR BIT DATA) for column typed in DATE. Though latter regards it as expected. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- /* Tomohito Nakayama [EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED] Naka http://www5.ocn.ne.jp/~tomohito/TopPage.html */
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436122 ] Knut Anders Hatlen commented on DERBY-1610: --- Although embedded throws XCL12 in some cases, I don't think the client driver needs to do the same. From the comments in parameterMapping, it seems like XCL12 was not meant to be used permanently. I think it would be better if the client consistently threw 22005 for all the type errors. The patch looks good. Perhaps you could add a comment describing the PossibleTypes class? Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12436209 ] Tomohito Nakayama commented on DERBY-1610: -- Thank you for your reviewing. I tried derbyall last night and found several error happens. I will submit next patch also with the modification for your suggestion. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12435783 ] Tomohito Nakayama commented on DERBY-1610: -- I found same problem in VARBINARY as in http://issues.apache.org/jira/browse/DERBY-1610#action_12435413... Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, DERBY-1610_5.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, TestTypeCompatibility.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12434120 ] Tomohito Nakayama commented on DERBY-1610: -- Hello. 1) The jdbcapi/parameterMapping.java takes both of XCL12 and 22005 as expected Exception... Well .. anyway, I wiill test and report it. However, I'm not sure whether 22005 is reasonable Exception . 2) Technically possible. However I think define them as constants will make the code harder to read ... Well ... avoid allocating a new memory would be much more important for the program 3) I sorted the element by hand and the result was hard-coded. DEBUG code in checkType method proof that they are in correct order. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12434234 ] Knut Anders Hatlen commented on DERBY-1610: --- Thank you for the explanation and the new patch, Tomohito! Since the constant arrays are required to be sorted, I think they should have a comment saying they must be sorted in case someone needs to modify them later. Also, I think it would be clearer (and safer) if they were defined as CONSTANT = Arrays.sort(new int[] { }); That would explicitly show that they are sorted. Since the sorting only happens when the class is loaded, it shouldn't be a performance issue. Another small comment is that POSSIBLE_TYPES_IN_SET_XXX is identical for boolean, byte, short, int, long, float, double and BigDecimal. It would probably be good to use one constant only (for instance, POSSIBLE_TYPES_IN_SET_SCALAR). It would reduce the disk and memory footprint. The same comment is valid for the POSSIBLE_TYPES_FOR_XXX_NULL constants. (In fact, for the types mentioned above, the POSSIBLE_TYPES_FOR_XXX_NULL constants could also be used by the setXXX methods. The only difference between FOR_XXX_NULL and IN_SET_XXX, is that the setNull constants contain BIT, TINYINT, NUMERIC and FLOAT whereas the setXXX ones don't. Since these types also are compatible with int, byte, boolean etc., it wouldn't hurt to add them to the setXXX constants.) I don't know what is meant by XCL12 is temp in parameterMapping, but I assume it's because the one who wrote it meant only one SQL state should be used for all conversion errors. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, DERBY-1610_4.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java, XCL12.diff There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12433196 ] Knut Anders Hatlen commented on DERBY-1610: --- Hi Tomohito, Thank you for working on this issue! I have only had a brief look at your patch. It looks like a great start, but I have a couple of questions/comments: 1) throwLangDataTypeSetException() throws an exception with state XCL12. Does that match embedded? I though embedded used 22005. 2) Would it be possible to have the integer arrays as constants? I think it would be good to avoid allocating a new array for each call to a setter method. Also, it would make the getPossibleTypesForNull() method more compact. 3) checkType() uses Arrays.binarySearch(), which requires that the array is sorted, but I don't think the arrays that are passed in are sorted. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, DERBY-1610_3.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, parameterMapping_3.diff, TestNullChar.java There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
Hello. I understood your suggestion that SQLState 22005 is not equal to just a error of get method, though there exists some message problem when setNull throws Exception for it. Thank you. Knut Anders Hatlen (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12432568 ] Knut Anders Hatlen commented on DERBY-1610: --- LANG_DATA_TYPE_GET_MISMATCH is not the only exception with SQLState 22005. From SQLState.java: String LANG_DATA_TYPE_GET_MISMATCH = 22005; // same 22005 error String UNSUPPORTED_ENCODING= 22005.S.1; String CHARACTER_CONVERTER_NOT_AVAILABLE = 22005.S.2; String CANT_CONVERT_UNICODE_TO_EBCDIC = 22005.S.3; String NET_UNRECOGNIZED_JDBC_TYPE = 22005.S.4; String NET_INVALID_JDBC_TYPE_FOR_PARAM = 22005.S.5; String UNRECOGNIZED_JAVA_SQL_TYPE = 22005.S.6; .S.X is only used internally and not part of the SQL state, so all of these have SQL state 22005. EmbedPreparedStatement.setNull() calls EmbedPreparedStatement.dataTypeConversion() to generate a data conversion exception. In fact, dataTypeConversion() uses SQLState.LANG_DATA_TYPE_GET_MISMATCH. This means the error message is inaccurate for the setters (An attempt was made to get a data value of type ''{0}'' from a data value of type ''{1}''.), but the SQL state is correct. Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, TestNullChar.java There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- /* Tomohito Nakayama [EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED] Naka http://www5.ocn.ne.jp/~tomohito/TopPage.html */
[jira] Commented: (DERBY-1610) Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver
[ http://issues.apache.org/jira/browse/DERBY-1610?page=comments#action_12431576 ] Tomohito Nakayama commented on DERBY-1610: -- Reading the org.apache.derby.client.am.PreparedStatement, I think each settype name and setNull method should have type checking implementation. It will resolve problem of 1) and 2) and 3). Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Key: DERBY-1610 URL: http://issues.apache.org/jira/browse/DERBY-1610 Project: Derby Issue Type: Bug Components: Network Server, Network Client Reporter: Tomohito Nakayama Assigned To: Tomohito Nakayama Attachments: DERBY-1610.diff, DERBY-1610_2.diff, parameterMapping.diff, parameterMapping.diff, parameterMapping.diff.betweenEmbedded_and_NetworkServerNetworkClient, TestNullChar.java There exists difference of type compatibility between Embedded and NetworkServer/NetworkClient. This issue tries to resolve it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira