[jira] Updated: (DERBY-3793) Remove unnecessary methods from InternalClob interface
[ https://issues.apache.org/jira/browse/DERBY-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3793: --- Priority: Minor (was: Trivial) Derby Info: (was: [Patch Available]) Fix Version/s: (was: 10.4.2.0) Committed 'derby-3793-2b-remove_getByteLength.diff' to trunk with revision 691608. Removed 10.4.2.0 from the fix versions. The first patch shouldn't have any performance or functional consequences, where as the second patch does. Remove unnecessary methods from InternalClob interface -- Key: DERBY-3793 URL: https://issues.apache.org/jira/browse/DERBY-3793 Project: Derby Issue Type: Improvement Components: JDBC Affects Versions: 10.5.0.0 Reporter: Kristian Waagan Assignee: Kristian Waagan Priority: Minor Fix For: 10.5.0.0 Attachments: derby-3793-1a-remove_getBytePosition.diff, derby-3793-1a-remove_getBytePosition.stat, derby-3793-2a-remove_getByteLength.diff, derby-3793-2a-remove_getByteLength.diff, derby-3793-2a-remove_getByteLength.stat, derby-3793-2b-remove_getByteLength.diff, derby-3793-2b-remove_getByteLength.stat The method InternalClob.getBytePosition is only used in one internal Clob implementation, and can be removed to reduce complexity and code volume. The method InternalClob.getByteLength can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3793) Remove unnecessary methods from InternalClob interface
[ https://issues.apache.org/jira/browse/DERBY-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3793: --- Attachment: derby-3793-2b-remove_getByteLength.stat derby-3793-2b-remove_getByteLength.diff 'derby-3793-2b-remove_getByteLength.diff' adds another test, adds/changes documentation for InternalClob.getRawByteStream, removes the InternalClob.getByteLength, and does the required changes for the removal. Regarding the test, I changed it to also add an id to the test table to be able to select specific Clobs. Rerunning suites.All and derbyall, no errors so far. Patch ready for review. Remove unnecessary methods from InternalClob interface -- Key: DERBY-3793 URL: https://issues.apache.org/jira/browse/DERBY-3793 Project: Derby Issue Type: Improvement Components: JDBC Affects Versions: 10.5.0.0 Reporter: Kristian Waagan Assignee: Kristian Waagan Priority: Trivial Fix For: 10.4.2.0, 10.5.0.0 Attachments: derby-3793-1a-remove_getBytePosition.diff, derby-3793-1a-remove_getBytePosition.stat, derby-3793-2a-remove_getByteLength.diff, derby-3793-2a-remove_getByteLength.diff, derby-3793-2a-remove_getByteLength.stat, derby-3793-2b-remove_getByteLength.diff, derby-3793-2b-remove_getByteLength.stat The method InternalClob.getBytePosition is only used in one internal Clob implementation, and can be removed to reduce complexity and code volume. The method InternalClob.getByteLength can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3793) Remove unnecessary methods from InternalClob interface
[ https://issues.apache.org/jira/browse/DERBY-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3793: --- Attachment: derby-3793-2a-remove_getByteLength.stat derby-3793-2a-remove_getByteLength.diff 'derby-3793-2a-remove_getByteLength.diff' removes InternalClob.getByteLength. The most interesting part of the patch is probably in LOBStreamControl.copyData. The rest of the changes are mostly deletions of code. Patch ready for review. Remove unnecessary methods from InternalClob interface -- Key: DERBY-3793 URL: https://issues.apache.org/jira/browse/DERBY-3793 Project: Derby Issue Type: Improvement Components: JDBC Affects Versions: 10.5.0.0 Reporter: Kristian Waagan Assignee: Kristian Waagan Priority: Trivial Fix For: 10.4.2.0, 10.5.0.0 Attachments: derby-3793-1a-remove_getBytePosition.diff, derby-3793-1a-remove_getBytePosition.stat, derby-3793-2a-remove_getByteLength.diff, derby-3793-2a-remove_getByteLength.stat The method InternalClob.getBytePosition is only used in one internal Clob implementation, and can be removed to reduce complexity and code volume. The method InternalClob.getByteLength can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3793) Remove unnecessary methods from InternalClob interface
[ https://issues.apache.org/jira/browse/DERBY-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3793: --- Derby Info: [Patch Available] Remove unnecessary methods from InternalClob interface -- Key: DERBY-3793 URL: https://issues.apache.org/jira/browse/DERBY-3793 Project: Derby Issue Type: Improvement Components: JDBC Affects Versions: 10.5.0.0 Reporter: Kristian Waagan Assignee: Kristian Waagan Priority: Trivial Fix For: 10.4.2.0, 10.5.0.0 Attachments: derby-3793-1a-remove_getBytePosition.diff, derby-3793-1a-remove_getBytePosition.stat, derby-3793-2a-remove_getByteLength.diff, derby-3793-2a-remove_getByteLength.stat The method InternalClob.getBytePosition is only used in one internal Clob implementation, and can be removed to reduce complexity and code volume. The method InternalClob.getByteLength can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3793) Remove unnecessary methods from InternalClob interface
[ https://issues.apache.org/jira/browse/DERBY-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3793: --- Attachment: derby-3793-2a-remove_getByteLength.diff Updated patch 2a. The only change is the removal of a now unused variable (constant) in StoreStreamClob. Remove unnecessary methods from InternalClob interface -- Key: DERBY-3793 URL: https://issues.apache.org/jira/browse/DERBY-3793 Project: Derby Issue Type: Improvement Components: JDBC Affects Versions: 10.5.0.0 Reporter: Kristian Waagan Assignee: Kristian Waagan Priority: Trivial Fix For: 10.4.2.0, 10.5.0.0 Attachments: derby-3793-1a-remove_getBytePosition.diff, derby-3793-1a-remove_getBytePosition.stat, derby-3793-2a-remove_getByteLength.diff, derby-3793-2a-remove_getByteLength.diff, derby-3793-2a-remove_getByteLength.stat The method InternalClob.getBytePosition is only used in one internal Clob implementation, and can be removed to reduce complexity and code volume. The method InternalClob.getByteLength can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3793) Remove unnecessary methods from InternalClob interface
[ https://issues.apache.org/jira/browse/DERBY-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3793: --- Attachment: derby-3793-1a-remove_getBytePosition.stat derby-3793-1a-remove_getBytePosition.diff 'derby-3793-1a-remove_getBytePosition.diff' removes the getBytePosition method from the interface. In TemporaryClob it is made private, in StoreStreamClob it is deleted. I had to delete some package private tests. The implementation of TemporaryClob.getBytePosition now has to be tested indirectly through InteralClob.insertString, for which there already are some tests. Remove unnecessary methods from InternalClob interface -- Key: DERBY-3793 URL: https://issues.apache.org/jira/browse/DERBY-3793 Project: Derby Issue Type: Improvement Components: JDBC Affects Versions: 10.5.0.0 Reporter: Kristian Waagan Assignee: Kristian Waagan Priority: Trivial Fix For: 10.4.1.4, 10.5.0.0 Attachments: derby-3793-1a-remove_getBytePosition.diff, derby-3793-1a-remove_getBytePosition.stat The method InternalClob.getBytePosition is only used in one internal Clob implementation, and can be removed to reduce complexity and code volume. The method InternalClob.getByteLength can be removed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
