Re: Anyone going to be using ConsoleKit for 3.16 ?
Hey, Just to follow up here... On Wed, Feb 18, 2015 at 10:31 PM, Ray Strode halfl...@gmail.com wrote: I'll excise the code of ConsoleKit and provide the reversion patches before 3.15.91. I'm holding off for now since a bunch of changes went in for 3.15.90 and I want to make sure that things are settled down a little before generating patches (so they don't go stale right out of the gate) I didn't get this done for 3.15.91 and by the time 3.15.92 was around (code-freeze) I decided it's probably a little too late in the game to do it. So the new plan is keep ConsoleKit support in tree for 3.16 and just drop it from 3.18 --Ray ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
Hi again, Okay so there's a pretty good middle ground we can come up with here. I'll leave the --with-console-kit argument in configure, but if it gets used, then I'll error out and point to the wiki page mclasen suggests in another message. So I started a wiki page here: https://wiki.gnome.org/wiki/Projects/ConsoleKit It probably needs to be fleshed out more. I haven't dropped the ConsoleKit support from GDM yet, but I did add the message and change configure to default with ConsoleKit off. I'll excise the code of ConsoleKit and provide the reversion patches before 3.15.91. I'm holding off for now since a bunch of changes went in for 3.15.90 and I want to make sure that things are settled down a little before generating patches (so they don't go stale right out of the gate) ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
Given that it's broken/removed in gnome-shell 3.16 and that there's been no feedback, I don't see the problem. We should have removed the support in concert, instead of different parts of GNOME doing it at different times, but the expectation already is that ConsoleKit support should be a downstream patch for most parts of GNOME. One more isn't going to hurt. That's the reason we reverted: https://git.gnome.org/browse/gnome-shell/commit/?id=a244c1e987502e359c45c0a9bc0012b5bc635553 in 3.14 for OpenBSD (and FreeBSD). -- Antoine ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
Okay guys, so what I'll do then is take the code out but post a patch to https://bugzilla.gnome.org/show_bug.cgi?id=743940 that adds it back. You guys can ship that with 3.16 and then drop it with 3.18 when LoginKit is integrated into your distros. That's awesome. Thanks a lot. -- Antoine ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
It might be nice to put together a wiki page with pointers to the various patches that are needed for CK support in 3.16 ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
On Wed, 2015-02-04 at 10:24 +0100, Olav Vitters wrote: On Tue, Feb 03, 2015 at 03:36:36PM -0500, Ray Strode wrote: Hi, On Tue, Feb 3, 2015 at 12:00 PM, Olav Vitters o...@vitters.nl wrote: Can't we hide it behind a --this-is-going-away-in-3.18 configure switch? That was certainly a possibility, but, what's the advantage of doing it? The bug Antoine pointed to shows that distros that use ConsoleKit in 3.14 are already shipping patches to keep it working. No one who has chimed in has said that one more would be a big deal. And this is really only for one release, by 3.18 everyone should be using the newer apis, and then the patches will go away. It wouldn't be a big deal to deprecate for a release but no one who will be using ConsoleKit in 3.16 advocated for that. And cutting out the code is a net win for the codebase, so I'd rather do it now than later. Because I'm wondering if we're reaching everyone with this announcement, and it is a bit late in the cycle. Having a configure option would not mean it is suddenly gone (if they miss this email, they'd also not know about the patch), but it clearly tells them it'll be gone. Given that it's broken/removed in gnome-shell 3.16 and that there's been no feedback, I don't see the problem. We should have removed the support in concert, instead of different parts of GNOME doing it at different times, but the expectation already is that ConsoleKit support should be a downstream patch for most parts of GNOME. One more isn't going to hurt. ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
On Tue, Feb 03, 2015 at 03:36:36PM -0500, Ray Strode wrote: Hi, On Tue, Feb 3, 2015 at 12:00 PM, Olav Vitters o...@vitters.nl wrote: Can't we hide it behind a --this-is-going-away-in-3.18 configure switch? That was certainly a possibility, but, what's the advantage of doing it? The bug Antoine pointed to shows that distros that use ConsoleKit in 3.14 are already shipping patches to keep it working. No one who has chimed in has said that one more would be a big deal. And this is really only for one release, by 3.18 everyone should be using the newer apis, and then the patches will go away. It wouldn't be a big deal to deprecate for a release but no one who will be using ConsoleKit in 3.16 advocated for that. And cutting out the code is a net win for the codebase, so I'd rather do it now than later. Because I'm wondering if we're reaching everyone with this announcement, and it is a bit late in the cycle. Having a configure option would not mean it is suddenly gone (if they miss this email, they'd also not know about the patch), but it clearly tells them it'll be gone. -- Regards, Olav ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
Hi, On Wed, Feb 4, 2015 at 4:24 AM, Olav Vitters o...@vitters.nl wrote: Having a configure option would not mean it is suddenly gone (if they miss this email, they'd also not know about the patch), but it clearly tells them it'll be gone. Okay so there's a pretty good middle ground we can come up with here. I'll leave the --with-console-kit argument in configure, but if it gets used, then I'll error out and point to the wiki page mclasen suggests in another message. --Ray ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
On Wed, Feb 04, 2015 at 09:48:19AM -0500, Ray Strode wrote: On Wed, Feb 4, 2015 at 4:24 AM, Olav Vitters o...@vitters.nl wrote: Having a configure option would not mean it is suddenly gone (if they miss this email, they'd also not know about the patch), but it clearly tells them it'll be gone. Okay so there's a pretty good middle ground we can come up with here. I'll leave the --with-console-kit argument in configure, but if it gets used, then I'll error out and point to the wiki page mclasen suggests in another message. Ah, that's awesome! -- Regards, Olav ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
Hi Ray. Thanks a lot asking about this. OpenBSD *will* keep using ConsoleKit for 3.16. I expect that we should be able to be rid of it for 3.18 -- either using systembsd (far from ready) or the logind implementation that ConsoleKit2 is expected to provide iirc or ... something else. There are several other components of GNOME that still have some ConsoleKit support (at least in 3.14) and I would not mind removing such support for 3.16 if and only if reverting the removal is easy and not too intrusive. Not that I have a big say about it but... I forgot to mention that in its current form, GDM is broken by the way: https://bugzilla.gnome.org/show_bug.cgi?id=738691 The commit breaking CKit support was: https://git.gnome.org/browse/gnome-shell/commit/js/misc/loginManager.js?id=a244c1e987502e359c45c0a9bc0012b5bc635553 -- Antoine ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
On Tue, Feb 03, 2015 at 10:54:12AM -0500, Ray Strode wrote: [..] I'm wondering if there are distros/platforms that are planning on using 3.16 and ConsoleKit together. [..] I would not mind removing such support for 3.16 if and only if reverting the removal is easy and not too intrusive. FreeBSD will also be using ConsoleKit for 3.16. Antoine pretty much said everything that goes for us already. Okay guys, so what I'll do then is take the code out but post a patch to https://bugzilla.gnome.org/show_bug.cgi?id=743940 that adds it back. You guys can ship that with 3.16 and then drop it with 3.18 when LoginKit is integrated into your distros. Can't we hide it behind a --this-is-going-away-in-3.18 configure switch? -- Regards, Olav ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
Hi, I'm wondering if there are distros/platforms that are planning on using 3.16 and ConsoleKit together. I'm leaning toward getting rid of it in 3.16 (versus say 3.18). Distros, of course, could ship a patch to reverse to removal if necessary, so I don't think doing it for 3.16 should be too controversial, but I wanted to shoot a mail first anyway to gauge the reaction. I would not mind removing such support for 3.16 if and only if reverting the removal is easy and not too intrusive. FreeBSD will also be using ConsoleKit for 3.16. Antoine pretty much said everything that goes for us already. Okay guys, so what I'll do then is take the code out but post a patch to https://bugzilla.gnome.org/show_bug.cgi?id=743940 that adds it back. You guys can ship that with 3.16 and then drop it with 3.18 when LoginKit is integrated into your distros. --Ray ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
Hi, On Tue, Feb 3, 2015 at 12:00 PM, Olav Vitters o...@vitters.nl wrote: Can't we hide it behind a --this-is-going-away-in-3.18 configure switch? That was certainly a possibility, but, what's the advantage of doing it? The bug Antoine pointed to shows that distros that use ConsoleKit in 3.14 are already shipping patches to keep it working. No one who has chimed in has said that one more would be a big deal. And this is really only for one release, by 3.18 everyone should be using the newer apis, and then the patches will go away. It wouldn't be a big deal to deprecate for a release but no one who will be using ConsoleKit in 3.16 advocated for that. And cutting out the code is a net win for the codebase, so I'd rather do it now than later. --Ray ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
On Fri, 2015-01-30 at 23:10 +0100, Antoine Jacoutot wrote: On Fri, Jan 30, 2015 at 02:25:20PM -0500, Ray Strode wrote: Hey, I'm wondering if there are distros/platforms that are planning on using 3.16 and ConsoleKit together. I know there's LoginKit, systemd-shim and systembsd now that try to provide logind compatible interfaces for non-systemd systems, so I'd really like to get rid of the ConsoleKit code in GDM. The code is complicated and not really tested. I'm leaning toward getting rid of it in 3.16 (versus say 3.18). Distros, of course, could ship a patch to reverse to removal if necessary, so I don't think doing it for 3.16 should be too controversial, but I wanted to shoot a mail first anyway to gauge the reaction. Hi Ray. Thanks a lot asking about this. OpenBSD *will* keep using ConsoleKit for 3.16. I expect that we should be able to be rid of it for 3.18 -- either using systembsd (far from ready) or the logind implementation that ConsoleKit2 is expected to provide iirc or ... something else. There are several other components of GNOME that still have some ConsoleKit support (at least in 3.14) and I would not mind removing such support for 3.16 if and only if reverting the removal is easy and not too intrusive. Not that I have a big say about it but... Hello Ray, FreeBSD will also be using ConsoleKit for 3.16. Antoine pretty much said everything that goes for us already. -Koop ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Anyone going to be using ConsoleKit for 3.16 ?
Hey, I'm wondering if there are distros/platforms that are planning on using 3.16 and ConsoleKit together. I know there's LoginKit, systemd-shim and systembsd now that try to provide logind compatible interfaces for non-systemd systems, so I'd really like to get rid of the ConsoleKit code in GDM. The code is complicated and not really tested. I'm leaning toward getting rid of it in 3.16 (versus say 3.18). Distros, of course, could ship a patch to reverse to removal if necessary, so I don't think doing it for 3.16 should be too controversial, but I wanted to shoot a mail first anyway to gauge the reaction. Thoughts? Ray ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
Re: Anyone going to be using ConsoleKit for 3.16 ?
On Fri, Jan 30, 2015 at 02:25:20PM -0500, Ray Strode wrote: Hey, I'm wondering if there are distros/platforms that are planning on using 3.16 and ConsoleKit together. I know there's LoginKit, systemd-shim and systembsd now that try to provide logind compatible interfaces for non-systemd systems, so I'd really like to get rid of the ConsoleKit code in GDM. The code is complicated and not really tested. I'm leaning toward getting rid of it in 3.16 (versus say 3.18). Distros, of course, could ship a patch to reverse to removal if necessary, so I don't think doing it for 3.16 should be too controversial, but I wanted to shoot a mail first anyway to gauge the reaction. Hi Ray. Thanks a lot asking about this. OpenBSD *will* keep using ConsoleKit for 3.16. I expect that we should be able to be rid of it for 3.18 -- either using systembsd (far from ready) or the logind implementation that ConsoleKit2 is expected to provide iirc or ... something else. There are several other components of GNOME that still have some ConsoleKit support (at least in 3.14) and I would not mind removing such support for 3.16 if and only if reverting the removal is easy and not too intrusive. Not that I have a big say about it but... -- Antoine ___ desktop-devel-list mailing list desktop-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/desktop-devel-list
