[GitHub] [ant] arturobernalg closed pull request #160: Simplify conditions that always produces the same result.
arturobernalg closed pull request #160: URL: https://github.com/apache/ant/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg commented on pull request #160: Simplify conditions that always produces the same result.
arturobernalg commented on pull request #160: URL: https://github.com/apache/ant/pull/160#issuecomment-927323463 HI @bodewig Thank you for your response. Sorry for the 41 files. I'll close the PR and create another one keeping in mind your remarks. TY -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Release 1.10.12 of Ant?
On 19/09/21 3:30 pm, Stefan Bodewig wrote: On 2021-09-16, Stefan Bodewig wrote: On 2021-09-15, Jaikiran Pai wrote: I wanted to look into and sort out https://bz.apache.org/bugzilla/show_bug.cgi?id=65424 in this release too, but it looks like I may not be able to do that and I'm not sure how many more days I'll need to get to that issue. The coming weekend I may (or may not) find some time to lend a hand. I believe the HELPERS Hashtable (as well as others) in IntrospecitonHelper could be replaced with a ConcurrentHashMap and some synchronization could be removed if we really want to do that. Unlike some other parts of Ant we don't expose the data structures in public APIs. Actually forget the ConcurrentHashMap thought for now, I'll comment in the ticket with a more detailed answer. Thank you Stefan for reviewing this fix. I was planning to initiate a release tonight, but trying to upgrade one of the optional dependencies has shown up some interesting issue in the maven ant task (which apparently has been EOLed[1]) that we use in our fetch.xml. I'll try and sort that one out first and see what we can do there. I still hope to trigger a release this coming week. [1] https://maven.apache.org/ant-tasks/ -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #138: Update the optional dependencies
bodewig commented on pull request #138: URL: https://github.com/apache/ant/pull/138#issuecomment-927281536 @twogee the switch to jakarta.mail is not backwards compatible. I don't think we can do it that way at all. Rather we'll need to introduce a new type of Mailer and an additional jar with different dependencies, I'm afraid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #160: Simplify conditions that always produces the same result.
bodewig commented on pull request #160: URL: https://github.com/apache/ant/pull/160#issuecomment-927281071 Thank you @arturobernalg. I must admit at least I am not a friend of a pull request that touches 41 unrelated files. Some of your changes I'm not really happy with. Broadly * I don't see any harm with a redundant null check. * in your change to DirectoryScanner your change decreases readability for me. Where I could see we are passing on the fast parameter as a method argument I now see a constant and I need to figure out it is true/false because `fast` is. There are similry changes later. * in your change to Tar I don't even see why you are sure the size can never be bigger than TarConstants.MAX_SIZE :-) (and why the replacement r.size() statement is there) * the change to AncestorAnalyzer and the other bcel classes change behavior as we'd now throw on IOExceptions - see the code comment as for why the code is what it is * I don't see why you believe ZipEntry getName() can never return null. Other team members may feel different about the first two points. This is not a "failed review", please consider it a remark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig merged pull request #156: Replace Lambda with method reference.
bodewig merged pull request #156: URL: https://github.com/apache/ant/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig merged pull request #155: Simplify single assignment and avoid redundant if conditions.
bodewig merged pull request #155: URL: https://github.com/apache/ant/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #157: Performance:
bodewig commented on pull request #157: URL: https://github.com/apache/ant/pull/157#issuecomment-927263551 Thank you @arturobernalg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig merged pull request #157: Performance:
bodewig merged pull request #157: URL: https://github.com/apache/ant/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #158: Replace assert by simpler but equivalent calls.
bodewig commented on pull request #158: URL: https://github.com/apache/ant/pull/158#issuecomment-927263448 thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig merged pull request #158: Replace assert by simpler but equivalent calls.
bodewig merged pull request #158: URL: https://github.com/apache/ant/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg commented on a change in pull request #155: Simplify single assignment and avoid redundant if conditions.
arturobernalg commented on a change in pull request #155:
URL: https://github.com/apache/ant/pull/155#discussion_r716157501
##
File path: src/main/org/apache/tools/ant/taskdefs/XmlProperty.java
##
@@ -404,17 +404,14 @@ public Object processNode(Node node, String prefix,
Object container) {
}
String nodeText = null;
boolean emptyNode = false;
-boolean semanticEmptyOverride = false;
-if (node.getNodeType() == Node.ELEMENT_NODE
+boolean semanticEmptyOverride = node.getNodeType() == Node.ELEMENT_NODE
&& semanticAttributes
&& node.hasAttributes()
&& (node.getAttributes().getNamedItem(VALUE) != null
-|| node.getAttributes().getNamedItem(LOCATION) != null
-|| node.getAttributes().getNamedItem(REF_ID) != null
-|| node.getAttributes().getNamedItem(PATH) != null ||
node.getAttributes()
-.getNamedItem(PATHID) != null)) {
-semanticEmptyOverride = true;
-}
+|| node.getAttributes().getNamedItem(LOCATION) != null
Review comment:
hi @bodewig
Changed.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg commented on a change in pull request #157: Performance:
arturobernalg commented on a change in pull request #157:
URL: https://github.com/apache/ant/pull/157#discussion_r716156789
##
File path: src/main/org/apache/tools/ant/taskdefs/compilers/JavacExternal.java
##
@@ -94,9 +94,8 @@ private int moveArgFileEligibleOptionsToEnd(String[]
commandLine) {
for(int i = nonArgFileOptionIdx + 1; i < commandLine.length; i++) {
if (!isArgFileEligible(commandLine[i])) {
String option = commandLine[i];
-for(int j = i - 1; j >= nonArgFileOptionIdx; j--) {
-commandLine[j + 1] = commandLine[j];
-}
+if (i - nonArgFileOptionIdx >= 0)
Review comment:
HI @bodewig
I just add the braces.
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Bug report for Ant [2021/09/26]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 5003|Opn|Blk|2001-11-21|exec task does not return after executed command f| | 6606|Opn|Enh|2002-02-21|META-BUG problems with delegating classloaders| | 7552|Opn|Cri|2002-03-28|Invalid task cache in targets | | 7712|New|Enh|2002-04-03|Provide patternset support for VSSGET task? | | 8294|New|Enh|2002-04-19|: Allow and to app| | 8866|New|Enh|2002-05-07|Signal handling in java task | | 8895|New|Enh|2002-05-08|ant and/or antcall should support forking | | 8972|New|Enh|2002-05-10|allow property expansion in property v| | 8981|New|Enh|2002-05-10|Tar task command additional features | | 9294|New|Enh|2002-05-21|[PATCH] optional/j2ee/ServerDeploy OC4J Support | | 9995|Ass|Enh|2002-06-19|MKS Source Integrity tasks| |10020|New|Enh|2002-06-19|'s dependency behaviour should be more con| |10231|New|Enh|2002-06-25|Need access to current file in SQLExec| |10283|New|Enh|2002-06-27|Add a destfile to the uptodate task | |10402|New|Enh|2002-07-02|adding the ability of html like whitespace preserv| |3|New|Enh|2002-07-24|keytool task | |11560|Opn|Enh|2002-08-08|Taskdef does not apply reverseLoader policy on sta| |12267|New|Enh|2002-09-03|Add ability to unzip into separate folders| |12292|New|Enh|2002-09-04|[PATCH] enable tag inside tar| |12334|New|Enh|2002-09-05|REQUEST: Ant task doesn't allow attachment of a bu| |12518|New|Enh|2002-09-11|Gunzip & BUnZip2 add filesets, patternsets, and ov| |12765|New|Enh|2002-09-18|"rmdir" and "deltree" patches for ftp task enhance| |12964|New|Enh|2002-09-24|ANTLR only takes one input file at a time | |13047|Inf|Enh|2002-09-26|Support for and on O| |13371|New|Enh|2002-10-07|[PATCH] Contributed new CvsExportDiff task| |13847|New|Nor|2002-10-22|pvcs task: wrong option (-r) specified for get (sh| |13934|New|Enh|2002-10-24|Translate task shouldn't load default locale prope| |13939|New|Enh|2002-10-24|Translate task should have better key matching cap| |14320|New|Enh|2002-11-06|copy fileset followsymlinks="false" does not copy | |14393|New|Enh|2002-11-08|Support use of jndi within ant| |14512|New|Enh|2002-11-13|Allow creating database connection similar to with does not spot bad symlin| |15149|New|Enh|2002-12-06|Replace task | |15244|New|Enh|2002-12-10|tar task should be able to store symbolic links as| |15430|New|Enh|2002-12-17|Enhancement to ReplaceRegExp.java | |15596|New|Enh|2002-12-21|Identity mapper in uptodate task. | |15747|New|Enh|2003-01-01|change tasks (e.g. Ant) to take urls as well as fi| |15853|New|Enh|2003-01-07|Allow to plug-in different XML Catalog resolver in| |15949|Opn|Enh|2003-01-10|please provide links to docs.xml and jakarta-site2| |16131|New|Enh|2003-01-15|not possible to suppress "BUILD SUCCESSFUL" messag| |16427|New|Enh|2003-01-26|Output return value of setLastModified/document be| |16469|New|Enh|2003-01-27|Apply task should allow parallel execution on diff| |16562|New|Enh|2003-01-29|Can not accept characters from keyboard in a thre| |16860|New|Enh|2003-02-06|Silent or Debug a single target | |16896|New|Enh|2003-02-07|Support in ProjectHelper / ProjectHelperImpl to op| |17074|New|Enh|2003-02-14|Contribution for WLSTOP | |17181|New|Nor|2003-02-18|Build fails while trying to get VSS files by label| |17372|New|Enh|2003-02-25|Enhancement of replace Task | |17742|New|Maj|2003-03-06|PVCS task generates GET with promotion group incor| |17781|New|Enh|2003-03-07|name attribute of record task is not relative to b| |17829|New|Enh|2003-03-10|Allow ejbjar task to accept nested manifest | |17850|New|Nor|2003-03-10|PVCS task dont work with promotion group | |17961|New|Enh|2003-03-13|New task to collect services from a JAR
[GitHub] [ant] arturobernalg commented on a change in pull request #158: Replace assert by simpler but equivalent calls.
arturobernalg commented on a change in pull request #158:
URL: https://github.com/apache/ant/pull/158#discussion_r716154780
##
File path: src/tests/junit/org/apache/tools/ant/util/DeweyDecimalTest.java
##
@@ -107,10 +107,10 @@ public void isGreaterThanOrEqual() {
@Test
public void equals() {
DeweyDecimal dd = new DeweyDecimal("1.2.3");
- assertFalse(dd.equals("other"));
- assertFalse(dd.equals(null));
- assertTrue(dd.equals(new DeweyDecimal("1.2.3")));
- assertTrue(dd.equals(new DeweyDecimal("1.2.3.0")));
+assertNotEquals("other", dd);
+assertNotEquals(null, dd);
Review comment:
Agree. Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
