Re: [PR] IVY-1651 Augment 'Child elements’ section of 'File System Resolver' documentation [ant-ivy]
Seros commented on PR #101: URL: https://github.com/apache/ant-ivy/pull/101#issuecomment-2133442798 Hey ^^ Just wanted to ask when we can expect this change to be merged as it seems it's the only one left for the [next version 2.5.3](https://issues.apache.org/jira/issues?jql=project%20%3D%20IVY%20AND%20fixVersion%20%3D%202.5.3) and we are eagerly waiting for the fix in https://issues.apache.org/jira/browse/IVY-1647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PR] Add checksum check to `TarEntry` [ant]
basil opened a new pull request, #210: URL: https://github.com/apache/ant/pull/210 I am migrating from Commons Compress to Ant for tar/untar functionality, since new releases of Commons Compress pull in unwanted dependencies, while new releases of Ant are self-contained. But while doing so, I noticed this missing feature in Ant, so I backported it from Commons Compress. As far as I understand it, these two projects have the same license, so this should be legal. This PR backports apache/commons-compress@811fb4e1f7cb0b87d9af62cc892ac06a413eb560 and its associated test to this repository. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] pull [ant]
jaikiran closed pull request #209: pull URL: https://github.com/apache/ant/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PR] pull [ant]
obsfeil opened a new pull request, #209: URL: https://github.com/apache/ant/pull/209 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PR] IVY-1651 Augment 'Child elements’ section of 'File System Resolver' documentation [ant-ivy]
lewismc opened a new pull request, #101: URL: https://github.com/apache/ant-ivy/pull/101 PR to address https://issues.apache.org/jira/browse/IVY-1651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] fix example documentation in manual [ant]
jaikiran merged PR #208: URL: https://github.com/apache/ant/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] fix example documentation in manual [ant]
jaikiran commented on PR #208: URL: https://github.com/apache/ant/pull/208#issuecomment-1956990993 Thank you Dave for this fix. The change looks correct to me and matches the `compilerarg` documentation of the `javac` task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PR] fix example documentation in manual [ant]
mebigfatguy opened a new pull request, #208: URL: https://github.com/apache/ant/pull/208 documentation says the attribute name for is arg, but it's value. Updated doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PR] Partial fix for IVY-1649 [ant-ivy]
mbs-c opened a new pull request, #100: URL: https://github.com/apache/ant-ivy/pull/100 The namespaces of dependencies' extra attributes were forgotten before writing them to the cache when a module descriptor was created from scratch. With this change, namespaced attributes are correctly transferred to the generated module descriptor, but the xmlns declarations still have to be specified locally on each dependency element (see IVY-1650). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PR] Add classifier to extra info [ant-ivy]
mkitti opened a new pull request, #99: URL: https://github.com/apache/ant-ivy/pull/99 Currenty ivy does not include the classifier as a key for extra information. This pull request adds classifier to the extra info key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
jaikiran merged PR #207: URL: https://github.com/apache/ant/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
tg-freigmbh commented on PR #207: URL: https://github.com/apache/ant/pull/207#issuecomment-1892275667 Ah I already made an Contribution under a different account, I am Gösen ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
jaikiran commented on PR #207: URL: https://github.com/apache/ant/pull/207#issuecomment-1892272296 Thank you for the update, looks good to me. Since you are a first time contributor to Ant, we add your name to the contributors list we maintain in the repo. Is there a specific first name, last name you want us to add you as? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
tg-freigmbh commented on code in PR #207: URL: https://github.com/apache/ant/pull/207#discussion_r1452440245 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LauncherSupport.java: ## @@ -45,14 +45,7 @@ import org.junit.platform.launcher.listeners.SummaryGeneratingListener; import org.junit.platform.launcher.listeners.TestExecutionSummary; -import java.io.File; -import java.io.IOException; -import java.io.InputStream; -import java.io.OutputStream; -import java.io.PipedInputStream; -import java.io.PipedOutputStream; -import java.io.PrintStream; -import java.io.UncheckedIOException; +import java.io.*; Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
tg-freigmbh commented on PR #207: URL: https://github.com/apache/ant/pull/207#issuecomment-1892265688 I tried, but my ide realy doesnt like that :D maybe I can do it manually on github -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
jaikiran commented on code in PR #207: URL: https://github.com/apache/ant/pull/207#discussion_r1452430883 ## src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LauncherSupport.java: ## @@ -45,14 +45,7 @@ import org.junit.platform.launcher.listeners.SummaryGeneratingListener; import org.junit.platform.launcher.listeners.TestExecutionSummary; -import java.io.File; -import java.io.IOException; -import java.io.InputStream; -import java.io.OutputStream; -import java.io.PipedInputStream; -import java.io.PipedOutputStream; -import java.io.PrintStream; -import java.io.UncheckedIOException; +import java.io.*; Review Comment: Can you undo the `*` import and use the previous existing imports plus one new for the BufferedOutputStream? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Buffer for more Speed [ant]
jaikiran commented on PR #207: URL: https://github.com/apache/ant/pull/207#issuecomment-1892256118 Hello @tg-freigmbh, very good catch. This indeed is an issue. I've added a trivial comment inline, other than that this looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PR] Buffer for more Speed [ant]
tg-freigmbh opened a new pull request, #207: URL: https://github.com/apache/ant/pull/207 I realized that running tests using ant was much slower than running them from the IDE. The culprit was the legacy-xml reporter.  Using an unbuffered Output is very slow, even if you are using an .m2 disk.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]
mfaquan commented on PR #206: URL: https://github.com/apache/ant/pull/206#issuecomment-1815320520 > looks good, thank you. We'll also need to change the manual page, which I can do myself. > > If you want to be listed in Ant's contributor's list, please let us know which name you want us to use. Thank you. No need to add me to the contributor's list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]
bodewig merged PR #206: URL: https://github.com/apache/ant/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]
bodewig commented on PR #206: URL: https://github.com/apache/ant/pull/206#issuecomment-1815261409 looks good, thank you. We'll also need to change the manual page, which I can do myself. If you want to be listed in Ant's contributor's list, please let us know which name you want us to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]
mfaquan commented on PR #206: URL: https://github.com/apache/ant/pull/206#issuecomment-1815013377 > You are correct and I don't recall why the code works the way it does. But it has done so for more than 20 years now and changing it might break existing builds. Let me suggest to introduce a `failOnError` attribute like some other tasks have - and make it default to `false` for the sake of backwards compatibility. Sounds good. For backwards compatibility, the BuildExceptions that were already being thrown won't be affected by the failOnError flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]
bodewig commented on PR #206: URL: https://github.com/apache/ant/pull/206#issuecomment-1814953625 You are correct and I don't recall why the code works the way it does. But it has done so for more than 20 years now and changing it might break existing builds. Let me suggest to introduce a `failOnError` attribute like some other tasks have - and make it default to `false` for the sake of backwards compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[PR] Throw BuildExceptions in ReplaceRegExp for IOExceptions and missing files [ant]
mfaquan opened a new pull request, #206: URL: https://github.com/apache/ant/pull/206 Currently, if an IOException occurs in ReplaceRegExp or a file is missing, the task logs the error, but does not fail. This pull request has ReplaceRegExp throw a BuildException if the task encounters an IOException or a file is missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: [PR] Bump xalan:xalan from 2.7.2 to 2.7.3 in /src/etc/poms/ant-junit [ant]
Cmac299203 commented on PR #201: URL: https://github.com/apache/ant/pull/201#issuecomment-1793953335 Awesome -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] mataha commented on pull request #205: Fix `--release` param check in bootstrap.bat
mataha commented on PR #205: URL: https://github.com/apache/ant/pull/205#issuecomment-1722502639 The pleasure is mine! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #205: Fix `--release` param check in bootstrap.bat
jaikiran commented on PR #205: URL: https://github.com/apache/ant/pull/205#issuecomment-172236 Thank you @mataha for those details. I have now merged this PR and added you (`Mateusz Kazimierczuk`) as a contributor to our contributors list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] asfgit closed pull request #205: Fix `--release` param check in bootstrap.bat
asfgit closed pull request #205: Fix `--release` param check in bootstrap.bat URL: https://github.com/apache/ant/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] mataha commented on pull request #205: Fix `--release` param check in bootstrap.bat
mataha commented on PR #205: URL: https://github.com/apache/ant/pull/205#issuecomment-1722284523 These, of course, can be run on all Windows versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] mataha commented on pull request #205: Fix `--release` param check in bootstrap.bat
mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722247407
> Hello @mataha, what you propose here looks OK to me. However, I haven't
been able to reproduce the issue that prompted this change. Is there some
specific Windows version where this can be reproduced or how did you notice
this issue?
Hello,
Try these minimal examples:
```batchfile
cmd /d /y /c "echo "public class JavacVersionCheck {}" >check.java && javac
check.java"
```
```batchfile
cmd /d /y /c "if %ERRORLEVEL% equ 0 echo Success."
```
As for how I've noticed the issue: I wanted to analyze the bootstrapping
code (having come here from [Bootstrappable
Builds](https://bootstrappable.org/best-practices.html)); as I write a lot of
Batch scripts as a result of my hobby, the quotes in `echo` struck me as a red
flag immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #205: Fix `--release` param check in bootstrap.bat
jaikiran commented on PR #205: URL: https://github.com/apache/ant/pull/205#issuecomment-1722169214 Hello @mataha, what you propose here looks OK to me. However, I haven't been able to reproduce the issue that prompted this change. Is there some specific Windows version where this can be reproduced or how did you notice this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #204: bz-66552 fix Depend task does not handle Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant Pool entry Type 17
jaikiran commented on PR #204: URL: https://github.com/apache/ant/pull/204#issuecomment-1715096911 Thank you @jmichelberger for this patch, this looks OK to me and I've now merged it and I have added you to our contributors list. The patch doesn't have a test case, I'm guessing that you were however able to test these changes manually against the original project that you ran into an issue with. Is that right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] asfgit closed pull request #204: bz-66552 fix Depend task does not handle Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant Pool entry Type 17
asfgit closed pull request #204: bz-66552 fix Depend task does not handle Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant Pool entry Type 17 URL: https://github.com/apache/ant/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jmichelberger opened a new pull request, #204: bz-66552 fix Depend task does not handle Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant Pool entry Type 17
jmichelberger opened a new pull request, #204: URL: https://github.com/apache/ant/pull/204 In cases the Depend task scans a class file with Constant Pool entry Type 17 there was no handling, just fireing an Exception. Constant is defined since JDK11, and format is same as InvokeDynamic Type 18. Provide Identical handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran closed pull request #203: bz-67082 fix unintended trimmed string output by pathconvert
jaikiran closed pull request #203: bz-67082 fix unintended trimmed string output by pathconvert URL: https://github.com/apache/ant/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #203: bz-67082 fix unintended trimmed string output by pathconvert
jaikiran commented on PR #203: URL: https://github.com/apache/ant/pull/203#issuecomment-1710984197 Hello Sebastian, thank you for reporting this issue and providing a fix that too with a test case. This is a very well done patch. I've merged this and also included your name in our contributors list. The merged commit is https://github.com/apache/ant/commit/f3796ab1af7c6481553b758962cf7286099aaa67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] sratz opened a new pull request, #203: bz-67082 fix unintended trimmed string output by pathconvert
sratz opened a new pull request, #203: URL: https://github.com/apache/ant/pull/203 PropertyOutputStream by default trims output. This is undesired in the use case. Explicitly set it to false. Fixes regression introduced in 1.10.13 / 90ed3ff6cca8634e38d7c3c82858ce48c9c4be2b. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] stevenschlansker commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
stevenschlansker commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1680938966 Thank you very much :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jaikiran commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1680564559 Ant 1.10.14 (containing this change) is in voting phase if you would like to try it https://lists.apache.org/thread/th6yrxc4dtpqhc2vnzmrd7d9b881hk4g -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] dependabot[bot] closed pull request #202: Bump xalan:xalan from 2.7.2 to 2.7.3 in /src/etc/poms/ant-apache-xalan2
dependabot[bot] closed pull request #202: Bump xalan:xalan from 2.7.2 to 2.7.3 in /src/etc/poms/ant-apache-xalan2 URL: https://github.com/apache/ant/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] dependabot[bot] commented on pull request #202: Bump xalan:xalan from 2.7.2 to 2.7.3 in /src/etc/poms/ant-apache-xalan2
dependabot[bot] commented on PR #202: URL: https://github.com/apache/ant/pull/202#issuecomment-1680152807 Looks like xalan:xalan is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #122: Bugfix/catch dynamic test before each
jaikiran commented on PR #122: URL: https://github.com/apache/ant/pull/122#issuecomment-1676403559 Hello Marc, sorry this took this long. I saw this PR again this week and what you raise here is a valid bug. I've pushed a commit which should address this and should be available in our upcoming Ant 1.10.14 release. Please continue to raise any other issues you might see in this task or Ant in general. Sorry again about the delay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] asfgit closed pull request #122: Bugfix/catch dynamic test before each
asfgit closed pull request #122: Bugfix/catch dynamic test before each URL: https://github.com/apache/ant/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] dependabot[bot] opened a new pull request, #202: Bump xalan:xalan from 2.7.2 to 2.7.3 in /src/etc/poms/ant-apache-xalan2
dependabot[bot] opened a new pull request, #202: URL: https://github.com/apache/ant/pull/202 Bumps xalan:xalan from 2.7.2 to 2.7.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/ant/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] dependabot[bot] opened a new pull request, #201: Bump xalan:xalan from 2.7.2 to 2.7.3 in /src/etc/poms/ant-junit
dependabot[bot] opened a new pull request, #201: URL: https://github.com/apache/ant/pull/201 Bumps xalan:xalan from 2.7.2 to 2.7.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/ant/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran closed pull request #121: use displayName instead of legacyReportingName in xml reports
jaikiran closed pull request #121: use displayName instead of legacyReportingName in xml reports URL: https://github.com/apache/ant/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #121: use displayName instead of legacyReportingName in xml reports
jaikiran commented on PR #121: URL: https://github.com/apache/ant/pull/121#issuecomment-1675840459 I'll go ahead and close this PR since this was already delivered in Ant 1.10.10 release as part of https://bz.apache.org/bugzilla/show_bug.cgi?id=64564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #121: use displayName instead of legacyReportingName in xml reports
jaikiran commented on PR #121:
URL: https://github.com/apache/ant/pull/121#issuecomment-1675840246
Hello Vincent @don-vip,
> Can we please get the same output as JUnit 4?
Test.testMethod[displayedName]
I had forgottent about this. But now that I went backed and looked at it,
this should be easily customized using the `@ParameterizedTest`s `name`
attribute. I have now added an example to Ant testsuite to show how it's done.
See this
https://github.com/apache/ant/blob/master/src/tests/junit/org/example/junitlauncher/jupiter/JupiterSampleTest.java#L80
which uses:
```java
@ParameterizedTest(name = "{displayName} asserting {0} is an even
number")
...
void testEvenFails(final int val) {
```
and then in the junitlauncher's task:
```xml
...
...
```
which then reports the test as:
https://github.com/apache/ant/assets/143523/b937c32c-7ac2-4264-bd0d-9a3bfe90f1a9;>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jglick closed pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jglick closed pull request #200: Do not treat failure of `System.setSecurityManager` as fatal URL: https://github.com/apache/ant/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jglick commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jglick commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1675085764 Looks like this is indeed superseded by 689b6ea90ee1fbad580a437137d80609c9336f12 in particular. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jaikiran commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1673554885 Hello Jesse and Steven, I've pushed some commits to master branch which reverts all the complex/brittle workarounds we had added in Ant 1.10.13 to keep using SecurityManager. A fresh set of commits have now been made to not use SecurityManager in Ant in Java 18+ versions (Java 18 is the first release which by defaults disallows setting the SecurityManager). If anyone of you builds Ant from source using recent Java versions, please go ahead and build it and try it out against your projects. I'll run some more final tests tomorrow and send out a mail to Ant dev mailing list about these changes and requesting everyone to start testing their projects with these changes. I think you can now close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jglick commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jglick commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1634629922 > it would anyway require an Ant release Yes, and then for `spotbugs-maven-plugin` to update to that release and cut its own release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jaikiran commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1633402124 Hello Jesse, > > are you running these tests by building Ant from source? > > @jaikiran why would you ask that? [#200 (comment)](https://github.com/apache/ant/pull/200#issuecomment-1631658175) The reason I asked that question was to see if I should just go ahead and push this PR to master so that Steven could benefit from using the Ant version he builds from source to temporarily get past the issue he's running into. Instead of waiting for my bigger change. If Steven isn't using Ant built from source, then merging this wouldn't be of use to them since it would anyway require an Ant release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] stevenschlansker commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
stevenschlansker commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1633231279 No, I am running the latest spotbugs-maven-plugin release, which uses Ant as a library. The problem only manifests if you disable forking in the plugin configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jglick commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jglick commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1632843378 > are you running these tests by building Ant from source? @jaikiran why would you ask that? https://github.com/apache/ant/pull/200#issuecomment-1631658175 reports an error that looks identical to that long reported in https://github.com/spotbugs/spotbugs-maven-plugin/issues/423 [using an Ant release](https://github.com/spotbugs/spotbugs-maven-plugin/blob/e8d61beed8f78772d3ed764f1542f98fffec1bc9/pom.xml#L177). Perhaps I am missing something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant-ivy] didiksupriadi41 closed pull request #97: Remove unused dependencies
didiksupriadi41 closed pull request #97: Remove unused dependencies URL: https://github.com/apache/ant-ivy/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jaikiran commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1631739432 Sorry everyone, my testing with the changes I have is taking longer than expected. @stevenschlansker, are you running these tests by building Ant from source? If yes, then I'll go ahead and merge this PR since that will help your case for the time being. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg closed pull request #165: Use object equals instead of ==, which does a character-by-character comparison when the strings are different objects
arturobernalg closed pull request #165: Use object equals instead of ==, which does a character-by-character comparison when the strings are different objects URL: https://github.com/apache/ant/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] arturobernalg closed pull request #163: Make final var when is possible.
arturobernalg closed pull request #163: Make final var when is possible. URL: https://github.com/apache/ant/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant-ivy] apupier closed pull request #62: IVY-1572 - Check for Thread interruption while resolving resources
apupier closed pull request #62: IVY-1572 - Check for Thread interruption while resolving resources URL: https://github.com/apache/ant-ivy/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant-ivy] apupier commented on pull request #62: IVY-1572 - Check for Thread interruption while resolving resources
apupier commented on PR #62: URL: https://github.com/apache/ant-ivy/pull/62#issuecomment-1558743234 long time without progress and no more in my scope of work. Closing. feel free to reuse my work if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] asfgit closed pull request #197: Handling forked VM timeout in a similar way to junit ant task
asfgit closed pull request #197: Handling forked VM timeout in a similar way to junit ant task URL: https://github.com/apache/ant/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1512565293 The change in this PR looks fine to me. A test can be added separately - I haven't found the time to try and help you get the test implemented/run. I'll go ahead and merge this now and will add the test later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] mabartos commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
mabartos commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1511152337 @jaikiran Hello, any progress with this issue? Or is there any workaround for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jaikiran commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1503458393 > > the work we had done in a recent release to set `java.security.manager=allow` when launching Ant > > [82c70f3](https://github.com/apache/ant/commit/82c70f3202d5aec4d99fa3b6314ba4a6c338cd94) I guess. Right, that was the one we introduced in our latest Ant release. It has caused some regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jglick commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jglick commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1503392846 > the work we had done in a recent release to set `java.security.manager=allow` when launching Ant 82c70f3 I guess. Yes I think it would be appropriate to not even attempt to call `setSecurityManager` in recent Java releases; the original use case of running a program in-JVM which calls `System.exit` is rather dubious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #200: Do not treat failure of `System.setSecurityManager` as fatal
jaikiran commented on PR #200: URL: https://github.com/apache/ant/pull/200#issuecomment-1503324250 Hello Jesse, I'm currently in the process of undoing some of the work we had done in a recent release to set `java.security.manager=allow` when launching Ant. This change has caused more than one regression plus this anyway was only a small term fix. The original idea was that we wait for the JDK side of things related to security manager discussions settle down, so that we have clarity on how to address them in Ant. It's clear that not setting the security manager in Java 18+ (instead of setting that system property) is the right way to go. I have those changes in a local branch and running some tests. It of course has its own set of challenges but we have to address those anyway since security manager is going away. With the changes I have, the proposed changes in this PR won't be necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jglick opened a new pull request, #200: Do not treat failure of `System.setSecurityManager` as fatal
jglick opened a new pull request, #200: URL: https://github.com/apache/ant/pull/200 Fixes https://github.com/spotbugs/spotbugs-maven-plugin/issues/423. When running on Java 18+, where `System.setSecurityManager` is not allowed by default, just let in-process Java execution run without a security manager. Normally this is not a big deal; it would only matter if you were running a program which actually tried to `System.exit`, which is much better handled by simply forking. Verified by applying this patch as well as ```diff diff --git src/etc/poms/ant/pom.xml src/etc/poms/ant/pom.xml index 9a96764be..b062bbe63 100644 --- src/etc/poms/ant/pom.xml +++ src/etc/poms/ant/pom.xml @@ -343,7 +343,7 @@ ../../../../src/etc/testcases -true +false ../../../../src/main ``` (without which I get errors processing various binary or non-UTF-8 test resources; is this code path no tested?) and ```bash mvnd -f src/etc/poms -am -pl ant -DskipTests install ``` and then patching `spotbugs/spotbugs-maven-plugin` with ```diff diff --git pom.xml pom.xml index 3a95e22..ca4ef56 100644 --- pom.xml +++ pom.xml @@ -160,7 +160,7 @@ 4.7.3 2.0.7 -1.10.13 +1.10.14-SNAPSHOT 4.0.11 3.25.2 ``` and ```bash mvn -DskipTests install ``` and then in `jenkinsci/scm-api-plugin` running ```bash JAVA_HOME=/usr/lib/jvm/java-19-openjdk-amd64 mvn spotbugs:check -Dspotbugs.fork=false -Dspotbugs-maven-plugin.version=4.7.3.5-SNAPSHOT -e ``` (I initially tried to write an IT in `spotbugs-maven-plugin` but failed to reproduce the error there, for reasons unknown.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] tbw777 closed pull request #198: Using static modifier to normalize methods contract and performance
tbw777 closed pull request #198: Using static modifier to normalize methods contract and performance URL: https://github.com/apache/ant/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #199: Use verbose log level for loading stylesheets
bodewig commented on PR #199: URL: https://github.com/apache/ant/pull/199#issuecomment-1446276764 https://bz.apache.org/bugzilla/show_bug.cgi?id=66496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #199: Use verbose log level for loading stylesheets
bodewig commented on PR #199: URL: https://github.com/apache/ant/pull/199#issuecomment-1446269521 I'll create a bugzilla issue to scan for Resource#toString uses. This change here is fine as it is and we don't need to clutter it with more discussion. Thank you for catching this @dreis2211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #199: Use verbose log level for loading stylesheets
jaikiran commented on PR #199: URL: https://github.com/apache/ant/pull/199#issuecomment-1446256401 Hello Stefan, > Looks as if StringResource printed its contents, but that seems wrong to me as there may be more places where code expects toString to not reveal the contents. Agreed. The `StringResource` is overriding the toString() to print the contents and that looked wrong to me too. However, it has an explicit `@since` on it so it looked to me that this might have been done intentionally for some reason. Like you say, there might be additional places we need to check where we log the `Resource.toString()` in a message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #199: Use verbose log level for loading stylesheets
bodewig commented on PR #199: URL: https://github.com/apache/ant/pull/199#issuecomment-1446249553 I wonder what kind of `Resource` this is as `Resource#toString` is expected to only print the resource's name - and this is what the code here relied on. Looks as if `StringResource` printed its contents, but that seems wrong to me as there may be more places where code expects `toString` to not reveal the contents. Having said that, using `name` rather than `toString` here (and potentially more places) is the right thing to do in any case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] asfgit closed pull request #199: Use verbose log level for loading stylesheets
asfgit closed pull request #199: Use verbose log level for loading stylesheets URL: https://github.com/apache/ant/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #199: Use verbose log level for loading stylesheets
jaikiran commented on PR #199: URL: https://github.com/apache/ant/pull/199#issuecomment-1446237933 Thank you for these changes. Looks good to me. I'll merge this shortly. Since this is your first contribution to the Ant project, I'll be adding `Christoph Dreis` to our contributors list https://github.com/apache/ant/blob/master/CONTRIBUTORS. If you prefer a different first name, last name, feel free to let us know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] dreis2211 commented on a diff in pull request #199: Use verbose log level for loading stylesheets
dreis2211 commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118662584
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
stylesheetLoaded = true;
try {
-log("Loading stylesheet " + stylesheet, Project.MSG_INFO);
+log("Loading stylesheet " + stylesheet, Project.MSG_VERBOSE);
Review Comment:
Adjusted as suggested @jaikiran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on a diff in pull request #199: Use verbose log level for loading stylesheets
jaikiran commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118656632
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
stylesheetLoaded = true;
try {
-log("Loading stylesheet " + stylesheet, Project.MSG_INFO);
+log("Loading stylesheet " + stylesheet, Project.MSG_VERBOSE);
Review Comment:
Thank you Christoph for this change. I'm surprised it was logging the
contents of the file. I think what we should probably do here is keep it at
`INFO` level but change the log message to just print the name of the resource :
```
log("Loading stylesheet " + stylesheet.getName(), Project.MSG_INFO);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] dreis2211 opened a new pull request, #199: Use verbose log level for loading stylesheets
dreis2211 opened a new pull request, #199:
URL: https://github.com/apache/ant/pull/199
Hi,
I've noticed that working with `checkstyle` via Gradle (probably using it
directly will do the same) we always see the very verbose output of the
stylesheet being loaded. Imho this is not a good fit for the current `INFO`
level.
```
[ant:xslt] Loading stylesheet http://www.w3.org/1999/XSL/Transform; version="1.0">
.bannercell {
border: 0px;
padding: 0px;
}
body {
margin-left: 10;
margin-right: 10;
font:normal 80% arial,helvetica,sanserif;
background-color:#FF;
color:#00;
}
.a td {
background: #efefef;
}
.b td {
background: #fff;
}
th, td {
text-align: left;
vertical-align: top;
}
th {
font-weight:bold;
background: #ccc;
color: black;
}
table, th, td {
font-size:100%;
border: none
}
table.log tr td, tr th {
}
h2 {
font-weight:bold;
font-size:140%;
margin-bottom: 5;
}
h3 {
font-size:100%;
font-weight:bold;
background: #525D76;
color: white;
text-decoration: none;
padding: 5px;
margin-right: 2px;
margin-left: 2px;
margin-bottom: 0;
}
CheckStyle Audit
Designed for use with CheckStyle and Ant.
Files
Name
Errors
File
Error Description
Line
Back to top
Summary
Files
Errors
a
b
```
As you can see this is really long and verbose.
I wasn't sure what the difference between debug and verbose is in the
context of Ant, but going one level down seemed to be the defensive choice.
Cheers,
Christoph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] tkowalcz commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task
tkowalcz commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1436945641 @jaikiran I'm sorry but I was unable to run the tests. After implementing your instructions the `LegacyXmlResultFormatterTest` was run but there was no mention of `JUnitLauncherTaskTest` being run. I tried investigating this on multiple fronts but still have no idea how to run it as part of the suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #198: Using static modifier to normalize methods contract and performance
bodewig commented on PR #198: URL: https://github.com/apache/ant/pull/198#issuecomment-1422055507 I must say I find it extremely difficult to properly review a PR that touches 100+ files, even if the change is supposed to be mechanical. In this case I saw a change to `Antlib.java` where a string literal was replaced by a constant defined somewhere else in the class - a place that is not visible inside the diff so I need to look up its definition elsewhere. This not only makes the review more difficult it also means I can not just scroll down the page and press merge as the set of changes obviously also contains changes not described by the headline. All in all I don't see myself being able to review this in any reasonable time frame. If you want to see this applied, please cut it into smaller chunks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] Wade-tech commented on pull request #166: Support Jakarta Mail in MailLogger
Wade-tech commented on PR #166: URL: https://github.com/apache/ant/pull/166#issuecomment-1421930331 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #166: Support Jakarta Mail in MailLogger
jaikiran commented on PR #166: URL: https://github.com/apache/ant/pull/166#issuecomment-1421877210 Hello @Wade-tech, it will be present in the ant-jakartamail artifact which is here https://repo1.maven.org/maven2/org/apache/ant/ant-jakartamail/1.10.13/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] Wade-tech commented on pull request #166: Support Jakarta Mail in MailLogger
Wade-tech commented on PR #166: URL: https://github.com/apache/ant/pull/166#issuecomment-1421837416 Thanks, JakartaMimeMailer.java use jakarta.mail . I downdload org.apache.ant-ant-1.10.13 jar(url:https://mvnrepository.com/artifact/org.apache.ant/ant/1.10.13). In this jar , not found JakartaMimeMailer.java , i'm confused  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] bodewig commented on pull request #166: Support Jakarta Mail in MailLogger
bodewig commented on PR #166: URL: https://github.com/apache/ant/pull/166#issuecomment-1421399930 https://ant.apache.org/manual/Tasks/mail.html - Ant 1.10.13. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] Wade-tech commented on pull request #166: Support Jakarta Mail in MailLogger
Wade-tech commented on PR #166: URL: https://github.com/apache/ant/pull/166#issuecomment-1420290634 Hi ,tomcat10 change javax.* namespace to jakarta.*， Does ant now support jakarta.mail? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] tkowalcz commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task
tkowalcz commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419282632 Thanks. I will give it a try and let you know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419267691 > When I build the project the tests do not seem to be executed Some of the tasks in Ant, including the `junitlauncher` aren't part of the "core". You will have to first fetch the dependencies of these tasks as follows: ``` ant -f fetch.xml -Ddest=optional ``` and then run: ``` ./build.sh clean test ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] tkowalcz commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task
tkowalcz commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419257202 Hi, actually I had problems running the tests in the first place. When I build the project the tests do not seem to be executed (build pass even when I introduce failing assertion). I can later today copy exactly which steps I made. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] [ant] jaikiran commented on pull request #197: Handling forked VM timeout in a similar way to junit ant task
jaikiran commented on PR #197: URL: https://github.com/apache/ant/pull/197#issuecomment-1419253719 Hello Tomasz, I don't want to rush you, but if writing a test is proving to be time consuming or complicated, do let me know and I'll merge this fix (which looks good to me) and I'll add a test myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
