[GitHub] ant-ivy issue #71: Ivy main/standalone: Patch to include 'makepom' function
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/71 @aanno could you please rebase and push the branch in order to close the PR? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #71: Ivy main/standalone: Patch to include 'makepom' function
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/71 @aanno, thank you for this PR. I have gone ahead and included your patch with minor modifications to upstream and also included a test along with it. I have also included your name in our release notes. Since I couldn't find your full name in your github profile, I used `aanno`, if you prefer to have your full name included in the release notes, please let me know and I'll update it accordingly. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy issue #71: Ivy main/standalone: Patch to include 'makepom' function
Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/71 @aanno Thank you for the patch. This mostly looks fine. I have added some review comments. Can you please also introduce a test case for this? Something that tests that these command options are recognized and the pom file does get created. There's a `MainTest` which you can refer to and add a new test method there. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
