[GitHub] ant-ivy pull request #22: Fix transient test failures

[jaikiran]

Github user jaikiran closed the pull request at:

https://github.com/apache/ant-ivy/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #22: Fix transient test failures

[jaikiran]

GitHub user jaikiran opened a pull request:

https://github.com/apache/ant-ivy/pull/22

Fix transient test failures

The `WarnCircularDependencyStrategyTest` fails once in a while on Jenkins. 
Looking at the testcase, it resets/updates a shared JVM level logger instance 
(via `Message.setDefaultLogger`) across test methods. Given that JUnit can run 
the test methods parallely across different testcase instances, this can (and 
indeed seems to be) run into race conditions causing the tests to fail. The 
test was also leaving around the mock message logger as the default logger even 
after the test was complete.

The commit here fixes these issues and uses a test method specific logger 
instances and doesn't share them across the test methods. The 
`IgnoreCircularDependencyStrategyTest` had a similar issue, so that's been 
included in this fix as well.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaikiran/ant-ivy logger-test-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22


commit cae1b4425d3cbc27874f4e319edb2b36ca32b589
Author: Jaikiran Pai 
Date:   2017-05-20T03:43:17Z

Fix transient test failures - Don't share/update the MockMessageLogger 
between test methods




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org