[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-23 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/8#issuecomment-95677851
  
I think this is something we should make configurable via a task attribute 
rather than hardcode new default values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



RE: [GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-23 Thread Loren Kratzke
Just my 2 cents... 

In the year 2015, a 1K buffer is quite small. It is a bottleneck. I personally 
default to using 64K buffers unless I know for a fact that I am going to be 
transferring more than 1GB in which case I bump to a 1M or larger buffer.

64K or 128K was a lot of RAM back in 1982. I was there. In 1982 a 1K buffer was 
about the right size when you had 128K of RAM. These days 1K is not useful for 
anything. Peoples time is far more valuable and far less plentiful than this 
tiny amount of RAM. 

Nobody will notice if they have 63K less free RAM for 30 seconds on a machine 
with 4GB, but they will notice when their files copy/transfer 60x faster as 
pkures has demonstrated. 1 second vs 1 minute? Increase the buffer size. Make 
it an option to have a larger (or smaller) buffer, but the default size should 
be a sensible default.

L.K.

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request:

2015-04-23 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request:


https://github.com/apache/ant/commit/1a584200e27de7867d7f613ff9c910dc0cc9730a#commitcomment-10875019
  
In manual/Tasks/tar.html:
In manual/Tasks/tar.html on line 155:
Shouldn't this be since 1.9.5?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-23 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/8#issuecomment-95691366
  
github pull requests are an option that we haven't used heavily, but it is 
fine.  The canonical aproach would have been a Bugzilla issue with attachment 
(that's what we've been telling users for years now).

Also, if you want to get involved with Ant development (welcome!), please 
join the dev mailing list.

It's more about network packet size than memory.  Maybe it's a sign of me 
being old but 100k feels a bit too big.  Are you feeling up to the task of 
adding an attribute to the scp task?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-23 Thread ajmas
Github user ajmas commented on the pull request:

https://github.com/apache/ant/pull/8#issuecomment-95704421
  
May want to look at this for a perspective: 
http://stackoverflow.com/questions/236861/how-do-you-determine-the-ideal-buffer-size-when-using-fileinputstream
 while


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-23 Thread ajmas
Github user ajmas commented on the pull request:

https://github.com/apache/ant/pull/8#issuecomment-95706031
  
Last comment got cut short. How did you come about the 100k value? Has this 
been tested on networks with smaller through put? Consider the nature of data 
packet sizes. Not saying a bad value, though just trying to play it safe. 

Making it configurable would certainly be good. Even wondering whether 
there are algorithms out there for auto tuning the buffer size?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-23 Thread pkures
Github user pkures commented on the pull request:

https://github.com/apache/ant/pull/8#issuecomment-95718851
  
I was thinking along the lines of ... the transfer speed is 1MB/s but 
theoretically on 1 Gbit network you should see up to 100MB/s transfer speed 
ideally, so I tried to increase 100 times. It's about how often Java gets a 
chance to process InputStream data and how many of those 1K packets arrive 
between OS context switches. 

Increasing the buffer size from 1K to 100K increased the transfer speed to 
75MB/s (very large file), so the buffer size really does matter a lot. I can 
look how much the InputStream read method reads in one call on average - this 
should tell us how large the buffer needs to be for gigabit network. I can also 
test over our 15Mbit link, but I'am afraid that's slowest connection I have 
available except maybe cellular internet, hmmm, maybe I can test that also.

InputStream.read - Reads up to len bytes of data from the input stream into 
an array of bytes.  

In my experience it means that on slow network the only risk is that the 
excessive buffer space will be wasted for the duration of the transfer. As it 
will not wait for the buffer to fill.

But this is really getting little bit complicated for my time constraints 
:-) Maybe just adding the attribute to override the defaul buffer size is not a 
bad option after all. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-23 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/8#issuecomment-95794438
  
I appreciate the offer of doing more research, but it's not necessary.

The argument about the ftp task made me look into the other tasks we use 
for transferring files over the network - getalso uses 100k.  I'm going to 
merge this and #9 int the next days (unless anybody else beats me to it).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-22 Thread pkures
GitHub user pkures opened a pull request:

https://github.com/apache/ant/pull/8

increase buffer size to improve transfer speed

1024 byte buffer size is insufficient for transfering large files over 
faster ( 100Mbit) networks. We are transfering files tens or hundreds MB in 
size and transfer speed was 1MB/s. After increasing the buffer size too 100KB 
we are getting transfer speeds up to 60MB/s. Please consider increasing the 
BUFFER_SIZE in the next Ant release. Thanks, Peter

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pkures/ant patch-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 815a36f52f2e1a2211b58d7eab31cdcb97709dee
Author: pkures pku...@gmail.com
Date:   2015-04-22T11:05:25Z

increase buffer size to improve transfer speed

1024 byte buffer size is insufficient for transfering large files over 
faster ( 100Mbit) networks. We are transfering files tens or hundreds MB in 
size and transfer speed was 1MB/s. After increasing the buffer size too 100KB 
we are getting transfer speeds up to 60MB/s. Please consider increasing the 
BUFFER_SIZE in the next Ant release. Thanks, Peter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-22 Thread pkures
GitHub user pkures opened a pull request:

https://github.com/apache/ant/pull/9

increase buffer size to improve transfer speed

1024 byte buffer size is insufficient for transfering large files over 
faster ( 100Mbit) networks. We are transfering files tens or hundreds MB in 
size and transfer speed was 1MB/s. After increasing the buffer size too 100KB 
we are getting transfer speeds up to 60MB/s. Please consider increasing the 
BUFFER_SIZE in the next Ant release. Thanks, Peter

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pkures/ant patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit e145abe054a01e45f56b82a97638e9357e05648e
Author: pkures pku...@gmail.com
Date:   2015-04-22T11:04:14Z

increase buffer size to improve transfer speed

1024 byte buffer size is insufficient for transfering large files over 
faster ( 100Mbit) networks. We are transfering files tens or hundreds MB in 
size and transfer speed was 1MB/s. After increasing the buffer size too 100KB 
we are getting transfer speeds up to 60MB/s. Please consider increasing the 
BUFFER_SIZE in the next Ant release. Thanks, Peter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-22 Thread ajmas
Github user ajmas commented on a diff in the pull request:

https://github.com/apache/ant/pull/8#discussion_r28864296
  
--- Diff: 
src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java ---
@@ -36,7 +36,7 @@
 public class ScpToMessage extends AbstractSshMessage {
 
 private static final int HUNDRED_KILOBYTES = 102400;
-private static final int BUFFER_SIZE = 1024;
+private static final int BUFFER_SIZE = 100*1024;
--- End diff --

Any reason you don't make BUFFER = HUNDRED_KILOBYTES, since that constant 
is defined just above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: increase buffer size to improve transfer speed

2015-04-22 Thread pkures
Github user pkures commented on a diff in the pull request:

https://github.com/apache/ant/pull/8#discussion_r28864813
  
--- Diff: 
src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java ---
@@ -36,7 +36,7 @@
 public class ScpToMessage extends AbstractSshMessage {
 
 private static final int HUNDRED_KILOBYTES = 102400;
-private static final int BUFFER_SIZE = 1024;
+private static final int BUFFER_SIZE = 100*1024;
--- End diff --

Yes it's possible, but I didn't want to tie them together. The 
HUNDRED_KILOBYTES constant is used as a progress display threshold and IMHO 
should be named PROGRESS_DISPLAY_THRESHOLD or something like that, but that is 
left for another patch ;-)  I would then increase the value of 
PROGRESS_DISPLAY_THRESHOLD to at least 1MB, on local network 100KB file is 
quite small and progress display is really unnecessary. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Ant 17 branch

2015-03-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ant/pull/7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Ant 17 branch

2015-03-02 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/7#issuecomment-76888501
  
I'm not an Eclipse use at all, so I can't help.  Maybe you should ask your 
question on the Ant user mailing list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Ant 17 branch

2015-03-02 Thread rayhanul
Github user rayhanul commented on the pull request:

https://github.com/apache/ant/pull/7#issuecomment-76885905
  
i am using Ant 1.7 to analyze the code metrics for my thesis. actually i am
new in git. i don't know much more about how to manage files in git. i can
only commit and view the history.

sorry for my faults, i will close it. would you please show me the way how
can i download the source codes of Ant and run it using Eclipse. i have
already collected the Ant's source codes but i fails to run it.

On Mon, Mar 2, 2015 at 9:39 PM, Stefan Bodewig notificati...@github.com
wrote:

 I don't understand the purpose of this PR (or #2
 https://github.com/apache/ant/pull/2), is this an accident? Please
 explain what you are trying to do or close it.

 —
 Reply to this email directly or view it on GitHub
 https://github.com/apache/ant/pull/7#issuecomment-76733818.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Ant 17 branch

2015-03-02 Thread rayhanul
GitHub user rayhanul opened a pull request:

https://github.com/apache/ant/pull/7

Ant 17 branch



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/ant ANT_17_BRANCH

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #7


commit 83d75eb313a44197ee35886e621a80660e7d34a1
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-08T17:08:13Z

create Ant 1.7.x branch as threatened


git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@554389 
13f79535-47bb-0310-9956-ffa450edef68

commit 82e98c1593d1cb01b0928557137f498b2176a1bc
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-08T17:44:44Z

branch

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@554398 
13f79535-47bb-0310-9956-ffa450edef68

commit 8a3261e0cccb31b54e498623db1afac6b5c304e2
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-17T17:53:31Z

refine retry docs

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@556990 
13f79535-47bb-0310-9956-ffa450edef68

commit cb476ccd472b3797bace6609b9402ff07a88fabb
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-17T17:55:09Z

retry

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@556993 
13f79535-47bb-0310-9956-ffa450edef68

commit df01d3a8a27c23a7d27974155e8f8e9c2552b7b1
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-17T17:58:42Z

merge concat as RC doc

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@556998 
13f79535-47bb-0310-9956-ffa450edef68

commit 2b473fb84dba9d365ad3c3f9e806f163d8bf9bd2
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-17T18:00:59Z

merge concat as RC doc

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@557000 
13f79535-47bb-0310-9956-ffa450edef68

commit 7c14fe8142acde119165f0189db1d6cf4af4b3c3
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-17T18:03:55Z

merge; document scriptcondition return value

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@557002 
13f79535-47bb-0310-9956-ffa450edef68

commit 423042570526e1ea15fcde532733d26e587f716f
Author: Peter Reilly peterrei...@apache.org
Date:   2007-07-17T18:31:53Z

Bugzilla: 42802, Modified selector doesn't update the cache if only one 
file has changed

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@557009 
13f79535-47bb-0310-9956-ffa450edef68

commit d65d675a13795110dbbb79898443235f8c0732cc
Author: Peter Reilly peterrei...@apache.org
Date:   2007-07-18T20:10:59Z

merge jar strict attribute from trunk

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@557376 
13f79535-47bb-0310-9956-ffa450edef68

commit 0041d56db57d12f326b18df39a62ef51cecfbc8e
Author: Peter Reilly peterrei...@apache.org
Date:   2007-07-20T17:13:16Z

Merge - Bugzilla: 40776 work-around for javac generics bug

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@558060 
13f79535-47bb-0310-9956-ffa450edef68

commit 2cdebc3f414e577823ce64ace0a0a4d66eb94ac3
Author: Peter Reilly peterrei...@apache.org
Date:   2007-07-20T17:40:13Z

Merge - use the StrictMode enumerated class rather than a string for the 
setStrict method

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@558068 
13f79535-47bb-0310-9956-ffa450edef68

commit 58a6a007f837228ede7f4d7ac9989e52f17d2063
Author: Peter Reilly peterrei...@apache.org
Date:   2007-07-20T17:51:12Z

merge of checkstyle changes in IntrospectionHelper

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@558074 
13f79535-47bb-0310-9956-ffa450edef68

commit fa10e1a213a6c9d1c979d46f3f3a274ab31d33c1
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-24T15:16:40Z

merge

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@559079 
13f79535-47bb-0310-9956-ffa450edef68

commit d00b35fa38a2b4c7acbc8cd9ece79c5a9af9c50e
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-24T23:04:54Z

merge; fix test to expect punct. chgs

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@559251 
13f79535-47bb-0310-9956-ffa450edef68

commit 5a95430cdab1d80db618be278b86b1e30fba66f0
Author: Matthew Jason Benson mben...@apache.org
Date:   2007-07-24T23:05:39Z

Merge fix for Bugzilla 42967.



git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_17_BRANCH@559252 

[GitHub] ant pull request: Ant 17 branch

2015-03-02 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/7#issuecomment-76733818
  
I don't understand the purpose of this PR (or #2), is this an accident?  
Please explain what you are trying to do or close it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Clean up whitespace in build.xml example

2015-03-01 Thread razzius
GitHub user razzius opened a pull request:

https://github.com/apache/ant/pull/6

Clean up whitespace in build.xml example

The original author did a good job making readable xml using the HTML 
escape syntax, but I just noticed a few stray spaces when I copied the 
build.xml to start my own project.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/razzius/ant master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit 66adc2e34619ed47772a7f5bc302bf856394b8bc
Author: Razzi Abuissa razz...@gmail.com
Date:   2015-03-02T03:38:20Z

Clean up whitespace in build.xml example




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Shuffle the test methods in the same class(for j...

2015-01-06 Thread changgengli
Github user changgengli commented on the pull request:

https://github.com/apache/ant/pull/5#issuecomment-68926469
  
Michael,

Have you got a chance to review the code?

Thanks,
Changgeng


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Shuffle the unit tests order in the same class(f...

2014-12-31 Thread changgengli
Github user changgengli commented on the pull request:

https://github.com/apache/ant/pull/5#issuecomment-68461038
  
I've add an antunit test. Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: My 194

2014-12-27 Thread mc1arke
Github user mc1arke commented on the pull request:

https://github.com/apache/ant/pull/5#issuecomment-68174716
  
Your changes look reasonable from a quick scan of them, and I'm impressed 
with the speed you made them. I'll give it a more thorough review once you've 
got some tests in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: My 194

2014-12-23 Thread mc1arke
Github user mc1arke commented on the pull request:

https://github.com/apache/ant/pull/5#issuecomment-67930586
  
Some pointers for you:
* You're introducing a runtime dependency on JUnit 4 by referencing a JUnit 
class directly. There are still users of Ant who only use JUnit 3, so JUnit 4 
classes should be loaded reflectively.
* Your method of using a random number in a comparator may work, but it 
breaks the [contract of 
comparator](http://docs.oracle.com/javase/1.5.0/docs/api/java/util/Comparator.html#compare(T,%20T))s
 being reversible (e.g. `sgn(compareTo(o1, o2) == sgn(compareTo(o2, o1))`), and 
could therefore break with future versions of Java or JUnit. You'll probably 
need to make your algorithm deterministic to overcome this, which may mean your 
method order ends up only being pseudo-random. I'm happy to discuss this point 
to help find a technical solution, since it will have the biggest outcome on 
what this feature does.
* Ideally I'd want a way to be able to re-run the suite in the order of a 
previous execution (e.g. where I'd seen a new failure that I needed to 
investigate), so would probably want a way of seeding any random numbers used 
in this solution, and have the seed reported to me during execution so I can 
replay it at a later point
* I know this is only an initial concept, but I'd want to see some tests 
that prove this feature and protect it in future changes
* Use the generics in comparator - you may not currently make use of the 
parameters passed into the `compareTo` method, but that doesn't mean someone 
wont want to in the future, and future changes shouldn't have to require 
refactoring existing code before introducing a feature.
* As you've mentioned, this would definitely need a flag to turn it on (it 
should default to off since it could break tests that only work due to the 
order they're currently being run)

Whilst I've raised a few points above, I can see merit in the concept of 
what you're doing here and think there would be value in it being progressed.

Thanks,
Michael



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: My 194

2014-12-23 Thread changgengli
Github user changgengli commented on the pull request:

https://github.com/apache/ant/pull/5#issuecomment-67999297
  
Hello Michael,

Except for some tests that prove this feature and protect it in future 
changes, all other concerns should have been addressed. 

Please let me know how do you think of it now. I should be able to work out 
the tests during holiday break.

Thanks,
Changgeng


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: My 194

2014-12-19 Thread changgengli
GitHub user changgengli opened a pull request:

https://github.com/apache/ant/pull/5

My 194

Hello,

This PR is to randomize the excution order the junit test method in the 
same class. I came to this idea during the work we are upgrading from java 6 to 
java 8. A lot of test cases were broken after upgrade because those tests are 
relying on the execution order which is changed after upgrade.

This is actually just a hack for several hours. I can rework on it after I 
get more suggestion and more understanding to ant(eg. have a parameter to turn 
it off). But first, would this be valuable for others?


Thanks,
Changgeng


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/changgengli/ant my_194

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 0f2cdee8935ac0691a91ccb680621ecdad7d8664
Author: Antoine Levy-Lambert anto...@apache.org
Date:   2014-04-30T01:25:36Z

Tagging version 1.9.4 of Ant

git-svn-id: https://svn.apache.org/repos/asf/ant/core/tags/ANT_194@1591171 
13f79535-47bb-0310-9956-ffa450edef68

commit 1c927b15af84cfce315a0ef6f4db60c7d47c2c50
Author: Antoine Levy-Lambert anto...@apache.org
Date:   2014-04-30T03:03:47Z

Tagging version 1.9.4 of Ant

git-svn-id: https://svn.apache.org/repos/asf/ant/core/tags/ANT_194@1591180 
13f79535-47bb-0310-9956-ffa450edef68

commit 94f6a699db4a61bb3b15d2c5fb0b8d8258f91968
Author: Changgeng Li c...@tango.me
Date:   2014-12-20T02:09:26Z

randomize unit test order




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: junitreport: Expose classpath and factory of int...

2014-11-27 Thread gagern
Github user gagern commented on the pull request:

https://github.com/apache/ant/pull/3#issuecomment-64760699
  
Thanks for the quick merge!

I also have [a 
patch](https://issues.apache.org/bugzilla/attachment.cgi?id=23476) lying around 
for [issue 47003](https://issues.apache.org/bugzilla/show_bug.cgi?id=47003), an 
attempt to make the core loader accessible through the `classloader` task. 
That one apparently still requires some discussion. Would a pull request be a 
suitable place for such a discussion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Improve functionality of the classloader task wh...

2014-11-27 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/4#issuecomment-64855476
  
Personally I'd prefer to have the discussion about this pull request in a 
single place - see https://issues.apache.org/bugzilla/show_bug.cgi?id=47003 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: junitreport: Expose classpath and factory of int...

2014-11-26 Thread gagern
GitHub user gagern opened a pull request:

https://github.com/apache/ant/pull/3

junitreport: Expose classpath and factory of internal XSLTProcess task.

Trying to revive [bug 
47002](https://issues.apache.org/bugzilla/show_bug.cgi?id=47002) by filing a 
pull request for it.

This patch creates the nested XSLTProcess at creation of the
AggregateTransformer, not upon execution of the transformation.  This way it
is much easier to simply wrap parts of the interface I'd like to expose,
like the new classpath and factory nested elements, but also the
existing param elements.

I haven't called XSLTProcess.init(), as the previous code didn't do that
either.  I don't fully understand the difference between init() and a
constructor, but it might be a good thing to init the task somewhere.

The approach I chose is something like a whitelist delegation: the
XSLTProcess is a private member, and only selected methods of its interface
are wrapped and thus exposed to be configured.  As an alternative, one could
do something like a blacklist delegation by deriving a class from
XSLTProcess and forbidding access to certain settings by ovverriding the
corresponding methods and throwing exceptions therein.  In that case, one
might even turn the class derived from XSLTProcess into a nested xslt
element, which would be probably much clearer, as it would be configured in
the same way that a top-level xslt task is.  I didn't choose this approach
in my patch for now.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gagern/ant 47002-junitreport-classpath

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3


commit 95ea95ce56b27a68660a04bcfa8abde2add0dcf3
Author: Martin von Gagern martin.vgag...@gmx.net
Date:   2014-11-26T12:50:50Z

junitreport: Expose classpath and factory of internal XSLTProcess task.

This patch creates the nested XSLTProcess at creation of the
AggregateTransformer, not upon execution of the transformation.  This way it
is much easier to simply wrap parts of the interface I'd like to expose,
like the new classpath and factory nested elements, but also the
existing param elements.

I haven't called XSLTProcess.init(), as the previous code didn't do that
either.  I don't fully understand the difference between init() and a
constructor, but it might be a good thing to init the task somewhere.

The approach I chose is something like a whitelist delegation: the
XSLTProcess is a private member, and only selected methods of its interface
are wrapped and thus exposed to be configured.  As an alternative, one could
do something like a blacklist delegation by deriving a class from
XSLTProcess and forbidding access to certain settings by ovverriding the
corresponding methods and throwing exceptions therein.  In that case, one
might even turn the class derived from XSLTProcess into a nested xslt
element, which would be probably much clearer, as it would be configured in
the same way that a top-level xslt task is.  I didn't choose this approach
in my patch for now.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: junitreport: Expose classpath and factory of int...

2014-11-26 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ant/pull/3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: junitreport: Expose classpath and factory of int...

2014-11-26 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/3#issuecomment-64702076
  
Thanks!

One of the tests failed, after I merged your commit - I fixed the test as 
it didn't work the way Ant would create the corresponding task anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Update runant.py

2014-11-18 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/1#issuecomment-63479967
  
OK, I think I get that.  So it is not as much about long paths but rather 
paths with spaces in them.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Update runant.py

2014-11-18 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/1#issuecomment-63494396
  
I've taken the liberty and only committed the subset actually related to 
the path changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Update runant.py

2014-11-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ant/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Ant 18 branch

2014-11-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ant/pull/2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Update runant.py

2014-11-17 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/1#issuecomment-63274385
  
I'm not familiar with how Python works on Windows at all, so please bear 
with me.  How does stripping quotes and explicitly adding them later help with 
long path?

Also I don't get the os.system comment - at least you didn't change any 
usage of os.system.

The script's author-header is another issue, we've removed all author notes 
as a policy from Ant's code base but obviously missed this one.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Update runant.py

2014-11-17 Thread vit1251
Github user vit1251 commented on the pull request:

https://github.com/apache/ant/pull/1#issuecomment-63275249
  
Magic here:

-cmdline = ('%s %s -classpath %s -Dant.home=%s %s ' + \
+cmdline = ('%s %s -classpath %s -Dant.home=%s %s ' + \
 'org.apache.tools.ant.launch.Launcher %s %s %s') \
  % (JAVACMD, ANT_OPTS, LOCALCLASSPATH, ANT_HOME, OPTS, ANT_ARGS, \
 CLASSPATH, string.join(sys.argv[1:], ' '))

When JAVACMD is C:/Program Files/Java/jre_1_7_5/bin/java.exe 
os.system is call execute fileC:/Program but tht file is not found and it 
require quota.

I in my suggested patch add that quota but not tested in unix/linux ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Ant 18 branch

2014-11-01 Thread bodewig
Github user bodewig commented on the pull request:

https://github.com/apache/ant/pull/2#issuecomment-61364763
  
I don't understand this PR, is this just a mistake - if so, please close it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Ant 18 branch

2014-10-31 Thread Dele87
GitHub user Dele87 opened a pull request:

https://github.com/apache/ant/pull/2

Ant 18 branch



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/ant ANT_18_BRANCH

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2


commit 013585b343dafe07930a7648d7c28c8bcdcdb0c6
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-05T07:54:41Z

create a branch for Ant 1.8.3+

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1240672 
13f79535-47bb-0310-9956-ffa450edef68

commit 63f2a2f0dd03a567257378054c977ac8afb9553c
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-05T08:40:02Z

merge removal of starteam and weblogic references from trunk

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1240682 
13f79535-47bb-0310-9956-ffa450edef68

commit 06df14464441d050e6a6a7ca21467824ac8591c1
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-06T20:18:22Z

fix version at 1.8.3

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1241152 
13f79535-47bb-0310-9956-ffa450edef68

commit 1315875e95e9e5e9947e3685f872e95cee1f3422
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-06T21:04:42Z

merge from trunk and bump version

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1241179 
13f79535-47bb-0310-9956-ffa450edef68

commit 89b0b3d9c9f772db6d354aa5598e044b0c6caebe
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-06T21:22:58Z

missed a version to fix

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1241184 
13f79535-47bb-0310-9956-ffa450edef68

commit 15e681be7f90fd3faf899873feec6d1e08f1025f
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-07T08:51:07Z

merge test fixes from trunk

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1241379 
13f79535-47bb-0310-9956-ffa450edef68

commit f4e602947bb5640a949d004ffeaff62d4f9d995f
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-07T15:47:58Z

merge javadoc artifact name fix from trunk

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1241499 
13f79535-47bb-0310-9956-ffa450edef68

commit a6a638b4f2e1175a09591d7bf71a8d5a11261a17
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-22T16:55:22Z

merge changes made to manual in trunk

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1292397 
13f79535-47bb-0310-9956-ffa450edef68

commit 9b6680d3fc79b59cb6d3c2ae8a9a65d3ee0fa337
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-24T05:08:56Z

Use an absolute URL for FAQ link, merge from trunk

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1293081 
13f79535-47bb-0310-9956-ffa450edef68

commit bee376a9021a920023ff60a9d8d41ec2762209b2
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-25T16:57:16Z

merge fix for regression that re-enables double expansion of properties in 
macrodef attributes.  PR 52621

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1293649 
13f79535-47bb-0310-9956-ffa450edef68

commit b449d8f2a99718d80545a2eb211addd1237fee5b
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-25T18:18:53Z

merge STATUs change

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1293660 
13f79535-47bb-0310-9956-ffa450edef68

commit 856f8db7c204eb83cbf04f70c40ee6c3ca536c87
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-25T19:16:02Z

prepare for next release candidate

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1293666 
13f79535-47bb-0310-9956-ffa450edef68

commit f1326a33a53f058e578e77d20734f969cc03f394
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-25T19:22:00Z

move branch to 1.8.4alpha again

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1293671 
13f79535-47bb-0310-9956-ffa450edef68

commit fffd46c8bb30be2e4e3f5864f570f5b08300d649
Author: Stefan Bodewig bode...@apache.org
Date:   2012-02-26T06:12:05Z

merge fix for javadoc artifact name from trunk

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1293746 
13f79535-47bb-0310-9956-ffa450edef68

commit cbf9e62519161603231d1fa821b3497b6f9c7734
Author: Stefan Bodewig bode...@apache.org
Date:   2012-03-01T19:10:02Z

merge post-release cleanup from trunk

git-svn-id: 
https://svn.apache.org/repos/asf/ant/core/branches/ANT_18_BRANCH@1295751 
13f79535-47bb-0310-9956-ffa450edef68

commit 

[GitHub] ant pull request: Update runant.py

2014-09-02 Thread vit1251
GitHub user vit1251 opened a pull request:

https://github.com/apache/ant/pull/1

Update runant.py

Resolve long path problem when starting antrun.py on Windows 7
os.system is bad idea to use

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vit1251/ant patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1


commit c600946f5d3fc7032538ed5bb6e0a992758a7c5e
Author: Vitold S vit1...@gmail.com
Date:   2014-09-02T21:08:02Z

Update runant.py

Resolve long path problem when starting antrun.py on Windows 7
os.system is bad idea to use




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: [Trunk] Add a quiet attribute to GetTask to ea...

2014-03-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ant/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: typofixes

2014-03-01 Thread vlajos
Github user vlajos closed the pull request at:

https://github.com/apache/ant/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: typofixes

2014-02-28 Thread vlajos
GitHub user vlajos opened a pull request:

https://github.com/apache/ant/pull/4

typofixes

Typo fixes. Mostly non living code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vlajos/ant typofixes-20140218

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit e20c3d332d63dd73d6c132aa6f64cc8ad8c54239
Author: Lajos Veres vla...@gmail.com
Date:   2014-02-28T15:37:13Z

typofixes - https://github.com/vlajos/misspell_fixer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request: Typofixes

2014-02-28 Thread vlajos
Github user vlajos closed the pull request at:

https://github.com/apache/ant/pull/3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



<    1   2   3   4