Re: [PATCH]: Fix column name memory allocation for SQLite3
Quoting Garrett Rooney [EMAIL PROTECTED]: Just committed the column names patch to trunk, and will look at the bounds checking stuff when I get a chance. I've forgotten to ask... Any objections to having these two fixes in 1.2.x? -- Bojan
Re: [PATCH]: Fix column name memory allocation for SQLite3
On 3/14/06, Bojan Smojver [EMAIL PROTECTED] wrote: Quoting Garrett Rooney [EMAIL PROTECTED]: Just committed the column names patch to trunk, and will look at the bounds checking stuff when I get a chance. I've forgotten to ask... Any objections to having these two fixes in 1.2.x? Nope, just haven't gotten around to merging them yet. Will try to get to it tonight. -garrett
Re: [PATCH]: Fix column name memory allocation for SQLite3
Quoting Garrett Rooney [EMAIL PROTECTED]: Will try to get to it tonight. Legend! Thanks heaps. -- Bojan
Re: [PATCH]: Fix column name memory allocation for SQLite3
On 3/14/06, Bojan Smojver [EMAIL PROTECTED] wrote: Quoting Garrett Rooney [EMAIL PROTECTED]: Will try to get to it tonight. And it turns out I actually did do it, see r385977 and r385976. Legend! Thanks heaps. No problem. -garrett
Re: [PATCH]: Fix column name memory allocation for SQLite3
On Tue, 2006-03-14 at 22:18 -0800, Garrett Rooney wrote: And it turns out I actually did do it, see r385977 and r385976. Apologies for wasting your time :-( -- Bojan
Re: [PATCH]: Fix column name memory allocation for SQLite3
On 3/14/06, Bojan Smojver [EMAIL PROTECTED] wrote: On Tue, 2006-03-14 at 22:18 -0800, Garrett Rooney wrote: And it turns out I actually did do it, see r385977 and r385976. Apologies for wasting your time :-( No, I meant I did it tonight, as opposed to forgetting about it and needing you to remind me weeks from now ;-) -garrett
Re: [PATCH]: Fix column name memory allocation for SQLite3
On 3/7/06, Bojan Smojver [EMAIL PROTECTED] wrote: Quoting Bojan Smojver [EMAIL PROTECTED]: This patch fixes memory allocation problems with column names in both 1.2.2 and trunk. It compiled fine on FC4. Just being a pest... What are the chances of this patch and the bounds checking patch for SQLite2/3 being applied to 1.2.x and trunk? Sorry, I've been meaning to look at these and just hadn't gotten around to it. Just committed the column names patch to trunk, and will look at the bounds checking stuff when I get a chance. BTW, does the column names stuff need to be fixed in the sqlite2 implementation as well? -garrett
Re: [PATCH]: Fix column name memory allocation for SQLite3
Quoting Garrett Rooney [EMAIL PROTECTED]: Just committed the column names patch to trunk, and will look at the bounds checking stuff when I get a chance. Thanks. BTW, does the column names stuff need to be fixed in the sqlite2 implementation as well? It shouldn't need fixing, because sqlite2 calls sqlite_get_table, which preallocates memory for the whole result using malloc, which then includes column names too. Sqlite3 driver uses different logic to build results, so it needed column names allocation fix. -- Bojan
Re: [PATCH]: Fix column name memory allocation for SQLite3
On 3/8/06, Bojan Smojver [EMAIL PROTECTED] wrote: BTW, does the column names stuff need to be fixed in the sqlite2 implementation as well? It shouldn't need fixing, because sqlite2 calls sqlite_get_table, which preallocates memory for the whole result using malloc, which then includes column names too. Sqlite3 driver uses different logic to build results, so it needed column names allocation fix. Excellent, just wanted to make sure. -garrett
Re: [PATCH]: Fix column name memory allocation for SQLite3
Quoting Bojan Smojver [EMAIL PROTECTED]: This patch fixes memory allocation problems with column names in both 1.2.2 and trunk. It compiled fine on FC4. Just being a pest... What are the chances of this patch and the bounds checking patch for SQLite2/3 being applied to 1.2.x and trunk? -- Bojan
