Re: upgrade guava on trunk before 9/1?
Hi, Change logs are on Github releases page. It seems like only hash flooding protection which is added to ImmutableMap is relevant to Cassandra code. I haven’t checked whether we use deprecated APIs. But there isn’t much on table from what I see. Salih On 15 Aug 2018 17:55 +0300, Ariel Weisberg , wrote: > Hi, > > They don't even do release notes after 23. Also no API diffs. I mean I'm fine > with it, but it's mostly just changing to another arbitrary version that > won't match what is in apps. > > Ariel > > On Wed, Aug 15, 2018, at 10:48 AM, Jason Brown wrote: > > Hey Ariel, > > > > Tbqh, not that much. I was mostly thinking from the "I have conflicts on > > guava versions in my app because I pull in cassandra and XYZ libraries, and > > the transitive dependencies on guava use different versions" POV. Further, > > we'll be on this version of guava for 4.0 for at least two years from now. > > > > As I asked, "does anybody feeling strongly?". Personally, I'm sorta +0 to > > +0.5, but I was just throwing this out there in case someone does really > > think it best we upgrade (and wants to make a contribution). > > > > -Jason > > > > > > > > > > On Wed, Aug 15, 2018 at 7:25 AM, Ariel Weisberg wrote: > > > > > Hi, > > > > > > What do we get from Guava in exchange for upgrading? > > > > > > Ariel > > > > > > On Wed, Aug 15, 2018, at 10:19 AM, Jason Brown wrote: > > > > Hey all, > > > > > > > > Does anyone feel strongly about upgrading guava on trunk before the 9/1 > > > > feature freeze for 4.0? We are currently at 23.3 (thanks to > > > > CASSANDRA-13997), and the current is 26.0. > > > > > > > > I took a quick look, and there's about 17 compilation errors. They fall > > > > into two categories, both of which appear not too difficult to resolve > > > > (I > > > > didn't look too closely, tbh). > > > > > > > > If anyone wants to tackle this LHF I can rustle up some review time. > > > > > > > > Thanks, > > > > > > > > -Jason > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > For additional commands, e-mail: dev-h...@cassandra.apache.org >
Re: upgrade guava on trunk before 9/1?
Hi, They don't even do release notes after 23. Also no API diffs. I mean I'm fine with it, but it's mostly just changing to another arbitrary version that won't match what is in apps. Ariel On Wed, Aug 15, 2018, at 10:48 AM, Jason Brown wrote: > Hey Ariel, > > Tbqh, not that much. I was mostly thinking from the "I have conflicts on > guava versions in my app because I pull in cassandra and XYZ libraries, and > the transitive dependencies on guava use different versions" POV. Further, > we'll be on this version of guava for 4.0 for at least two years from now. > > As I asked, "does anybody feeling strongly?". Personally, I'm sorta +0 to > +0.5, but I was just throwing this out there in case someone does really > think it best we upgrade (and wants to make a contribution). > > -Jason > > > > > On Wed, Aug 15, 2018 at 7:25 AM, Ariel Weisberg wrote: > > > Hi, > > > > What do we get from Guava in exchange for upgrading? > > > > Ariel > > > > On Wed, Aug 15, 2018, at 10:19 AM, Jason Brown wrote: > > > Hey all, > > > > > > Does anyone feel strongly about upgrading guava on trunk before the 9/1 > > > feature freeze for 4.0? We are currently at 23.3 (thanks to > > > CASSANDRA-13997), and the current is 26.0. > > > > > > I took a quick look, and there's about 17 compilation errors. They fall > > > into two categories, both of which appear not too difficult to resolve (I > > > didn't look too closely, tbh). > > > > > > If anyone wants to tackle this LHF I can rustle up some review time. > > > > > > Thanks, > > > > > > -Jason > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > > For additional commands, e-mail: dev-h...@cassandra.apache.org > > > > - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
Re: upgrade guava on trunk before 9/1?
Hey Ariel, Tbqh, not that much. I was mostly thinking from the "I have conflicts on guava versions in my app because I pull in cassandra and XYZ libraries, and the transitive dependencies on guava use different versions" POV. Further, we'll be on this version of guava for 4.0 for at least two years from now. As I asked, "does anybody feeling strongly?". Personally, I'm sorta +0 to +0.5, but I was just throwing this out there in case someone does really think it best we upgrade (and wants to make a contribution). -Jason On Wed, Aug 15, 2018 at 7:25 AM, Ariel Weisberg wrote: > Hi, > > What do we get from Guava in exchange for upgrading? > > Ariel > > On Wed, Aug 15, 2018, at 10:19 AM, Jason Brown wrote: > > Hey all, > > > > Does anyone feel strongly about upgrading guava on trunk before the 9/1 > > feature freeze for 4.0? We are currently at 23.3 (thanks to > > CASSANDRA-13997), and the current is 26.0. > > > > I took a quick look, and there's about 17 compilation errors. They fall > > into two categories, both of which appear not too difficult to resolve (I > > didn't look too closely, tbh). > > > > If anyone wants to tackle this LHF I can rustle up some review time. > > > > Thanks, > > > > -Jason > > - > To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org > For additional commands, e-mail: dev-h...@cassandra.apache.org > >
Re: upgrade guava on trunk before 9/1?
Hi, What do we get from Guava in exchange for upgrading? Ariel On Wed, Aug 15, 2018, at 10:19 AM, Jason Brown wrote: > Hey all, > > Does anyone feel strongly about upgrading guava on trunk before the 9/1 > feature freeze for 4.0? We are currently at 23.3 (thanks to > CASSANDRA-13997), and the current is 26.0. > > I took a quick look, and there's about 17 compilation errors. They fall > into two categories, both of which appear not too difficult to resolve (I > didn't look too closely, tbh). > > If anyone wants to tackle this LHF I can rustle up some review time. > > Thanks, > > -Jason - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
upgrade guava on trunk before 9/1?
Hey all, Does anyone feel strongly about upgrading guava on trunk before the 9/1 feature freeze for 4.0? We are currently at 23.3 (thanks to CASSANDRA-13997), and the current is 26.0. I took a quick look, and there's about 17 compilation errors. They fall into two categories, both of which appear not too difficult to resolve (I didn't look too closely, tbh). If anyone wants to tackle this LHF I can rustle up some review time. Thanks, -Jason
