[jira] [Updated] (COCOON-2347) Make Cocoon 2.2 compatible with latest Spring Framework 4.2.x version
[ https://issues.apache.org/jira/browse/COCOON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò updated COCOON-2347: --- Description: The goal of this ticket is to make the current Cocoon TRUNK of 2.2 compatible with latest Spring Framework version. According to research and feedback in mailinglist following projects (maven modules) are affected: - cocoon-spring-configurator - cocoon-servlet-service-impl - cocoon-sitemap-impl - cocoon-pipeline-impl - cocoon-expression-api - cocoon-expression-language-impl .. Let's discuss problems, and append patches here and someone of the committers can then apply them to SVN. Original mail thread: http://markmail.org/message/kkdxrsjqoan6mhr6 SVN branches: * https://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_2_COCOON-2347 * https://svn.apache.org/repos/asf/cocoon/subprojects/cocoon-spring-configurator/branches/COCOON-2347 * https://svn.apache.org/repos/asf/cocoon/subprojects/cocoon-servlet-service-impl/branches/COCOON-2347 Jenkins job: https://builds.apache.org/job/Cocoon 2.2 was: The goal of this ticket is to make the current Cocoon TRUNK of 2.2 compatible with latest Spring Framework version. According to research and feedback in mailinglist following projects (maven modules) are affected: - cocoon-spring-configurator - cocoon-servlet-service-impl - cocoon-sitemap-impl - cocoon-pipeline-impl - cocoon-expression-api - cocoon-expression-language-impl .. Let's discuss problems, and append patches here and someone of the committers can then apply them to SVN. Original mail thread: http://markmail.org/message/kkdxrsjqoan6mhr6 SVN branches: * https://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_2_COCOON-2347 * https://svn.apache.org/repos/asf/cocoon/subprojects/cocoon-spring-configurator/branches/COCOON-2347 Jenkins job: https://builds.apache.org/job/Cocoon 2.2 > Make Cocoon 2.2 compatible with latest Spring Framework 4.2.x version > - > > Key: COCOON-2347 > URL: https://issues.apache.org/jira/browse/COCOON-2347 > Project: Cocoon > Issue Type: Improvement > Components: * Cocoon Core, - Components: Sitemap, - Expression > language, - Servlet service framework >Affects Versions: 2.2 >Reporter: Gabriel Gruber > Attachments: AbstractElementParser.java.patch, > AbstractTestCase.java.patch, BeanMapElementParser.java.patch, > BridgeElementParser.java.patch, CallScope.java.patch, > MockRequestAttributes.java.patch, MultiMap.java, MultiValueMap.java, > ObjectModel.java.patch, ObjectModelImpl.java.patch, > PipelineComponentInfoInitializerDecorator.java.patch, > PipelineComponentScope.java.patch, ServletDecorator.java.patch, > ServletScope.java.patch, SitemapElementParser.java.patch, > SourceResource.java.patch, WildcardBeanMap.java.patch > > > The goal of this ticket is to make the current Cocoon TRUNK of 2.2 compatible > with latest Spring Framework version. > According to research and feedback in mailinglist following projects (maven > modules) are affected: > - cocoon-spring-configurator > - cocoon-servlet-service-impl > - cocoon-sitemap-impl > - cocoon-pipeline-impl > - cocoon-expression-api > - cocoon-expression-language-impl > .. > Let's discuss problems, and append patches here and someone of the committers > can then apply them to SVN. > Original mail thread: http://markmail.org/message/kkdxrsjqoan6mhr6 > SVN branches: > * https://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_2_COCOON-2347 > * > https://svn.apache.org/repos/asf/cocoon/subprojects/cocoon-spring-configurator/branches/COCOON-2347 > * > https://svn.apache.org/repos/asf/cocoon/subprojects/cocoon-servlet-service-impl/branches/COCOON-2347 > Jenkins job: https://builds.apache.org/job/Cocoon 2.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Cocoon 2.2 with Java 8 and Spring Framework 4.2?
Hi all,
I have applied almost all provided patches to
* https://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_2_COCOON-2347
*
https://svn.apache.org/repos/asf/cocoon/subprojects/cocoon-spring-configurator/branches/COCOON-2347
*
https://svn.apache.org/repos/asf/cocoon/subprojects/cocoon-servlet-service-impl/branches/COCOON-2347
With respect to the patches attached to COCOON-2347, I had no need to
mess with MultiMap and MultiValueMap
FYI I am building with latest JDK 1.6 from Oracle (as said, we will
handle the Java 8 compatibility later).
As you can see by yourself, when building from BRANCH_2_2_COCOON-2347,
we have the following failures - as expected:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test)
on project cocoon-core: There are test failures.
[ERROR]
[ERROR] Please refer to
/home/ilgrosso/work/cocoon/2_2_COCOON-2347/core/cocoon-core/target/surefire-reports
for the individual test results.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test)
on project cocoon-servlet-service-components: There are test failures.
[ERROR]
[ERROR] Please refer to
/home/ilgrosso/work/cocoon/2_2_COCOON-2347/core/cocoon-servlet-service/cocoon-servlet-service-components/target/surefire-reports
for the individual test results.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal
org.apache.cocoon:cocoon-maven-plugin:1.0.0-M3:rcl (default) on project
cocoon-it: Execution default of goal
org.apache.cocoon:cocoon-maven-plugin:1.0.0-M3:rcl failed: Can't deploy
'/home/ilgrosso/work/cocoon/2_2_COCOON-2347/core/cocoon-core/target/classes'.
/home/ilgrosso/work/cocoon/2_2_COCOON-2347/core/cocoon-core/target/classes
(Is a directory) -> [Help 2]
[ERROR] Failed to execute goal
org.apache.cocoon:cocoon-maven-plugin:1.0.0-M3:rcl (rcl) on project
cocoon-welcome: Execution rcl of goal
org.apache.cocoon:cocoon-maven-plugin:1.0.0-M3:rcl failed: Can't deploy
'/home/ilgrosso/work/cocoon/2_2_COCOON-2347/core/cocoon-core/target/classes'.
/home/ilgrosso/work/cocoon/2_2_COCOON-2347/core/cocoon-core/target/classes
(Is a directory) -> [Help 2]
This is where I am looking forward for Javier's intervention :-)
Regards.
On 28/10/2015 09:39, Francesco Chicchiriccò wrote:
Hi Gabriel,
thanks again for your patches: see
https://issues.apache.org/jira/browse/COCOON-2347?focusedCommentId=14977966=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14977966
for an update.
May I ask you if you have already sent an ICLA to cover your contribution?
http://www.apache.org/licenses/#clas
Thanks.
Regards.
On 27/10/2015 17:59, Gabriel Gruber wrote:
One thing I forgot: it would be really nice to centralize the spring
version in a property within in the parent pom like this:
...
org.springframework
spring-_aop_
${spring-version}
_avalon_-framework
_avalon_-framework
_logkit_
_logkit_
...
4.2.2.RELEASE
...
Then being able to easily switch between versions.
Mit freundlichen Grüssen / Best regards,
Mag. Gabriel Gruber
Geschäftsführung
*/Workflow EDV Gesm.b.H./*
A-1030 Wien, Dannebergplatz 6/23
phone: +43 - 1 - 7188842 22
fax: +43 - 1 - 7188842 30
mobile: +43 - 676 - 3939435
mailto:gabriel.gru...@workflow.at
https://personalwolke.at
To: dev@cocoon.apache.org
Date: 27.10.2015 17:53
Subject: Re: Cocoon 2.2 with Java 8 and Spring Framework 4.2?
yes, I just use this:
mvn clean install -fn
Using following infrastructure on windows:
- maven 3.3.3
- JDK 1.8.0_51
The -fn (fail never) switch gives me a nice summary at the end, which
projects were successful and where there have been failures.
greets,
Gabriel
From: Francesco Chicchiriccò
To: dev@cocoon.apache.org
Date: 27.10.2015 17:42
Subject: Re: Cocoon 2.2 with Java 8 and Spring Framework 4.2?
On 27/10/2015 16:30, Gabriel Gruber wrote:
Hi Folks,
I was able to compile cocoon 2.2 with spring framework 4.2 and fix
all the obvious problems like
- Using RootBeanDefinition.setScope() instead of
RootBeanDefinition.setSingleton()
- finding the correct method calls after deprecated methods or
constants have been removed.
- forking the commons-collections MultiMap and MultiValueMap classes
into a util package of cooon-expression-language-api in order to make
the interface compatible with Java 8 maps (conflict in remove() method!)
- implement missing methods in PipelineComponentScope,
PipelineComponentInfoInitializerDecorator, CallScope, ServletScope,
MockRequestAttributes due to changes of Spring Superclasses
- implement missing method SourceResource.contentLength()
Cocoon 2.2 - Build # 6 - Unstable
The Apache Jenkins build system has built Cocoon 2.2 (build #6) Status: Unstable Check console output at https://builds.apache.org/job/Cocoon%202.2/6/ to view the results.
[jira] [Commented] (COCOON-2347) Make Cocoon 2.2 compatible with latest Spring Framework 4.2.x version
[ https://issues.apache.org/jira/browse/COCOON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982245#comment-14982245 ] Hudson commented on COCOON-2347: UNSTABLE: Integrated in Cocoon 2.2 #6 (See [https://builds.apache.org/job/Cocoon%202.2/6/]) [COCOON-2347] Applying provided patches + small reworks (removing deprecates and adding Override) (ilgrosso: [http://svn.apache.org/viewvc/?view=rev=1711430]) * BRANCH_2_2_COCOON-2347/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/components/pipeline/spring/PipelineComponentScope.java * BRANCH_2_2_COCOON-2347/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/components/pipeline/spring/PipelineComponentScopeHolder.java * BRANCH_2_2_COCOON-2347/core/cocoon-pipeline/cocoon-pipeline-impl/src/main/java/org/apache/cocoon/core/container/spring/pipeline/PipelineComponentInfoInitializerDecorator.java * BRANCH_2_2_COCOON-2347/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/core/container/spring/avalon/BridgeElementParser.java * BRANCH_2_2_COCOON-2347/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/core/container/spring/avalon/ConfigurationInfo.java * BRANCH_2_2_COCOON-2347/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/core/container/spring/avalon/ConfigurationReader.java * BRANCH_2_2_COCOON-2347/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/core/container/spring/avalon/SitemapElementParser.java * BRANCH_2_2_COCOON-2347/core/cocoon-sitemap/cocoon-sitemap-impl/src/main/java/org/apache/cocoon/core/container/spring/avalon/SourceResource.java * BRANCH_2_2_COCOON-2347/core/cocoon-sitemap/cocoon-sitemap-impl/src/test/java/org/apache/cocoon/AbstractTestCase.java * BRANCH_2_2_COCOON-2347/core/cocoon-sitemap/cocoon-sitemap-impl/src/test/java/org/apache/cocoon/MockWebApplicationContext.java * BRANCH_2_2_COCOON-2347/core/cocoon-sitemap/cocoon-sitemap-impl/src/test/java/org/apache/cocoon/environment/mock/MockRequestAttributes.java * BRANCH_2_2_COCOON-2347/parent/pom.xml > Make Cocoon 2.2 compatible with latest Spring Framework 4.2.x version > - > > Key: COCOON-2347 > URL: https://issues.apache.org/jira/browse/COCOON-2347 > Project: Cocoon > Issue Type: Improvement > Components: * Cocoon Core, - Components: Sitemap, - Expression > language, - Servlet service framework >Affects Versions: 2.2 >Reporter: Gabriel Gruber > Attachments: AbstractElementParser.java.patch, > AbstractTestCase.java.patch, BeanMapElementParser.java.patch, > BridgeElementParser.java.patch, CallScope.java.patch, > MockRequestAttributes.java.patch, MultiMap.java, MultiValueMap.java, > ObjectModel.java.patch, ObjectModelImpl.java.patch, > PipelineComponentInfoInitializerDecorator.java.patch, > PipelineComponentScope.java.patch, ServletDecorator.java.patch, > ServletScope.java.patch, SitemapElementParser.java.patch, > SourceResource.java.patch, WildcardBeanMap.java.patch > > > The goal of this ticket is to make the current Cocoon TRUNK of 2.2 compatible > with latest Spring Framework version. > According to research and feedback in mailinglist following projects (maven > modules) are affected: > - cocoon-spring-configurator > - cocoon-servlet-service-impl > - cocoon-sitemap-impl > - cocoon-pipeline-impl > - cocoon-expression-api > - cocoon-expression-language-impl > .. > Let's discuss problems, and append patches here and someone of the committers > can then apply them to SVN. > Original mail thread: http://markmail.org/message/kkdxrsjqoan6mhr6 > SVN branches: > * https://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_2_COCOON-2347 > * > https://svn.apache.org/repos/asf/cocoon/subprojects/cocoon-spring-configurator/branches/COCOON-2347 > * > https://svn.apache.org/repos/asf/cocoon/subprojects/cocoon-servlet-service-impl/branches/COCOON-2347 > Jenkins job: https://builds.apache.org/job/Cocoon 2.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
