Re: [math] correlation analysis with NaNs
On Thu, Nov 8, 2012 at 7:21 PM, Phil Steitz phil.ste...@gmail.com wrote: On 11/8/12 9:44 AM, Phil Steitz wrote: On 11/8/12 8:23 AM, Gilles Sadowski wrote: On Thu, Nov 08, 2012 at 05:00:52PM +0100, Thomas Neidhart wrote: On 11/08/2012 02:01 PM, Sébastien Brisard wrote: Hi, 2012/11/8 Gilles Sadowski gil...@harfang.homelinux.org: On Thu, Nov 08, 2012 at 09:39:00AM +0100, Thomas Neidhart wrote: Hi Patrick, On 11/07/2012 04:37 PM, Patrick Meyer wrote: I agree that it would be nice to have a constructor that allows you to specific the ranking algorithm only. +1 - patches welcome. As far as NaN and the Spearman correlation, maybe we should add a default strategy of NaNStrategy.FAIL so that an exception would occur if any NaN is encountered. R uses this treatment of missing data and forces users to choose how to handle it. If we implemented something like listwise or pairwise deletion it could be used in other classes too. As such, treatment of missing data should be part of a larger discussion and handled in a more comprehensive and systematic way. +1 to develop a strategy for representing how to represent and handle missing data (see below) I think this additional option makes sense, but I forward this discussion to the dev mailing list where it is better suited. I'm wary of having CM handle missing data. For one thing we'd have to define a convention to represent missing data. There is no good way to do that in Java. Using NaN for this purpose in a low-level library is not a good idea IMHO. I agree with Gilles, here. If I remember correctly, R has a special value NA, or something similar, which differs from NaN. Then, any convention might not be suitable for some user applications, which would lead such an application's developer to filter the data anyway in order to change his representation to CM's representation. Rather that calling two redundant filtering codes, I'd rather assume that CM gets a clean input on which its algorithm can operate. As usual, the input is subjected to precondition checks, and exceptions are thrown if the data is not clean enough. In summary: data validation (in the sense of discarding input) should not be done _before_ calling CM routines. +1. ok, I am now confused. First you say that CM should not be involved in data cleaning, but then you state that data validation should not be done before calling CM? May be there is a *not* too much? Yes, you are right: I wrote the opposite of what I meant. --- In summary: data validation (in the sense of discarding input) should be done _before_ calling CM routines. --- I think the proposition from Patrick was to exactly do that: throw an exception if such invalid data is encountered (NaNStrategy.FAIL). The other thing is, that the NaNStrategy.REMOVED is broken, so either we fix is or deprecate it. That we should fix. Please open a JIRA for this. I assume you are talking about the implementation in NaturalRanking. +1 [I mean (I think): If people rely on CM's removal of NaNs, we could fix it. However, if nobody could actually rely on this feature because it is broken, I'd prefer to remove it.] There are two issues here. One is specific to ranking algorithms. To be well-defined, a RankingAlgorithm needs a NaNStrategy, since the result has to be a total ordering. The NaNStrategy.REMOVED strategy is intended to represent removal of NaNs from the data to be ordered. If it is not implemented correctly in NaturalRanking or other rankings that is a bug and needs to be fixed. Sorry, I just reread Patrick's original mail. IIUC, there is nothing wrong with the implementation of NaNStrategy.REMOVED in NaturalRanking or other implemented rankings. The problem is how the Spearman's impl handles it. That is indeed a bug in Spearman's impl that should be fixed. The correct fix is to throw out the corresponding entry in the second array when REMOVED is the configured NaNStrategy. I agree with Patrick that adding .FAIL and setting that as the default is a good idea. Patches welcome. The second issue is the more general one of how to represent and handle missing data. I have always seen that as a limitation that we would eventually address on an algorithm by algorithm basis. Different algorithms can be configured to do different things when missing data are encountered. It is not always possible or desirable to preprocess the data to eliminate or impute missing data. Saying that we are just not going to deal with it is a limitation that I don't think we should impose. I am would like to hear others' ideas about good ways to model missing data in Java. Hi Phil, ok I have created three new issues: * MATH-891 * MATH-892 * MATH-893 Regarding the NaNStrategy.REMOVED, I think it will be necessary to adjust the RankingAlgorithm interface a bit. Right now, it
[GUMP@vmgump]: Project commons-io-test (in module apache-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-io-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 5 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-io-test : Apache Commons Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-io-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -WARNING- Overriding Maven settings: [/srv/gump/public/workspace/apache-commons/io/gump_mvn_settings.xml] -DEBUG- (Apache Gump generated) Apache Maven Settings in: /srv/gump/public/workspace/apache-commons/io/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/io/pom.xml -INFO- Project Reports in: /srv/gump/public/workspace/apache-commons/io/target/surefire-reports The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-io-test/gump_work/build_apache-commons_commons-io-test.html Work Name: build_apache-commons_commons-io-test (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 55 secs Command Line: /opt/maven2/bin/mvn --batch-mode --settings /srv/gump/public/workspace/apache-commons/io/gump_mvn_settings.xml test [Working Directory: /srv/gump/public/workspace/apache-commons/io] M2_HOME: /opt/maven2 - Running org.apache.commons.io.comparator.CompositeFileComparatorTest Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.164 sec Running org.apache.commons.io.comparator.DefaultFileComparatorTest Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 sec Running org.apache.commons.io.comparator.DirectoryFileComparatorTest Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.141 sec Running org.apache.commons.io.comparator.ExtensionFileComparatorTest Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.141 sec Running org.apache.commons.io.comparator.PathFileComparatorTest Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.136 sec Running org.apache.commons.io.comparator.NameFileComparatorTest Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.134 sec Running org.apache.commons.io.IOUtilsTestCase Tests run: 63, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.644 sec Running org.apache.commons.io.IOCaseTestCase Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.147 sec Running org.apache.commons.io.LineIteratorTestCase Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.246 sec Running org.apache.commons.io.FileUtilsCleanDirectoryTestCase Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec Running org.apache.commons.io.IOUtilsWriteTestCase Tests run: 53, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.414 sec Running org.apache.commons.io.FilenameUtilsWildcardTestCase Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.211 sec Running org.apache.commons.io.FileUtilsListFilesTestCase Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.158 sec Running org.apache.commons.io.FileSystemUtilsTestCase Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.304 sec Running org.apache.commons.io.DirectoryWalkerTestCaseJava4 Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.239 sec Results : Failed tests: testIO_356(org.apache.commons.io.input.CharSequenceInputStreamTest): bufferSize=10 dataSize=13: arrays first differed at element [0]; expected:65 but was:78 Tests run: 984, Failures: 1, Errors: 0, Skipped: 1 [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] There are test failures. Please refer to /srv/gump/public/workspace/apache-commons/io/target/surefire-reports for the individual test results. [INFO] [INFO] For more information, run Maven with the -e switch [INFO] [INFO] Total time: 1 minute 54 seconds [INFO] Finished at: Fri Nov 09 08:24:02 UTC 2012 [INFO] Final Memory: 37M/89M [INFO] - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/apache-commons/commons-io-test/rss.xml - Atom:
Re: [LANG] FastDateParserTest is failing
Hi Lam, thanks for your info. Can you file an issue in jira [1] and attach a patch for that? Reagrds, Benedikt [1] https://issues.apache.org/jira/ 2012/11/9 Lam nguyen phuc ruado1...@gmail.com Hi, I cloned the commons-lang repository from github and encountered a failed test in FastDateParserTest. Here is the output from junit: Testcase: testParses took 0.015 sec FAILED ja_JP 1940 G/y/M/d/h/a/E/Z America/New_York expected:Sat Feb 10 12:20:00 SGT 1940 but was:Sat Feb 10 12:00:00 SGT 1940 junit.framework.AssertionFailedError: ja_JP 1940 G/y/M/d/h/a/E/Z America/New_York expected:Sat Feb 10 12:20:00 SGT 1940 but was:Sat Feb 10 12:00:00 SGT 1940 at org.apache.commons.lang3.time.FastDateParserTest.testParses(FastDateParserTest.java:221) Digging into the test code, I found out that the format patterns (long and short forms) did not take minute into account, thus causing the test to fail in some certain locale (in this case it is the Japanese locale). Changing the patterns as follows effectively fixes the failing test: private static final String SHORT_FORMAT_NOERA = y/M/d/h/a/m/E/Z; private static final String LONG_FORMAT_NOERA = ///////; Regards, Harry
Re: [LANG] FastDateParserTest is failing
Hi Benedikt, Done. The jira case is at: https://issues.apache.org/jira/browse/LANG-852. Regards, Harry On Fri, Nov 9, 2012 at 4:34 PM, Benedikt Ritter benerit...@gmail.comwrote: Hi Lam, thanks for your info. Can you file an issue in jira [1] and attach a patch for that? Reagrds, Benedikt [1] https://issues.apache.org/jira/ 2012/11/9 Lam nguyen phuc ruado1...@gmail.com Hi, I cloned the commons-lang repository from github and encountered a failed test in FastDateParserTest. Here is the output from junit: Testcase: testParses took 0.015 sec FAILED ja_JP 1940 G/y/M/d/h/a/E/Z America/New_York expected:Sat Feb 10 12:20:00 SGT 1940 but was:Sat Feb 10 12:00:00 SGT 1940 junit.framework.AssertionFailedError: ja_JP 1940 G/y/M/d/h/a/E/Z America/New_York expected:Sat Feb 10 12:20:00 SGT 1940 but was:Sat Feb 10 12:00:00 SGT 1940 at org.apache.commons.lang3.time.FastDateParserTest.testParses(FastDateParserTest.java:221) Digging into the test code, I found out that the format patterns (long and short forms) did not take minute into account, thus causing the test to fail in some certain locale (in this case it is the Japanese locale). Changing the patterns as follows effectively fixes the failing test: private static final String SHORT_FORMAT_NOERA = y/M/d/h/a/m/E/Z; private static final String LONG_FORMAT_NOERA = ///////; Regards, Harry
[GUMP@vmgump]: Project commons-digester3 (in module apache-commons) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project commons-digester3 has an issue affecting its community integration.
This issue affects 2 projects,
and has been outstanding for 4 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-digester3 : XML to Java Object Configuration
- commons-digester3-test : Apache Commons
Full details are available at:
http://vmgump.apache.org/gump/public/apache-commons/commons-digester3/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-DEBUG- Sole jar output [commons-digester3-*[0-9T].jar] identifier set to
project name
-DEBUG- (Apache Gump generated) Apache Maven Settings in:
/srv/gump/public/workspace/apache-commons/digester/gump_mvn_settings.xml
-INFO- Failed with reason build failed
-DEBUG- Maven POM in:
/srv/gump/public/workspace/apache-commons/digester/pom.xml
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-digester3/gump_work/build_apache-commons_commons-digester3.html
Work Name: build_apache-commons_commons-digester3 (Type: Build)
Work ended in a state of : Failed
Elapsed: 60 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings
/srv/gump/public/workspace/apache-commons/digester/gump_mvn_settings.xml
package
[Working Directory: /srv/gump/public/workspace/apache-commons/digester]
M2_HOME: /opt/maven2
-
[INFO] [remote-resources:process {execution: default}]
[INFO] [buildnumber:create {execution: default}]
[INFO] Checking for local modifications: skipped.
[INFO] Updating project files from SCM: skipped.
[INFO] Executing: /bin/sh -c cd
/srv/gump/public/workspace/apache-commons/digester/annotations-processor svn
--non-interactive info
[INFO] Working directory:
/srv/gump/public/workspace/apache-commons/digester/annotations-processor
[INFO] Storing buildNumber: ?? at timestamp: 1352455164338
[INFO] Executing: /bin/sh -c cd
/srv/gump/public/workspace/apache-commons/digester/annotations-processor svn
--non-interactive info
[INFO] Working directory:
/srv/gump/public/workspace/apache-commons/digester/annotations-processor
[INFO] Storing buildScmBranch: UNKNOWN_BRANCH
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] Copying 2 resources to META-INF
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 5 source files to
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/target/classes
[INFO] [bundle:manifest {execution: bundle-manifest}]
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/src/test/resources
[INFO] Copying 0 resource to META-INF
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 3 source files to
/srv/gump/public/workspace/apache-commons/digester/annotations-processor/target/test-classes
@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern=rss/channel)
@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern=rss/channel/image)
@org.apache.commons.digester3.annotations.rules.ObjectCreate(pattern=rss/channel/item)
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR] error: Impossible to generate class
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule:
Attempt to recreate a file for type
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule
[ERROR] error: Impossible to generate class
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule:
Attempt to recreate a file for type
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule
[INFO] 2 errors
[INFO] -
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Compilation failure
error: Impossible to generate class
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule:
Attempt to recreate a file for type
org.apache.commons.digester3.annotations.processor.GeneratedRulesModule
error:
[GUMP@vmgump]: Project commons-chain2 (in module apache-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-chain2 has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 195 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-chain2 : GoF Chain of Responsibility pattern Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole jar output [commons-chain2-*[0-9T].jar] identifier set to project name -DEBUG- Sole pom output [pom.xml] identifier set to project name -DEBUG- (Apache Gump generated) Apache Maven Settings in: /srv/gump/public/workspace/apache-commons/chain/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/chain/pom.xml -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/gump_work/build_apache-commons_commons-chain2.html Work Name: build_apache-commons_commons-chain2 (Type: Build) Work ended in a state of : Failed Elapsed: 58 secs Command Line: /opt/maven2/bin/mvn --batch-mode --settings /srv/gump/public/workspace/apache-commons/chain/gump_mvn_settings.xml package [Working Directory: /srv/gump/public/workspace/apache-commons/chain] M2_HOME: /opt/maven2 - [INFO] Building war: /srv/gump/public/workspace/apache-commons/chain/apps/cookbook-examples/target/chain-cookbook-examples-2.0-SNAPSHOT.war [INFO] [INFO] Building Apache Commons Chain :: Distribution Packages [INFO]task-segment: [package] [INFO] [INFO] snapshot org.apache.commons:commons-chain2-configuration:2.0-SNAPSHOT: checking for updates from apache.snapshots Downloading: http://localhost:8192/repo/m2-snapshot-repository/org/apache/commons/commons-chain2-configuration/2.0-SNAPSHOT/commons-chain2-configuration-2.0-SNAPSHOT.pom [INFO] Unable to find resource 'org.apache.commons:commons-chain2-configuration:pom:2.0-SNAPSHOT' in repository apache.snapshots (http://repository.apache.org/snapshots) Downloading: http://localhost:8192/repo/m2-snapshot-repository/org/apache/commons/commons-chain2-configuration/2.0-SNAPSHOT/commons-chain2-configuration-2.0-SNAPSHOT.jar [INFO] Unable to find resource 'org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT' in repository apache.snapshots (http://repository.apache.org/snapshots) [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Failed to resolve artifact. Missing: -- 1) org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file -DgroupId=org.apache.commons -DartifactId=commons-chain2-configuration -Dversion=2.0-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file Alternatively, if you host your own repository you can deploy the file there: mvn deploy:deploy-file -DgroupId=org.apache.commons -DartifactId=commons-chain2-configuration -Dversion=2.0-SNAPSHOT -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id] Path to dependency: 1) org.apache.commons:commons-chain2:pom:2.0-SNAPSHOT 2) org.apache.commons:commons-chain2-configuration:jar:2.0-SNAPSHOT -- 1 required artifact is missing. for artifact: org.apache.commons:commons-chain2:pom:2.0-SNAPSHOT from the specified remote repositories: gump-central (http://localhost:8192/maven2), gump-apache.snapshots (http://localhost:8192/repo/m2-snapshot-repository) [INFO] [INFO] For more information, run Maven with the -e switch [INFO] [INFO] Total time: 57 seconds [INFO] Finished at: Fri Nov 09 11:08:05 UTC 2012 [INFO] Final Memory: 114M/241M [INFO] - To subscribe to this information via syndicated feeds: - RSS: http://vmgump.apache.org/gump/public/apache-commons/commons-chain2/rss.xml - Atom:
[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 9 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-proxy-test : Apache Commons Full details are available at: http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -WARNING- Overriding Maven settings: [/srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml] -DEBUG- (Apache Gump generated) Apache Maven Settings in: /srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml -INFO- Failed with reason build failed -DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/proxy/pom.xml -INFO- Project Reports in: /srv/gump/public/workspace/apache-commons/proxy/target/surefire-reports The following work was performed: http://vmgump.apache.org/gump/public/apache-commons/commons-proxy-test/gump_work/build_apache-commons_commons-proxy-test.html Work Name: build_apache-commons_commons-proxy-test (Type: Build) Work ended in a state of : Failed Elapsed: 15 secs Command Line: /opt/maven2/bin/mvn --batch-mode --settings /srv/gump/public/workspace/apache-commons/proxy/gump_mvn_settings.xml test [Working Directory: /srv/gump/public/workspace/apache-commons/proxy] M2_HOME: /opt/maven2 - Running org.apache.commons.proxy.factory.util.TestMethodSignature Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec Results : Tests in error: testMethodInvocationImplementation(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter) testSerialization(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter) testMethodInterception(org.apache.commons.proxy.interceptor.TestMethodInterceptorAdapter) testInvalidHandlerName(org.apache.commons.proxy.invoker.TestXmlRpcInvoker) testMethodInvocation(org.apache.commons.proxy.invoker.TestInvocationHandlerAdapter) testInterceptorEquals(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInterceptorWithSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInvokerWithSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testProxiesWithClashingFinalMethodInSuperclass(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInvokerEquals(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testMethodInvocationClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testMethodInvocationDuplicateMethods(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testMethodInvocationImplementation(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testWithNonAccessibleTargetType(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInvokerHashCode(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInterceptorHashCode(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testBooleanInterceptorParameter(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testChangingArguments(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testCreateInterceptorProxy(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInterceptingProxyClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInterceptingProxySerializable(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInterceptorProxyWithCheckedException(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInterceptorProxyWithUncheckedException(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInvokerProxy(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInvokerProxyClassCaching(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testInvokerProxySerializable(org.apache.commons.proxy.factory.javassist.TestJavassistProxyFactory) testCreateNullObject(org.apache.commons.proxy.TestProxyUtils) testCreateNullObjectWithClassLoader(org.apache.commons.proxy.TestProxyUtils) Tests run: 179, Failures: 0, Errors: 28, Skipped: 0 [INFO] [ERROR] BUILD FAILURE [INFO] [INFO] There
[GUMP@vmgump]: Project commons-dbutils (in module apache-commons) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project commons-dbutils has an issue affecting its community integration.
This issue affects 1 projects,
and has been outstanding for 173 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-dbutils : Commons DbUtils
Full details are available at:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbutils/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-DEBUG- Sole jar output [commons-dbutils-*[0-9T].jar] identifier set to
project name
-INFO- Optional dependency mockito failed with reason build failed
-DEBUG- (Apache Gump generated) Apache Maven Settings in:
/srv/gump/public/workspace/apache-commons/dbutils/gump_mvn_settings.xml
-INFO- Failed with reason build failed
-DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/dbutils/pom.xml
-INFO- Project Reports in:
/srv/gump/public/workspace/apache-commons/dbutils/target/surefire-reports
-WARNING- No directory
[/srv/gump/public/workspace/apache-commons/dbutils/target/surefire-reports]
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbutils/gump_work/build_apache-commons_commons-dbutils.html
Work Name: build_apache-commons_commons-dbutils (Type: Build)
Work ended in a state of : Failed
Elapsed: 16 secs
Command Line: /opt/maven2/bin/mvn --batch-mode --settings
/srv/gump/public/workspace/apache-commons/dbutils/gump_mvn_settings.xml package
[Working Directory: /srv/gump/public/workspace/apache-commons/dbutils]
M2_HOME: /opt/maven2
-
1K downloaded (mockito-core-1.9.0.pom)
Downloading:
http://localhost:8192/maven2/org/hamcrest/hamcrest-all/1.1/hamcrest-all-1.1.pom
479b downloaded (hamcrest-all-1.1.pom)
Downloading:
http://localhost:8192/maven2/org/mockito/mockito-core/1.9.0/mockito-core-1.9.0.jar
Downloading:
http://localhost:8192/maven2/org/hamcrest/hamcrest-all/1.1/hamcrest-all-1.1.jar
273K downloaded (hamcrest-all-1.1.jar)
1381K downloaded (mockito-core-1.9.0.jar)
[INFO] [antrun:run {execution: javadoc.resources}]
[INFO] Executing tasks
main:
[copy] Copying 2 files to
/srv/gump/public/workspace/apache-commons/dbutils/target/apidocs/META-INF
[INFO] Executed tasks
[WARNING] The parameter expression: 'project.build.resources' used in mojo:
'process' has been deprecated. Use 'project.resources' instead.
[INFO] [remote-resources:process {execution: default}]
[INFO] [buildnumber:create {execution: default}]
[INFO] Checking for local modifications: skipped.
[INFO] Updating project files from SCM: skipped.
[INFO] Executing: /bin/sh -c cd
/srv/gump/public/workspace/apache-commons/dbutils svn --non-interactive info
[INFO] Working directory: /srv/gump/public/workspace/apache-commons/dbutils
[INFO] Storing buildNumber: ?? at timestamp: 1352461873464
[INFO] Executing: /bin/sh -c cd
/srv/gump/public/workspace/apache-commons/dbutils svn --non-interactive info
[INFO] Working directory: /srv/gump/public/workspace/apache-commons/dbutils
[INFO] Storing buildScmBranch: UNKNOWN_BRANCH
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'iso-8859-1' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/srv/gump/public/workspace/apache-commons/dbutils/src/main/resources
[INFO] Copying 2 resources to META-INF
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 29 source files to
/srv/gump/public/workspace/apache-commons/dbutils/target/classes
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/srv/gump/public/workspace/apache-commons/dbutils/src/main/java/org/apache/commons/dbutils/DbUtils.java:[334,25]
error: DriverProxy is not abstract and does not override abstract method
getParentLogger() in Driver
[INFO] 1 error
[INFO] -
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Compilation failure
/srv/gump/public/workspace/apache-commons/dbutils/src/main/java/org/apache/commons/dbutils/DbUtils.java:[334,25]
error: DriverProxy is not abstract and does not override abstract method
getParentLogger() in Driver
[INFO]
[INFO] For more information, run Maven
[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project commons-scxml-test has an issue affecting its community integration.
This issue affects 1 projects,
and has been outstanding for 178 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-scxml-test : Apache Commons
Full details are available at:
http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-WARNING- Overriding Maven settings:
[/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml]
-DEBUG- (Apache Gump generated) Apache Maven Settings in:
/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml
-INFO- Failed with reason build failed
-DEBUG- Maven POM in: /srv/gump/public/workspace/apache-commons/scxml/pom.xml
-INFO- Project Reports in:
/srv/gump/public/workspace/apache-commons/scxml/target/surefire-reports
The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-scxml-test/gump_work/build_apache-commons_commons-scxml-test.html
Work Name: build_apache-commons_commons-scxml-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -Dsimplelog.defaultlog=info
--settings
/srv/gump/public/workspace/apache-commons/scxml/gump_mvn_settings.xml test
[Working Directory: /srv/gump/public/workspace/apache-commons/scxml]
M2_HOME: /opt/maven2
-
[INFO] SimpleSCXMLListener - /s2/s2.1/e1.2
[INFO] SimpleSCXMLListener - /s2/s2.1/e1.2
[INFO] SimpleSCXMLListener - /s2/s2.1
[INFO] SimpleSCXMLListener - /s2
[INFO] SimpleSCXMLListener - transition (event = s2.1.done, cond = null, from =
/s2, to = /s3)
[INFO] SimpleSCXMLListener - /s3
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.24 sec
Running org.apache.commons.scxml.issues.Issue64Test
[INFO] SCXMLSemantics - null: Begin transition bug test ...
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SCXMLSemantics - null: somedata
[INFO] SCXMLSemantics - null: *somedata
[INFO] SimpleSCXMLListener - transition (event = show.bug, cond = null, from =
/tranbug, to = /end)
[INFO] SimpleSCXMLListener - /end
[WARN] SCXMLParser - Ignoring element misplaced in namespace
http://www.w3.org/2005/07/scxml; at
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:30:21
and digester match scxml/datamodel/misplaced
[WARN] SCXMLParser - Ignoring element foo in namespace
http://www.w3.org/2005/07/scxml; at
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:36:19
and digester match scxml/state/onentry/foo
[WARN] SCXMLParser - Ignoring element bar in namespace
http://my.foo.example/; at
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:37:22
and digester match scxml/state/onentry/bar
[WARN] SCXMLParser - Ignoring element datamodel in namespace
http://www.w3.org/2005/07/scxml; at
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:41:21
and digester match scxml/state/transition/datamodel
[WARN] SCXMLParser - Ignoring element data in namespace
http://www.w3.org/2005/07/scxml; at
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:42:41
and digester match scxml/state/transition/datamodel/data
[WARN] SCXMLParser - Ignoring element baz in namespace
http://my.foo.example/; at
file:/srv/gump/public/workspace/apache-commons/scxml/target/test-classes/org/apache/commons/scxml/issues/issue64-02.xml:49:14
and digester match scxml/baz
[INFO] SCXMLSemantics - null: Begin transition bug test ...
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SimpleSCXMLListener - /tranbug
[INFO] SCXMLSemantics - null: null
[WARN] SimpleErrorReporter - EXPRESSION_ERROR (eval(''*' + dummy'):null):
[INFO] SimpleSCXMLListener - transition (event = show.bug, cond = null, from =
/tranbug, to = /end)
[INFO] SimpleSCXMLListener - /end
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec
Results :
Failed tests:
testCustomActionCallbacks(org.apache.commons.scxml.model.CustomActionTest)
Tests run: 229, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[ERROR] BUILD FAILURE
[INFO]
Re: svn commit: r1407141 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
On Fri, Nov 9, 2012 at 1:53 AM, Jörg Schaible
joerg.schai...@scalaris.comwrote:
Hi Greg,
the pattern matches (also) a single space that gets replaced by a single
space. Therefor are most of the actual performed replacements completely
superfluous, since I expect this to be the common case. The pattern should
be something along [\\s[^ ]]\\s*.
That seems to say a whitespace character that is not a space, optionally
followed by any number of whitespace characters. Wouldn't this
necessarily preclude any block of whitespace that *does* begin with a
space? This does seem to be on the right track, however. What about:
(?: \\s|[\\s[^ ]])\\s*
This seems to do the right thing: beginning with a non-capturing group
that matches { EITHER a space followed by a whitespace character OR a
whitespace character that is not a space }, optionally followed by any
number of whitespace characters.
Matt
- Jörg
---
Betreff: svn commit: r1407141 -
/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Absender: ggregory-1odqgaof3lkdnm+yrof...@public.gmane.org
Datum: Thu, 08 Nov 2012 15:54:25 +
Newsgruppe: gmane.comp.jakarta.commons.scm
Author: ggregory
Date: Thu Nov 8 15:54:25 2012
New Revision: 1407141
URL: http://svn.apache.org/viewvc?rev=1407141view=rev
Log:
Rename private WHITESPACE_BLOCK to WHITESPACE_PATTERN.
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java?rev=1407141r1=1407140r2=1407141view=diff
==
---
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
(original)
+++
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Thu Nov 8 15:54:25 2012
@@ -144,7 +144,7 @@ public class StringUtils {
/**
* A regex pattern for recognizing blocks of whitespace characters.
*/
-private static final Pattern WHITESPACE_BLOCK =
Pattern.compile(\\s+);
+private static final Pattern WHITESPACE_PATTERN =
Pattern.compile(\\s+);
/**
* p{@code StringUtils} instances should NOT be constructed in
@@ -6472,7 +6472,7 @@ public class StringUtils {
if (str == null) {
return null;
}
-return WHITESPACE_BLOCK.matcher(trim(str)).replaceAll( );
+return WHITESPACE_PATTERN.matcher(trim(str)).replaceAll( );
}
/**
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
RE: [math] Math-817 and .equals questions. .
Any thoughts on the below email? If not, I will submit one patch, probably today or tomorrow. --- Hello, I am about to submit some code for issue Math-817 involving fitting multivariate normal mixture models using the EM algorithm. In order to simplify the unit test, I added overrode equals and hashCode. This in turn required me to make a few changes to code in the previously resolved issues Math-815 and Math-816. Am I supposed to just send one patch to 817, or am I supposed to break the patches up according to issue number? Also, I notice the equals method in org.apache.commons.math3.linear.AbstractRealMatrix directly compares the results of getEntry(), which are often doubles. Is this OK? I don't have a great deal of experience in overriding equals where doubles are involved. I have read that it is a good idea to use Double.doubleToLongBits and the use == or !=. http://www.javapractices.com/topic/TopicAction.do?Id=17 Thanks, Jared Email Disclaimer: www.stjude.org/emaildisclaimer Consultation Disclaimer: www.stjude.org/consultationdisclaimer - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1407525 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrBuilder.java
Good one Matt.
G
On Fri, Nov 9, 2012 at 11:26 AM, mben...@apache.org wrote:
Author: mbenson
Date: Fri Nov 9 16:26:44 2012
New Revision: 1407525
URL: http://svn.apache.org/viewvc?rev=1407525view=rev
Log:
support varargs in StrBuilder.appendAll(); also convert iterable form of
method to use enhanced for loop
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrBuilder.java
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrBuilder.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrBuilder.java?rev=1407525r1=1407524r2=1407525view=diff
==
---
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrBuilder.java
(original)
+++
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/text/StrBuilder.java
Fri Nov 9 16:26:44 2012
@@ -992,7 +992,7 @@ public class StrBuilder implements CharS
* @return this, to enable chaining
* @since 2.3
*/
-public StrBuilder appendAll(Object[] array) {
+public T StrBuilder appendAll(T... array) {
if (array != null array.length 0) {
for (Object element : array) {
append(element);
@@ -1012,9 +1012,8 @@ public class StrBuilder implements CharS
*/
public StrBuilder appendAll(Iterable? iterable) {
if (iterable != null) {
-Iterator? it = iterable.iterator();
-while (it.hasNext()) {
-append(it.next());
+for (Object o : iterable) {
+append(o);
}
}
return this;
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0
Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
Re: [math] Math-817 and .equals questions. .
Hi Jared. Any thoughts on the below email? If not, I will submit one patch, probably today or tomorrow. --- Hello, I am about to submit some code for issue Math-817 involving fitting multivariate normal mixture models using the EM algorithm. In order to simplify the unit test, I added overrode equals and hashCode. This in turn required me to make a few changes to code in the previously resolved issues Math-815 and Math-816. Am I supposed to just send one patch to 817, or am I supposed to break the patches up according to issue number? Also, I notice the equals method in org.apache.commons.math3.linear.AbstractRealMatrix directly compares the results of getEntry(), which are often doubles. Is this OK? I don't have a great deal of experience in overriding equals where doubles are involved. I have read that it is a good idea to use Double.doubleToLongBits and the use == or !=. http://www.javapractices.com/topic/TopicAction.do?Id=17 It will be better to have a discussion based on some actual code. [If you need a feature for MATH-817, it's fine to add it in the same patch.] Best regards, Gilles - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1407141 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Committed revision 1407536.
On Fri, Nov 9, 2012 at 9:51 AM, Matt Benson gudnabr...@gmail.com wrote:
On Fri, Nov 9, 2012 at 1:53 AM, Jörg Schaible joerg.schai...@scalaris.com
wrote:
Hi Greg,
the pattern matches (also) a single space that gets replaced by a single
space. Therefor are most of the actual performed replacements completely
superfluous, since I expect this to be the common case. The pattern should
be something along [\\s[^ ]]\\s*.
That seems to say a whitespace character that is not a space, optionally
followed by any number of whitespace characters. Wouldn't this
necessarily preclude any block of whitespace that *does* begin with a
space? This does seem to be on the right track, however. What about:
(?: \\s|[\\s[^ ]])\\s*
This seems to do the right thing: beginning with a non-capturing group
that matches { EITHER a space followed by a whitespace character OR a
whitespace character that is not a space }, optionally followed by any
number of whitespace characters.
Matt
- Jörg
---
Betreff: svn commit: r1407141 -
/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Absender: ggregory-1odqgaof3lkdnm+yrof...@public.gmane.org
Datum: Thu, 08 Nov 2012 15:54:25 +
Newsgruppe: gmane.comp.jakarta.commons.scm
Author: ggregory
Date: Thu Nov 8 15:54:25 2012
New Revision: 1407141
URL: http://svn.apache.org/viewvc?rev=1407141view=rev
Log:
Rename private WHITESPACE_BLOCK to WHITESPACE_PATTERN.
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Modified:
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
URL:
http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java?rev=1407141r1=1407140r2=1407141view=diff
==
---
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
(original)
+++
commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Thu Nov 8 15:54:25 2012
@@ -144,7 +144,7 @@ public class StringUtils {
/**
* A regex pattern for recognizing blocks of whitespace characters.
*/
-private static final Pattern WHITESPACE_BLOCK =
Pattern.compile(\\s+);
+private static final Pattern WHITESPACE_PATTERN =
Pattern.compile(\\s+);
/**
* p{@code StringUtils} instances should NOT be constructed in
@@ -6472,7 +6472,7 @@ public class StringUtils {
if (str == null) {
return null;
}
-return WHITESPACE_BLOCK.matcher(trim(str)).replaceAll( );
+return WHITESPACE_PATTERN.matcher(trim(str)).replaceAll( );
}
/**
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1407141 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Hi Matt,
Matt Benson wrote:
On Fri, Nov 9, 2012 at 1:53 AM, Jörg Schaible
joerg.schai...@scalaris.comwrote:
Hi Greg,
the pattern matches (also) a single space that gets replaced by a single
space. Therefor are most of the actual performed replacements completely
superfluous, since I expect this to be the common case. The pattern
should be something along [\\s[^ ]]\\s*.
That seems to say a whitespace character that is not a space, optionally
followed by any number of whitespace characters.
Right.
Wouldn't this
necessarily preclude any block of whitespace that *does* begin with a
space?
Fine in the context where the pattern is actually used, since the matching
string is trimmed first.
This does seem to be on the right track, however. What about:
(?: \\s|[\\s[^ ]])\\s*
This seems to do the right thing: beginning with a non-capturing group
that matches { EITHER a space followed by a whitespace character OR a
whitespace character that is not a space }, optionally followed by any
number of whitespace characters.
IMHO the capturing group is not necessary here.
Cheers,
Jörg
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1407141 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
I think we're mostly good, but just to make sure there's no confusion:
On Fri, Nov 9, 2012 at 3:05 PM, Jörg Schaible joerg.schai...@gmx.de wrote:
Hi Matt,
Matt Benson wrote:
On Fri, Nov 9, 2012 at 1:53 AM, Jörg Schaible
joerg.schai...@scalaris.comwrote:
Hi Greg,
the pattern matches (also) a single space that gets replaced by a single
space. Therefor are most of the actual performed replacements completely
superfluous, since I expect this to be the common case. The pattern
should be something along [\\s[^ ]]\\s*.
That seems to say a whitespace character that is not a space, optionally
followed by any number of whitespace characters.
Right.
Wouldn't this
necessarily preclude any block of whitespace that *does* begin with a
space?
Fine in the context where the pattern is actually used, since the matching
string is trimmed first.
I don't agree; the string against which the pattern is applied is trimmed,
but this still won't catch e.g. SPACE TAB embedded in non-whitespace.
This does seem to be on the right track, however. What about:
(?: \\s|[\\s[^ ]])\\s*
This seems to do the right thing: beginning with a non-capturing group
that matches { EITHER a space followed by a whitespace character OR a
whitespace character that is not a space }, optionally followed by any
number of whitespace characters.
IMHO the capturing group is not necessary here.
*non*-capturing. I agree, it's not necessary, but AFAIK some form of
grouping is needed to separate our alternatives from the final \\s*, and if
I hadn't included ?: to mark the group as non-capturing, it would by
default have been a capturing group. Since we'd never use the capture I
thought it less confusing to explicitly denote such.
br,
Matt
Cheers,
Jörg
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: svn commit: r1407141 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/StringUtils.java
Matt Benson wrote:
I think we're mostly good, but just to make sure there's no confusion:
On Fri, Nov 9, 2012 at 3:05 PM, Jörg Schaible joerg.schai...@gmx.de
wrote:
Hi Matt,
Matt Benson wrote:
On Fri, Nov 9, 2012 at 1:53 AM, Jörg Schaible
joerg.schai...@scalaris.comwrote:
Hi Greg,
the pattern matches (also) a single space that gets replaced by a
single space. Therefor are most of the actual performed replacements
completely superfluous, since I expect this to be the common case. The
pattern should be something along [\\s[^ ]]\\s*.
That seems to say a whitespace character that is not a space,
optionally followed by any number of whitespace characters.
Right.
Wouldn't this
necessarily preclude any block of whitespace that *does* begin with a
space?
Fine in the context where the pattern is actually used, since the
matching string is trimmed first.
I don't agree; the string against which the pattern is applied is trimmed,
but this still won't catch e.g. SPACE TAB embedded in non-whitespace.
This does seem to be on the right track, however. What about:
(?: \\s|[\\s[^ ]])\\s*
This seems to do the right thing: beginning with a non-capturing group
that matches { EITHER a space followed by a whitespace character OR a
whitespace character that is not a space }, optionally followed by any
number of whitespace characters.
IMHO the capturing group is not necessary here.
*non*-capturing. I agree, it's not necessary, but AFAIK some form of
grouping is needed to separate our alternatives from the final \\s*, and
if I hadn't included ?: to mark the group as non-capturing, it would by
default have been a capturing group. Since we'd never use the capture I
thought it less confusing to explicitly denote such.
It seems, I should go to bed. You're right here. ;-)
Cheers,
Jörg
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
Re: [math] correlation analysis with NaNs
On 11/9/12 12:18 AM, Thomas Neidhart wrote: On Thu, Nov 8, 2012 at 7:21 PM, Phil Steitz phil.ste...@gmail.com wrote: On 11/8/12 9:44 AM, Phil Steitz wrote: On 11/8/12 8:23 AM, Gilles Sadowski wrote: On Thu, Nov 08, 2012 at 05:00:52PM +0100, Thomas Neidhart wrote: On 11/08/2012 02:01 PM, Sébastien Brisard wrote: Hi, 2012/11/8 Gilles Sadowski gil...@harfang.homelinux.org: On Thu, Nov 08, 2012 at 09:39:00AM +0100, Thomas Neidhart wrote: Hi Patrick, On 11/07/2012 04:37 PM, Patrick Meyer wrote: I agree that it would be nice to have a constructor that allows you to specific the ranking algorithm only. +1 - patches welcome. As far as NaN and the Spearman correlation, maybe we should add a default strategy of NaNStrategy.FAIL so that an exception would occur if any NaN is encountered. R uses this treatment of missing data and forces users to choose how to handle it. If we implemented something like listwise or pairwise deletion it could be used in other classes too. As such, treatment of missing data should be part of a larger discussion and handled in a more comprehensive and systematic way. +1 to develop a strategy for representing how to represent and handle missing data (see below) I think this additional option makes sense, but I forward this discussion to the dev mailing list where it is better suited. I'm wary of having CM handle missing data. For one thing we'd have to define a convention to represent missing data. There is no good way to do that in Java. Using NaN for this purpose in a low-level library is not a good idea IMHO. I agree with Gilles, here. If I remember correctly, R has a special value NA, or something similar, which differs from NaN. Then, any convention might not be suitable for some user applications, which would lead such an application's developer to filter the data anyway in order to change his representation to CM's representation. Rather that calling two redundant filtering codes, I'd rather assume that CM gets a clean input on which its algorithm can operate. As usual, the input is subjected to precondition checks, and exceptions are thrown if the data is not clean enough. In summary: data validation (in the sense of discarding input) should not be done _before_ calling CM routines. +1. ok, I am now confused. First you say that CM should not be involved in data cleaning, but then you state that data validation should not be done before calling CM? May be there is a *not* too much? Yes, you are right: I wrote the opposite of what I meant. --- In summary: data validation (in the sense of discarding input) should be done _before_ calling CM routines. --- I think the proposition from Patrick was to exactly do that: throw an exception if such invalid data is encountered (NaNStrategy.FAIL). The other thing is, that the NaNStrategy.REMOVED is broken, so either we fix is or deprecate it. That we should fix. Please open a JIRA for this. I assume you are talking about the implementation in NaturalRanking. +1 [I mean (I think): If people rely on CM's removal of NaNs, we could fix it. However, if nobody could actually rely on this feature because it is broken, I'd prefer to remove it.] There are two issues here. One is specific to ranking algorithms. To be well-defined, a RankingAlgorithm needs a NaNStrategy, since the result has to be a total ordering. The NaNStrategy.REMOVED strategy is intended to represent removal of NaNs from the data to be ordered. If it is not implemented correctly in NaturalRanking or other rankings that is a bug and needs to be fixed. Sorry, I just reread Patrick's original mail. IIUC, there is nothing wrong with the implementation of NaNStrategy.REMOVED in NaturalRanking or other implemented rankings. The problem is how the Spearman's impl handles it. That is indeed a bug in Spearman's impl that should be fixed. The correct fix is to throw out the corresponding entry in the second array when REMOVED is the configured NaNStrategy. I agree with Patrick that adding .FAIL and setting that as the default is a good idea. Patches welcome. The second issue is the more general one of how to represent and handle missing data. I have always seen that as a limitation that we would eventually address on an algorithm by algorithm basis. Different algorithms can be configured to do different things when missing data are encountered. It is not always possible or desirable to preprocess the data to eliminate or impute missing data. Saying that we are just not going to deal with it is a limitation that I don't think we should impose. I am would like to hear others' ideas about good ways to model missing data in Java. Hi Phil, ok I have created three new issues: * MATH-891 * MATH-892 * MATH-893 Thanks! Regarding the NaNStrategy.REMOVED, I think it will be necessary to adjust the RankingAlgorithm interface a bit. Right now, it only takes as input a
[GUMP@vmgump]: Project commons-dbcp (in module commons-dbcp-1.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-dbcp has an issue affecting its community integration. This issue affects 18 projects, and has been outstanding for 6 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-dbcp : Object Pooling - db-ddlutils : Easy-to-use component for working with Database Definition (... - jakarta-tomcat-4.0 : Servlet 2.3 and JSP 1.2 Reference Implementation - jakarta-tomcat-catalina : Servlet 2.4 Reference Implementation - jakarta-tomcat-dbcp : Servlet 2.4 and JSP 2.0 Reference Implementation - jakarta-tomcat-jk : Connectors to various web servers - javax.el : Java Servlet 2.5 Server Pages JSP 2.1 implementation (for ... - javax.servlet : Java Servlet 2.5 Server Pages JSP 2.1 implementation (for ... - javax.servlet.jsp : Java Servlet 2.5 Server Pages JSP 2.1 implementation (for ... - solr : Java Based Search Engine - solr-test : Java Based Search Engine - tomcat-tc6 : Java Servlet 2.5 Server Pages JSP 2.1 implementation (for ... - tomcat-tc7.0.x : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... - tomcat-tc7.0.x-dbcp : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... - tomcat-tc7.0.x-test : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... - tomcat-trunk : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... - tomcat-trunk-dbcp : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... - tomcat-trunk-test : Tomcat 8.x, a web server implementing Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/commons-dbcp-1.x/commons-dbcp/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole jar output [commons-dbcp.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/commons-dbcp-1.x/commons-dbcp/gump_work/build_commons-dbcp-1.x_commons-dbcp.html Work Name: build_commons-dbcp-1.x_commons-dbcp (Type: Build) Work ended in a state of : Failed Elapsed: 9 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml dist [Working Directory: /srv/gump/public/workspace/commons-dbcp-1.x] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/junit/dist/junit-10112012.jar:/srv/gump/public/workspace/junit/dist/junit-dep-10112012.jar:/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar:/srv/gump/public/workspace/commons-pool-1.x/dist/commons-pool-1.6.1-SNAPSHOT.jar - [javac]^ [javac] where T is a type-variable: [javac] T extends Object declared in method TgetObject(String,ClassT) [javac] /srv/gump/public/workspace/commons-dbcp-1.x/src/java/org/apache/commons/dbcp/DelegatingConnection.java:65: error: DelegatingConnection is not abstract and does not override abstract method getNetworkTimeout() in Connection [javac] public class DelegatingConnection extends AbandonedTrace [javac]^ [javac] /srv/gump/public/workspace/commons-dbcp-1.x/src/java/org/apache/commons/dbcp/DelegatingDatabaseMetaData.java:38: error: DelegatingDatabaseMetaData is not abstract and does not override abstract method generatedKeyAlwaysReturned() in DatabaseMetaData [javac] public class DelegatingDatabaseMetaData extends AbandonedTrace [javac]^ [javac] /srv/gump/public/workspace/commons-dbcp-1.x/src/java/org/apache/commons/dbcp/DelegatingResultSet.java:61: error: DelegatingResultSet is not abstract and does not override abstract method TgetObject(String,ClassT) in ResultSet [javac] public class DelegatingResultSet extends
[GUMP@vmgump]: Project commons-dbcp2 (in module apache-commons) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project commons-dbcp2 has an issue affecting its community integration.
This issue affects 1 projects,
and has been outstanding for 175 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-dbcp2 : Database Connection Pool
Full details are available at:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbcp2/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-DEBUG- Sole jar output [commons-dbcp2-*[0-9T].jar] identifier set to project
name
-INFO- Failed with reason build failed
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://vmgump.apache.org/gump/public/apache-commons/commons-dbcp2/gump_work/build_apache-commons_commons-dbcp2.html
Work Name: build_apache-commons_commons-dbcp2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 9 secs
Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true
-Dbuild.sysclasspath=only
-Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml
dist
[Working Directory: /srv/gump/public/workspace/apache-commons/dbcp]
CLASSPATH:
/usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/apache-commons/dbcp/dist/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar:/srv/gump/packages/jdbc2_0/jdbc2_0-stdext.jar:/srv/gump/public/workspace/junit/dist/junit-10112012.jar:/srv/gump/public/workspace/junit/dist/junit-dep-10112012.jar:/srv/gump/public/workspace/apache-commons/pool/dist/commons-pool2-2.0-SNAPSHOT.jar
-
[mkdir] Created dir:
/srv/gump/public/workspace/apache-commons/dbcp/build/classes
[javac] Compiling 52 source files to
/srv/gump/public/workspace/apache-commons/dbcp/build/classes
[javac]
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/BasicDataSource.java:52:
error: BasicDataSource is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[javac] public class BasicDataSource implements DataSource {
[javac]^
[javac]
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingConnection.java:65:
error: DelegatingConnection is not abstract and does not override abstract
method getNetworkTimeout() in Connection
[javac] public class DelegatingConnection extends AbandonedTrace
[javac]^
[javac]
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingStatement.java:46:
error: DelegatingStatement is not abstract and does not override abstract
method isCloseOnCompletion() in Statement
[javac] public class DelegatingStatement extends AbandonedTrace implements
Statement {
[javac]^
[javac]
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java:57:
error: DelegatingPreparedStatement is not abstract and does not override
abstract method isCloseOnCompletion() in Statement
[javac] public class DelegatingPreparedStatement extends DelegatingStatement
[javac]^
[javac]
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingCallableStatement.java:58:
error: DelegatingCallableStatement is not abstract and does not override
abstract method TgetObject(String,ClassT) in CallableStatement
[javac] public class DelegatingCallableStatement extends
DelegatingPreparedStatement
[javac]^
[javac] where T is a type-variable:
[javac] T extends Object declared in method
TgetObject(String,ClassT)
[javac]
/srv/gump/public/workspace/apache-commons/dbcp/src/java/org/apache/commons/dbcp2/DelegatingDatabaseMetaData.java:36:
error: DelegatingDatabaseMetaData is not abstract and does not override
abstract method generatedKeyAlwaysReturned() in DatabaseMetaData
[javac] public
