date:20170610

Re: [fileupload] Remove @version tags from javadocs

2017-06-10 Thread Gary Gregory

On Jun 10, 2017 9:25 PM, "Bruno P. Kinoshita"
 wrote:

Hi all,

Looking at https://git.apache.org/, looks like commons-fileupload has been
migrated to Git.

Any objection to removing the @version tags from the code now? I believe
these were used to show the last SVN commit, if my memory serves me well,
and are not supported in Git. So should be OK to remove them now?


+1

Gary


Cheers
Bruno

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload issue #1: Commons fileupload headerfix

2017-06-10 Thread kinow

Github user kinow commented on the issue:

https://github.com/apache/commons-fileupload/pull/1
  
Hmmm, this pull request seems to be a bit messed up due to either changes 
in the branch, or to the way the commit was created. There are also IDE files 
committed. @developerSid if you could update the pull request, making sure to 
rebase your changes against the remote branch, that might make it easier to be 
reviewed.

Thanks
Bruno


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[fileupload] Remove @version tags from javadocs

2017-06-10 Thread Bruno P. Kinoshita

Hi all,

Looking at https://git.apache.org/, looks like commons-fileupload has been 
migrated to Git.

Any objection to removing the @version tags from the code now? I believe these 
were used to show the last SVN commit, if my memory serves me well, and are not 
supported in Git. So should be OK to remove them now?

Cheers
Bruno

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [text] Deprecate CsvTranslators

2017-06-10 Thread Amey Jadiye

well, i'm still unclear about the action to be taken here, so i'll keep on
beating a dead horse till we fix it or close it at some logic end.

Regards,
Amey

On Fri, May 26, 2017 at 12:14 PM, Amey Jadiye  wrote:

> Hi Gary, just to conclude the final action and clear midst here, I wish
> you and team to elaborate your thought more on.
>
> 1. Deprecate CsvTranslator and point javadoc to use same methods present
> in StringEscapeUtils in Commons Text.(moved from lang3)
>
> 2. Move CsvTranalator to Commons CSV all together.
>
> 3. Anything else ?
>
> I like to go with 1st point which I agreed upon before.
>
> Regards,
> Amey
>
>
> On Fri, May 26, 2017, 12:41 AM Gary Gregory 
> wrote:
>
>> Mentioning the big picture again, Javadocs could also point to Commons
>> CSV.
>>
>> Gary
>>
>> On May 25, 2017 12:06 PM, "Amey Jadiye"  wrote:
>>
>> > Agreed!, Thanks for sharing thoughts gary, now only marking
>> CsvTranslator
>> > as deprecated will be OK.
>> >
>> > I'm marking methods from commons-text StringEscapeUtils as alternative
>> > to CsvTranslator,
>> > Thanks.
>> >
>> > Regards,
>> > Amey
>> >
>> > On Fri, May 26, 2017 at 12:25 AM, Gary Gregory 
>> > wrote:
>> >
>> > > I think we need to step back here, or up, and look at the big picture.
>> > >
>> > > Commons CSV reads and writes CSV files. There a couple of additional
>> > cases
>> > > like writing CSV from JDBC result set.
>> > >
>> > > The Commons Text CSV methods do low level work that is already done
>> > within
>> > > the guts of Commons CSV.
>> > >
>> > > What is the use case of Commons Text and Lang CSV methods? Build
>> parts of
>> > > CSV IO code I would guess.
>> > >
>> > > I do not want to just move code between components in this case. This
>> is
>> > > not like WordUtils moving from Lang to Text.
>> > >
>> > > How is this code used? Can a user just do away with it by recoding to
>> > > Commons CSV?
>> > >
>> > > Gary
>> > >
>> > > On May 25, 2017 11:26 AM, "Amey Jadiye"  wrote:
>> > >
>> > > > Hi Gary,
>> > > >
>> > > > I have deprecated the CsvTranslator from commons text and was
>> looking
>> > for
>> > > > alternate API, we have it in StringEscapeUtils in commons text (and
>> in
>> > > > commons lang3 which is deprecated & which i'm not worry about), I
>> think
>> > > we
>> > > > should remove those csv related methods from StringEscapeUtils as
>> well
>> > > and
>> > > > create CsvEscapeUtils in commons CSV as its better place, thoughts ?
>> > > >
>> > > > Regards,
>> > > > Amey
>> > > >
>> > > >
>> > > >
>> > > > On Thu, May 25, 2017 at 1:04 AM, Gary Gregory <
>> garydgreg...@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > I'm not talking about moving the [text] classes to [csv] but
>> rather I
>> > > > want
>> > > > > folks to use [csv] instead of [txt]. If we have to add a few APIs
>> > here
>> > > > and
>> > > > > there fine. But I would hope that all we need is there already.
>> > > > >
>> > > > > Gary
>> > > > >
>> > > > > On Tue, May 23, 2017 at 3:24 AM, Emmanuel Bourg <
>> ebo...@apache.org>
>> > > > wrote:
>> > > > >
>> > > > > > Le 23/05/2017 à 01:06, Gary Gregory a écrit :
>> > > > > >
>> > > > > > > I wonder if we should deprecate CsvTranslators in favor of
>> > Commons
>> > > > > CSV. I
>> > > > > > > wish I had noticed CsvTranslators eariler :-(
>> > > > > >
>> > > > > > +1
>> > > > > >
>> > > > > > Emmanuel Bourg
>> > > > > >
>> > > > > >
>> > > > > > 
>> > > -
>> > > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> > > > > > For additional commands, e-mail: dev-h...@commons.apache.org
>> > > > > >
>> > > > > >
>> > > > >
>> > > > >
>> > > > > --
>> > > > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> > > > > Java Persistence with Hibernate, Second Edition
>> > > > > > > > > > tl?ie=UTF8=1789=9325=1617290459&
>> > > > > linkCode=as2=garygregory-20=
>> > cadb800f39946ec62ea2b1af9fe6a2
>> > > b8>
>> > > > >
>> > > > > > > garygregory-20=am2=1=
>> > > > > 1617290459>
>> > > > > JUnit in Action, Second Edition
>> > > > > > > > > > tl?ie=UTF8=1789=9325=1935182021&
>> > > > > linkCode=as2=garygregory-20=
>> > 31ecd1f6b6d1eaf8886ac902a24de4
>> > > > 18%22
>> > > > > >
>> > > > >
>> > > > > > > garygregory-20=am2=1=
>> > > > > 1935182021>
>> > > > > Spring Batch in Action
>> > > > > > > > > > tl?ie=UTF8=1789=9325=1935182951&
>> > > > > linkCode=%7B%7BlinkCode%7D%7D=garygregory-20=%7B%
>> > > > > 7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
>> > > > > > > garygregory-20=am2=1=
>> > > > > 1935182951>
>> > > > > Blog:

[GitHub] commons-text issue #42: TEXT-83: Deprecate CsvTranslators from from commons ...

2017-06-10 Thread ameyjadiye

Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-text/pull/42
  
Hi @chtompki, do we expect anything more to be done here ? as per 
@garydgregory it looks good to be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

2017-06-10 Thread Oliver Heger

All my remarks have been addressed.

+1

Thank you very much!
Oliver

Am 10.06.2017 um 03:57 schrieb Rob Tompkins:
> Hello all,
> 
> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC6).
> 
> Tag name:
>commons-fileupload-1.3.3-RC6 (signature can be checked from git using 'git
> tag -v')
> 
> Tag URL:
>
> https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=tag;h=refs/tags/commons-fileupload-1.3.3-RC6
> 
> Commit ID the tag points at:
>18734e9f77a267ebc82ff2ffce6d96e82a34260f
> 
> Site:
>http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC6
> 
> Distribution files (committed at revision 19983):
>https://dist.apache.org/repos/dist/dev/commons/fileupload/
> 
> Distribution files hashes (SHA1):
>commons-fileupload-1.3.3-bin.tar.gz
>(SHA1: eb955261c3588b26dac8ffdd2b6a4256c68bed7a)
>commons-fileupload-1.3.3-bin.zip
>(SHA1: 42a0267650765b4192cc672a3e77ed9063e50406)
>commons-fileupload-1.3.3-src.tar.gz
>(SHA1: 57da8d59a94420fb3d2034b6e1d6ac86d2721765)
>commons-fileupload-1.3.3-src.zip
>(SHA1: 218acaed035c9f12e67166b21405178491c4e3c6)
> 
> These are the Maven artifacts and their hashes:
>commons-fileupload-1.3.3-javadoc.jar
>(SHA1: d44ff01a7e0217b5c849c5375a3a8ad13a338375)
>commons-fileupload-1.3.3-sources.jar
>(SHA1: 34c8608c461e2c832a364ec1a9e70f360f47d9f7)
>commons-fileupload-1.3.3-test-sources.jar
>(SHA1: fec543dc748908577513ba39c550e59abc29875b)
>commons-fileupload-1.3.3-tests.jar
>(SHA1: a7be58ed6dd0b3759a563c41ff4957fa5c8afcfb)
>commons-fileupload-1.3.3.jar
>(SHA1: 04ff14d809195b711fd6bcc87e6777f886730ca1)
>commons-fileupload-1.3.3.pom
>(SHA1: 3dcfa2e705e8822b80c14949ba624f290cdfd04e)
> 
> KEYS file to check signatures:
>http://www.apache.org/dist/commons/KEYS
> 
> Maven artifacts:
>https://repository.apache.org/content/repositories/orgapachecommons-1252
> 
> Please select one of the following options[1]:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
> 
> This vote will be open at least 72 hours, i.e. until 
> 2017-06-13T02:00:00Z
> (this is UTC time).
> 
> 
> Cheers,
> -Rob
> 
> [1] http://apache.org/foundation/voting.html
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: NUMBERS-40: Review exception usage in package "o.a.c.numbers.gamma"

2017-06-10 Thread Gilles


Hi.

On Thu, 8 Jun 2017 19:38:55 -0500, Tharaka De Silva wrote:

Thank you for the response!

On Thu, Jun 8, 2017 at 5:13 AM, Gilles  
wrote:



Hi.

On Wed, 7 Jun 2017 17:00:46 -0500, Tharaka De Silva wrote:


Hello everyone,

I am new to the ASF community



Welcome.



Thank you!





and decided to grab something easy to

attempt. I decided to take a shot at:
https://issues.apache.org/jira/browse/NUMBERS-40.



Easy to change is not always similar to easy to decide what
changes to perform. ;-)



I did not think of it that way. It makes sense.





The rationale of implementing this design would be this:
GammaException is currently a subclass of IllegalArgumentException 
but the
reason for an argument to be invalid would be because it is 
arithmetically
impossible hence why it should be an ArithmeticException rather 
than a

IllegalArgumentException.



In quite a few cases, it is actually _not_ "arithmetically 
impossible",

it is a limitation of the implementation.



I was looking at it and the one I saw was for negative log and I made 
my

assumptions from that.


In effect, I raised the issue to make sure that the way to handle
(input) errors is consistent throughout the component.

The choice is even larger; for example, in the "log" case, do we
want to raise an exception on negative input, or return NaN (as
"Math.log" does)?
Which is more useful/safer/more standard?



The JIRA report asks whether it is possible to use a single 
exception
type (currently "GammaException") for all programming errors, given 
that
the base class of all errors _cannot_ be "ArithmeticException" (as 
the

above explains).


So you think that leaving it as a subclass of 
IllegalArgumentException

makes more sense?


When the Javadoc states that a method should not be called with
some selection of the argument(s), then yes, I do.  [A priori; but
another rationale could come out from answering the above questions,
comparing with how those situations are handled in class "Complex".]

As an aside, in the unit tests, the use of the exception's base 
(JDK)

class in the "expected" clause is intentional as the unit tests are
mainly supposed to  check the public API (and "GammaException" is
package-private).
In "Commons Numbers", the idea would be to have a most simple 
exception
handling (throwing only JDK exceptions) since it is expected (TBC) 
that

all of them result from incorrect usage or bugs in the library.



Yeah, I didn't think of it this way. The unit tests probably should
probably be modified to assert for the JDK exceptions.


We must first decide whether the public API should contain specific
exceptions; the question is whether the caller can do more with a
specific type than with a JDK exception.
E.g. if use-cases only involve reading the stack trace after a
program crash, in order to fix the bug, then the answer is "no".


Regards,
Gilles





What do you guys think?







-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC4

2017-06-10 Thread Gary Gregory

+1

Building the site with Oracle Java 7 default settings gave me a PermSpace
error so I switched to Java Oracle 8.

>From src zip: ASC, MD5, SHA1 OK.
Release notes and notice file OK.

Running 'mvn clean verify site' OK with Oracle Java 8:

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T12:39:06-07:00)
Maven home: C:\Java\apache-maven-3.5.0\bin\..
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_131\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Running 'mvn clean verify site' OK with IBM Java 8:

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T12:39:06-07:00)
Maven home: C:\Java\apache-maven-3.5.0\bin\..
Java version: 1.8.0, vendor: IBM Corporation
Java home: C:\eclipse\IBM-6.4.5\ibm_sdk80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "x86", family: "windows"

java version "1.8.0"
Java(TM) SE Runtime Environment (build pwi3280sr4fp5-20170421_01(SR4 FP5))
IBM J9 VM (build 2.8, JRE 1.8.0 Windows 10 x86-32 20170419_344392 (JIT
enabled, AOT enabled)
J9VM - R28_20170419_1004_B344392
JIT  - tr.r14.java_20170419_344392
GC   - R28_20170419_1004_B344392
J9CL - 20170419_344392)
JCL - 20170420_01 based on Oracle jdk8u131-b11

Note that with IBM Java 8, Clirr shows internal errors but does not break
the build:

[INFO] <<< clirr-maven-plugin:2.8:clirr < compile @ commons-lang3 <<<
[INFO]
[INFO] 'compile' forked phase execution for clirr-maven-plugin:clirr report
preparation done
[INFO] configuring report plugin
org.apache.maven.plugins:maven-checkstyle-plugin:2.17
[INFO] configuring report plugin
org.codehaus.mojo:findbugs-maven-plugin:3.0.3
[INFO] configuring report plugin
org.apache.maven.plugins:maven-pmd-plugin:3.7
[INFO] configuring report plugin org.codehaus.mojo:taglist-maven-plugin:2.4
[INFO] configuring report plugin org.codehaus.mojo:javancss-maven-plugin:2.1
[INFO] Fork Value is true
 [java] The following errors occurred during analysis:
 [java]   Error processing opcode invokestatic @ 0 in
java.lang.String. : ()V
 [java] java.lang.NullPointerException
 [java]   At
edu.umd.cs.findbugs.OpcodeStack.processMethodCall(OpcodeStack.java:2637)
 [java]   At
edu.umd.cs.findbugs.OpcodeStack.sawOpcode(OpcodeStack.java:2103)
 [java]   At
edu.umd.cs.findbugs.OpcodeStack$JumpInfoFactory$JumpStackComputation.sawOpcode(OpcodeStack.java:2846)
 [java]   At
edu.umd.cs.findbugs.visitclass.DismantleBytecode.visit(DismantleBytecode.java:883)
 [java]   At
edu.umd.cs.findbugs.visitclass.BetterVisitor.visitCode(BetterVisitor.java:218)
 [java]   At
edu.umd.cs.findbugs.visitclass.PreorderVisitor.visitCode(PreorderVisitor.java:235)
 [java]   At
edu.umd.cs.findbugs.OpcodeStack$JumpInfoFactory$JumpStackComputation.visitCode(OpcodeStack.java:2832)
 [java]   At org.apache.bcel.classfile.Code.accept(Code.java:135)
 [java]   At
edu.umd.cs.findbugs.visitclass.PreorderVisitor.doVisitMethod(PreorderVisitor.java:307)
 [java]   At
edu.umd.cs.findbugs.OpcodeStack$JumpInfoFactory.computeJumpInfo(OpcodeStack.java:2876)
 [java]   At
edu.umd.cs.findbugs.OpcodeStack$JumpInfoFactory.analyze(OpcodeStack.java:2806)
 [java]   At
edu.umd.cs.findbugs.OpcodeStack$JumpInfoFactory.analyze(OpcodeStack.java:2789)
 [java]   At
edu.umd.cs.findbugs.classfile.impl.AnalysisCache.analyzeMethod(AnalysisCache.java:369)
 [java]   At
edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getMethodAnalysis(AnalysisCache.java:322)
 [java]   At
edu.umd.cs.findbugs.OpcodeStack.getJumpInfo(OpcodeStack.java:3007)
 [java]   At
edu.umd.cs.findbugs.OpcodeStack.resetForMethodEntry(OpcodeStack.java:2978)
 [java]   At
edu.umd.cs.findbugs.bcel.OpcodeStackDetector.visitCode(OpcodeStackDetector.java:62)
 [java]   At org.apache.bcel.classfile.Code.accept(Code.java:135)
 [java]   At
edu.umd.cs.findbugs.visitclass.PreorderVisitor.doVisitMethod(PreorderVisitor.java:307)
 [java]   At
edu.umd.cs.findbugs.visitclass.PreorderVisitor.visitJavaClass(PreorderVisitor.java:395)
 [java]   At
org.apache.bcel.classfile.JavaClass.accept(JavaClass.java:215)
 [java]   At
edu.umd.cs.findbugs.BytecodeScanningDetector.visitClassContext(BytecodeScanningDetector.java:38)
 [java]   At
edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76)
 [java]   At
edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1089)
 [java]   At
edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:283)
 [java]   At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:402)
 [java]   At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1200)

Gary

On Fri, Jun 9, 2017 at 2:56 AM, Benedikt Ritter  wrote:

> Hello,
>
> we

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

2017-06-10 Thread Gary Gregory

On Fri, Jun 9, 2017 at 11:03 PM, Gary Gregory 
wrote:

> +1
>
> Not a blocker: bin zip contains two copies of the Javadoc site, neither of
> which load from their respective index.html; I get the three Javadoc frames
> and an error icon in each frame.
>

Actually both sites are fine. There are just, well, two of them. Not great
to waste bandwidth on all the mirrors but still not a blocker.

Gary


>
> From src zip:
>
> ASC, MD5, SHA1 OK
>
> Build OK with 'mvn clean verify site'
> The Javadoc site is fine there.
> Reports OK.
>
> Using:
>
> Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
> 2017-04-03T12:39:06-07:00)
> Maven home: C:\Java\apache-maven-3.5.0
> Java version: 1.7.0_80, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_80\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"
>
> Gary
>
> On Fri, Jun 9, 2017 at 6:57 PM, Rob Tompkins  wrote:
>
>> Hello all,
>>
>> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC6).
>>
>> Tag name:
>>commons-fileupload-1.3.3-RC6 (signature can be checked from git using
>> 'git
>> tag -v')
>>
>> Tag URL:
>>https://git-wip-us.apache.org/repos/asf?p=commons-fileup
>> load.git;a=tag;h=refs/tags/commons-fileupload-1.3.3-RC6
>>
>> Commit ID the tag points at:
>>18734e9f77a267ebc82ff2ffce6d96e82a34260f
>>
>> Site:
>>http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC6
>>
>> Distribution files (committed at revision 19983):
>>https://dist.apache.org/repos/dist/dev/commons/fileupload/
>>
>> Distribution files hashes (SHA1):
>>commons-fileupload-1.3.3-bin.tar.gz
>>(SHA1: eb955261c3588b26dac8ffdd2b6a4256c68bed7a)
>>commons-fileupload-1.3.3-bin.zip
>>(SHA1: 42a0267650765b4192cc672a3e77ed9063e50406)
>>commons-fileupload-1.3.3-src.tar.gz
>>(SHA1: 57da8d59a94420fb3d2034b6e1d6ac86d2721765)
>>commons-fileupload-1.3.3-src.zip
>>(SHA1: 218acaed035c9f12e67166b21405178491c4e3c6)
>>
>> These are the Maven artifacts and their hashes:
>>commons-fileupload-1.3.3-javadoc.jar
>>(SHA1: d44ff01a7e0217b5c849c5375a3a8ad13a338375)
>>commons-fileupload-1.3.3-sources.jar
>>(SHA1: 34c8608c461e2c832a364ec1a9e70f360f47d9f7)
>>commons-fileupload-1.3.3-test-sources.jar
>>(SHA1: fec543dc748908577513ba39c550e59abc29875b)
>>commons-fileupload-1.3.3-tests.jar
>>(SHA1: a7be58ed6dd0b3759a563c41ff4957fa5c8afcfb)
>>commons-fileupload-1.3.3.jar
>>(SHA1: 04ff14d809195b711fd6bcc87e6777f886730ca1)
>>commons-fileupload-1.3.3.pom
>>(SHA1: 3dcfa2e705e8822b80c14949ba624f290cdfd04e)
>>
>> KEYS file to check signatures:
>>http://www.apache.org/dist/commons/KEYS
>>
>> Maven artifacts:
>>https://repository.apache.org/content/repositories/orgap
>> achecommons-1252
>>
>> Please select one of the following options[1]:
>>   [ ] +1 Release it.
>>   [ ] +0 Go ahead; I don't care.
>>   [ ] -0 There are a few minor glitches: ...
>>   [ ] -1 No, do not release it because ...
>>
>> This vote will be open at least 72 hours, i.e. until
>> 2017-06-13T02:00:00Z
>> (this is UTC time).
>> 
>>
>> Cheers,
>> -Rob
>>
>> [1] http://apache.org/foundation/voting.html
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>>
>

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

2017-06-10 Thread Gary Gregory

On Fri, Jun 9, 2017 at 11:39 PM, Bruno P. Kinoshita <
brunodepau...@yahoo.com.br.invalid> wrote:

>  [x] +1 Release it.
>
> Build passing for IBM JDK 8 and Oracle JDK 8. Site generated successfully,
> reports look good too.
>

Oh, good catch on IBM Java 8! That had skipped my mind.

Gary


>
> Cheers
> Bruno
> 
> From: Rob Tompkins 
> To: Commons Developers List 
> Sent: Saturday, 10 June 2017 1:58 PM
> Subject: [VOTE] Release Commons Fileupload 1.3.3 based on RC6
>
>
>
> Hello all,
>
>
> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC6).
>
>
> Tag name:
>
>commons-fileupload-1.3.3-RC6 (signature can be checked from git using
> 'git
>
> tag -v')
>
>
> Tag URL:
>
>   https://git-wip-us.apache.org/repos/asf?p=commons-
> fileupload.git;a=tag;h=refs/tags/commons-fileupload-1.3.3-RC6
>
>
> Commit ID the tag points at:
>
>18734e9f77a267ebc82ff2ffce6d96e82a34260f
>
>
> Site:
>
>   http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC6
>
>
> Distribution files (committed at revision 19983):
>
>   https://dist.apache.org/repos/dist/dev/commons/fileupload/
>
>
> Distribution files hashes (SHA1):
>
>commons-fileupload-1.3.3-bin.tar.gz
>
>(SHA1: eb955261c3588b26dac8ffdd2b6a4256c68bed7a)
>
>commons-fileupload-1.3.3-bin.zip
>
>(SHA1: 42a0267650765b4192cc672a3e77ed9063e50406)
>
>commons-fileupload-1.3.3-src.tar.gz
>
>(SHA1: 57da8d59a94420fb3d2034b6e1d6ac86d2721765)
>
>commons-fileupload-1.3.3-src.zip
>
>(SHA1: 218acaed035c9f12e67166b21405178491c4e3c6)
>
>
> These are the Maven artifacts and their hashes:
>
>commons-fileupload-1.3.3-javadoc.jar
>
>(SHA1: d44ff01a7e0217b5c849c5375a3a8ad13a338375)
>
>commons-fileupload-1.3.3-sources.jar
>
>(SHA1: 34c8608c461e2c832a364ec1a9e70f360f47d9f7)
>
>commons-fileupload-1.3.3-test-sources.jar
>
>(SHA1: fec543dc748908577513ba39c550e59abc29875b)
>
>commons-fileupload-1.3.3-tests.jar
>
>(SHA1: a7be58ed6dd0b3759a563c41ff4957fa5c8afcfb)
>
>commons-fileupload-1.3.3.jar
>
>(SHA1: 04ff14d809195b711fd6bcc87e6777f886730ca1)
>
>commons-fileupload-1.3.3.pom
>
>(SHA1: 3dcfa2e705e8822b80c14949ba624f290cdfd04e)
>
>
> KEYS file to check signatures:
>
>   http://www.apache.org/dist/commons/KEYS
>
>
> Maven artifacts:
>
>   https://repository.apache.org/content/repositories/orgapachecommons-1252
>
>
> Please select one of the following options[1]:
>
>   [ ] +1 Release it.
>
>   [ ] +0 Go ahead; I don't care.
>
>   [ ] -0 There are a few minor glitches: ...
>
>   [ ] -1 No, do not release it because ...
>
>
> This vote will be open at least 72 hours, i.e. until
>
> 2017-06-13T02:00:00Z
>
> (this is UTC time).
>
> 
>
>
> Cheers,
>
> -Rob
>
>
> [1] http://apache.org/foundation/voting.html
>
> -
>
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>
> For additional commands, e-mail: dev-h...@commons.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC4

2017-06-10 Thread Bruno P. Kinoshita

Build passing with Oracle JDK 8 and IBM JDK 8. Successfully generated site, 
reports look OK.


[X] +1 Release these artifacts
Cheers
Bruno




From: Benedikt Ritter 
To: Commons Developers List  
Sent: Friday, 9 June 2017 9:56 PM
Subject: [VOTE] Release Apache Commons Lang 3.6 based on RC4



Hello,


we have fixed quite a few bugs and added some nice new features since Commons 
Lang 3.5 was released, so I would like to release Commons Lang 3.6 based on RC4.


The only change compared to RC3 is a partial revert of LANG-1334: The compile 
time constants in CharEncoding (which has also been deprecated in this release) 
have been restored. An accompanying unit test makes sure, that they have the 
same values as defined in java.nio.charsets.StandardCharset.


Further more we have fixed these issues for RC3, which were discovered in RC2:


- Site build now works from source distribution

- IBM JDK test failures have been fixed

- Automatic-Module-Name MANIFEST entry has been added for Java 9 compatibility


Commons Lang 3.4 R3 is available for review here:

https://dist.apache.org/repos/dist/dev/commons/lang (svn revision 19964)


The tag is here:

https://git-wip-us.apache.org/repos/asf?p=commons-lang.git;a=tag;h=de6627363d7f53a3e8f8daf32c55e39e69022402


Commit ID the tag points at:

09043bfa6f1f9ebb946c7b159735c83259e3a89f


Maven Artifacts:

https://repository.apache.org/content/repositories/orgapachecommons-1251


These are the Maven artifacts and their hashes:


/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-javadoc.jar

(SHA1: 988675c1853c2a4f2cd8e7056eaa5bd6985ccd06)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-sources.jar.asc

(SHA1: b71e4c9b540e85627170e9f3675571389652d294)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.pom.asc

(SHA1: a1dfabbc0e81555ef0f832c159919613d4db942c)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.pom

(SHA1: 0fb4499188c94c63b3cba44f12481e193708c4a8)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar.asc

(SHA1: 96c33aedaa5ae5c795b00cc3dc5a38784f2ecf55)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-javadoc.jar.asc

(SHA1: 9e9cd1d38a8a0483a58d8da392c6e5e3c26d3347)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-sources.jar

(SHA1: 4765e418c9084c4e01233cb5f09bdd6b5f311ccc)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar

(SHA1: 9d28a6b23650e8a7e9063c04588ace6cf7012c17)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-tests.jar.asc

(SHA1: 5eda68b1db192cd8a1732f1e652fd219682d7b37)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-test-sources.jar.asc

(SHA1: 796bb7c5783e814f17daf9423b5ba83e38727c71)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-test-sources.jar

(SHA1: 80303a5a53413c13b1491a6c5728e0a1bf2d7b91)

/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6-tests.jar

(SHA1: ad971e62b400b400702433445d22264e3816dec2)


I have tested this with JDK 7, JDK 8 and JDK 9 EA b172 using Maven 3.5.0.


Details of changes since 3.5 are in the release notes:

  https://dist.apache.org/repos/dist/dev/commons/lang/RELEASE-NOTES.txt

  http://home.apache.org/~britter/commons/lang/LANG_3_6_RC4/changes-report.html


Site:

http://home.apache.org/~britter/commons/lang/LANG_3_6_RC4

(note some *relative* links are broken and the 3.6 directories are

not yet created - these will be OK once the site is deployed)


Clirr Report (compared to 3.5):

  http://home.apache.org/~britter/commons/lang/LANG_3_6_RC4/clirr-report.html


RAT Report:

  http://home.apache.org/~britter/commons/lang/LANG_3_6_RC4/rat-report.html


KEYS:

https://www.apache.org/dist/commons/KEYS


Please review the release candidate and vote.

This vote will close no sooner that 72 hours from now,

i.e. sometime after 12:00 CEST (UTC+2) 12-June 2017


[ ] +1 Release these artifacts

[ ] +0 OK, but...

[ ] -0 OK, but really should fix...

[ ] -1 I oppose this release because...


Thanks!

Benedikt

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

2017-06-10 Thread Bruno P. Kinoshita

 [x] +1 Release it.

Build passing for IBM JDK 8 and Oracle JDK 8. Site generated successfully, 
reports look good too.


Cheers
Bruno

From: Rob Tompkins 
To: Commons Developers List  
Sent: Saturday, 10 June 2017 1:58 PM
Subject: [VOTE] Release Commons Fileupload 1.3.3 based on RC6



Hello all,


This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC6).


Tag name:

   commons-fileupload-1.3.3-RC6 (signature can be checked from git using 'git

tag -v')


Tag URL:

  
https://git-wip-us.apache.org/repos/asf?p=commons-fileupload.git;a=tag;h=refs/tags/commons-fileupload-1.3.3-RC6


Commit ID the tag points at:

   18734e9f77a267ebc82ff2ffce6d96e82a34260f


Site:

  http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC6


Distribution files (committed at revision 19983):

  https://dist.apache.org/repos/dist/dev/commons/fileupload/


Distribution files hashes (SHA1):

   commons-fileupload-1.3.3-bin.tar.gz

   (SHA1: eb955261c3588b26dac8ffdd2b6a4256c68bed7a)

   commons-fileupload-1.3.3-bin.zip

   (SHA1: 42a0267650765b4192cc672a3e77ed9063e50406)

   commons-fileupload-1.3.3-src.tar.gz

   (SHA1: 57da8d59a94420fb3d2034b6e1d6ac86d2721765)

   commons-fileupload-1.3.3-src.zip

   (SHA1: 218acaed035c9f12e67166b21405178491c4e3c6)


These are the Maven artifacts and their hashes:

   commons-fileupload-1.3.3-javadoc.jar

   (SHA1: d44ff01a7e0217b5c849c5375a3a8ad13a338375)

   commons-fileupload-1.3.3-sources.jar

   (SHA1: 34c8608c461e2c832a364ec1a9e70f360f47d9f7)

   commons-fileupload-1.3.3-test-sources.jar

   (SHA1: fec543dc748908577513ba39c550e59abc29875b)

   commons-fileupload-1.3.3-tests.jar

   (SHA1: a7be58ed6dd0b3759a563c41ff4957fa5c8afcfb)

   commons-fileupload-1.3.3.jar

   (SHA1: 04ff14d809195b711fd6bcc87e6777f886730ca1)

   commons-fileupload-1.3.3.pom

   (SHA1: 3dcfa2e705e8822b80c14949ba624f290cdfd04e)


KEYS file to check signatures:

  http://www.apache.org/dist/commons/KEYS


Maven artifacts:

  https://repository.apache.org/content/repositories/orgapachecommons-1252


Please select one of the following options[1]:

  [ ] +1 Release it.

  [ ] +0 Go ahead; I don't care.

  [ ] -0 There are a few minor glitches: ...

  [ ] -1 No, do not release it because ...


This vote will be open at least 72 hours, i.e. until 

2017-06-13T02:00:00Z

(this is UTC time).




Cheers,

-Rob


[1] http://apache.org/foundation/voting.html

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

2017-06-10 Thread Gary Gregory

+1

Not a blocker: bin zip contains two copies of the Javadoc site, neither of
which load from their respective index.html; I get the three Javadoc frames
and an error icon in each frame.

>From src zip:

ASC, MD5, SHA1 OK

Build OK with 'mvn clean verify site'
The Javadoc site is fine there.
Reports OK.

Using:

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T12:39:06-07:00)
Maven home: C:\Java\apache-maven-3.5.0
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"

Gary

On Fri, Jun 9, 2017 at 6:57 PM, Rob Tompkins  wrote:

> Hello all,
>
> This is a [VOTE] for releasing Apache Commons Fileupload 1.3.3 (from RC6).
>
> Tag name:
>commons-fileupload-1.3.3-RC6 (signature can be checked from git using
> 'git
> tag -v')
>
> Tag URL:
>https://git-wip-us.apache.org/repos/asf?p=commons-
> fileupload.git;a=tag;h=refs/tags/commons-fileupload-1.3.3-RC6
>
> Commit ID the tag points at:
>18734e9f77a267ebc82ff2ffce6d96e82a34260f
>
> Site:
>http://home.apache.org/~chtompki/commons-fileupload-1.3.3-RC6
>
> Distribution files (committed at revision 19983):
>https://dist.apache.org/repos/dist/dev/commons/fileupload/
>
> Distribution files hashes (SHA1):
>commons-fileupload-1.3.3-bin.tar.gz
>(SHA1: eb955261c3588b26dac8ffdd2b6a4256c68bed7a)
>commons-fileupload-1.3.3-bin.zip
>(SHA1: 42a0267650765b4192cc672a3e77ed9063e50406)
>commons-fileupload-1.3.3-src.tar.gz
>(SHA1: 57da8d59a94420fb3d2034b6e1d6ac86d2721765)
>commons-fileupload-1.3.3-src.zip
>(SHA1: 218acaed035c9f12e67166b21405178491c4e3c6)
>
> These are the Maven artifacts and their hashes:
>commons-fileupload-1.3.3-javadoc.jar
>(SHA1: d44ff01a7e0217b5c849c5375a3a8ad13a338375)
>commons-fileupload-1.3.3-sources.jar
>(SHA1: 34c8608c461e2c832a364ec1a9e70f360f47d9f7)
>commons-fileupload-1.3.3-test-sources.jar
>(SHA1: fec543dc748908577513ba39c550e59abc29875b)
>commons-fileupload-1.3.3-tests.jar
>(SHA1: a7be58ed6dd0b3759a563c41ff4957fa5c8afcfb)
>commons-fileupload-1.3.3.jar
>(SHA1: 04ff14d809195b711fd6bcc87e6777f886730ca1)
>commons-fileupload-1.3.3.pom
>(SHA1: 3dcfa2e705e8822b80c14949ba624f290cdfd04e)
>
> KEYS file to check signatures:
>http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>https://repository.apache.org/content/repositories/
> orgapachecommons-1252
>
> Please select one of the following options[1]:
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
> This vote will be open at least 72 hours, i.e. until
> 2017-06-13T02:00:00Z
> (this is UTC time).
> 
>
> Cheers,
> -Rob
>
> [1] http://apache.org/foundation/voting.html
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [fileupload] Remove @version tags from javadocs

[GitHub] commons-fileupload issue #1: Commons fileupload headerfix

[fileupload] Remove @version tags from javadocs

Re: [text] Deprecate CsvTranslators

[GitHub] commons-text issue #42: TEXT-83: Deprecate CsvTranslators from from commons ...

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

Re: NUMBERS-40: Review exception usage in package "o.a.c.numbers.gamma"

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC4

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

Re: [VOTE] Release Apache Commons Lang 3.6 based on RC4

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

Re: [VOTE] Release Commons Fileupload 1.3.3 based on RC6

13 matches

Site Navigation

Mail list logo

Footer information