[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

[ameyjadiye]

Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-text/pull/48
  
I think we are good to merge this as per discussion here 
[TEXT-88](https://issues.apache.org/jira/browse/TEXT-88)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/48
  

[![Coverage 
Status](https://coveralls.io/builds/12224670/badge)](https://coveralls.io/builds/12224670)

Coverage decreased (-0.002%) to 97.302% when pulling 
**3f5dfd4b1cc24fa31446a9ea5821cf267375e552 on ameyjadiye:TEXT-88** into 
**5e479dcd74dab262e5080991796395c3e29222b9 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-io pull request #38: FileUtils.readFileToByteArray - optimize readin...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-io/pull/38


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-io pull request #38: FileUtils.readFileToByteArray - optimize readin...

[ilmarmors]

GitHub user ilmarmors opened a pull request:

https://github.com/apache/commons-io/pull/38

FileUtils.readFileToByteArray - optimize reading of files with known size

IO-251 added optimization for reading files with known size as byte arrays, 
 but it was reverted in IO-453 due to regression, because File.length() method 
may return 0 for path files denoting system-dependent entities such as devices 
or pipes

More optimal solution is to treat 0 as unknown size, but if size is known 
(> 0) use more efficient approach and read content into pre-allocated byte 
array with exact size.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ilmarmors/commons-io master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-io/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #38


commit 3ce13884f3b2d78c6ca6cbf9a85c240c6b6532c3
Author: Ilmars Poikans 
Date:   2017-07-02T13:01:23Z

FileUtils.readFileToByteArray - optimize reading of files with known size




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org