Re: Git/Github Access

2017-07-06 Thread Gary Gregory 
I saw that. Cool.

Gary

On Thu, Jul 6, 2017 at 8:25 PM, Carl Hall  wrote:

> Thanks so much, Gary!  Looks like the bits are flowing now.
>
> On Wed, Jul 5, 2017 at 9:46 AM, Gary Gregory 
> wrote:
>
> > Carl,
> >
> > You are now in the Commons group per Whimsy.
> >
> > Gary
> >
> > On Wed, Jul 5, 2017 at 12:58 AM, sebb  wrote:
> >
> > > In the long term, we should ask INFRA to ensure all Commons repos are
> > > open to all committers.
> > >
> > > In the short term, a work-round is to update the Commons committer
> list.
> > >
> > > This can be done through Whimsy:
> > >
> > > https://whimsy.apache.org/roster/committee/commons
> > >
> > > I suspect only the chair can do so at present.
> > >
> > >
> > > On 4 July 2017 at 23:39, Carl Hall  wrote:
> > > > Ah, this appears to be common.
> > > > https://issues.apache.org/jira/browse/INFRA-12866
> > > >
> > > > So sorry to become a pest for this whole thing.  Should I file the
> > ticket
> > > > and ask for a PMC member to approve or is there a boilerplate ticket
> a
> > > PMC
> > > > member could copy & submit?  Thanks for all the help!
> > > >
> > > > On Mon, Jul 3, 2017 at 9:22 PM, Carl Hall 
> wrote:
> > > >
> > > >> Thanks, Gary!  I've started to put things together locally.  I tried
> > to
> > > >> push a branch, but don't seem to have access.
> > > >>
> > > >> Message from git:
> > > >> >remote: You are not authorized to edit this repository.
> > > >> >remote:
> > > >> >To https://git-wip-us.apache.org/repos/asf/commons-dbutils.git
> > > >> > ! [remote rejected] master -> master (pre-receive hook declined)
> > > >> >error: failed to push some refs to 'https://git-wip-us.apache.
> > > >> org/repos/asf/commons-dbutils.git'
> > > >>
> > > >> githbox.apache.org/setup tells me:
> > > >> >You do not seem to have access to any repositories. Please make
> sure
> > > you
> > > >> are in the correct LDAP groups!
> > > >>
> > > >> Is there anything I can update from my side?
> > > >>
> > > >>
> > > >>
> > > >> On Mon, Jul 3, 2017 at 4:50 PM, Gary Gregory <
> garydgreg...@gmail.com>
> > > >> wrote:
> > > >>
> > > >>> Hi All,
> > > >>>
> > > >>> I requested https://git-wip-us.apache.org/
> > > repos/asf/commons-dbutils.git
> > > >>>
> > > >>> Gary
> > > >>>
> > > >>> On Mon, Jul 3, 2017 at 2:53 PM, Carl Hall 
> > wrote:
> > > >>>
> > > >>> > Thanks, Benedikt!
> > > >>> >
> > > >>> > A lazy vote has succeeded for dbutils, but I may have jumped the
> > gun
> > > a
> > > >>> > bit.  I've just noticed that I can't request the git repo[1]
> > without
> > > >>> being
> > > >>> > on the PMC.  Would someone on the Commons PMC be so kind as to
> > > request
> > > >>> the
> > > >>> > new git repo?
> > > >>> >
> > > >>> > Thanks,
> > > >>> > Carl
> > > >>> >
> > > >>> > 1 https://reporeq.apache.org/
> > > >>> >
> > > >>> >
> > > >>> > On Wed, Jun 28, 2017 at 12:19 AM, Benedikt Ritter <
> > > brit...@apache.org>
> > > >>> > wrote:
> > > >>> >
> > > >>> > > Hi Carl,
> > > >>> > >
> > > >>> > > > Am 28.06.2017 um 05:48 schrieb Carl Hall <
> carl.h...@gmail.com
> > >:
> > > >>> > > >
> > > >>> > > > Hi friends,
> > > >>> > > >
> > > >>> > > > I'd like to move commons-dbutils to git rather than
> continuing
> > to
> > > >>> deal
> > > >>> > > with
> > > >>> > > > git-svn.  Could someone point me in the right direction for
> > > >>> requesting
> > > >>> > > this
> > > >>> > > > or point me to the right person/group to pose my request?
> > > >>> > >
> > > >>> > > The process is described here [1]. In short: start a vote by
> lazy
> > > >>> > > consensus, use the infra self service for requesting a
> > repository,
> > > >>> move
> > > >>> > the
> > > >>> > > code to that repository, move the SVN code base to the archive.
> > > >>> > >
> > > >>> > > Cheers,
> > > >>> > > Benedikt
> > > >>> > >
> > > >>> > > [1] https://wiki.apache.org/commons/MovingToGit <
> > > >>> > https://wiki.apache.org/
> > > >>> > > commons/MovingToGit>
> > > >>> > > >
> > > >>> > > > Thanks,
> > > >>> > > > Carl
> > > >>> > >
> > > >>> > >
> > > >>> >
> > > >>>
> > > >>
> > > >>
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > For additional commands, e-mail: dev-h...@commons.apache.org
> > >
> > >
> >
>

Re: Git/Github Access

2017-07-06 Thread Carl Hall 
Thanks so much, Gary!  Looks like the bits are flowing now.

On Wed, Jul 5, 2017 at 9:46 AM, Gary Gregory  wrote:

> Carl,
>
> You are now in the Commons group per Whimsy.
>
> Gary
>
> On Wed, Jul 5, 2017 at 12:58 AM, sebb  wrote:
>
> > In the long term, we should ask INFRA to ensure all Commons repos are
> > open to all committers.
> >
> > In the short term, a work-round is to update the Commons committer list.
> >
> > This can be done through Whimsy:
> >
> > https://whimsy.apache.org/roster/committee/commons
> >
> > I suspect only the chair can do so at present.
> >
> >
> > On 4 July 2017 at 23:39, Carl Hall  wrote:
> > > Ah, this appears to be common.
> > > https://issues.apache.org/jira/browse/INFRA-12866
> > >
> > > So sorry to become a pest for this whole thing.  Should I file the
> ticket
> > > and ask for a PMC member to approve or is there a boilerplate ticket a
> > PMC
> > > member could copy & submit?  Thanks for all the help!
> > >
> > > On Mon, Jul 3, 2017 at 9:22 PM, Carl Hall  wrote:
> > >
> > >> Thanks, Gary!  I've started to put things together locally.  I tried
> to
> > >> push a branch, but don't seem to have access.
> > >>
> > >> Message from git:
> > >> >remote: You are not authorized to edit this repository.
> > >> >remote:
> > >> >To https://git-wip-us.apache.org/repos/asf/commons-dbutils.git
> > >> > ! [remote rejected] master -> master (pre-receive hook declined)
> > >> >error: failed to push some refs to 'https://git-wip-us.apache.
> > >> org/repos/asf/commons-dbutils.git'
> > >>
> > >> githbox.apache.org/setup tells me:
> > >> >You do not seem to have access to any repositories. Please make sure
> > you
> > >> are in the correct LDAP groups!
> > >>
> > >> Is there anything I can update from my side?
> > >>
> > >>
> > >>
> > >> On Mon, Jul 3, 2017 at 4:50 PM, Gary Gregory 
> > >> wrote:
> > >>
> > >>> Hi All,
> > >>>
> > >>> I requested https://git-wip-us.apache.org/
> > repos/asf/commons-dbutils.git
> > >>>
> > >>> Gary
> > >>>
> > >>> On Mon, Jul 3, 2017 at 2:53 PM, Carl Hall 
> wrote:
> > >>>
> > >>> > Thanks, Benedikt!
> > >>> >
> > >>> > A lazy vote has succeeded for dbutils, but I may have jumped the
> gun
> > a
> > >>> > bit.  I've just noticed that I can't request the git repo[1]
> without
> > >>> being
> > >>> > on the PMC.  Would someone on the Commons PMC be so kind as to
> > request
> > >>> the
> > >>> > new git repo?
> > >>> >
> > >>> > Thanks,
> > >>> > Carl
> > >>> >
> > >>> > 1 https://reporeq.apache.org/
> > >>> >
> > >>> >
> > >>> > On Wed, Jun 28, 2017 at 12:19 AM, Benedikt Ritter <
> > brit...@apache.org>
> > >>> > wrote:
> > >>> >
> > >>> > > Hi Carl,
> > >>> > >
> > >>> > > > Am 28.06.2017 um 05:48 schrieb Carl Hall  >:
> > >>> > > >
> > >>> > > > Hi friends,
> > >>> > > >
> > >>> > > > I'd like to move commons-dbutils to git rather than continuing
> to
> > >>> deal
> > >>> > > with
> > >>> > > > git-svn.  Could someone point me in the right direction for
> > >>> requesting
> > >>> > > this
> > >>> > > > or point me to the right person/group to pose my request?
> > >>> > >
> > >>> > > The process is described here [1]. In short: start a vote by lazy
> > >>> > > consensus, use the infra self service for requesting a
> repository,
> > >>> move
> > >>> > the
> > >>> > > code to that repository, move the SVN code base to the archive.
> > >>> > >
> > >>> > > Cheers,
> > >>> > > Benedikt
> > >>> > >
> > >>> > > [1] https://wiki.apache.org/commons/MovingToGit <
> > >>> > https://wiki.apache.org/
> > >>> > > commons/MovingToGit>
> > >>> > > >
> > >>> > > > Thanks,
> > >>> > > > Carl
> > >>> > >
> > >>> > >
> > >>> >
> > >>>
> > >>
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >
>

[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...

2017-07-06 Thread jbduncan 
Github user jbduncan commented on the issue:

https://github.com/apache/commons-text/pull/55
  
@ameyjadiye I don't know if there's a convention in Apache Commons for 
preferring `new X.Builder()` over static factory methods like `X.builder()`, 
but if there isn't, then I would encourage changing the API so that instead of 
`new RandomStringGenerator.Builder()`, one can write the shorter and arguably 
more readable `RandomStringGenerator.builder()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...

2017-07-06 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/55
  
Sure...I'll try to look at this in the coming day or so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...

2017-07-06 Thread ameyjadiye 
Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-text/pull/55
  
@chtompki , @PascalSchumacher , can you please express your opinion on this 
, please check JIRA for detail discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #48: TEXT-88: Fixed issue with empty delimiters ar...

2017-07-06 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

2017-07-06 Thread ameyjadiye 
Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-text/pull/48
  
```isDelimiter``` is simply the method to identify if codePoint or char is 
present in given second parameter which is array. ofcource if array is empty it 
means first param is not present in array and should return false, I think 
overall behaviour of ```capitalizeFully```  is correct now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Graph] the future of commons-graph and modularization

2017-07-06 Thread Oliver Kopp 
Hi,

2013-05-26 17:35 GMT+02:00 Simone Tripodi :

> What I would like to propose to work _in a separated branch_, is
> trying to split the big monolith in smaller modules and separate APIs
> from related implementation as much as possible.

I know, I am very late to rejoin the party. :) Here some pointers, I
could reconstruct from the mails:

- current code:
http://svn.apache.org/viewvc/commons/sandbox/graph/trunk/src/main/java/
- the current modularization is going on at
http://svn.apache.org/viewvc/commons/sandbox/graph/branches/modularization/
- overview on alternatives to Apache Commons Graph:
https://issues.apache.org/jira/browse/SANDBOX-458

According to the homepage, there is no current release:
https://commons.apache.org/sandbox/commons-graph/

May I ask whether there is still some activity on Apache Commons Graph?

Is there a GitHub mirror of Sandbox as a whole or Graph?

What would be the required steps to make an initial release of Apache
Commons Graph and how could I support these steps?

Cheers,

Oliver
--
https://github.com/koppor/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...

2017-07-06 Thread chtompki 
Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/48
  
Should we add to `public static boolean isDelimiter(final char ch, final 
char[] delimiters)` or `isDelimiter` generally, documentation stating that if 
an empty array is passed in we always return false?

I'm torn on this. What are your thoughts @ameyjadiye?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [collections] How about a HashBidiMap?

2017-07-06 Thread Efremov, Rodion 
Having taking a closer look the way DualHashBidiMap and Java's HashMap are 
implemented, my implementation has only two advantages:


(1) It maintains an additional list of entries. This allows faster iteration 
since it does not have to visit empty collision chain buckets. Also, it allows 
faster relinking of the mapping objects when making the hash tables larger. (I 
believe this may be alleviated by using LinkedHashMaps in DualHashBidiMap 
instead of HashMaps.)


(2) Collision "chains" are actually collision (AVL) trees; this allows worst 
case logarithmic modification/access in case the hash function is poor.


What would your opinion on the above arrangements?


Best regards,

Rodion




From: Javen O'Neal 
Sent: Thursday, July 6, 2017 1:11:23 PM
To: Commons Developers List
Subject: Re: [collections] How about a HashBidiMap?

It wasn't a rhetorical question. I wanted to open discussion on your
contribution, and wanted to start with what folks on this mailing list are
most familiar with.

I'm not a Commons Collection maintainer, but I'm curious if you could
describe your implementation in a few sentences and how it differs from the
current DualHashBidiMap implementation. Is it faster than other
implementations? Does it have a lower memory footprint by sharing key and
value objects between two underlying HashMaps? Does it implement its own
HashMap interface implementing its own Map data structure?

Can you name one or two scenarios where your implementation would be
preferred over the existing implementations?

On Jul 6, 2017 11:56, "Efremov, Rodion"  wrote:

> From
> http://svn.apache.org/viewvc/commons/proper/collections/
> trunk/src/main/java/org/apache/commons/collections4/
> bidimap/DualHashBidiMap.java?view=markup
>
> "Commons Collections would welcome the addition of a direct hash-based
> implementation of the BidiMap interface"
>
> Guess I was wrong.
>
> 
> From: Javen O'Neal 
> Sent: Thursday, July 6, 2017 12:51:25 PM
> To: Commons Developers List
> Subject: Re: [collections] How about a HashBidiMap?
>
> How is this different from the existing DualHashBidiMap?
>
> https://commons.apache.org/proper/commons-collections/
> javadocs/api-release/org/apache/commons/collections4/
> bidimap/DualHashBidiMap.html
>
> On Jul 6, 2017 09:06, "Efremov, Rodion" 
> wrote:
>
> > Hello,
> >
> >
> > I am working on a hash table based BidiMap at
> > https://github.com/coderodde/BidirectionalHashMap/blob/
> > master/src/net/coderodde/util/BidirectionalHashMap.java
> >
> > and would like to contribute it to Commons Collections. Could someone
> > working on the project discuss my contribution attempt?
> >
> >
> > Best regards,
> >
> > Rodion
> >
> > [https://avatars2.githubusercontent.com/u/1770505?v=3=400] > github.com/coderodde/BidirectionalHashMap/blob/
> > master/src/net/coderodde/util/BidirectionalHashMap.java>
> >
> > coderodde/BidirectionalHashMap > BidirectionalHashMap/blob/master/src/net/coderodde/util/
> > BidirectionalHashMap.java>
> > github.com
> > BidirectionalHashMap - My implementation of a bidirectional bijective
> hash
> > map in Java
> >
> >
> >
>

Re: [collections] How about a HashBidiMap?

2017-07-06 Thread Javen O'Neal 
It wasn't a rhetorical question. I wanted to open discussion on your
contribution, and wanted to start with what folks on this mailing list are
most familiar with.

I'm not a Commons Collection maintainer, but I'm curious if you could
describe your implementation in a few sentences and how it differs from the
current DualHashBidiMap implementation. Is it faster than other
implementations? Does it have a lower memory footprint by sharing key and
value objects between two underlying HashMaps? Does it implement its own
HashMap interface implementing its own Map data structure?

Can you name one or two scenarios where your implementation would be
preferred over the existing implementations?

On Jul 6, 2017 11:56, "Efremov, Rodion"  wrote:

> From
> http://svn.apache.org/viewvc/commons/proper/collections/
> trunk/src/main/java/org/apache/commons/collections4/
> bidimap/DualHashBidiMap.java?view=markup
>
> "Commons Collections would welcome the addition of a direct hash-based
> implementation of the BidiMap interface"
>
> Guess I was wrong.
>
> 
> From: Javen O'Neal 
> Sent: Thursday, July 6, 2017 12:51:25 PM
> To: Commons Developers List
> Subject: Re: [collections] How about a HashBidiMap?
>
> How is this different from the existing DualHashBidiMap?
>
> https://commons.apache.org/proper/commons-collections/
> javadocs/api-release/org/apache/commons/collections4/
> bidimap/DualHashBidiMap.html
>
> On Jul 6, 2017 09:06, "Efremov, Rodion" 
> wrote:
>
> > Hello,
> >
> >
> > I am working on a hash table based BidiMap at
> > https://github.com/coderodde/BidirectionalHashMap/blob/
> > master/src/net/coderodde/util/BidirectionalHashMap.java
> >
> > and would like to contribute it to Commons Collections. Could someone
> > working on the project discuss my contribution attempt?
> >
> >
> > Best regards,
> >
> > Rodion
> >
> > [https://avatars2.githubusercontent.com/u/1770505?v=3=400] > github.com/coderodde/BidirectionalHashMap/blob/
> > master/src/net/coderodde/util/BidirectionalHashMap.java>
> >
> > coderodde/BidirectionalHashMap > BidirectionalHashMap/blob/master/src/net/coderodde/util/
> > BidirectionalHashMap.java>
> > github.com
> > BidirectionalHashMap - My implementation of a bidirectional bijective
> hash
> > map in Java
> >
> >
> >
>

Re: [collections] How about a HashBidiMap?

2017-07-06 Thread Efremov, Rodion 
From
http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bidimap/DualHashBidiMap.java?view=markup

"Commons Collections would welcome the addition of a direct hash-based 
implementation of the BidiMap interface"

Guess I was wrong.


From: Javen O'Neal 
Sent: Thursday, July 6, 2017 12:51:25 PM
To: Commons Developers List
Subject: Re: [collections] How about a HashBidiMap?

How is this different from the existing DualHashBidiMap?

https://commons.apache.org/proper/commons-collections/javadocs/api-release/org/apache/commons/collections4/bidimap/DualHashBidiMap.html

On Jul 6, 2017 09:06, "Efremov, Rodion"  wrote:

> Hello,
>
>
> I am working on a hash table based BidiMap at
> https://github.com/coderodde/BidirectionalHashMap/blob/
> master/src/net/coderodde/util/BidirectionalHashMap.java
>
> and would like to contribute it to Commons Collections. Could someone
> working on the project discuss my contribution attempt?
>
>
> Best regards,
>
> Rodion
>
> [https://avatars2.githubusercontent.com/u/1770505?v=3=400] github.com/coderodde/BidirectionalHashMap/blob/
> master/src/net/coderodde/util/BidirectionalHashMap.java>
>
> coderodde/BidirectionalHashMap BidirectionalHashMap/blob/master/src/net/coderodde/util/
> BidirectionalHashMap.java>
> github.com
> BidirectionalHashMap - My implementation of a bidirectional bijective hash
> map in Java
>
>
>

Re: [collections] How about a HashBidiMap?

2017-07-06 Thread Javen O'Neal 
How is this different from the existing DualHashBidiMap?

https://commons.apache.org/proper/commons-collections/javadocs/api-release/org/apache/commons/collections4/bidimap/DualHashBidiMap.html

On Jul 6, 2017 09:06, "Efremov, Rodion"  wrote:

> Hello,
>
>
> I am working on a hash table based BidiMap at
> https://github.com/coderodde/BidirectionalHashMap/blob/
> master/src/net/coderodde/util/BidirectionalHashMap.java
>
> and would like to contribute it to Commons Collections. Could someone
> working on the project discuss my contribution attempt?
>
>
> Best regards,
>
> Rodion
>
> [https://avatars2.githubusercontent.com/u/1770505?v=3=400] github.com/coderodde/BidirectionalHashMap/blob/
> master/src/net/coderodde/util/BidirectionalHashMap.java>
>
> coderodde/BidirectionalHashMap BidirectionalHashMap/blob/master/src/net/coderodde/util/
> BidirectionalHashMap.java>
> github.com
> BidirectionalHashMap - My implementation of a bidirectional bijective hash
> map in Java
>
>
>

[GitHub] commons-io pull request #40: IO-279: Added ignoreNew parameter on instantiat...

2017-07-06 Thread myyron 
GitHub user myyron opened a pull request:

https://github.com/apache/commons-io/pull/40

IO-279: Added ignoreNew parameter on instantiating Tailer.

Encountered this bug today when we try to tail a file that is being 
modified even though there is no new content being added.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myyron/commons-io IO_279

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-io/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 79dd3567811f0f155c43cb88f331489b85e6189c
Author: mlatorilla 
Date:   2017-07-06T08:44:57Z

IO-279: Added ignoreNew parameter on instantiating Tailer.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [compress] HasCharset is a bad name

2017-07-06 Thread Stefan Bodewig 
On 2017-07-05, Gary Gregory wrote:

> The new interface name HasCharset is pretty bad IMO.

fair enough.

> CharsetProvider is the obvious (to me) better name even though there
> already is a class called java.nio.charset.spi.CharsetProvider.

I don't think so, this really is a marker interface for classes also
implementing ZipEncoding (Simon didn't want to extend the existing
interface).

Hmm, maybe we could make it extend ZipEncoding and call it something
like ZipEncodingWithCharset?

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org