[GitHub] commons-text issue #58: Add tests

2017-07-28 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/58
  

[![Coverage 
Status](https://coveralls.io/builds/12601363/badge)](https://coveralls.io/builds/12601363)

Coverage increased (+0.06%) to 98.222% when pulling 
**49c25105742f9dc75a1a51800799c08f4f1c8434 on TheRealHaui:add-tests** into 
**6773be0a357988126d22decb82e75f601d9814b9 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text issue #58: Add tests

2017-07-28 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/58
  

[![Coverage 
Status](https://coveralls.io/builds/12601363/badge)](https://coveralls.io/builds/12601363)

Coverage increased (+0.06%) to 98.222% when pulling 
**49c25105742f9dc75a1a51800799c08f4f1c8434 on TheRealHaui:add-tests** into 
**6773be0a357988126d22decb82e75f601d9814b9 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text issue #58: Add tests

2017-07-28 Thread TheRealHaui
Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-text/pull/58
  
You're welcome!
Here we go regarding the exception detection code style.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [collections][proposal] Java 7

2017-07-28 Thread Gary Gregory
On Fri, Jul 28, 2017 at 5:40 AM, Rob Tompkins  wrote:

>
> > On Jul 27, 2017, at 12:53 PM, Gary Gregory 
> wrote:
> >
> > We have not in the past forced a major version and Maven coordinate
> change
> > when updating the Java platform. We could do that of course.
>
> I’m a tad surprised by this. It feels like updating the minimum
> accommodated java version would necessitate a major version change.
>

It does not.

If we want to break Binary Compatibility (BC), then we update the major
version, the package name (commons-lang -> commons-lang3), and the Maven
Coordinates (commons-lang -> commons-lang3). At that point, if the group ID
is not org.apache.commons, then we update that too.

In the past, BC has always meant API BC, not byte code level compatibility
(it's confusing that both acronyms are BC.) In some cases, we have broken
source-level compatibility without a major version changes.

Gary


>
> -Rob
>
> >
> > Gary
> >
> > On Jul 27, 2017 06:47, "Jochen Wiedmann" 
> wrote:
> >
> >> Wouldn't that make it 5.0? (Binary incompatible change)
> >>
> >> Note: I am not opposing the change, I just propose an additional
> >> change in the version number.
> >>
> >> Jochen
> >>
> >>
> >> On Wed, Jul 26, 2017 at 12:18 AM, Gary Gregory 
> >> wrote:
> >>> Hi All:
> >>>
> >>> I propose we make Java 7 the minimum for Commons Collection 4.2.
> >>>
> >>> Gary
> >>
> >>
> >>
> >> --
> >> The next time you hear: "Don't reinvent the wheel!"
> >>
> >> http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/
> >> evolution-of-the-wheel-300x85.jpg
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >> For additional commands, e-mail: dev-h...@commons.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


[GitHub] commons-text issue #59: add oraclejdk9 to travis configuration

2017-07-28 Thread ameyjadiye
Github user ameyjadiye commented on the issue:

https://github.com/apache/commons-text/pull/59
  
@chtompki , I'm testing same on my Commons Text fork , that shell file need 
a bit modification for Commons ,  will raise PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text issue #59: add oraclejdk9 to travis configuration

2017-07-28 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/59
  
Looks like a very complex setup.

But the actual travis report looks good:  
https://travis-ci.org/jacoco/jacoco/builds/255021437?utm_source=github_status_medium=notification


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text issue #59: add oraclejdk9 to travis configuration

2017-07-28 Thread chtompki
Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/59
  
Get a load of this:
https://github.com/jacoco/jacoco/blob/master/.travis.sh
https://github.com/jacoco/jacoco/blob/master/.travis.yml


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text pull request #59: add oraclejdk9 to travis configuration

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/59


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text issue #59: add oraclejdk9 to travis configuration

2017-07-28 Thread coveralls
Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/59
  

[![Coverage 
Status](https://coveralls.io/builds/12598637/badge)](https://coveralls.io/builds/12598637)

Coverage remained the same at 98.163% when pulling 
**be0a5aa0af58d184948cf044532f49f04a8f03f4 on 
PascalSchumacher:add_jdk9_to_travis** into 
**6773be0a357988126d22decb82e75f601d9814b9 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text pull request #59: add oraclejdk9 to travis configuration

2017-07-28 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-text/pull/59

add oraclejdk9 to travis configuration

add maven java9 profile:
- use maven-javadoc-plugin version 3.0.0-M1, because versions below 3.0.0 
do not work on java 9
- skip maven-coveralls-plugin, because version 4.3.0 does not work on java 
9, see https://github.com/trautonen/coveralls-maven-plugin/issues/112

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-text 
add_jdk9_to_travis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-text/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #59


commit be0a5aa0af58d184948cf044532f49f04a8f03f4
Author: Pascal Schumacher 
Date:   2017-07-28T17:43:44Z

add oraclejdk9 to travis configuration

add maven java9 profile:
- use maven-javadoc-plugin version 3.0.0-M1, because versions below 3.0.0 
do not work on java 9
- skip maven-coveralls-plugin, because version 4.3.0 does not work on java 
9, see https://github.com/trautonen/coveralls-maven-plugin/issues/112




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

2017-07-28 Thread chtompki
Github user chtompki commented on the issue:

https://github.com/apache/commons-cli/pull/15
  
I'll try to get to it today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

2017-07-28 Thread chtompki
Github user chtompki commented on the issue:

https://github.com/apache/commons-cli/pull/15
  
I'll try to get to it today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

2017-07-28 Thread rubin55
Github user rubin55 commented on the issue:

https://github.com/apache/commons-cli/pull/15
  
@chtompki Any progress on this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

2017-07-28 Thread rubin55
Github user rubin55 commented on the issue:

https://github.com/apache/commons-cli/pull/15
  
@chtompki Any progress on this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[Numbers] C99 (Was: [...] git commit: [NUMBERS-13] is closed.)

2017-07-28 Thread Gilles

Hi.

On Fri, 28 Jul 2017 11:34:48 -, ericbarnh...@apache.org wrote:

NUMBERS-13: Complex() passes all tests and meets all the C99
standards. This issue is closed.


Thanks for this work! :-)

Do you think of adding some info (in Javadoc, or in a "User guide")
about the new functionality (references and prominent features)?

Best,
Gilles



[...]



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [1/2] commons-numbers git commit: NUMBERS-13: atanh() passes all tests

2017-07-28 Thread Gilles

Hi Eric.

Changing
  0 -> 0.0
is not necessary, and since the latter is less esthetically pleasing,
why bother?
And, as usual, we should avoid mixing different types of changes in
the same commit.

Regards,
Gilles

On Fri, 28 Jul 2017 11:34:47 -, ericbarnh...@apache.org wrote:

Repository: commons-numbers
Updated Branches:
  refs/heads/complex-dev af5fc05bb -> 387f4e09b


NUMBERS-13: atanh() passes all tests


Project: http://git-wip-us.apache.org/repos/asf/commons-numbers/repo
Commit:

http://git-wip-us.apache.org/repos/asf/commons-numbers/commit/a9437c90
Tree: 
http://git-wip-us.apache.org/repos/asf/commons-numbers/tree/a9437c90
Diff: 
http://git-wip-us.apache.org/repos/asf/commons-numbers/diff/a9437c90


Branch: refs/heads/complex-dev
Commit: a9437c90666ca8c3045f1d59de1b77e536addba6
Parents: af5fc05
Author: Eric Barnhill 
Authored: Fri Jul 28 13:24:12 2017 +0200
Committer: Eric Barnhill 
Committed: Fri Jul 28 13:24:12 2017 +0200


--
 .../apache/commons/numbers/complex/Complex.java | 75 
+++-

 .../commons/numbers/complex/CStandardTest.java  |  4 +-
 2 files changed, 44 insertions(+), 35 deletions(-)

--



http://git-wip-us.apache.org/repos/asf/commons-numbers/blob/a9437c90/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java

--
diff --git

a/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java

b/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java
index fc3ff93..5a77a9f 100644
---

a/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java
+++

b/commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/Complex.java
@@ -641,7 +641,7 @@ in the
  * @return the inverse cosine of this complex number.
  */
 public Complex acos() {
-if (real == 0 && Double.isNaN(imaginary)) {
+if (real == 0.0&& Double.isNaN(imaginary)) {
 return new Complex(Math.PI * 0.5, Double.NaN);
 } else if (neitherInfiniteNorZeroNorNaN(real) && imaginary
== Double.POSITIVE_INFINITY) {
 return new Complex(Math.PI * 0.5, 
Double.NEGATIVE_INFINITY);

@@ -704,13 +704,13 @@ in the
 if (neitherInfiniteNorZeroNorNaN(real) && imaginary ==
Double.POSITIVE_INFINITY) {
 return new Complex(Double.POSITIVE_INFINITY, Math.PI * 
0.5);

 } else if (real == Double.POSITIVE_INFINITY &&
!Double.isInfinite(imaginary) && !Double.isNaN(imaginary)) {
-return new Complex(Double.POSITIVE_INFINITY, 0);
+return new Complex(Double.POSITIVE_INFINITY, 0.0);
 } else if (real == Double.POSITIVE_INFINITY && imaginary ==
Double.POSITIVE_INFINITY) {
 return new Complex(Double.POSITIVE_INFINITY, Math.PI * 
0.25);

 } else if (real == Double.POSITIVE_INFINITY &&
Double.isNaN(imaginary)) {
 return new Complex(Double.POSITIVE_INFINITY,  
Double.NaN);

-} else if (Double.isNaN(real) && imaginary == 0) {
-return new Complex(Double.NaN, 0);
+} else if (Double.isNaN(real) && imaginary == 0.0) {
+return new Complex(Double.NaN, 0.0);
 } else if (Double.isNaN(real) && imaginary ==
Double.POSITIVE_INFINITY) {
 return new Complex(Double.POSITIVE_INFINITY, 
Double.NaN);

 }
@@ -729,10 +729,10 @@ in the
  * @since 1.2
  */
 public Complex atanh(){
-if (real == 0  && Double.isNaN(imaginary)) {
+if (real == 0.0 && Double.isNaN(imaginary)) {
 return new Complex(0, Double.NaN);
-} else if (neitherInfiniteNorZeroNorNaN(real) && imaginary 
== 0) {

-return new Complex(Double.POSITIVE_INFINITY, 0);
+} else if (neitherInfiniteNorZeroNorNaN(real) && imaginary 
== 0.0) {

+return new Complex(Double.POSITIVE_INFINITY, 0.0);
 } else if (neitherInfiniteNorZeroNorNaN(real) && imaginary
== Double.POSITIVE_INFINITY) {
 return new Complex(0, Math.PI*0.5);
 } else if (real == Double.POSITIVE_INFINITY &&
neitherInfiniteNorZeroNorNaN(imaginary)) {
@@ -808,18 +808,18 @@ in the
  * @return the hyperbolic cosine of this complex number.
  */
 public Complex cosh() {
-if (real == 0 && imaginary == Double.POSITIVE_INFINITY) {
-return new Complex(Double.NaN, 0);
-} else if (real == 0 && Double.isNaN(imaginary)) {
-return new Complex(Double.NaN, 0);
-} else if (real == Double.POSITIVE_INFINITY && imaginary == 
0) {

-return new Complex(Double.POSITIVE_INFINITY, 0);
+if (real == 0.0&& imaginary == Double.POSITIVE_INFINITY) {
+return new Complex(Double.NaN, 0.0);
+} else if (real 

Re: [all/travis-ci] Regarding using ibmjava on travis

2017-07-28 Thread Rob Tompkins


> On Jul 28, 2017, at 8:32 AM, Amey Jadiye  wrote:
> 
> Thanks, I'm taking Commons Text as my test guineapig for jacoco style
> implementation , once confident in implementation we can move it to other
> components.
> 

Sounds good to me. 

> Regards,
> Amey
> 
>> On Jul 28, 2017 5:39 PM, "Rob Tompkins"  wrote:
>> 
>> 
>>> On Jul 27, 2017, at 4:10 PM, Amey Jadiye  wrote:
>>> 
>>> Hi Rob,
>>> 
>>> If this is still pending I would like to pickup this task. If docker is
>> not
>>> much  helpful OR we need to wait for it I think we should try what jacoco
>>> did. what do you think ?
>> 
>> Sure. That makes sense to me, especially since the Travis folks say that
>> they’ve got on the backlog to install the IBM JDKs on their build
>> environments.
>> 
>>> 
>>> Is it mandatory to use official java images ?Else I am also thinking to
>>> create my own ibmjdk8 image on top of given by IBM and have some tools
>> and
>>> scrips  ready in that so on fail it should return -1.
>> 
>> I contributed to the official maven docker image to add the ibm jdk, but
>> I”m not sure how the build works out there. So I’m not sure it’s in docker
>> hub yet.
>> 
>>> 
>>> Not sure how much travis-ci be helpful here since I saw Pascal removed
>>> oraclejdk7 from .travis configuration because its not available. I'm not
>>> keeping much hopes on Travis  at this point as their provision on
>> different
>>> jdk images seems very slow to me .
>> 
>> I think there was some flavour of issue with Java7 in that the image
>> wasn’t loading properly. It could be worth trying the jacoco approach to
>> see if that works.
>> 
>>  -Rob
>> 
>>> 
>>> Regards,
>>> Amey
>>> 
 On Sat, Jul 1, 2017, 6:43 PM Rob Tompkins  wrote:
 
 Hello all,
 
 Pardon my disappearance for the last week or so. My day job has been a
 little over consuming (c’est la vie). Regardless, I’ve been looking at
>> how
 we can use the current appetite in the travis-ci community to push them
>> to
 install ibmjava8 and ibmjava9 in this working thread:
 https://github.com/travis-ci/travis-ci/issues/2682 <
 https://github.com/travis-ci/travis-ci/issues/2682>. Hopefully we can
 gain some traction there.
 
 Regardless, they seem to have far more idk’s installed in their build
 environment than documented
 https://github.com/travis-ci/travis-cookbooks/tree/master/
>> cookbooks/travis_java/recipes
 <
 https://github.com/travis-ci/travis-cookbooks/tree/master/
>> cookbooks/travis_java/recipes>.
 Which, as Amey noted earlier, jacoco seems to be utilizing
 https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23 <
 https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23>.
 
 I’m not particularly looking for any responses to this email. I more
>> just
 wanted to document my current research efforts here.
 
 Cheers,
 -Rob
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [collections][proposal] Java 7

2017-07-28 Thread Rob Tompkins

> On Jul 27, 2017, at 12:53 PM, Gary Gregory  wrote:
> 
> We have not in the past forced a major version and Maven coordinate change
> when updating the Java platform. We could do that of course.

I’m a tad surprised by this. It feels like updating the minimum accommodated 
java version would necessitate a major version change.

-Rob

> 
> Gary
> 
> On Jul 27, 2017 06:47, "Jochen Wiedmann"  wrote:
> 
>> Wouldn't that make it 5.0? (Binary incompatible change)
>> 
>> Note: I am not opposing the change, I just propose an additional
>> change in the version number.
>> 
>> Jochen
>> 
>> 
>> On Wed, Jul 26, 2017 at 12:18 AM, Gary Gregory 
>> wrote:
>>> Hi All:
>>> 
>>> I propose we make Java 7 the minimum for Commons Collection 4.2.
>>> 
>>> Gary
>> 
>> 
>> 
>> --
>> The next time you hear: "Don't reinvent the wheel!"
>> 
>> http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/
>> evolution-of-the-wheel-300x85.jpg
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: [ALL] Moving view on builds.a.o

2017-07-28 Thread Rob Tompkins

> On Jul 27, 2017, at 10:39 PM, Gary Gregory  wrote:
> 
> You don't have karma to use what in the UI? I do not see a "move" kind of
> operation, only "new" ops.

That’s a good question. I suppose that I’m not certain what I should be able to 
see vs what I shouldn’t in the UI. But, all I really have the ability to do is 
trigger builds.

Do you know what the difference is between just having an apache LDAP account 
vs having had this run for your username:
https://cwiki.apache.org/confluence/display/INFRA/Jenkins#Jenkins-HowdoIgetanaccount
 


-Rob

> 
> Gary
> 
> On Wed, Jul 26, 2017 at 11:53 AM, Rob Tompkins  wrote:
> 
>> Happy to do it, but I don't have the correct permissions.
>> 
>>> On Jul 26, 2017, at 2:10 PM, Gary Gregory 
>> wrote:
>>> 
>>> Hi All:
>>> 
>>> Does anyone know how to move our view?
>>> 
>>> Please see the warning on https://builds.apache.org/
>> view/Apache%20Commons/
>>> 
>>> Gary
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
>> 



Re: [all/travis-ci] Regarding using ibmjava on travis

2017-07-28 Thread Amey Jadiye
Thanks, I'm taking Commons Text as my test guineapig for jacoco style
implementation , once confident in implementation we can move it to other
components.

Regards,
Amey

On Jul 28, 2017 5:39 PM, "Rob Tompkins"  wrote:

>
> > On Jul 27, 2017, at 4:10 PM, Amey Jadiye  wrote:
> >
> > Hi Rob,
> >
> > If this is still pending I would like to pickup this task. If docker is
> not
> > much  helpful OR we need to wait for it I think we should try what jacoco
> > did. what do you think ?
>
> Sure. That makes sense to me, especially since the Travis folks say that
> they’ve got on the backlog to install the IBM JDKs on their build
> environments.
>
> >
> > Is it mandatory to use official java images ?Else I am also thinking to
> > create my own ibmjdk8 image on top of given by IBM and have some tools
> and
> > scrips  ready in that so on fail it should return -1.
>
> I contributed to the official maven docker image to add the ibm jdk, but
> I”m not sure how the build works out there. So I’m not sure it’s in docker
> hub yet.
>
> >
> > Not sure how much travis-ci be helpful here since I saw Pascal removed
> > oraclejdk7 from .travis configuration because its not available. I'm not
> > keeping much hopes on Travis  at this point as their provision on
> different
> > jdk images seems very slow to me .
>
> I think there was some flavour of issue with Java7 in that the image
> wasn’t loading properly. It could be worth trying the jacoco approach to
> see if that works.
>
>   -Rob
>
> >
> > Regards,
> > Amey
> >
> > On Sat, Jul 1, 2017, 6:43 PM Rob Tompkins  wrote:
> >
> >> Hello all,
> >>
> >> Pardon my disappearance for the last week or so. My day job has been a
> >> little over consuming (c’est la vie). Regardless, I’ve been looking at
> how
> >> we can use the current appetite in the travis-ci community to push them
> to
> >> install ibmjava8 and ibmjava9 in this working thread:
> >> https://github.com/travis-ci/travis-ci/issues/2682 <
> >> https://github.com/travis-ci/travis-ci/issues/2682>. Hopefully we can
> >> gain some traction there.
> >>
> >> Regardless, they seem to have far more idk’s installed in their build
> >> environment than documented
> >> https://github.com/travis-ci/travis-cookbooks/tree/master/
> cookbooks/travis_java/recipes
> >> <
> >> https://github.com/travis-ci/travis-cookbooks/tree/master/
> cookbooks/travis_java/recipes>.
> >> Which, as Amey noted earlier, jacoco seems to be utilizing
> >> https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23 <
> >> https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23>.
> >>
> >> I’m not particularly looking for any responses to this email. I more
> just
> >> wanted to document my current research efforts here.
> >>
> >> Cheers,
> >> -Rob
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


Re: [all/travis-ci] Regarding using ibmjava on travis

2017-07-28 Thread Rob Tompkins

> On Jul 27, 2017, at 4:10 PM, Amey Jadiye  wrote:
> 
> Hi Rob,
> 
> If this is still pending I would like to pickup this task. If docker is not
> much  helpful OR we need to wait for it I think we should try what jacoco
> did. what do you think ?

Sure. That makes sense to me, especially since the Travis folks say that 
they’ve got on the backlog to install the IBM JDKs on their build environments.

> 
> Is it mandatory to use official java images ?Else I am also thinking to
> create my own ibmjdk8 image on top of given by IBM and have some tools and
> scrips  ready in that so on fail it should return -1.

I contributed to the official maven docker image to add the ibm jdk, but I”m 
not sure how the build works out there. So I’m not sure it’s in docker hub yet.

> 
> Not sure how much travis-ci be helpful here since I saw Pascal removed
> oraclejdk7 from .travis configuration because its not available. I'm not
> keeping much hopes on Travis  at this point as their provision on different
> jdk images seems very slow to me .

I think there was some flavour of issue with Java7 in that the image wasn’t 
loading properly. It could be worth trying the jacoco approach to see if that 
works.

  -Rob

> 
> Regards,
> Amey
> 
> On Sat, Jul 1, 2017, 6:43 PM Rob Tompkins  wrote:
> 
>> Hello all,
>> 
>> Pardon my disappearance for the last week or so. My day job has been a
>> little over consuming (c’est la vie). Regardless, I’ve been looking at how
>> we can use the current appetite in the travis-ci community to push them to
>> install ibmjava8 and ibmjava9 in this working thread:
>> https://github.com/travis-ci/travis-ci/issues/2682 <
>> https://github.com/travis-ci/travis-ci/issues/2682>. Hopefully we can
>> gain some traction there.
>> 
>> Regardless, they seem to have far more idk’s installed in their build
>> environment than documented
>> https://github.com/travis-ci/travis-cookbooks/tree/master/cookbooks/travis_java/recipes
>> <
>> https://github.com/travis-ci/travis-cookbooks/tree/master/cookbooks/travis_java/recipes>.
>> Which, as Amey noted earlier, jacoco seems to be utilizing
>> https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23 <
>> https://github.com/jacoco/jacoco/blob/master/.travis.yml#L14-L23>.
>> 
>> I’m not particularly looking for any responses to this email. I more just
>> wanted to document my current research efforts here.
>> 
>> Cheers,
>> -Rob


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org