date:20170801

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/61
  
In my opinion this is overkill. I don't think commons-text needs to be 
tested against the eclipse java compiler and early access version of java 8 and 
9. The script looks difficult to debug and maintain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #61: Added flexible Travis-ci build script.

2017-08-01 Thread chtompki

Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/61
  
I'll get to this soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

2017-08-01 Thread ameyjadiye

GitHub user ameyjadiye opened a pull request:

https://github.com/apache/commons-text/pull/61

Added flexible Travis-ci  build script.

This enables ua to use any jdk against our code and not keeps us dependency 
on Travis to provide jdk 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ameyjadiye/commons-text travis-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-text/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #61


commit 4af7ca425032c40ba71e23da0664d38a2d307576
Author: Amey Jadiye 
Date:   2017-07-29T14:49:17Z

added jacoco style travis build

commit 2bd09c827b2b1297b6b8fd4c85a7d4587b7bb1da
Author: Amey Jadiye 
Date:   2017-07-29T14:55:11Z

modified permission to executable file

commit 935be51655f57dcefe2ffd7dc15758cd12cc3047
Author: Amey Jadiye 
Date:   2017-07-29T15:00:47Z

removed java6 option

commit cba4a1e8740f60c760d31f501882f539b3cca055
Author: Amey Jadiye 
Date:   2017-07-29T18:30:17Z

added ibm java 8

commit f8fc754cedb19dd28e90a5673944d2a024356368
Author: Amey Jadiye 
Date:   2017-07-29T18:55:55Z

print system info

commit 4147b1bc07c4863bec07f3f4fcc8d04fe91281e8
Author: Amey Jadiye 
Date:   2017-07-29T19:17:43Z

install ibmjdk8 to ./

commit 796cc3a927c757aae15bd8710ad32c56387273fc
Author: Amey Jadiye 
Date:   2017-07-29T19:22:05Z

install ibmjdk8 to ./

commit 8827c044cf237b7a95d53d61cbc62a01e80639c9
Author: Amey Jadiye 
Date:   2017-07-30T11:22:17Z

check space on travis box

commit 111678e8679ec8d3fa73ebaf93b74a29eccdfd88
Author: Amey Jadiye 
Date:   2017-07-30T11:27:04Z

use trusty for build

commit e92323096cfd3fed7e0980144b31f98575fdd387
Author: Amey Jadiye 
Date:   2017-07-30T11:39:06Z

back to precise plus sudo truewq

commit 44c36828b5b335ee1df09d28a477ab9c88079157
Author: Amey Jadiye 
Date:   2017-08-01T19:28:34Z

using 64 bit edition




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #60: additional-tests

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-text/pull/60
  
You're welcome!
Thought it would be preferred by comments.
However, I will try to keep in mind.
And be cautious what you wish. ;-) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

Github user coveralls commented on the issue:

https://github.com/apache/commons-cli/pull/16
  

[![Coverage 
Status](https://coveralls.io/builds/12646111/badge)](https://coveralls.io/builds/12646111)

Coverage remained the same at 96.287% when pulling 
**d6dcadb6d7c8a25996a0e71ec482c419ae963ea0 on ameyjadiye:master** into 
**34fe9e5250a1a568b52ba277fdc86314c20aece3 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli issue #16: added findbug and checkstyle support while building

Github user coveralls commented on the issue:

https://github.com/apache/commons-cli/pull/16
  

[![Coverage 
Status](https://coveralls.io/builds/12646111/badge)](https://coveralls.io/builds/12646111)

Coverage remained the same at 96.287% when pulling 
**d6dcadb6d7c8a25996a0e71ec482c419ae963ea0 on ameyjadiye:master** into 
**34fe9e5250a1a568b52ba277fdc86314c20aece3 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Fwd: [2/2] commons-cli git commit: add default mvn default (clean, test, clirr, rat and javadoc) and run it on travis

2017-08-01 Thread Amey Jadiye

Just checked commons-cli pom.xml and found checkstyle and findbug support
is already present in reporting section, just copied same setting in build
section and we are good.

https://github.com/apache/commons-cli/pull/16

You are welcome :-)

Regards,
Amey


On Tue, Aug 1, 2017 at 11:26 PM, Pascal Schumacher  wrote:

> Imho yes, but to make this possible existing violations have to be
> analyzed and then either fixed or ignored.
>
>
> Am 01.08.2017 um 19:37 schrieb Amey Jadiye:
>
>> It would be nice to add checkstyle and findbug as well ?
>>
>> Regards,
>> Amey
>>
>> -- Forwarded message --
>> From: 
>> Date: Tue, Aug 1, 2017 at 10:57 PM
>> Subject: [2/2] commons-cli git commit: add default mvn default (clean,
>> test, clirr, rat and javadoc) and run it on travis
>> To: comm...@commons.apache.org
>>
>>
>> add default mvn default (clean, test, clirr, rat and javadoc) and run it
>> on
>> travis
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/commons-cli/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/commons-cli/commit/34
>> fe9e52
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-cli/tree/34fe9e52
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-cli/diff/34fe9e52
>>
>> Branch: refs/heads/master
>> Commit: 34fe9e5250a1a568b52ba277fdc86314c20aece3
>> Parents: 3637948
>> Author: pascalschumacher 
>> Authored: Tue Aug 1 19:27:50 2017 +0200
>> Committer: pascalschumacher 
>> Committed: Tue Aug 1 19:27:50 2017 +0200
>>
>> --
>>   .travis.yml | 3 +++
>>   pom.xml | 1 +
>>   2 files changed, 4 insertions(+)
>> --
>>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-cli/blob/34fe
>> 9e52/.travis.yml
>> --
>> diff --git a/.travis.yml b/.travis.yml
>> index 9f73b73..f9d9265 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -21,5 +21,8 @@ jdk:
>> - openjdk7
>> - oraclejdk8
>>
>> +script:
>> +  - mvn
>> +
>>   after_success:
>> - mvn clean test jacoco:report coveralls:report -Ptravis-jacoco
>>
>> http://git-wip-us.apache.org/repos/asf/commons-cli/blob/34fe9e52/pom.xml
>> --
>> diff --git a/pom.xml b/pom.xml
>> index cb2e0b4..124163b 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -193,6 +193,7 @@
>> 
>>
>> 
>> +clean verify apache-rat:check clirr:check
>> javadoc:javadoc
>>   
>> 
>>   maven-assembly-plugin
>>
>>
>>
>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #16: added findbug and checkstyle support while bui...

2017-08-01 Thread ameyjadiye

GitHub user ameyjadiye opened a pull request:

https://github.com/apache/commons-cli/pull/16

added findbug and checkstyle support while building



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ameyjadiye/commons-cli master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-cli/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit d6dcadb6d7c8a25996a0e71ec482c419ae963ea0
Author: Amey Jadiye 
Date:   2017-08-01T18:45:47Z

added findbug and checkstyle support while building




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

CVE-2017-9801: Apache Commons Email SMTP header injection vulnerabilty

2017-08-01 Thread Stefan Bodewig

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

CVE-2017-9801: Apache Commons Email SMTP header injection vulnerabilty

Severity: low

Vendor:
The Apache Software Foundation

Versions Affected:
Apache Commons Email 1.0 to 1.4.

Description:
When a call-site passes a subject for an email that contains
line-breaks, the caller can add arbitrary SMTP headers.

Mitigation:
Users should upgrade to Commons Email 1.5.
You can mitigate this vulnerability for older versions of Commons
Email by stripping line-breaks from the subject before passing it to
the setSubject(String) method.

Credit:
This issue was discovered by Adam Williams.

References:
http://commons.apache.org/proper/commons-email/security-reports.html
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iEYEARECAAYFAlmAyP8ACgkQohFa4V9ri3K7XQCgj69yH9nkBGRVJBG9+0DS1jc8
GJUAnRZrLznaNRzokj08JGBMy5wwHNTt
=oSDx
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANN] Apache Commons Email 1.5 Released

2017-08-01 Thread Stefan Bodewig

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

The Apache Commons Team is pleased to announce the release of Apache
Commons Email 1.5.

This is a major and security bugfix release which adds some new
features and fixes several bugs present in the 1.4 release. All
current users are encouraged to upgrade.

For the security bugfix see
https://commons.apache.org/proper/commons-email/security-reports.html#Fixed_in_Apache_Commons_Email_1.5

The Apache Commons Email Library aims to provide a API for sending
email. It builds on the JavaMail API with the aim of presenting a
simplified API which is easy for developers who are not mail experts
to use. It is a compact component with a small number of classes.

Source and binary distributions are available for download from the
Apache Commons download site:

http://commons.apache.org/proper/commons-email/download_email.cgi

When downloading, please verify signatures using the KEYS file available
at the above location when downloading the release.

Changes in this version include:

== Compatibility ==

* Java 6 or later is required.

* JavaMail dependency has been upgraded to version 1.5.6,
as a consequence, the maven dependency has changed to:

com.sun.mail
javax.mail
1.5.6

== New Features ==

* Add Support for International Domain Names. This change requires JDK 1.6+.
Issue: EMAIL-160

* Add Email#getHeader(String) and Email#getHeaders() methods.
Issue: EMAIL-154. Thanks to Ken Geis, Balachandran Sivakumar

== Updates ==

* Update Oracle JavaMail dependency from 1.5.2 to 1.5.6.
Issue: EMAIL-165.

* Remove "javax.activation" dependency since it is included in JDK 1.6
Issue: EMAIL-161.

== Fixed Bugs ==

* DataSourceClassPathResolver doesn't close InputStream when resolving resources
Issue: EMAIL-167. Thanks to Lucian Burja.

* CVE-2017-9801 - stripped all line-breaks from subjects in order to
prevent SMTP header injection.

For complete information on Commons Email, including instructions
on how to submit bug reports, patches, or suggestions for improvement,
see the Apache Commons Email website:

http://commons.apache.org/email/

Stefan Bodewig, on behalf of the Apache Commons community
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iEYEARECAAYFAlmAyFMACgkQohFa4V9ri3J+kACcDuO7+0echoLLZPDglWkot2FD
FlIAoJ5Lu12NRpmnnl6tVAP3qS8MK513
=t6js
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Fwd: [2/2] commons-cli git commit: add default mvn default (clean, test, clirr, rat and javadoc) and run it on travis

2017-08-01 Thread Pascal Schumacher

Imho yes, but to make this possible existing violations have to be 
analyzed and then either fixed or ignored.


Am 01.08.2017 um 19:37 schrieb Amey Jadiye:

It would be nice to add checkstyle and findbug as well ?

Regards,
Amey

-- Forwarded message --
From: 
Date: Tue, Aug 1, 2017 at 10:57 PM
Subject: [2/2] commons-cli git commit: add default mvn default (clean,
test, clirr, rat and javadoc) and run it on travis
To: comm...@commons.apache.org


add default mvn default (clean, test, clirr, rat and javadoc) and run it on
travis


Project: http://git-wip-us.apache.org/repos/asf/commons-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-cli/commit/34fe9e52
Tree: http://git-wip-us.apache.org/repos/asf/commons-cli/tree/34fe9e52
Diff: http://git-wip-us.apache.org/repos/asf/commons-cli/diff/34fe9e52

Branch: refs/heads/master
Commit: 34fe9e5250a1a568b52ba277fdc86314c20aece3
Parents: 3637948
Author: pascalschumacher 
Authored: Tue Aug 1 19:27:50 2017 +0200
Committer: pascalschumacher 
Committed: Tue Aug 1 19:27:50 2017 +0200

--
  .travis.yml | 3 +++
  pom.xml | 1 +
  2 files changed, 4 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/commons-cli/blob/34fe9e52/.travis.yml
--
diff --git a/.travis.yml b/.travis.yml
index 9f73b73..f9d9265 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -21,5 +21,8 @@ jdk:
- openjdk7
- oraclejdk8

+script:
+  - mvn
+
  after_success:
- mvn clean test jacoco:report coveralls:report -Ptravis-jacoco

http://git-wip-us.apache.org/repos/asf/commons-cli/blob/34fe9e52/pom.xml
--
diff --git a/pom.xml b/pom.xml
index cb2e0b4..124163b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -193,6 +193,7 @@



+clean verify apache-rat:check clirr:check
javadoc:javadoc
  

  maven-assembly-plugin







-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Fwd: [2/2] commons-cli git commit: add default mvn default (clean, test, clirr, rat and javadoc) and run it on travis

2017-08-01 Thread Amey Jadiye

It would be nice to add checkstyle and findbug as well ?

Regards,
Amey

-- Forwarded message --
From: 
Date: Tue, Aug 1, 2017 at 10:57 PM
Subject: [2/2] commons-cli git commit: add default mvn default (clean,
test, clirr, rat and javadoc) and run it on travis
To: comm...@commons.apache.org


add default mvn default (clean, test, clirr, rat and javadoc) and run it on
travis


Project: http://git-wip-us.apache.org/repos/asf/commons-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-cli/commit/34fe9e52
Tree: http://git-wip-us.apache.org/repos/asf/commons-cli/tree/34fe9e52
Diff: http://git-wip-us.apache.org/repos/asf/commons-cli/diff/34fe9e52

Branch: refs/heads/master
Commit: 34fe9e5250a1a568b52ba277fdc86314c20aece3
Parents: 3637948
Author: pascalschumacher 
Authored: Tue Aug 1 19:27:50 2017 +0200
Committer: pascalschumacher 
Committed: Tue Aug 1 19:27:50 2017 +0200

--
 .travis.yml | 3 +++
 pom.xml | 1 +
 2 files changed, 4 insertions(+)
--


http://git-wip-us.apache.org/repos/asf/commons-cli/blob/34fe9e52/.travis.yml
--
diff --git a/.travis.yml b/.travis.yml
index 9f73b73..f9d9265 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -21,5 +21,8 @@ jdk:
   - openjdk7
   - oraclejdk8

+script:
+  - mvn
+
 after_success:
   - mvn clean test jacoco:report coveralls:report -Ptravis-jacoco

http://git-wip-us.apache.org/repos/asf/commons-cli/blob/34fe9e52/pom.xml
--
diff --git a/pom.xml b/pom.xml
index cb2e0b4..124163b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -193,6 +193,7 @@
   

   
+clean verify apache-rat:check clirr:check
javadoc:javadoc
 
   
 maven-assembly-plugin




-- 

-

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #57: TEXT-98: Remove isDelimiter and use HashSets ...

2017-08-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/57


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #60: additional-tests

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-text/pull/60
  
Thanks! :+1: 

By the way: Feel free to raise a jira issue for anything you think that 
maybe be a bug (e.g. NullPointerExceptions). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #60: additional-tests

2017-08-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/commons-text/pull/60


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...

2017-08-01 Thread chtompki

Github user chtompki commented on the issue:

https://github.com/apache/commons-text/pull/57
  
Will get to this today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...

2017-08-01 Thread arunvinudss

Github user arunvinudss commented on the issue:

https://github.com/apache/commons-text/pull/57
  
@chtompki Please review and merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...

Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/57
  

[![Coverage 
Status](https://coveralls.io/builds/12640859/badge)](https://coveralls.io/builds/12640859)

Coverage decreased (-0.2%) to 98.021% when pulling 
**fb6d5935451397c561bd52cf1d483975f83b2c7b on arunvinudss:TEXT-98** into 
**998764ebe38113eb51e6850058ca01936625dd92 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #60: additional-tests

Github user PascalSchumacher commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/60#discussion_r130633380
  
--- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java 
---
@@ -592,4 +593,43 @@ public void testUnscapeXSI() {
 assertEquals("", unescapeXSI("\\"));
 }
 
+@Test
+public void testUnescapeEcmaScript() {
+assertNull("Should be null.", 
StringEscapeUtils.unescapeEcmaScript(null));
+assertEquals("8lvc1u+6B#-I", 
StringEscapeUtils.unescapeEcmaScript("8lvc1u+6B#-I"));
+assertEquals("",
+StringEscapeUtils.unescapeEcmaScript("")
+);
+assertEquals(">",
+StringEscapeUtils.unescapeEcmaScript(">")
+);
+}
+
+@Test
+public void testEscapeHtmlFour() {
+assertNull("Should be null.", StringEscapeUtils.escapeHtml3(null));
+assertEquals("a", StringEscapeUtils.escapeHtml3("a"));
+assertEquals("ba", StringEscapeUtils.escapeHtml3("a"));
+}
+
+@Test
+public void testUnescapeJson() {
+
+String jsonString = 
"{\"age\":100,\"name\":\"kyong.com\n\",\"messages\":[\"msg 1\",\"msg 2\",\"msg 
3\"]}";
+
+assertEquals("", StringEscapeUtils.unescapeJson(""));
+assertEquals(" ", StringEscapeUtils.unescapeJson(" "));
+assertEquals("a:b", StringEscapeUtils.unescapeJson("a:b"));
+assertEquals(jsonString, 
StringEscapeUtils.unescapeJson(jsonString));
+}
+
+@Ignore("Bug found.")
+@Test
+public void testUnescapeJsonFoundBug() {
--- End diff --

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[RESULT] Release Commons Email 1.5 Based on RC1

2017-08-01 Thread Stefan Bodewig

Hi all

with the binding +1s by Oliver Heger, Gary Gregory and myself (cast
implicitly) as well as the +1 by Amey Jadiye this vote has passed.

I'll publish the artifacts and give the mirrors a little time to catch
up before announcing the release.

Many thanks to those who reviewed the release

 Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #60: additional-tests

Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/60
  

[![Coverage 
Status](https://coveralls.io/builds/12639540/badge)](https://coveralls.io/builds/12639540)

Coverage increased (+0.3%) to 98.489% when pulling 
**fd33b1cbbc7e1188ebe2b1580606d5d1dbb12329 on TheRealHaui:additional-tests** 
into **998764ebe38113eb51e6850058ca01936625dd92 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging issue #30: add-tests

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-imaging/pull/30
  
Checks failed due to Travis JDK crashing not due to problems in code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #60: additional-tests

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-text/pull/60
  
Rechecked for blank lines and removed them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #60: additional-tests

Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/60#discussion_r130609309
  
--- Diff: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java 
---
@@ -592,4 +593,43 @@ public void testUnscapeXSI() {
 assertEquals("", unescapeXSI("\\"));
 }
 
+@Test
+public void testUnescapeEcmaScript() {
+assertNull("Should be null.", 
StringEscapeUtils.unescapeEcmaScript(null));
+assertEquals("8lvc1u+6B#-I", 
StringEscapeUtils.unescapeEcmaScript("8lvc1u+6B#-I"));
+assertEquals("",
+StringEscapeUtils.unescapeEcmaScript("")
+);
+assertEquals(">",
+StringEscapeUtils.unescapeEcmaScript(">")
+);
+}
+
+@Test
+public void testEscapeHtmlFour() {
+assertNull("Should be null.", StringEscapeUtils.escapeHtml3(null));
+assertEquals("a", StringEscapeUtils.escapeHtml3("a"));
+assertEquals("ba", StringEscapeUtils.escapeHtml3("a"));
+}
+
+@Test
+public void testUnescapeJson() {
+
+String jsonString = 
"{\"age\":100,\"name\":\"kyong.com\n\",\"messages\":[\"msg 1\",\"msg 2\",\"msg 
3\"]}";
+
+assertEquals("", StringEscapeUtils.unescapeJson(""));
+assertEquals(" ", StringEscapeUtils.unescapeJson(" "));
+assertEquals("a:b", StringEscapeUtils.unescapeJson("a:b"));
+assertEquals(jsonString, 
StringEscapeUtils.unescapeJson(jsonString));
+}
+
+@Ignore("Bug found.")
+@Test
+public void testUnescapeJsonFoundBug() {
--- End diff --

Done.
See https://issues.apache.org/jira/browse/TEXT-100.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #60: additional-tests