Re: [COLLECTIONS] Test failures on Windows

2017-09-25 Thread Bruno P. Kinoshita 
I have the environment prepared to debug it but didn't have time for it before 
going overseas.
If anyone has a Win + jvm8 environment, clone the repo and run the 
HashSetValuedHashMapTest.
The failures happen in the inherited tests, from the Abstract... test class.
My idea was to copy one of these methods to the HashSetValuedHashMapTest for 
ease of debugging. Disable other tests, and try to understand what's wrong with 
the HashSetValuedHashMap data structure.
I think I saw an ArrayList somewhere being pre initialized. I kind of remember 
of an issue in some JVM involving arraylist elements order after 
initialization... maybe some of it will be helpful if anyone decides to have 
fun debugging it?
Happy to investigate once I'm back in two weeks.
CheersBruno
Sent from Yahoo Mail on Android 
 
  On Tue, 26 Sep 2017 at 4:02, Benedikt Ritter wrote:   Hi,

who can help with the test failures on Windows? I’d like to push out the next 
release soon to get Collections Java 9 ready. I don’t have access to a Windows 
installation and I don’t feel like debugging inside a VM :o)

Regards,
Benedikt



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
  
 
 
  On Tue, 26 Sep 2017 at 4:02, Benedikt Ritter wrote:   Hi,

who can help with the test failures on Windows? I’d like to push out the next 
release soon to get Collections Java 9 ready. I don’t have access to a Windows 
installation and I don’t feel like debugging inside a VM :o)

Regards,
Benedikt



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-io pull request #44: Add another test for ClassLoaderObjectInputStre...

2017-09-25 Thread testingsavvy 
GitHub user testingsavvy opened a pull request:

https://github.com/apache/commons-io/pull/44

Add another test for ClassLoaderObjectInputStream::resolveProxyClass

Currently, `ClassLoaderObjectInputStreamTest::testResolveProxyClass` only 
tests `ClassLoaderObjectInputStream::resolveProxyClass` with single-element 
array. This PR adds a new test to check for the case where the `Proxy` class is 
assignable from multiple interfaces, and that the `Proxy` class is only a proxy 
for the interfaces that it implements.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/testingsavvy/commons-io master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-io/pull/44.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #44


commit 4d5e45cdb44f61202ce439caa3d417813375f9b7
Author: Owolabi Legunsen 
Date:   2017-09-25T19:39:34Z

added test to exercise ClassLoaderObjectInputStream::resolveProxyClass with 
multiple interfaces




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text

2017-09-25 Thread coveralls 
Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/62
  

[![Coverage 
Status](https://coveralls.io/builds/13422531/badge)](https://coveralls.io/builds/13422531)

Coverage increased (+0.002%) to 98.238% when pulling 
**f7758f1d880660918dcae933f2f4aa284b66d6a2 on ameyjadiye:TEXT-101** into 
**3bb08232fe080f6e421d51a0856d77ce44ea2e2a on apache:master**.



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ALL] Javadoc.io - a new GitHub badge for our projects?

2017-09-25 Thread Benedikt Ritter 
I’ve added this to commons-lang. It can be reviewed on the GitHub mirror.

> Am 18.09.2017 um 12:17 schrieb Amey Jadiye :
> 
> +1, LGTM.
> 
> Regards,
> Amey
> 
> On Mon, Sep 18, 2017, 3:24 PM Benedikt Ritter  wrote:
> 
>> Hi,
>> 
>> I just became aware of https://javadoc.io/  a
>> website which provides hosting for all javadocs on Maven Central. They also
>> provide badges for GitHub. Do we want to add this to our README.md files?
>> 
>> Cheers,
>> Benedikt
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #19: JIRA issue - CLI-279- adding period to javadoc...

2017-09-25 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-cli/pull/19


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-cli pull request #19: JIRA issue - CLI-279- adding period to javadoc...

2017-09-25 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/commons-cli/pull/19


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[COLLECTIONS] Test failures on Windows

2017-09-25 Thread Benedikt Ritter 
Hi,

who can help with the test failures on Windows? I’d like to push out the next 
release soon to get Collections Java 9 ready. I don’t have access to a Windows 
installation and I don’t feel like debugging inside a VM :o)

Regards,
Benedikt



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [JCS] Recent commit and binary compatiblity

2017-09-25 Thread Thomas Vandahl 
On 25.09.17 17:19, Gary Gregory wrote:
> The recent trunk commits to [JCS] for 3.0-SNAPSHOT break binary
> compatibility.
> 
> Will there be upcoming package name and Maven coordinate changes?

If that is unavoidable, yes. Let's first push 2.2.1 out.

Bye, Thomas


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #62: TEXT-101: Moved RandomStringUtils to Commons-...

2017-09-25 Thread ameyjadiye 
Github user ameyjadiye commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/62#discussion_r140843601
  
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java 
---
@@ -324,6 +324,40 @@ public Builder withinRange(final int minimumCodePoint, 
final int maximumCodePoin
 
 /**
  * 
+ * Specifies the array of minimum and maximum char allowed in the
+ * generated string.
+ * 
+ *
+ * For example:
+ * 
+ * {@code
+ * char [][] pairs = {{'0','9'}};
+ * char [][] pairs = {{'a','z'}};
+ * char [][] pairs = {{'a','z'},{'0','9'}};
+ * }
+ * 
+ *
+ * @param pairs array of charachters array, expected is to pass 
min, max pairs through this arg.
+ * @return {@code this}, to allow method chaining.
+ */
+public Builder withinRange(final char[] ... pairs) {
+characterList = new ArrayList();
+for (char[] pair :  pairs) {
+final int minimumCodePoint = pair[0];
+final int maximumCodePoint = pair[1];
--- End diff --

I think we should put that for better exception handling, also check of 
```minimumCodePoint  < maximumCodePoint ```, thanks



---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #62: TEXT-101: Moved RandomStringUtils to Commons-...

2017-09-25 Thread chtompki 
Github user chtompki commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/62#discussion_r140835603
  
--- Diff: src/main/java/org/apache/commons/text/RandomStringGenerator.java 
---
@@ -324,6 +324,40 @@ public Builder withinRange(final int minimumCodePoint, 
final int maximumCodePoin
 
 /**
  * 
+ * Specifies the array of minimum and maximum char allowed in the
+ * generated string.
+ * 
+ *
+ * For example:
+ * 
+ * {@code
+ * char [][] pairs = {{'0','9'}};
+ * char [][] pairs = {{'a','z'}};
+ * char [][] pairs = {{'a','z'},{'0','9'}};
+ * }
+ * 
+ *
+ * @param pairs array of charachters array, expected is to pass 
min, max pairs through this arg.
+ * @return {@code this}, to allow method chaining.
+ */
+public Builder withinRange(final char[] ... pairs) {
+characterList = new ArrayList();
+for (char[] pair :  pairs) {
+final int minimumCodePoint = pair[0];
+final int maximumCodePoint = pair[1];
--- End diff --

Do we want validation on the definition of a `pair` here? Do we want to 
throw an `InvalidParameterException` in this fashion:
```java
for(char[] pair: pairs) {
if (pair.length != 2) {
  throw new InvalidParameterException("A char[] pair should look 
like {'', ''}");
}
}
I'm not sure. I could go either way. Thoughts?
```


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [chain] Is anybody still interested

2017-09-25 Thread Benedikt Ritter 
Hello Manfred.

> Am 19.09.2017 um 09:03 schrieb Manfred Wolff :
> 
> Hi everybody
> 
> In the early 2000 I used to use commons chain very often. The approach is 
> nice: Small pieces of software, well testable, configurable via XML or 
> Spring, what ever.
> 
> I have an own framework, modern implemented with generics, and I wonder if 
> the "commons" community is interested in. It is still part of maven 
> repository and documentation is found here: 
> https://mwolff.info/wiki/display/SCF/Documentation+version+1.5 (of course has 
> to pimp actually I'm not a native English)
> 
> So my question is:
> 
> 
> -  Is anybody interested?
> 
> -  Who is the best contact person to discuss?
> 
> -  What are the quality gates?
> 
> -  Does it matter?

I worked on Chain 2.0 a few years ago, but nobody really cared. So I started 
working on other things. There hasn’t been much interest in Chain for a long 
time, so I’m not sure it’s worth the effort to revamp it.

Cheers,
Benedikt

> 
> Thanks for your ear
> Manfred
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons JCS 2.2.1

2017-09-25 Thread Gary Gregory 
-1

The file
https://dist.apache.org/repos/dist/dev/commons/jcs/source/commons-jcs-dist-2.2.1-src.zip
does not contain any of the modules folders.

Gary

On Sun, Sep 24, 2017 at 5:01 AM, Romain Manni-Bucau 
wrote:

> As announced on the list, I would like to release the [jcs] component to
> resolve a cdi performance issue (
> https://issues.apache.org/jira/browse/JCS-183).
>
>  Maven artifacts are at:
> https://repository.apache.org/content/repositories/orgapachecommons-1269/
>
>  The Subversion tag is:
> http://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2.1/
>
>  The release notes are available at:
> http://svn.apache.org/repos/asf/commons/proper/jcs/tags/
> commons-jcs-2.2.1/RELEASE-NOTES.txt
>
>  The staged sources and binaries are available at
> https://dist.apache.org/repos/dist/dev/commons/jcs/
>
>  Please review the release candidate and vote.
>
>[ ] +1 Release these artifacts
>[ ] +-0 don't care
>[ ] -1 I oppose this release because ${reason}
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github  rmannibucau> |
> LinkedIn  | JavaEE Factory
> 
>

[JCS] Recent commit and binary compatiblity

2017-09-25 Thread Gary Gregory 
Hi All:

The recent trunk commits to [JCS] for 3.0-SNAPSHOT break binary
compatibility.

Will there be upcoming package name and Maven coordinate changes?

Gary

[GitHub] commons-cli pull request #19: JIRA issue - CLI-279- adding period to javadoc...

2017-09-25 Thread kandunoori 
GitHub user kandunoori opened a pull request:

https://github.com/apache/commons-cli/pull/19

JIRA issue - CLI-279- adding period to javadocs

Fix for JIRA issue https://issues.apache.org/jira/browse/CLI-279. Adding 
period to javadocs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kandunoori/commons-cli 
commons-cli-adding-period-to-javadoc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-cli/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit 04697739edb6b60ecdbcccbfeb4e787728674942
Author: Krishna Mohan 
Date:   2017-09-24T15:36:30Z

adding period to javadocs




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [RESULT][VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-25 Thread Rob Tompkins 

> On Sep 25, 2017, at 2:56 AM, Benedikt Ritter  wrote:
> 
>> 
>> Am 24.09.2017 um 02:50 schrieb Rob Tompkins > >:
>> 
>> The following votes were case:
>> 
>> Gary Gregory +1 (binding)
>> Oliver Heger +1 (binding)
>> Rob Tompkins +1 (binding)
>> 
>> Thus, the vote passes.
>> 
>> Many thanks to all who voted. I will proceed with the release processing. 
> 
> Good job! Sorry, I didn’t have the time to help here.

No worries. :-)

> 
>> 
>>> On Sep 20, 2017, at 9:36 AM, Rob Tompkins  wrote:
>>> 
>>> Hello,
>>> 
>>> Commons Jelly 1.0.1 RC6 is available for review here:
>>> https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision 21718)
>>> 
>>> The tag is here (tag commit 1808993):
>>> https://svn.apache.org/repos/asf/commons/proper/jelly/tags/commons-jelly-1.0.1-RC6
>>> 
>>> Commit the tag points at:
>>> 1808992
>>> 
>>> Maven Artifacts:
>>> https://repository.apache.org/content/repositories/orgapachecommons-1264
>>> 
>>> These are the Maven artifacts and their hashes:
>>> 
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar
>>> 
>>> (SHA1: 3a81887847dac154c12171028f01e4dd252a0fd0)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc
>>> 
>>> (SHA1: 465eea91cc0a7f088ea8bd571e4633ef1904713a)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar
>>> 
>>> (SHA1: c6c6c1a54b12f268d24abc6a0f920bd2e5896d4c)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc
>>> 
>>> (SHA1: e24cc221bed60203d74f17b93cdfb12d5ca607f6)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar
>>> 
>>> (SHA1: 71b63b2619a8767d9d0ac0530dcb208f307261ff)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar.asc
>>> 
>>> (SHA1: f07dc38b9e4da5860fdad861c815876814184570)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar
>>> 
>>> (SHA1: 59525df8d5ac104d72c77792da2f72cf381f4420)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc
>>> 
>>> (SHA1: c99baf87964992e674435f69e7d4270803c5b956)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar
>>> 
>>> (SHA1: a20261c0f6be2fa4d6572fe22da0450d93195de9)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc
>>> 
>>> (SHA1: 68fb5704f4ca3aefe4fa3369c85b3257be7bfa2c)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom
>>> 
>>> (SHA1: ea2c451db75da2384ab5a51e9f1dc2b21c8e14cb)
>>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc
>>> 
>>> (SHA1: 4f1945ac4669c0bdb186f37d4bc56a864a6c5050)
>>> 
>>> I have tested this with JDK 1.5.0_22-b03 using Ant 1.6.0. Notes on building 
>>> can
>>> be found in the 
>>> BUILDING.md, included in the source distributions. And, the only changes 
>>> between
>>> release candidates are documentation and build script changes.
>>> 
>>> Details of changes since 1.0 are in the release notes:
>>>  https://dist.apache.org/repos/dist/dev/commons/jelly/RELEASE-NOTES.txt
>>> 
>>> Site:
>>>I have no site as this was generated with ant. My plan was to simply make
>>> minimal 
>>>changes to the existant site for the purpose of documenting the patch.
>>> 
>>> KEYS:
>>> https://www.apache.org/dist/commons/KEYS
>>> 
>>> Please review the

Re: [RESULT][VOTE] Release commons-jelly-1.0.1 based on RC6

2017-09-25 Thread Benedikt Ritter 

> Am 24.09.2017 um 02:50 schrieb Rob Tompkins :
> 
> The following votes were case:
> 
> Gary Gregory +1 (binding)
> Oliver Heger +1 (binding)
> Rob Tompkins +1 (binding)
> 
> Thus, the vote passes.
> 
> Many thanks to all who voted. I will proceed with the release processing. 

Good job! Sorry, I didn’t have the time to help here.

> 
>> On Sep 20, 2017, at 9:36 AM, Rob Tompkins  wrote:
>> 
>> Hello,
>> 
>> Commons Jelly 1.0.1 RC6 is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/jelly (svn revision 21718)
>> 
>> The tag is here (tag commit 1808993):
>> https://svn.apache.org/repos/asf/commons/proper/jelly/tags/commons-jelly-1.0.1-RC6
>> 
>> Commit the tag points at:
>> 1808992
>> 
>> Maven Artifacts:
>> https://repository.apache.org/content/repositories/orgapachecommons-1264
>> 
>> These are the Maven artifacts and their hashes:
>> 
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar
>> 
>> (SHA1: 3a81887847dac154c12171028f01e4dd252a0fd0)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-javadoc.jar.asc
>> 
>> (SHA1: 465eea91cc0a7f088ea8bd571e4633ef1904713a)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar
>> 
>> (SHA1: c6c6c1a54b12f268d24abc6a0f920bd2e5896d4c)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-sources.jar.asc
>> 
>> (SHA1: e24cc221bed60203d74f17b93cdfb12d5ca607f6)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar
>> 
>> (SHA1: 71b63b2619a8767d9d0ac0530dcb208f307261ff)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-test-sources.jar.asc
>> 
>> (SHA1: f07dc38b9e4da5860fdad861c815876814184570)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar
>> 
>> (SHA1: 59525df8d5ac104d72c77792da2f72cf381f4420)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1-tests.jar.asc
>> 
>> (SHA1: c99baf87964992e674435f69e7d4270803c5b956)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar
>> 
>> (SHA1: a20261c0f6be2fa4d6572fe22da0450d93195de9)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.jar.asc
>> 
>> (SHA1: 68fb5704f4ca3aefe4fa3369c85b3257be7bfa2c)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom
>> 
>> (SHA1: ea2c451db75da2384ab5a51e9f1dc2b21c8e14cb)
>> /commons-jelly/commons-jelly/1.0.1/commons-jelly-1.0.1.pom.asc
>> 
>> (SHA1: 4f1945ac4669c0bdb186f37d4bc56a864a6c5050)
>> 
>> I have tested this with JDK 1.5.0_22-b03 using Ant 1.6.0. Notes on building 
>> can
>> be found in the 
>> BUILDING.md, included in the source distributions. And, the only changes 
>> between
>> release candidates are documentation and build script changes.
>> 
>> Details of changes since 1.0 are in the release notes:
>>   https://dist.apache.org/repos/dist/dev/commons/jelly/RELEASE-NOTES.txt
>> 
>> Site:
>> I have no site as this was generated with ant. My plan was to simply make
>> minimal 
>> changes to the existant site for the purpose of documenting the patch.
>> 
>> KEYS:
>> https://www.apache.org/dist/commons/KEYS
>> 
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now,
>> i.e. sometime after 14:00 (UTC) 23-September 2017
>> 
>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but