Re: [Net] JUnit 5 migration discussion

[Elric V]

Following Rob's suggestion, I migrated FTPSClientTest from 
@Parameterized to @Nested


The result so far can be found here: 
https://github.com/apache/commons-net/pull/227/commits/b14ee39cca486bda106758a48d31c91ad52d0d83


Basically the test methods were moved from FTPSClientTest.java [1] to 
AbstractFtpsTest.java [2]. The two @Parameterized values are then 
injected using @Nested.


The behaviour in maven is exactly the same as before. The behaviour in 
Eclipse bugs me a little, instead of asking both nested tests by 
default, it asks which one should be executed. But that seems to be the 
case with @Nested tests in general.


[1] 
https://github.com/apache/commons-net/blob/b14ee39cca486bda106758a48d31c91ad52d0d83/src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java


[2] 
https://github.com/apache/commons-net/blob/b14ee39cca486bda106758a48d31c91ad52d0d83/src/test/java/org/apache/commons/net/ftp/AbstractFtpsTest.java


Any feedback is welcome. I personally feel like this test case is a bit 
too complex to be easily grokked, and perhaps it can be improved a bit 
more after the JUnit migration.


I'll try to tackle some more tests at some point this week.

Best,

Elric

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANNOUNCE] Apache Commons DBCP 2.12.0

[Gary Gregory]

The Apache Commons DBCP team is pleased to announce the release of
Apache Commons DBCP 2.12.0.

Apache Commons DBCP software implements Database Connection Pooling.

This is a minor release, including bug fixes and enhancements. Commons
DBCP requires Java 8 or above.

The list of changes is here:
https://commons.apache.org/proper/commons-dbcp/changes-report.html#a2.12.0

For complete information on Apache Commons DBCP, including
instructions on how to submit bug reports, patches, or suggestions for
improvement, see the Apache Commons DBCP website:

https://commons.apache.org/proper/commons-dbcp/

Download page: https://commons.apache.org/proper/commons-dbcp/download_dbcp.cgi

Gary Gregory
Apache Commons Team

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[CODEC] Bug in DoubleMetaphone in 1.16.1

[Martin Frydl]

Hello,

it looks like there is a bug in DoubleMetaphone implementation in
commons-codec 1.16.1. Older 1.16.0 is fine. In fact I'm not 100% sure it is
a bug, but it behaves differently and the old output looks much more
reasonable than the new one.

Old code contains index+=2 -
https://github.com/apache/commons-codec/blob/rel/commons-codec-1.16.0/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java#L462
New code does not contain that line -
https://github.com/apache/commons-codec/blob/rel/commons-codec-1.16.1/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java#L619

Regards,
Martin

Simple test:

import org.apache.commons.codec.language.DoubleMetaphone;

public class Test {
public static void main(String[] args) {
// ANKL - old version
// ANKK - new version - wrong
System.out.println(new
DoubleMetaphone().doubleMetaphone("ANGHELINA"));
}
}