Re: [OGNL] Drop commons-ognl project

[Lukasz Lenart]

pt., 3 gru 2021 o 12:30 sebb  napisał(a):
> Only TLPs can be moved to the Attic.
>
> Commons components can be moved to dormant if they are no longer being
> developed.

Thanks sebb, didn't know that :)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Drop commons-ognl project

[Lukasz Lenart]

And just to clarify one thing: by drop I mean moving the project into
the attic, I still would like to extract some stuff (like benchmarks)
into the code hosted at Github.


Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

pt., 26 lis 2021 o 10:28 Lukasz Lenart  napisał(a):
>
> czw., 25 lis 2021 o 15:57 Mark Thomas  napisał(a):
> > Am I reading the archives correctly when I conclude there has never been
> > an ASF release of Commons OGNL of any version? (snapshots don't count)
>
> Yes, no stable release of Commons OGNL.
>
> > Why will migrating changes from 3.x be any easier if the code is hosted
> > elsewhere?
>
> I won't be migrating them, I'll continue to support the 3.x line (and
> 4.x at some point) based on the Github version but under SML
> organisation (it's a two clicks process).
>
> When I opted to move OGNL under the ASF umbrella I thought it would be
> easier to maintain the code and release it and in the beginning it
> looked like this. Yet, after some time, the both versions of code
> started to diverge and now it's almost impossible to merge the changes
> back from 3.x into Commons-OGNL (it should be possible the other way
> around). Also it's a way easier for me to release a new version based
> on GH than to perform the same process at ASF.
>
> > A cursory review of GitHub stats does show that the old 3.x has been
> > more active. It looks like you have been doing most of the work. Why do
> > you think 3.x has seen more activity than 4.x?
>
> As mentioned above, a faster release cycle (in most cases it depends
> just on me, less bureaucracy), I'm able to release a new version and
> test it in Struts the same day. Also there are other non-ASF projects
> which depend on the 3.x and it's easier for them to discuss/fix
> problems just using GH (my assumption) than create tickets in JIRA and
> then PRs in GH.
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Struts 2.5.28

[Lukasz Lenart]

pt., 26 lis 2021 o 12:03 sebb  napisał(a):
> Wrong mailing list?

Right, sorry for that and thanks for pointing this out :)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Struts 2.5.28

[Lukasz Lenart]

Hi,

A small problem was discovered in 2.5.27 and I would like to quickly
release 2.5.28 with the fix [1], then wait a few weeks and release
another 2.5.x with Yasser's changes and close the 2.5.x line (if no
more problems will be reported after the last version).

[1] https://github.com/apache/struts/pull/510


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Drop commons-ognl project

[Lukasz Lenart]

czw., 25 lis 2021 o 15:57 Mark Thomas  napisał(a):
> Am I reading the archives correctly when I conclude there has never been
> an ASF release of Commons OGNL of any version? (snapshots don't count)

Yes, no stable release of Commons OGNL.

> Why will migrating changes from 3.x be any easier if the code is hosted
> elsewhere?

I won't be migrating them, I'll continue to support the 3.x line (and
4.x at some point) based on the Github version but under SML
organisation (it's a two clicks process).

When I opted to move OGNL under the ASF umbrella I thought it would be
easier to maintain the code and release it and in the beginning it
looked like this. Yet, after some time, the both versions of code
started to diverge and now it's almost impossible to merge the changes
back from 3.x into Commons-OGNL (it should be possible the other way
around). Also it's a way easier for me to release a new version based
on GH than to perform the same process at ASF.

> A cursory review of GitHub stats does show that the old 3.x has been
> more active. It looks like you have been doing most of the work. Why do
> you think 3.x has seen more activity than 4.x?

As mentioned above, a faster release cycle (in most cases it depends
just on me, less bureaucracy), I'm able to release a new version and
test it in Struts the same day. Also there are other non-ASF projects
which depend on the 3.x and it's easier for them to discuss/fix
problems just using GH (my assumption) than create tickets in JIRA and
then PRs in GH.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Drop commons-ognl project

[Lukasz Lenart]

czw., 25 lis 2021 o 15:42 Jason Pyeron  napisał(a):
> > I wonder what do you think about dropping commons-ognl project? This
> > was supposed to be the next major version (4.x) but there was no
> > activity in the project for a long time. Also migrating all the
>
> Does not imply it is not used, loved, and stable.

There was no single release of commons-ognl

> > changes from the previous Github version is rather an impossible task.
> > At the same time I want to move the Github project under
> > Softwaremill's umbrella [1].
>
> By drop, does that mean it will no longer be an ASF project?

Yes, that's my intention, because there is vast diverge between Github
version and ASF one.

> I would rather provide ASF resources. Is there a reason ASF wants to divest 
> OGNL? Can SoftwareMill provide resources to ASF? Can we?

It's also an option, but somehow less popular (at least from my point of view).


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[OGNL] Drop commons-ognl project

[Lukasz Lenart]

Hi,

I wonder what do you think about dropping commons-ognl project? This
was supposed to be the next major version (4.x) but there was no
activity in the project for a long time. Also migrating all the
changes from the previous Github version is rather an impossible task.
At the same time I want to move the Github project under
Softwaremill's umbrella [1].

I'm eager to hear your opinions :)

[1] https://github.com/jkuhnert/ognl/issues/141


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Preparing a release

[Lukasz Lenart]

niedz., 27 gru 2020 o 21:14 Bernd Eckenfels  napisał(a):
> I would say if the maven release plugin and the maven pgp plug-ins work (on 
> your system and for the Pom) and the project builds on al l supported 
> platforms, go for it. If you have your ASF login and thenPgpg key in the Keys 
> file you would meet the criteria.
>
> I am not sure about backward compatibility, package names and so on, but if 
> it’s the first release it should be a new major, either 1.0 or 4.0.

I would love to reduce the number of Maven plugins in the project,
OGNL depends on ASM only, but there are a dozen of plugins, not sure
if all of them are required.

Another question, I have noticed that the issue reference in
changes.xml doesn't match a JIRA ticket, is that ok? e.g.:
Import the
OGNL codebase
but
https://issues.apache.org/jira/browse/OGNL-1 -> Type conversion improvements


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Preparing a release

[Lukasz Lenart]

Sorry, I was not subscribed to the list.

On 2020/12/25 01:18:00, Gary Gregory  wrote: 
> There might be a lot more to consider here since this would be a major
> release. Are there breaking API changes we want to make? Are there
> deprecated APIs we want to drop?
> 
> I see a lot of errors fly by when I do a local build on Windows but these
> do not seem to fail the build which is odd.

Not sure if I understand your questions, I still actively support OGNL 3.x 
which lives on Github, there is a lot of smaller changes which should be moved 
into this project to keep backward compatibility with projects depending on 
OGNL.

As imported version was 3.0.1 and now there is OGNL 3.2.18 I think this 
supposed to be the first step.

> It seems to me that this project has not been released in a long time, so
> there should be some consideration to taking advantage of the version of
> Java the component is now sitting on.

This project was never released after moving it under ASF umbrella.

> I think I saw an animal sniffer setting set to Java 15? How does that make
> sense?

I just tried to understand what to do to build the project, and as I understand 
java15 means Java 1.5
https://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/usage.html

> To make a long story short, we should not be in a rush to release a major
> new version just for the sake of creating a release. Maybe that would be
> better in the 3.x context, I'm not sure.

Right, I'm just trying understand the requirements of releasing a project which 
belongs to Commons family.


Regards
Lukasz



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Preparing a release

[Lukasz Lenart]

Hi,

I would like to (finally) prepare a first release of the Apache
Commons OGNL project. I'm reading the docs [1][2], which I think is
enough to prepare the release.

Is it possible to release a version just to learn how to do the
release? I mean, there is still a lot of code that I would like to
fork from the original source [3], but this is a manual process and in
the meantime I would like to test/learn the release process.

[1] https://commons.apache.org/releases/prepare.html
[2] https://commons.apache.org/proper/commons-release-plugin/index.html
[3] https://github.com/jkuhnert/ognl


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Collections] UnmodifiableSet/UnmodifiableList

[Lukasz Lenart]

2017-03-23 16:55 GMT+01:00 Javen O'Neal :
> The best solution is to document where you return an UnmodifiableSet versus
> a regular Set in your Javadocs.

Disagree, compare these two examples:

/**
 * An immutable set, do not try to modify it
 */
private Set excluded;

vs

private UnmodifiableSet excluded;


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Collections] UnmodifiableSet/UnmodifiableList

[Lukasz Lenart]

2017-03-23 16:35 GMT+01:00 sebb <seb...@gmail.com>:
> On 23 March 2017 at 15:02, Lukasz Lenart <lukaszlen...@apache.org> wrote:
>> 2017-03-23 14:37 GMT+01:00 sebb <seb...@gmail.com>:
>>> Not sure I follow.
>>>
>>> What exactly can the compiler check?
>>
>> You can declare a variable or a field of type UnmodifiableSet but
>> there is no way to create instance of the type UnmodifiableSet - there
>> is no such constructor neither factory method :)
>>
>
> You can create an instance:
>
> UnmodifiableSet us = (UnmodifiableSet)
> UnmodifiableSet.unmodifiableSet(new java.util.HashSet());

Hmm... it is a solution ...

> us.clear(); // The compiler is happy with this, but it fails at 
> runtime

I don't care, internal code won't use it, if someone will try call
clear() it will be they problem ;-)

> AFAICT the only way the compiler can check is to create a class or
> interface that does not have the update methods.
>
> One could potentially create a ReadOnlySet interface that is
> implemented by UnmodifiableSet.
> Similarly for the other unmodifiable Collections.
>
> However would it be worth it?

I think it's worth do such thing, ReadOnlySet speaks better than any JavaDoc :)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Collections] UnmodifiableSet/UnmodifiableList

[Lukasz Lenart]

2017-03-23 14:37 GMT+01:00 sebb :
> Not sure I follow.
>
> What exactly can the compiler check?

You can declare a variable or a field of type UnmodifiableSet but
there is no way to create instance of the type UnmodifiableSet - there
is no such constructor neither factory method :)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[Collections] UnmodifiableSet/UnmodifiableList

[Lukasz Lenart]

Hi,

I see that the Collections4 provides those classes. Anyway I wonder
why I the constructor is private and why the factory method
unmodifiableSet() returns Set?

I would love to use those classes directly, to be straightforward that
I expect the UnmodifiableSet and not just a Set.

What about adding a method like in Guava? Something like this:

public static UnmodifiableSet of(Set set)

This allows define UnmodifiableSets in code and use compiler to check
if everything is ok.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Enable travis-ci for commons-io?

[Lukasz Lenart]

2016-11-08 8:33 GMT+01:00 Pascal Schumacher :
> Hello everybody,
>
> what about enabling travis-ci for commons-io, so that pull requests are
> tested automatically?

You can also setup Jenkins to build PRs

https://builds.apache.org/view/S-Z/view/Struts/job/Struts-JDK7-pull-request/


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] big patches or lots of little patches?

[Lukasz Lenart]

The best is patch per JIRA issue IMHO - if there is more work to do
with one issue, create subtasks to handle them


2014/1/2 Jason Pyeron jpye...@pdinc.us:
 I am working OGNL-145 right now and it is a lot of work and a lot of changes.

 I think it is best to make the change in atomic chunks and to collect the lint
 patches up and apply them when done.

 What does the group think?

 -Jason

 -Original Message-
 From: Lukasz Lenart (JIRA)
 Sent: Thursday, January 02, 2014 1:50
 Subject: [jira] [Commented] (OGNL-241) remove unneeded
 reflection in OgnlException


 [

 https://issues.apache.org/jira/browse/OGNL-241?page=com.atlassian.jira.plugin.sy
 stem.issuetabpanels:comment-
 tabpanelfocusedCommentId=13860050#comment-13860050 ]

 Lukasz Lenart commented on OGNL-241:
 

 Can you prepare a patch or pull request?

  remove unneeded reflection in OgnlException
  ---
 
  Key: OGNL-241
  URL: https://issues.apache.org/jira/browse/OGNL-241
  Project: Commons OGNL
   Issue Type: Improvement
   Components: Core Runtime
 Affects Versions: 4.0
 Reporter: Jason Pyeron
  Fix For: 4.0
 
  Attachments:
  0001-OGNL-241-clean-up-the-OgnlException-for-Java-1.4-and.patch
 
 
  Since OGNL no longer supports Java 1.3 and below, the
 initCause method is always available.

 --
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 -   -
 - Jason Pyeron  PD Inc. http://www.pdinc.us -
 - Principal Consultant  10 West 24th Street #100-
 - +1 (443) 269-1555 x333Baltimore, Maryland 21218   -
 -   -
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 This message is copyright PD Inc, subject to license 20080407P00.




 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

Did some cleanup in JIRA

https://issues.apache.org/jira/browse/OGNL/fixforversion/12323958

2013/12/30 Lukasz Lenart lukaszlen...@apache.org:
 2013/12/30 Jason Pyeron jpye...@pdinc.us:
 There are a lot of formatting chenges between the version in git and apache 
 svn.
 I am still looking for patches in git not yet applied to subversion, do you
 know of any?

 All should be already applied or don't affect Apache's version


 Regards
 --
 Łukasz
 + 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Apache-Legacy class adapters was RE: [OGNL] A new release

[Lukasz Lenart]

2013/12/31 Benedikt Ritter brit...@apache.org:
   The old OGNL (legacy) releases use the
  
   package ognl;
  
   declarations, where as the apache releases will use
  
   package org.apache.commons.ognl;
  
   I would create a set of proxy classes in the old package
  space which
   call the classes in the new space.
 
  These will only be required for a small proportion of users,
  so I suggest they are packaged in a separate jar.

 That was always assumed. The question would it be appropiate for an Apache
 release, or should it be released elsewhere.


 Our software usually uses the org.apache.commons namespace. I'm not sure if
 this is an absolute requirement. To me it feels like these adapters should
 be developed and maintained else where. Thoughts?

Introducing that proxies is a bad idea - Apache Ognl is a bit
different beast than original Ognl and it will never be a drop-in
replacement, you will have to migrate your code anyway.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2013/12/30 Jason Pyeron jpye...@pdinc.us:
 There are a lot of formatting chenges between the version in git and apache 
 svn.
 I am still looking for patches in git not yet applied to subversion, do you
 know of any?

All should be already applied or don't affect Apache's version


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

I think OGNL-239 and OGNL-240 are the only real (semi)blocking issues
before we can start a new release.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

2013/12/25 Jason Pyeron jpye...@pdinc.us:
 -Original Message-
 From: Benedikt Ritter
 Sent: Wednesday, December 25, 2013 11:53

 You've set the issue to status resolved. That's propably the

 After adding the patch.

 reason why nobody had a look at it.
 I don't know if there's anybody planing to roll out a release
 soon. But low svn activity indicates, that this is not the case...

 I took it as a stability indicator... [looks like is active on git
 https://issues.apache.org/jira/browse/OGNL-145?focusedCommentId=13395741page=co
 m.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13395741]

 I am willing to step up to the plate if there are steps or bugs blocking a
 release. When looking through the open 4.0 issues I did not see any notable
 blockers. OGNL-145 is a nice to have, and OGNL-238 may be a limit of Java.

 Either way I am going to browse the updates in
 https://github.com/jkuhnert/ognl.git


 Regards,
 Benedikt

 Send from my mobile device

  Am 25.12.2013 um 06:06 schrieb Jason Pyeron jpye...@pdinc.us:
 
  I have not seen any updates on subversion since September.
 Are there
  any plans on a release?
 
  Either way, please commit the patch on
  https://issues.apache.org/jira/i#browse/OGNL-240
 
  Is there something I can do for the project?
 
  -Jason
 
  -Original Message-
  From: simone.trip...@gmail.com
  [mailto:simone.trip...@gmail.com] On Behalf Of Simone Tripodi
  Sent: Thursday, March 28, 2013 10:35
  To: Commons Developers List
  Subject: Re: [OGNL] A new release
 
  Your are welcome, Javin!
 
  have a nice day, all the best,
  -Simo
 
  http://people.apache.org/~simonetripodi/
  http://simonetripodi.livejournal.com/
  http://twitter.com/simonetripodi
  http://www.99soft.org/
 
 
  On Thu, Mar 28, 2013 at 1:49 PM, Javin Paul
 savingfu...@gmail.com
  wrote:
  Thanks Simo, that's very neat.
 
  On Wed, Mar 27, 2013 at 8:39 PM, Simone Tripodi
  simonetrip...@apache.orgwrote:
 
  Is there list of changes, sort of a release notes?
 
  Sure, we track resolved issues with fix version:
 
 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313
  525versio
  n=12323958
 
  HTH!
  -Simo
 
  http://people.apache.org/~simonetripodi/
  http://simonetripodi.livejournal.com/
  http://twitter.com/simonetripodi
  http://www.99soft.org/
 
 
  On Wed, Mar 27, 2013 at 1:26 PM, Javin Paul
  savingfu...@gmail.com wrote:
  Is there list of changes, sort of a release notes?
 
  On Wed, Mar 27, 2013 at 7:09 PM, Lukasz Lenart
  lukaszlen...@apache.org
  wrote:
 
  I have removed @Deprecated methods, tomorrow will
  review all the
  TODOs. After that we can start planning the release.
 
  --
  -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  -   -
  - Jason Pyeron  PD Inc. http://www.pdinc.us -
  - Principal Consultant  10 West 24th Street #100-
  - +1 (443) 269-1555 x333Baltimore, Maryland 21218   -
  -   -
  -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  This message is copyright PD Inc, subject to license 20080407P00.
 
 
 
 -
  To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
  For additional commands, e-mail: dev-h...@commons.apache.org
 

 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org






 --
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 -   -
 - Jason Pyeron  PD Inc. http://www.pdinc.us -
 - Principal Consultant  10 West 24th Street #100-
 - +1 (443) 269-1555 x333Baltimore, Maryland 21218   -
 -   -
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 This message is copyright PD Inc, subject to license 20080407P00.




 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Make use of logging?

[Lukasz Lenart]

Jason submitted his patch [1], what should we do? apply or leave it?

[1] https://issues.apache.org/jira/browse/OGNL-239


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

2013/11/14 Christian Grobmeier grobme...@gmail.com:
 On 14 Nov 2013, at 10:01, Emmanuel Bourg wrote:

 Le 10/11/2013 21:46, Christian Grobmeier a écrit :

 From all the log4j talks I gave recently there were zero people using
 commons-logging. For me it is dead.


 For what it's worth, the install base of commons-logging in Debian is
 ten times the one of slf4j, and there is no sign of it declining:


 Not sure how debian users install that package and why. Maybe its indirectly
 referenced by some widley used software package. I don't know.
 That statistics doesn't count much to me.

 Of course my experiences cannot be generalized too. They are subjective. But
 if you
 ask your audience who is using what and nobody uses commons-logging it makes
 you think.
 This has happened at multiple talks reaching a total of around 1500 persons.


 We'll soon have an opportunity to improve commons-logging while
 preserving backward compatibility thanks to the default methods in Java 8.


 Preserving backwards compatibility? Till when? 2020? Too much backwards
 compatibility
 broke Commons. While other projects are not doing enough for bc, we are
 doing too much.

 Java 8 is in future. In the meantime other logging frameworks will go on.

 I have seen people are annoyed of the back and forth of logging. Commons
 Logging ads just some spice
 to the problems of logging, but not a real solution. I have had some hard
 fights with promoting
 Log4j2. I am not going to put any effort to fix commons-logging as I don't
 see the value.

 Instead, I am going to spent my time to Log4j 2 and I am really surprised to
 hear
 that some Commons folks prefer to make commons-logging looking modern
 instead of contributing
 to Log4j2 which also provides a modern API.

 Anyway, its up to you folks. Have fun!

 Cheers



 Emmanuel Bourg


 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org



 ---
 http://www.grobmeier.de
 @grobmeier
 GPG: 0xA5CC90DB

 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Make use of logging?

[Lukasz Lenart]

Ok, so let's leave logging layer for now and we should focus on
preparing the first release

2013/11/9 Gary Gregory garydgreg...@gmail.com:
 Neither does log4j 2 ;)

  Original message 
 From: henrib hen...@apache.org
 Date:11/09/2013  12:23  (GMT-05:00)
 To: dev@commons.apache.org
 Subject: RE: [OGNL] Make use of logging?

 IMHO, commons logging is the best choice for this kinds of lib; it does not
 force the choice of the implementation library.
 Henrib



 --
 View this message in context: 
 http://apache-commons.680414.n4.nabble.com/OGNL-Make-use-of-logging-tp4653577p4656625.html
 Sent from the Commons - Dev mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Make use of logging?

[Lukasz Lenart]

2013/11/7 Jason Pyeron jpye...@pdinc.us:

 -Original Message-
 From: Benedikt Ritter
 Sent: Thursday, November 07, 2013 11:00

 Yes, as long as it's Log4j2 ;-)

 Now I need a sed script to replace j.u.l. to it...

 Is Log4j2 the one that is desired? I figured SLF4J was going to be the 
 request.

I rather opt to have no logging layer at all or at least to have
independent layer with default implementation based on j.u.l. - there
is nothing worst than ten different logging libs in a project ;-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Make use of logging?

[Lukasz Lenart]

So what's the idea here? Should we apply additional logging layer (as
Jason proposed)? Or throw it away and start thinking about new
release?

I have reviewed TODOs and I haven't spotted any urgent task for now.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

2013/9/4 Jason Pyeron jpye...@pdinc.us:
 -Original Message-
 From: Benedikt Ritter [mailto:brit...@apache.org]
 Sent: Wednesday, September 04, 2013 4:28
 To: Commons Developers List
 Subject: Re: [OGNL] Make use of logging?

 2013/9/4 Lukasz Lenart lukaszlen...@apache.org

  2013/9/3 Christian Grobmeier grobme...@gmail.com:
   I found 11 uses of e.printStackTrace and think its pretty bad.
   Including OgnlException overwrites printStackTrace and writes to
   System.err for some reason.
  
   In addition there are a lot of System.out's, but those are all
   commented and seem to have served debugging purposes.
  
   I believe small libs like OGNL should not have logging at
 all, but
   it seems some of the logging here might make sense. I am
 tending to
   enable slf4j, which is already used in the testing scope.
 Once done
   we should use the logging methods for System.out and
 printStackTrace.
 
  Why not Log4j or commons-logging?
 
  And it's really annoying to have different logging libs in the same
  project just because dependency uses that particular one - I like
  Struts2 way where you can choose what logging library you
 want to use.
  I don't know if developing additional thin layer is a huge
 problem -
  we can copy paste from S2 ;-)
 

 I agree that small libs should not have logging at all. Are
 you really sure it is needed (sorry don't have the time to
 dig into the code myself right know)?


 As someone who has had to modify the code, yes logging should exist. I have a
 fork of it with util.logging here.


 --
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 -   -
 - Jason Pyeron  PD Inc. http://www.pdinc.us -
 - Principal Consultant  10 West 24th Street #100-
 - +1 (443) 269-1555 x333Baltimore, Maryland 21218   -
 -   -
 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 This message is copyright PD Inc, subject to license 20080407P00.




 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Make use of logging?

[Lukasz Lenart]

2013/11/5 Christian Grobmeier grobme...@gmail.com:
 On 5 Nov 2013, at 14:29, Lukasz Lenart wrote:

 So what's the idea here? Should we apply additional logging layer (as
 Jason proposed)? Or throw it away and start thinking about new
 release?

 I have reviewed TODOs and I haven't spotted any urgent task for now.


 Currently I am sympathizing with just doing a new release. As mentioned
 there
 are commented sysouts, but I believe we can deal with that later.
 It easier to enable logging instead of removing it.

So, let's go then :-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Make use of logging?

[Lukasz Lenart]

2013/9/3 Christian Grobmeier grobme...@gmail.com:
 I found 11 uses of e.printStackTrace and think its pretty bad.
 Including OgnlException overwrites printStackTrace and writes to
 System.err for some reason.

 In addition there are a lot of System.out's, but those are all commented
 and seem to have served debugging purposes.

 I believe small libs like OGNL should not have logging at all, but it
 seems some of the logging here might make sense. I am tending to enable
 slf4j, which is already used in the testing scope. Once done we should
 use the logging methods for System.out and printStackTrace.

Why not Log4j or commons-logging?

And it's really annoying to have different logging libs in the same
project just because dependency uses that particular one - I like
Struts2 way where you can choose what logging library you want to use.
I don't know if developing additional thin layer is a huge problem -
we can copy paste from S2 ;-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

I have removed @Deprecated methods, tomorrow will review all the
TODOs. After that we can start planning the release.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

https://issues.apache.org/jira/browse/OGNL-232

2013/3/26 Lukasz Lenart lukaszlen...@apache.org:
 Ok, done. Should I just commit the changes? Or do I have to register
 an issue first in JIRA? Maybe it will be better...


 Regards
 --
 Łukasz
 + 48 606 323 122 http://www.lenart.org.pl/

 2013/3/26 Lukasz Lenart lukaszlen...@apache.org:
 I'm not sure what API should be removed/renamed/etc as almost
 everything is public static ;-)

 Anyway, I'm trying to remove two deprecated classes right now.


 Regards
 --
 Łukasz
 + 48 606 323 122 http://www.lenart.org.pl/

 2013/3/8 Christian Grobmeier grobme...@gmail.com:
 On Wed, Mar 6, 2013 at 10:11 AM, sebb seb...@gmail.com wrote:
 On 6 March 2013 06:49, Lukasz Lenart lukaszlen...@apache.org wrote:
 Hi,

 I was checking out what should be solved before releasing a new
 version and in my opinion most of PMD [1] errors can be omitted, maybe
 These nested if statements could be combined should be resolved, but
 the rest I don't see a point instead of just satisfying PMD itself.

 Some of the Findbugs [2] errors are related to generated classes,
 should I exclude them?

 Another thing is Checkstyle [3], especially Missing a Javadoc
 comment. - I don't know what to put as it without analysing source
 code deeply.

 My question is what really should be solved to be ready to release a
 new version?

 I don't personally worry too much about PMD or Checkstyle; they depend
 so much on the rules chosen.

 Guess we need to decide on a few rules here. If they are somehow
 connected to method naming et al we should look at them more closely


 Findbugs is more useful, but it looks like most of the errors are for
 generated code.

 Bugs can be fixed by a new release, but future binary compatibility
 can easily be compromised.

 Once a bad or broken API is released, it's very difficult to fix it.

 So I would say the most important aspect to get right is to fix
 anything that makes it more difficult to maintain binary compatibility
 in future.

 For example, if one of the new methods has a name that is
 non-standard, it is easy to change it now.
 Likewise, if there is a new public method which should be private or
 package protected, do it now.

 Or new non-private mutable variables - they make thread-safety - and
 testing - much more difficult

 +1
 We should look over all of our methods right now and discuss
 everything which is public.

 Speaking of which, there does not seem to be a Clirr report.

 I have added the clirr report plugin right now. I doesn't report for
 the first build, as it cannot compare to anything.
 I am bit confused since there is basically no configuration necessary,
 just the plugin definition - is it correct?

 That's very important.
 Apart from checking for unintended compatibility issues, it is useful
 in ensuring that new classes and methods etc. are annotated with
 @since markers.

 We have moved OGNL to 4.0 and Apache - should we annotate everything
 with since 4.0.0 then?
 Imho it doesn't make much sense to annotate with 3.x, as the package
 has changed and both releases are not fully interchangeable

 Cheers



 [1] http://commons.apache.org/proper/commons-ognl/pmd.html
 [2] http://commons.apache.org/proper/commons-ognl/findbugs.html
 [3] http://commons.apache.org/proper/commons-ognl/checkstyle.html


 Regards
 --
 Łukasz
 + 48 606 323 122 http://www.lenart.org.pl/

 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org


 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org




 --
 http://www.grobmeier.de
 https://www.timeandbill.de

 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2013/3/26 Christian Grobmeier grobme...@gmail.com:
 +1, go for it.
 Now its time to see if our testcases are good.

They are, I made a slight mistake and tests showed that :-)

 I also think we should test it in conjunction with struts.

Not so easy, OGNL 4 is a different beast, but I'll try ;-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2013/3/26 Maurizio Cucchiara mcucchi...@apache.org:
 I thought that it won't be a piece of cake, but we might make it
 easier, for example what about to start a new branch on struts to
 integrate the new version of OGNL? (perhaps this is not the right
 place, or at least the only place, where this discussion should
 happen)

I have noticed one thing: isEvalChain() method isn't available in OGNL 4


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2013/3/26 Maurizio Cucchiara mcucchi...@apache.org:
 Do you mean this [1] isEvalChain method?

 [1] 
 https://svn.apache.org/repos/asf/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/SimpleNode.java

IDEA cheats me ;-) It used wrong version ;-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

Hi,

I was checking out what should be solved before releasing a new
version and in my opinion most of PMD [1] errors can be omitted, maybe
These nested if statements could be combined should be resolved, but
the rest I don't see a point instead of just satisfying PMD itself.

Some of the Findbugs [2] errors are related to generated classes,
should I exclude them?

Another thing is Checkstyle [3], especially Missing a Javadoc
comment. - I don't know what to put as it without analysing source
code deeply.

My question is what really should be solved to be ready to release a
new version?

[1] http://commons.apache.org/proper/commons-ognl/pmd.html
[2] http://commons.apache.org/proper/commons-ognl/findbugs.html
[3] http://commons.apache.org/proper/commons-ognl/checkstyle.html


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1451672 - /commons/proper/ognl/trunk/pom.xml

[Lukasz Lenart]

2013/3/2 Olivier Lamy ol...@apache.org:
 2013/3/2 Lukasz Lenart lukaszlen...@apache.org:
 2013/3/1 Olivier Lamy ol...@apache.org:
 -
 commons.scmPubCheckoutDirectorysite-content/commons.scmPubCheckoutDirectory
 +
 commons.scmPubCheckoutDirectory${project.build.directory}/site-content/commons.scmPubCheckoutDirectory
 so if you use mvn clean. You will checkout again the content from svn.
 The goal with using site-content directory is to do only update rather
 than a full checkout even when using clean.

 Yes, I know and I thought about that a bit, either solution wasn't
 good for me. I don't know how the Commons' release process looks like,
 but in the Struts project we always perform release and site deploy
 base on clear checkout, which means we must checkout the site anyway.

 Default from parent is
 !-- scm publish plugin configuration --
 commons.site.cache${user.home}/commons-sites/commons.site.cache
 !-- value modules can override it --
 commons.site.path${project.artifactId}/commons.site.path
 
 commons.scmPubCheckoutDirectory${commons.site.cache}/${commons.site.path}/commons.scmPubCheckoutDirectory

 IMHO it's better value.Note I added the hack with some antrun for
 sites which contains old javadocs which we don't modifiy so no need to
 checkout those paths.
 With your change as you checkout content to
 ${project.build.directory}/site-content, it means running mvn clean
 site twice you will checkout the content twice. Is it very helpful to
 checkout content twice because you're just building the site for
 testing purpose ?

I'm still a bit confused as I thought the site-content will be checked
out only when I want to make a new release and update the site. I see
how the profile is defined but I don't understand the flow :\

That said I'm going to revert the change :-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1451672 - /commons/proper/ognl/trunk/pom.xml

[Lukasz Lenart]

2013/3/1 Olivier Lamy ol...@apache.org:
 -
 commons.scmPubCheckoutDirectorysite-content/commons.scmPubCheckoutDirectory
 +
 commons.scmPubCheckoutDirectory${project.build.directory}/site-content/commons.scmPubCheckoutDirectory
 so if you use mvn clean. You will checkout again the content from svn.
 The goal with using site-content directory is to do only update rather
 than a full checkout even when using clean.

Yes, I know and I thought about that a bit, either solution wasn't
good for me. I don't know how the Commons' release process looks like,
but in the Struts project we always perform release and site deploy
base on clear checkout, which means we must checkout the site anyway.

It would be better to keep site content in a separate folder eg.
../commons-ognl-site-content or in user home folder - I don't what is
better.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2013/3/1 Lukasz Lenart lukaszlen...@apache.org:
 How can I update ognl website? Simple checkout [1] and update what I
 need? and then what to do?

I found this [1], but I have one question, how to check locally how
the site will look like before deploying it? I have the only solution:

mvn clean site
copy target/site into site-content

is that ok?

[1] http://commons.apache.org/site-publish.html


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2013/3/1 Olivier Lamy ol...@apache.org:
 to test website it's the usual: mvn clean site (then browse files in
 target/site/)
 to deploy: mvn clean site-deploy.
 and site-content must excluded from rat. Do you want to fix that ? If not I 
 can.

I just moved site-content into target/ folder and that solved the
problem. But feel free to add the exclude, then I will learn something
new :-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

How can I update ognl website? Simple checkout [1] and update what I
need? and then what to do?

eg. RAT report is broken as it includes all the html files [2]

[1] 
https://svn.apache.org/repos/infra/websites/production/commons/content/proper/commons-ognl/
[2] http://commons.apache.org/proper/commons-ognl/rat-report.html


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

Why the Download section is commented out in the site.xml ?

https://issues.apache.org/jira/browse/OGNL-231


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: CMS/SvnPubSub for site live ?

[Lukasz Lenart]

ech.. I don't want to complain, but I had (have) the same problem with
Struts project which is basically related to pushing changes directly
into production branch, which means you cannot test the changes on the
staging before pushing to production :\


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: CMS/SvnPubSub for site live ?

[Lukasz Lenart]

2013/2/2 Olivier Lamy ol...@apache.org:
 That's because maven relativize urls while building the site.

 Check a maven site build log you will see something like:
 Relativizing decoration links with respect to project URL:
 http://commons.apache.org/ognl/
 So as the link for commons home is declared as
 http://commons.apache.org, Maven transform it to ../ .
 I have fixed ognl
 url in pom with
 urlhttp://people.apache.org/~olamy/commons-content/proper/commons-ognl//url
 So I have my log saying
 Relativizing decoration links with respect to project URL:
 http://people.apache.org/~olamy/commons-content/proper/commons-ognl/

 So that fix here: http://people.apache.org/~olamy/commons-content/ognl/

 I hope it make sense ?

Not really, but I'm sure you know what you doing :-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: CMS/SvnPubSub for site live ?

[Lukasz Lenart]

2013/1/30 Olivier Lamy ol...@apache.org:
 Hi Folks,
 Ok to go live ?

 Something missing ? (maybe sandbox parent release ?)

When I enter a subproject and then I want to go back to the main page
via Home link on the right (under Commons section), it directs me to
proper/ which simply returns directory listing. The same is for the
rest of links under Commons section and for General Information as
well - contain /proper/ in the url.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2013/1/8 Lukasz Lenart lukaszlen...@apache.org:
 AFAICS you won't be able to release with 27, because of the new svnpub
 requirement for the site and 28 is not ready yet, waiting for INFRA. See
 vote thread for commons-email.

 Thanks Jörg!

Looks like something changed as ognl build passed on Jenkins ;-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2013/1/8 Jörg Schaible joerg.schai...@scalaris.com:
 Hi Lukasz,

 Lukasz Lenart wrote:

 Hi,

 Another issue, I've noticed that the parent is defined as 28-SNAPSHOT,
 should it be simple 27 - the latest released version?

 AFAICS you won't be able to release with 27, because of the new svnpub
 requirement for the site and 28 is not ready yet, waiting for INFRA. See
 vote thread for commons-email.

Thanks Jörg!


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

Hi,

Another issue, I've noticed that the parent is defined as 28-SNAPSHOT,
should it be simple 27 - the latest released version?


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2013/1/8 Christian Grobmeier grobme...@gmail.com:
 On Tue, Jan 8, 2013 at 7:44 AM, Lukasz Lenart lukaszlen...@apache.org wrote:
 Another issue, I've noticed that the parent is defined as 28-SNAPSHOT,
 should it be simple 27 - the latest released version?

 Not sure about the differences of these 2, but I think we cannot
 release a stable version with a dependency to a -SNAPSHOT version. I
 think this is also true for parent poms. I also think it should be 27
 stable

Ok, will change that.

Do you know how to exclude some files/directories from the rat-plugin
scan ? Right now it includes .idea folder in the scan which produces
mass of errors :\


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

How to generate reports locally ?


Thanks in advance
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2012/3/9 Simone Tripodi simonetrip...@apache.org:
 I don't think it is necessary when fixing this kind of issues, unless
 you need to heavily change the code, but I don't suspect so ;)
 let me know if I can be helpful in some way - more than just helping
 on fixing issues :P

I have few doubts regarding checkstyle report, there are many issues
related to JavaDocs and some line are too long and so one - I don't
treat them as a big problems (especially with current formatting). But
there are some strange errors like [2] which says:

Name 'INDEXED_PROPERTY_NONE' must match pattern '^[a-z][a-zA-Z0-9]*$'.
Variable 'INDEXED_PROPERTY_NONE' must be private and have accessor methods

where the INDEXED_PROPERTY_NONE is defined as a constant:

public static final int INDEXED_PROPERTY_NONE = 0;

It looks like the checkstyle is configured in wrong way. Is there a
Commons official checkstyle config ? Or am I free to adjust checkstyle
included with OGNL ?

[1] http://commons.apache.org/ognl/checkstyle.html
[2] 
http://commons.apache.org/ognl/checkstyle.html#org.apache.commons.ognl.OgnlRuntime.java


Regards
-- 
Łukasz
mobile +48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] A new release

[Lukasz Lenart]

2012/10/24 Maurizio Cucchiara mcucchi...@apache.org:
 That's really weird, last time I have seen (and also corrected) a bunch of
 error like this, but they all were more than justified.

 I'll try to generate the report and see what happens.

Maybe the website is out of sync ? How to deploy a new version ?


Regards
-- 
Łukasz
mobile +48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: I have the opensymphony JIRA export

[Lukasz Lenart]

2011/6/20 Jason Pyeron jpye...@pdinc.us:
 Please let me know how it should be handled.

 Both the JIRA xml export and the attachments.

 (this message is going to 2 lists struts and commons, you do not have to reply
 to both)

Here [1] you have XWork related issue, you can create another one for Ognl

[1] https://issues.apache.org/jira/browse/INFRA-2577


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Release a new version

[Lukasz Lenart]

You're right, it looks like releasing 3.0.2 from GitHub is the best
option. I'll try to prepare a release ASAP and then talk to Sonatype
guys ;-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[OGNL] Release a new version

[Lukasz Lenart]

Hi all,

Can we make a new release ? OGNL is under incubation still but that
shouldn't be a problem.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Release a new version

[Lukasz Lenart]

Sure, not a problem, but how long it will take ? Jochen ?


Thanks in advance
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/

2011/6/11 Simone Tripodi simonetrip...@apache.org:
 Hi Lukasz,
 I don't know if you already noticed the Jochen message, but he's
 working in order to have OGNL-8 fixed, I'd wait for it before
 releasing it.
 WDYT? Have a nice weekend, all the best!
 Simo

 http://people.apache.org/~simonetripodi/
 http://www.99soft.org/



 On Sat, Jun 11, 2011 at 10:55 PM, Lukasz Lenart
 lukasz.len...@googlemail.com wrote:
 Hi all,

 Can we make a new release ? OGNL is under incubation still but that
 shouldn't be a problem.


 Regards
 --
 Łukasz
 + 48 606 323 122 http://www.lenart.org.pl/
 Warszawa JUG conference - Confitura http://confitura.pl/

 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] Release a new version

[Lukasz Lenart]

2011/6/11 Jochen Wiedmann jochen.wiedm...@gmail.com:
 On Sat, Jun 11, 2011 at 11:34 PM, Lukasz Lenart
 lukasz.len...@googlemail.com wrote:

 Sure, not a problem, but how long it will take ? Jochen ?

 Dunno. Ask me again in a week or so. :-) Or feel free to take the task over.

Thanks Jochen!  I'm asking because we have a critical issue with
Struts 2 build and it's already solved in OGNL ;-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [OGNL] drop old opensymphony build

[Lukasz Lenart]

+1 for dropping the old way of build


REgards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL Infrastructure questions

[Lukasz Lenart]

+1 for JIRA space and issues@commons.a.o


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Warszawa JUG conference - Confitura http://confitura.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

Moving OGNL to Struts 2 could have one pitfall - it can be driven by
the project's needs. But that can be good as well ;-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Confitura 2011 http://confitura.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

2011/3/3 Antonio Petrelli antonio.petre...@gmail.com:
 2011/3/3 Lukasz Lenart lukasz.len...@googlemail.com:
 Moving OGNL to Struts 2 could have one pitfall - it can be driven by
 the project's needs. But that can be good as well ;-)

 Just a note FWIW. Spring WebFlow also uses OGNL.

So, OGNL as a TPL project would be the best.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Confitura 2011 http://confitura.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

2011/3/3 Simone Tripodi simonetrip...@apache.org:
 Anyone more? :)

You can count on me, but I'm a Struts Committer.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Confitura 2011 http://confitura.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Fwd: OGNL as a part of Commons

[Lukasz Lenart]

One more :-)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Confitura 2011 http://confitura.pl



-- Forwarded message --
From: Maurizio Cucchiara maurizio.cucchi...@gmail.com
Date: 2011/3/3
Subject: Re: OGNL as a part of Commons
To: Struts Developers List d...@struts.apache.org, lukasz.len...@gmail.com


Lukasz,
you can count on me too, feel free to tell me how I can help you (I've
already subscribed on every apache commons mailing list and incubator
one too)

On 3 March 2011 12:04, Lukasz Lenart lukasz.len...@googlemail.com wrote:
 Hi,

 As Antonio suggested, is anybody else interested here in supporting
 OGNL and the whole incubation process ?

 There's a discussion going on on the dev@commons mailing list about that.


 Regards
 --
 Łukasz
 + 48 606 323 122 http://www.lenart.org.pl/
 Confitura 2011 http://confitura.pl


 -- Forwarded message --
 From: Antonio Petrelli antonio.petre...@gmail.com
 Date: 2011/3/3
 Subject: Re: OGNL as a part of Commons
 To: Commons Developers List dev@commons.apache.org, lukasz.len...@gmail.com
 DW: Lukasz Lenart lukasz.len...@googlemail.com


 2011/3/3 Lukasz Lenart lukasz.len...@googlemail.com:
 2011/3/3 Simone Tripodi simonetrip...@apache.org:
 Anyone more? :)

 You can count on me, but I'm a Struts Committer.

 I know it :-) for incubation, being an Apache commiter is a plus when
 creating an incubation proposal.
 I think you should ask the Struts dev mailing list to see if anyone
 else is interested.

 Antonio

 -
 To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
 For additional commands, e-mail: dev-h...@struts.apache.org





--
Maurizio Cucchiara

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Fwd: OGNL as a part of Commons

[Lukasz Lenart]

FYI

-- Forwarded message --
From: Dave Newton davelnew...@gmail.com
Date: 2011/3/3
Subject: Re: OGNL as a part of Commons
To: Struts Developers List d...@struts.apache.org, lukasz.len...@gmail.com
DW: Lukasz Lenart lukasz.len...@googlemail.com


It seems like it might be a good idea for the ASF to have a performant
(how I hate that word) EL, possible taking a look at how MVEL/etc.
does some things, etc. I kind of like OGNL and the power it provides,
just wish it was faster--I'd help with that as time allows.

Dave

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Fwd: OGNL as a part of Commons

[Lukasz Lenart]

FYI

-- Forwarded message --
From: Paul Benedict pbened...@apache.org
Date: 2011/3/3
Subject: Re: OGNL as a part of Commons
To: Struts Developers List d...@struts.apache.org


Count me in for backup. If someone gets tied up with day work and you need
an extra hand, I will help take over for that person the best I can.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

Hi,

So, where I should start ?


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

2011/3/1 Antonio Petrelli antonio.petre...@gmail.com:
 There is another problem: is OpenSymphony willing to donate the code to 
 Apache?
 It's not only a problem of forking, because the entire copyright
 will pass to Apache, at least for the donated code as it is (the
 copyright will remain to OpenSymphony until the act of donation).
 If not, you cannot donate/incubate at Apache. There are other options
 though, e.g. forking and apache-extras.

OGNL was moved to GitHub some time ago and right now it's more or less
ownerless. Before I've started asking you guys, I had been talking to
two main people behind OGNL and they had approved my idea to move OGNL
under ASF umbrella. So, I can send an official request to them to
donate OGNL to ASF if it's needed.


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

2011/3/1 Stephen Colebourne scolebou...@joda.org:
 Based on what I know of OGNL, it is/was reasonably well used. Trying
 to merge it into another project doesn't help those existing users.

Yep, that's true

 The question is what are the author(s) of OGNL looking for? A home for
 maintainance? The Apache brand? To reinvigorate it? The latter fits
 with a merger into other projects. The former should make commons ask
 if it wants to become a home for maintainance mode (not necessarily a
 bad thing).

A home, right now OGNL is homeless and ownerless. As I know, Struts 2
and Tapestry are both using it extensively.


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

2010/12/15 Jörg Schaible joerg.schai...@scalaris.com:
 What happened to OpenSymphony that you cannot use their infrastructure
 anymore?

I don't know, there was some rumor about domain owners or so. Also
other projects were moved out from OpenSymphony: WebWork became Struts
2, XWork was moved to ASF and it's a part of Struts, Quartz as well.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

2010/12/14 sebb seb...@gmail.com:
 So does it offer anything that JEXL does not?

I think no, it looks like JEXL2 is even much better than OGNL. I don't
know JEXL2 so deep, but with OGNL you can create objects directly (o
= new Object()) and you can call methods with parameters
(foo.doit(o)).


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

2010/12/13 Gary Gregory ggreg...@seagullsoftware.com:
 I am wondering how OGNL relates to Commons JXPath 
 http://commons.apache.org/jxpath/

 When would you use one vs. the other?

OGNL is an Expression Language like UEL, it has some nice features
like calling statics or using constructors. It's used internally by
Struts 2 to evaluate user expressions and not only in JSP but in any
other place. JXPath looks like a XPath for Java objects, so it's used
to query for values from graph of objects.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: OGNL as a part of Commons

[Lukasz Lenart]

2010/12/13 sebb seb...@gmail.com:
 OGNL is an Expression Language like UEL, it has some nice features
 like calling statics or using constructors. It's used internally by
 Struts 2 to evaluate user expressions and not only in JSP but in any
 other place.

 In which case it seems to be similar to Commons JEXL in approach and scope?

Yep, probably.

 Can OGNL be used as a javax.script (JSR-223) language?

Right now no, but in the future...


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

OGNL as a part of Commons

[Lukasz Lenart]

Hi all,

I want to ask you all, is it possible to include OGNL
(https://github.com/jkuhnert/ognl , http://www.opensymphony.com/ognl/
) into Commons project?

As I know OGNL is used by few ASF projects (Struts 2, Tapestry) and
right now it's homeless project. It's very hard to prepare a new
release, to update documentation, and so on. It would be much better
to include it in Commons and base on ASF infrastructure. Right now I'm
the only contributor to that project and I've been talking with the
authors of OGNL and they agreed to move OGNL to ASF.

What do you think?


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org