[GitHub] commons-fileupload issue #1: Commons fileupload headerfix
Github user developerSid commented on the issue: https://github.com/apache/commons-fileupload/pull/1 I just checked the code out, and this has already been fixed. Looks like the change I wanted to try and get into upstream was done on 3/16/2011 by Wiedmann. I'm going to close this. Thanks for taking a look though guys. I really appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #1: Commons fileupload headerfix
Github user developerSid commented on the issue: https://github.com/apache/commons-fileupload/pull/1 I totally agree this was a pretty botched pull request. How would you like me to handle this once I get it fixed? Leave this thread open and comment here with the new pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #1: Commons fileupload headerfix
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/1 On another issue: Please remove .classpath, and .project from the pull request. These are IDE specific, thus not supposed to live in an Apache project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #1: Commons fileupload headerfix
Github user jochenw commented on the issue: https://github.com/apache/commons-fileupload/pull/1 Honestly: 88 files changed for one pull request? No chance to get that pulled in. Try to split your changes into smaller change sets. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #1: Commons fileupload headerfix
Github user developerSid commented on the issue: https://github.com/apache/commons-fileupload/pull/1 Sure I can give that a try. I had forgotten about having actually done this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #1: Commons fileupload headerfix
Github user kinow commented on the issue: https://github.com/apache/commons-fileupload/pull/1 Hmmm, this pull request seems to be a bit messed up due to either changes in the branch, or to the way the commit was created. There are also IDE files committed. @developerSid if you could update the pull request, making sure to rebase your changes against the remote branch, that might make it easier to be reviewed. Thanks Bruno --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
